Commit Graph

1205 Commits

Author SHA1 Message Date
wmayer
3dc9acef62 PD: [skip ci] fix warning -Wunused-variable 2021-11-17 19:06:35 +01:00
Yorik van Havre
a26fb4db1a Merged crowdin translations 2021-11-16 17:30:39 +01:00
wmayer
cd2955f3d3 PD: simplify Pad/Pocket commands 2021-11-16 00:58:55 +01:00
Uwe
838bdf93bc [PD] fix issue 0004785
- then the profile of a pad/pocket was a face, the direction handling was completely broken
2021-11-15 15:44:28 +01:00
Uwe
61481dc9c5 [PD] uniform pad and pocket handling
- since pockets now can have a certain direction, also handle the reference axis like for pad
- uniforms initial length to 10.0
2021-11-15 15:32:56 +01:00
Uwe
414f4d706e [PD] uniform Pad/pocket UI
now that pockets have the same functionality as pads, the UIs can be unified:

- the position of the Offset widget in the UI is better in pocket, thus use it for pad too
- add missing tabstops for pad
- add missing tooltip for pocket
- update tabstops for pocket
2021-11-14 03:58:21 +01:00
Uwe
4a4db353a5 [PD] fix pad/pocket direction issue
- the info if a custom direction is used, was incorrectly determined by checking a checkbox that only displays the vector value, no matter if it is a custom vector or not
2021-11-13 04:03:04 +01:00
Ajinkya Dahale
5aaf6e68b4 [PD] Allow body faces when making loft by pre-selection 2021-11-12 01:33:46 +01:00
Uwe
0b3839f0f6 [PD] TaskDlgPipeParameters - refactor comments
update/refactor comments after today's changes
2021-11-12 00:44:35 +01:00
Uwe
0995c81240 [PD] add feature to set direction for pockets
This PR adds the functionality of pads to pad along either a custom direction or along an edge to pockets.

So with this PR Pad and Pocket are on the same level of functionality.
2021-11-11 15:55:42 -06:00
wmayer
126fadd2d6 PD: make sure to switch off Profile and Section highlighting when closing sweep dialog 2021-11-11 20:33:27 +01:00
wmayer
fb9a3eecff PD: change visibility handling of sweep to support undo/redo 2021-11-11 20:21:47 +01:00
Chris Hennes
c62239d0ba Merge pull request #4626 from pavltom/GUI_TreeView_Item_Ordering
[Gui] Issue #3923 - Add arbitrary Tree View item ordering
2021-11-10 23:35:05 -06:00
Chris Hennes
bef1df4d40 Merge pull request #5163 from donovaly/PD-sweep-section-visibility2
[PD] fix sweep visibility bug
2021-11-10 22:43:49 -06:00
Uwe
8173f79dc7 [PD] code improvements for TaskPadParameters
as requested by @chennes in PR #5164, the code can be simplified:

- remove a redundant type cast, a redundant qualifier and an inconsistent and unnecessary check
2021-11-11 02:08:57 +01:00
Ajinkya Dahale
a4fa45b589 [PD] Check if property is named before strcmp 2021-11-11 01:13:17 +01:00
Uwe
6069d48b6d [PD] fix sweep visibility bug
Currently:

    only sweep path is toggled correctly in its visibility, the profile is never shown
    the sections are always shown

This PR fixes this inconsistency reported here: https://forum.freecadweb.org/viewtopic.php?f=19&t=63544
2021-11-11 00:00:58 +01:00
Ajinkya Dahale
37df050d59 [PD] Clear other taskbox buttons in loft and pipe when one pressed 2021-11-10 17:59:45 +01:00
Uwe
e06034e772 [PD] fix a typo
- also some sorting
2021-11-10 03:26:23 +01:00
Ajinkya Dahale
314ff0053c [PD] Fixed loft and sweep breaking on section deletion
Item removal in `onDeleteSection()` was also clearing subname details so if one
of the remaining sections was a face this caused a failure.
2021-11-09 23:05:29 +01:00
Ajinkya Dahale
03a8ff7841 [PD] Support adding solid faces for loft and pipe sections
With these changes, one face per solid can be added as either the first
"profile" or subsequent sections in loft and pipe.

This commit depends on `App::PropertyXLinkSubList` preserving the order in which
sections are added.

A minor change this also adds is that when a solid's face is selected that face
is mentioned in the fields instead of the solid (eg `Box:Face1` instead of
`Box`).
2021-11-09 23:05:29 +01:00
wmayer
5c77af421d PD: [skip ci] fix crash in ReferenceSelection::allow 2021-11-09 18:37:54 +01:00
Uwe
0b77c2b2b5 [PD] fixes loft visibility on creation and modification
- the PR fixes the issue reported here: https://forum.freecadweb.org/viewtopic.php?f=3&t=63252

- (also a MSVC code formatting fix)
2021-11-07 21:57:00 +01:00
Uwe
0b4405e935 [PD] simplify Loft code
- also two automatic style fixes made by MSVC
2021-11-07 19:04:38 +01:00
wmayer
84274f5c80 PD: [skip ci] fix ambiguous shortcut overload in TaskDlgPipeParameters 2021-11-07 08:27:33 +01:00
Ajinkya Dahale
e30efba754 [PartDesign] Fix typo in method name 2021-11-06 00:03:48 +01:00
wmayer
8366028e6f PD: [skip ci] open a transaction when creating a new body with DlgActiveBody 2021-11-04 23:21:14 +01:00
Chris Hennes
d8f38a886a Merge pull request #5128 from luzpaz/freecad-translation-6
PD: Expose missing commands to translation in Measure dropdown menu
2021-11-01 00:22:28 -05:00
wmayer
a3a7b5a6a6 PD: [skip ci] if no active body exists then by default pre-select the first option to create a new body 2021-10-31 12:33:48 +01:00
0penBrain
0bd0ec5ed2 [PartDesign] Remove useless function overriding
Double-click is already handled by PartDesign::ViewProvider::doubleClicked()
 Overridings in Loft & Pipe brings no specific behavior
 By removing overridings, behavioral consistency is improved both in ...
 ... undo commands & body activation management when PartDesign items ...
 ... are double-clicked
2021-10-29 17:30:06 +02:00
Tomas Pavlicek
345dcd5252 [Gui] Issue #3923 - Arbitrary Tree item ordering + tests 2021-10-26 19:09:34 +02:00
luz paz
f3631c8ff1 PD: Expose missing commands to translation in Measure dropdown menu
Fixes https://github.com/FreeCAD/FreeCAD-translations/issues/6
2021-10-26 10:35:21 -04:00
wmayer
87ad1c0dde PD: [skip ci] when creating a datum object allow user to create a body if needed 2021-10-22 20:23:16 +02:00
wmayer
45c3cee264 PD: open transaction when calling item of context-menu of sketch based features 2021-10-22 20:01:43 +02:00
wmayer
d39233313b PD: [skip ci] code cleanup 2021-10-22 19:06:57 +02:00
wmayer
f628050732 PD: simplify code to display add/sub shape 2021-10-09 11:38:25 +02:00
wmayer
5b4c246944 PD: simplify code to display rejected shape and move it to its own function 2021-10-08 22:32:26 +02:00
wmayer
c2c5ae1bf0 Part: remove ViewProviderPartExt::getNormals 2021-10-08 19:34:48 +02:00
wmayer
0503f06930 PD: do not enforce a reference axis when no profile is used to pad a face 2021-10-08 18:21:42 +02:00
wmayer
f411390d33 PD: do not set ReferenceAxis when no profile is used to pad a face 2021-10-08 17:45:59 +02:00
Chris Hennes
7339bb8382 Merge pull request #5071 from donovaly/PD-pad_along_fixes
[PD] fixes for padding along edge
2021-09-29 13:25:13 -05:00
Yorik van Havre
77925c428e Updated ts files 2021-09-29 14:32:12 +02:00
donovaly
fb49450c62 [PD] fixes for padding along edge
- handle custom direction like all other directions
- allow to view the direction vector for all directions, but only to edit for custom
- fix enabling of the length alongNormal option
- also fix a translation issue
2021-09-29 01:11:50 +02:00
wmayer
b8c1877133 PD: [skip ci] fix minor issues:
* don't need to clear an empty vector
* remove two code blocks that effectively do nothing (except of producing a warning :) )
2021-09-28 15:43:25 +02:00
Chris Hennes
9ad741249b Merge pull request #4685 from donovaly/PD-pad-direction-selection
[PD] add feature to select pad direction via an edge
2021-09-27 13:11:40 -05:00
Yorik van Havre
b042405933 Merged crowdin translations 2021-09-23 17:14:48 +02:00
donovaly
52436033b8 rebase to master 2021-09-20 01:37:47 +02:00
donovaly
6ce6a8a1e0 small fixes as suggested by @chennes
therefore also in the helix code
2021-09-20 00:59:17 +02:00
donovaly
069e765db0 [PD] add feature to select pad direction via an edge
This was requested by users in the forum and is indeed very valuable for the usability.
2021-09-20 00:59:16 +02:00
Ajinkya Dahale
e305dbd49c PartDesign: Add new need active body dialog with option to choose body (#4949)
* [PD] Add new need active body dialog

Intended for use wherever an active body is needed but none exists. The dialog
contains a list with the bodies present in the document, with an extra option to
make a new body. Custom text can be provided if needed.

This commit also replaces the warnings used by "new sketch" and "primitive"
command with this new dialog.

Addresses issue #4288.
2021-09-16 12:27:46 -05:00