kindred/create
1
1
Fork 0
Code Issues 44 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity
27,187 Commits 40 Branches 6 Tags
501b45bac84b5e44d0e78f575cb83663bd479afa
Commit Graph

59 Commits

Author SHA1 Message Date
Uwe
501b45bac8 [PD] uniform default Pad/Pocket lengths 
- the goal of the recent Pad/Pocket code refactoring was to handle Pad and Pocket the same
  default Pad were 10 long, Pocket only 5 -> uniform this to 10
- the initialization of the length were different than the default set in Command.cpp
- it was annoying that the default 2nd length was 10 and 20 times the default for the 1st length -> uniform and take the same than the 1st length
 2022-01-23 04:58:58 +01:00
Uwe
e2f883fcc4 [PD] Pad/Pocket: sort out common code 
- sort out a constraint used by Pad and Pocket
- also unify Length2 parameter naming
 2022-01-08 00:45:19 +01:00
Uwe
64b2677ac0 [PD] get rid of a CI compiler warning (#5335) 
* [PD] get rid of a CI compiler warning

The CI compiler outputs this warning:
FeaturePad.cpp:101:20: warning: variable 'obj' set but not used [-Wunused-but-set-variable]

Co-authored-by: 0penBrain <48731257+0penBrain@users.noreply.github.com>
 2022-01-05 12:26:48 +01:00
wmayer
4fa4446f01 PD: [skip ci] code clean-up in pad and pocket feature 2021-11-20 12:01:55 +01:00
wmayer
ab480df745 PD: move duplicated code to common base class 2021-11-20 11:45:13 +01:00
wmayer
a8cb5ed419 PD: [skip ci] for pockets use opposite direction of reference axis 2021-11-16 00:35:57 +01:00
Uwe
0995c81240 [PD] add feature to set direction for pockets 
This PR adds the functionality of pads to pad along either a custom direction or along an edge to pockets.

So with this PR Pad and Pocket are on the same level of functionality.
 2021-11-11 15:55:42 -06:00
wmayer
bc5311b3ee PD: fixes #0004567: Pattern from a feature type UpToFace and Offset > copy whole body 2021-02-24 17:08:20 +01:00
wmayer
2389b4779a PD: [skip ci] code refactoring 
Move adding offset to face from getUpToFace() to addOffsetToFace()
 2021-02-24 16:08:03 +01:00
wmayer
42ccdb8122 PartDesign: [skip ci] fixes #0004494: Error "Result is empty" for Pads and Pockets with non zero Offset 2020-11-16 14:45:55 +01:00
wmayer
d819a62db2 PartDesign: [skip ci] support negative values as second length of a pocket 2020-11-16 11:35:05 +01:00
vocx-fc
0a445d9e5b PartDesign: replace unicode characters with simple hyphens 2020-06-03 14:51:01 +02:00
wmayer
972ec50f28 fixes #0003979: Pocket with mode 'up to face' doesn't work correctly 2019-06-15 23:54:10 +02:00
Abdullah Tahiri
a415ad72e1 PartDesign: 3rdParty to PCH 2019-05-02 07:12:27 +02:00
wmayer
563d020b67 improve error messages for Pocket, Hole and Groove feature 2018-12-31 18:30:13 +01:00
wandererfan
7e781bcfd0 Revise multiple solids message 2018-07-13 10:23:42 -03:00
wandererfan
883a726d52 Fix #3401 warning on multiple solid 
- PartDesign only uses the first result shape
  of an operation and discards the rest without
  warning.

- this also fixes #1707
 2018-07-13 10:23:42 -03:00
Abdullah Tahiri
663e4ee369 PartDesign: Extension of Pocket Feature to have two dimensions 
fixes #2915
 2018-01-20 16:15:38 +01:00
wmayer
949c86d364 Port to occ7.2: 
+ Standard_Failure::Caught() is now marked as deprecated and should be replaced with standard C++ exception handling
 2017-09-01 16:27:46 +02:00
Peter Lama
a75a98ef27 Use OCCT Handle macro for Handle_ classes 
This is the result of running OCCT's upgrade script provided
with OCCT 7.0. See
https://www.opencascade.com/content/freecad-occt710-and-windows-rtti-data-missing#comment-form
and
https://www.forum.freecadweb.org/viewtopic.php?f=4&t=21405&start=120#p169019
for why this is necessary for OCCT >= 7.1
 2017-04-20 12:27:34 +02:00
AjinkyaDahale
6a385f5ee3 Possible solution to a problem in pad/pocket up-to-face 
Somehow we weren't able to pad/pocket up-to-face when the profile sketch
is made on a datum plane
 2017-03-19 18:09:14 -03:00
Stefan Tröger
83ce80f133 fixes #0002512 Allow multi-face part design tools 2016-05-18 23:54:18 +02:00
wmayer
bca7a1866e + port to OCC 7.0 2016-05-14 16:53:27 +02:00
Stefan Tröger
f712f5e4ac PartDesign: Modeling features work with faces 
-Rename Sketchbased to ProfileBased to show new behavior
-Adopt ProfileBased to make the relevant helper functions work with faces too
-Adopt features for unified use of helper functions
-Adopt commands to allow face selection
 2016-04-12 18:12:22 +02:00
Alexander Golubev
96486cc4ed PartDesign/App: a small fix to offset constraint syntax for Pad and Pocket 2016-04-12 18:12:21 +02:00
Alexander Golubev
bf94c3ebf7 PartDesign: fix negative Offset property in pad and pocket 2016-04-12 18:12:16 +02:00
Alexander Golubev
0ca40ed48b PartDesign/Task{Pad,Pocket}Parameters: massive refactoring 
Give a massive refactoring to Task dialogs for pocket and pad.
This commit features:
 * Make Task dialogs for pocket and pad look nice in side-by side diff and
   cross import features missing in each other.
 * As a result it fixes several minor bugs.
 * Gives a rework to the UpdateUI function.
 * This one also fixes offset option support and migrates it to use unit
   framework.
 2016-04-12 18:12:15 +02:00
DeepSOIC
4b48362ec6 PartDesign: refactor positionBySketch 
Rename it to positionByPrevious. Rewrite.
Rewrite SketchBased::transformPlacement.
 2016-04-12 18:12:11 +02:00
DeepSOIC
03be8e1bba PartDesign: tidy up sketch support and base feature confusion 
Not complete, transformPlacement and positionBySketch are pending...
 2016-04-12 18:12:11 +02:00
Stefan Tröger
9a2f5eea65 allow non-sketch based additive and subtractive features 2016-04-12 18:12:06 +02:00
jrheinlaender
9dba4c01e2 Added some comments about things to be fixed in the future 2016-04-12 18:11:55 +02:00
jrheinlaender
f1b5a6044d Allow extruding from a datum plane to another face or plane, optionally with an offset 2016-04-12 18:11:53 +02:00
jrheinlaender
1e615043cd Give user feedback about not being able to extrude UpToFace if sketch is on a datum plane 2016-04-12 18:11:52 +02:00
jrheinlaender
a8e4f0f1ca Allow Pad and Pocket up to a face with sketch located on datum plane 2016-04-12 18:11:51 +02:00
jrheinlaender
b18958b3d9 Miscellaneous fixes 2016-04-12 18:11:51 +02:00
jrheinlaender
f954a51430 Pad/Pocket: Allow extrude up to a datum plane 2016-04-12 18:11:50 +02:00
jrheinlaender
0bcdb0511f Added Reversed button to Pocket UI if the sketch plane is a datum plane 2016-04-12 18:11:50 +02:00
jrheinlaender
7d84c7e6f0 Made Pocket, Revolution and Groove aware of the SketchBased::BaseFeature property 2016-04-12 18:11:48 +02:00
wmayer
a6436f7d12 + fixes #0001655: Pocket type UpToFirst and UpToFace doesn't produce expected results. 2015-05-16 12:44:07 +02:00
wmayer
225184270a + set correct group information to pad and pocket properties 2014-03-21 15:18:26 +01:00
wmayer
3cc032c11e + Add option to refine solid on sketch-based features 2013-09-21 09:16:44 +02:00
wmayer
ce0e6e5cef Make FeaturePython Python binding a template class to avoid code duplication 2013-03-22 00:34:18 +01:00
wmayer
64e1c3635d Fix build failures with automake 2012-12-06 20:13:24 +01:00
wmayer
1fb178db62 Reset modified flag after document is loaded, touch pad/pocket if its Type has changed 2012-11-06 21:12:39 +01:00
wmayer
efd61d256d Algorithm to remap support shape, fix bugs in pad/pocket 2012-11-04 16:48:52 +01:00
jrheinlaender
13d68e99aa PartDesign, 758, 766, 773, 775: several improvements, fixes and code refactoring for Pad and Pocket 2012-11-03 23:07:48 +01:00
jrheinlaender
f6c728d8ba PartDesign: improve failure handling and error messages 2012-10-31 10:48:12 +01:00
jrheinlaender
e5bdcc1322 PartDesign: avoid duplicate code in getting the support shape 2012-10-29 16:09:54 +01:00
jrheinlaender
3fa415584e PartDesign: improved feature parameters checks and avoid duplicate code 2012-10-27 19:48:55 +02:00
jrheinlaender
ded5b893a8 PartDesign: tidy up PartDesign feature dependencies 2012-09-09 10:05:43 +02:00