kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity
22,156 Commits 41 Branches 6 Tags
505e43645b767b3af1f9d5852a7b0f3f1a27b075
Commit Graph

2310 Commits

Author SHA1 Message Date
J-Dunn
2b79cb731a prevent added paths creating tool crash #4260 #3028 
In this path dressup a bogus machine position is used to get an initial edge, this results in a path element which does reflect the input path data and can lead to a tool crash. This PR checks whether X and Y actually come from the input path data and prevent new path elements being added until true machine position has been set. 
Forum thread: https://forum.freecadweb.org/viewtopic.php?f=15&t=42820
 2020-07-28 14:12:11 +01:00
sliptonic
ebe45e5603 Merge pull request #3689 from etrombly/edgesMatchShape 
[PATH] fix pocket attribute error if edge cannot be flipped
 2020-07-27 12:53:37 -05:00
wmayer
13fc0554a0 LGTM: [skip ci] fix: Missing header guard 2020-07-27 11:16:41 +02:00
wmayer
45e0673645 LGTM: [skip ci] fix: Declaration hides parameter 
A local variable hides a parameter. This may be confusing. Consider renaming one of them.
 2020-07-27 10:57:34 +02:00
wmayer
e079e7a7bb LGTM: [skip ci] fix: Non-virtual destructor in base class 2020-07-24 19:30:12 +02:00
wmayer
c162037476 LGTM: [skip ci] fix: Large object passed by value 2020-07-24 18:32:31 +02:00
Mark Ganson TheMarkster
181eaa1b7a coverity issue cid 305102 2020-07-23 13:55:32 +02:00
sliptonic
43f4ae927d Merge pull request #3709 from etrombly/3dSurface 
[Path] fix two never ending while loops in PathSurfaceSupport
 2020-07-21 10:58:48 -05:00
wmayer
c4bb1ff762 Coverity: Copied into fixed size buffer 2020-07-20 17:34:25 +02:00
wmayer
083d0e012f Coverity: Invalid printf format string 2020-07-20 17:34:23 +02:00
wmayer
4807fd3b33 PVS: V730 Not all members of a class are initialized inside the constructor 2020-07-18 10:59:27 +02:00
Eric Trombly
fca189debc fix two never ending while loops in PathSurfaceSupport 2020-07-17 13:59:10 -05:00
Eric Trombly
29e842d4e0 fix attributeError if edge can't be flipped 2020-07-14 18:53:54 -05:00
luz paz
e4f6689e0a Merged crowdin translations 2020-07-13 14:49:45 +02:00
Yorik van Havre
da262c0b45 Updated master ts files 2020-07-13 13:20:21 +02:00
sliptonic
5faa738002 Merge pull request #3688 from etrombly/deleted 
[PATH] fix Cannot access attribute 'Document' of deleted object when cancelling PathPocket operation
 2020-07-12 16:27:35 -05:00
Eric Trombly
547c6fa26e cleaner fix 2020-07-10 15:42:00 -05:00
Eric Trombly
6a1c68a647 fix deleted object error 2020-07-10 15:42:00 -05:00
sliptonic
82f13231c7 unhide the property for the interpolation surface 2020-07-09 10:47:58 -05:00
Russell Johnson
7c3a1f2ee8 Path: Add basic support for arc and circular edges 
- Arc and circular slots available using single edge selection.
- `ExtendRadius` property to allow for tool compensation.
- Extend path start and end is available. Value is measured along the arc, not linear.
- Includes collision check for arc and circular slots.
 2020-07-02 01:16:22 -05:00
luz.paz
ef37cc3930 Fix typos [skip-ci] 
Found via codespell v1.18.0.dev0  
```
codespell -q 3 -L aci,ake,aline,alle,alledges,alocation,als,ang,anid,ba,beginn,behaviour,bloaded,byteorder,calculater,cancelled,cancelling,cas,cascade,centimetre,childs,colour,colours,commen,connexion,currenty,dof,doubleclick,dum,eiter,elemente,ende,feld,finde,findf,freez,hist,iff,indicies,initialisation,initialise,initialised,initialises,initialisiert,ist,kilometre,lod,mantatory,methode,metres,millimetre,modell,nd,noe,normale,normaly,nto,numer,oder,orgin,orginx,orginy,ot,pard,pres,programm,que,recurrance,rougly,seperator,serie,sinc,strack,substraction,te,thist,thru,tread,uint,unter,vertexes,wallthickness,whitespaces -S ./.git,*.po,*.ts,./ChangeLog.txt,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/CXX,./src/zipios++,./src/Base/swig*,./src/Mod/Robot/App/kdl_cp,./src/Mod/Import/App/SCL,./src/WindowsInstaller,./src/Doc/FreeCAD.uml
```
 2020-06-29 20:52:23 +02:00
sliptonic
1b643536b9 Merge pull request #3657 from Russ4262/MillFace_fix 
[Path] MillFace - Fix calculation of OpFinalDepth default value
 2020-06-29 09:54:04 -05:00
sliptonic
2c74dd8e28 Merge pull request #3645 from Russ4262/BaseGeomList_resize 
[Path] Resize the Base Geometry list dynamically
 2020-06-29 09:53:18 -05:00
Eric Trombly
74ef899a75 check if pcLineCoords is empty 2020-06-28 19:52:59 -05:00
Eric Trombly
031a3d0816 fix null reference 2020-06-28 19:52:59 -05:00
Russell Johnson
22bc65b54c Path: Resize the Base Geometry list dynamically 
Make the size of the Base Geometry list dynamically adjust to its contents.
 2020-06-27 15:05:00 -05:00
Russell Johnson
ebc1a42880 Path: Fix calculation of OpFinalDepth default value 
Remove commented lines.
Modify PathLog.Level assignment for easier readability.
 2020-06-27 09:36:14 -05:00
sliptonic
5c5a882ec5 Merge pull request #3599 from GeneGH/Edits 
Path Simulator - Recognition of canned cycle cancellation
 2020-06-21 13:22:49 -05:00
sliptonic
0c79264d5c Merge branch 'master' into master 2020-06-21 10:38:47 -05:00
Russell Johnson
f525fedd11 Path: Slot operation fixes and improvements 
- Add `CutPattern` feature, defaulting to `ZigZag`.
- Change inter-pass retractions to SafeHeight for multi-pass operations.
- Fix division by zero instance for particular Perpendicular use case.
- Synchronize property values with inputs in both the Property View and Tasks Editor windows.
- Change `LayerMode` default value to `Multi-pass`.
- Improve debug messaging.
- Consolidate code and remove unused code.

Path: fix exception thrown
 2020-06-20 14:27:12 -05:00
sliptonic
48b0c71c20 [Path] Make jobs delete cleanly. 
Deletion of tool controllers now works for toolbits as well
 2020-06-19 13:17:17 -05:00
sliptonic
c9418a7597 Merge pull request #3631 from Russ4262/task_panel_icons 
[Path] Add icons to Tasks Window tabs
 2020-06-19 12:32:07 -05:00
sliptonic
25445b0cb5 Merge pull request #3584 from gwicke/area_tweaks 
Path: Area fixes and robustness tweaks
 2020-06-19 12:30:32 -05:00
sliptonic
b5ba6b96bd Merge pull request #3629 from gwicke/line_simplification 
[path] Implement Ramer-Douglas-Peucker line simplification
 2020-06-19 11:12:35 -05:00
sliptonic
a7a86f54bc Merge pull request #3624 from Russ4262/SlotCutter 
[Path] Add new `Slot` operation to PathWB 2D tool group
 2020-06-19 11:12:01 -05:00
sliptonic
3dab70097c Merge pull request #3600 from sliptonic/feature/customimprove 
[PATH] make -custom- op compliant. Improve gcode_pre importer
 2020-06-19 11:11:21 -05:00
sliptonic
c238c7fd6f Merge pull request #3568 from Russ4262/3D_Surface_fixes_2 
[Path] 3D Surface and Waterline: FinalDepth guess and `InternalFeaturesCut` fixes
 2020-06-19 11:10:14 -05:00
sliptonic
38cda180b2 Merge pull request #3545 from Russ4262/Multi-profile 
[Path] Profile - New `ExpandProfile` feature for compound profile operations
 2020-06-19 11:09:04 -05:00
Russell Johnson
1f69d4a941 Path: Format and add DocStrings and comments 2020-06-18 20:13:41 -05:00
Russell Johnson
e7a6903fb2 Path: Fix timing of updatePanelVisibility() call 
Targeted function call needed to be after `updateBase()` call after the `for` loop.
 2020-06-18 19:56:52 -05:00
Russell Johnson
add80615eb Path: Add new Slot operation 
New slotting operation:
- Accepts selection of up to two features.
- Selectable features include: faces, edges, and vertices.
- User may select a single face or edge, or a pair of features.
- The path may be extended at the start and end.
- The path may be reversed.
- The path may be altered to the perpendicular in some cases.
- A unique Slot icon is included.
- Includes simple collision detection with warning message.
 2020-06-18 19:56:52 -05:00
Russell Johnson
ab33df3595 Path: Add icons to feature tabs 
Add Base Geometry, Heights, Depths, and Operation icons on the tabs in the Tasks Window editor.
 2020-06-18 15:54:14 -05:00
Russell Johnson
5ec70701ca Path: Add icon reference to UI panel 2020-06-18 15:54:14 -05:00
Russell Johnson
e8ea6af98f Path: Add operation's label to task panel window title 2020-06-18 01:39:26 -05:00
Russell Johnson
5f362e21a5 Path: Cleanup and simplify code 2020-06-18 01:39:26 -05:00
Russell Johnson
8dd767239c Path: Add ExpandProfile feature 
Two new properties, `ExpandProfile` (length) and `ExpandProfileStepOver` (percent) added for new feature.
New feature converts the normal single offset profile into a compound profile containing multiple increasing/decreasing offsets.
The new feature clears a each layer completely before stepping down to the next layer.
Adjust sorting procedure in PathAreaOp due to `ExpandProfile` modifications to open edges code.
 2020-06-18 01:39:26 -05:00
Russell Johnson
562c449c83 Path: Add operation's label to task panel window title 2020-06-18 01:36:54 -05:00
Russell Johnson
a2b6ac28d8 Path: Fix error when selection includes vertical faces. 2020-06-18 01:36:54 -05:00
Russell Johnson
82fbfa95d1 Path: Add opUpdateDepths() method as in 3D Surface 2020-06-18 01:36:54 -05:00
Russell Johnson
99038db23e Path: Fix broken InternalFeaturesCut processing 2020-06-18 01:36:54 -05:00