Commit Graph

24374 Commits

Author SHA1 Message Date
sliptonic
5196a4c01b Merge pull request #8145 from sliptonic/bug/7600
[Path] use correct widgets in task panel Fix #7600
2023-01-09 10:28:50 -06:00
Abdullah Tahiri
152dda172c Part/Sketcher: Geometry/Geometry facade pass by const-reference instead of by value 2023-01-09 17:13:26 +01:00
Abdullah Tahiri
04a7478afb Sketcher: Do not mark as fully constrained sketches that do not converge
=======================================================================

In uncommon situations, the analysis of QR decomposition leads to full rank, but the result does not converge.

We avoid marking a sketch as fully constrained when no convergence is achieved.
2023-01-09 17:11:14 +01:00
Uwe
1ca527c6ad [skip ci] [TD] fix a typo as reported by the CI 2023-01-09 15:47:40 +01:00
Uwe
c947055821 [TD] remove unused headers (#8155)
* [TD] remove unused headers

- also some sorting
- also improve readability by not using an abbreviation (we consistently don't abbreviate class names)
2023-01-09 14:55:22 +01:00
Yorik van Havre
ec6b14bbee Merged crowdin translations 2023-01-09 14:06:28 +01:00
Yorik van Havre
c1160c598a Updated ts files 2023-01-09 13:24:16 +01:00
Uwe
2f2480df7b [TD] final fix of compilation after #8141
- in DimensionValidators.h the declarations must not be with TechDrawExport
- add missing precompiled headers

- also fix too long lines (fixed by clang)
- also some re-sorting
- also remove unused headers
2023-01-09 12:48:15 +01:00
Uwe
864ef31d81 [TD] minor fixes
- typos and code formatting as reported by the CI
- some more re-sorting
2023-01-09 12:02:50 +01:00
wmayer
c80a60d8be TD: fixes #8144: TD crash 2023-01-09 11:43:14 +01:00
Uwe
79ae9b8280 [TD] attempt to fix compilation with PCH after #8141
- also resort includes
2023-01-09 11:26:51 +01:00
wandererfan
6a42d6991c [TD]fix loss of precision in view direction 2023-01-08 17:50:49 -05:00
wandererfan
503b58daee [TD]fix dimension retains light on dark colour 2023-01-08 17:50:49 -05:00
sliptonic
3b954f95f3 use correct widgets in task panel 2023-01-08 12:05:34 -06:00
wandererfan
97b6788464 [TD]fix wrong calculation of 3d two edge angle 2023-01-07 16:32:03 -05:00
wandererfan
7d5c47c633 [TD]fix exception on empty list during restore 2023-01-07 16:32:03 -05:00
wandererfan
88c7aac0d9 [TD]fix issues reported by 3d dimension testers
- correct interpretation of True vs Projected

- handle long subelement names in references

- fix "too small" value condition

- better error messages for bad dimension geometry
2023-01-07 16:32:03 -05:00
wandererfan
208104e9e0 [TD]Refactor Dimensions for 3d upgrade
- separate validation, geometry and reference handling into
  individual files
- improve 3d reference geometry handling
- eliminate duplicate dim creation code

- add Dimension reference repair dialog

- Refactor formatting out of DrawViewDimension

- move dimension repaint control to ViewProvider
2023-01-07 16:32:03 -05:00
wandererfan
9e48f5a158 [Measure]fix angle returns supplementary value 2023-01-07 16:32:03 -05:00
luzpaz
171d09f2ac Crowdin: [skip ci] fix string in Arch/ArchSite.py
Props to david69 https://crowdin.com/translate/freecad/6766/en-fr#6604817
2023-01-07 20:08:28 +01:00
luzpaz
6babde5845 Crowdin: fix string in Arch/ArchStairs.py
Props to david69 in https://crowdin.com/translate/freecad/6766/en-fr#6605247:drl:44875:david69
2023-01-07 20:07:57 +01:00
Abdullah Tahiri
9811d6cbb9 GCS: Improvements to popularity contest and conflicting identification
======================================================================

1. Instead of excluding internal alignment constraints from popularity candidate selection, exclude them from the group altogether. This
ensures no group is non-empty with uneligible candidates, which prevents an infinite loop in uncommon circumnstances (when DoFs collapse).

2. Ensure no internal alignment constraint is identified when conflict ensues.
2023-01-06 13:49:56 -06:00
wmayer
f2908e251c [skip ci] fix typos 2023-01-06 18:16:50 +01:00
sliptonic
c909b753a4 Fix for Partial edge drilling Fixes 8131 2023-01-05 17:35:08 -06:00
wmayer
90b7b461b8 TD: [skip ci] fix -Winconsistent-missing-override 2023-01-05 11:14:30 +01:00
Uwe
0a0902532d [TD] fix compilation with PCH after b18f1e5e
- also add includes to QtAll
2023-01-05 00:50:32 +01:00
Ajinkya Dahale
9aba979b27 [Sketcher] Delete check for OCC >= 6.9.0
The oldest version we plan to support is 7.0.0. See
https://forum.freecadweb.org/viewtopic.php?f=10&p=650487#p650487.
2023-01-05 00:27:01 +01:00
wmayer
be9634b23c Part: move to new-style connect of DlgPrimitives dialog 2023-01-04 13:06:26 +01:00
Chris Hennes
2575629e92 Addon Manager: Fix macro installer bug
Also some minor tweaks to the GUI unit testing.
2023-01-03 20:19:41 -06:00
wandererfan
0e402ae075 [TD]add light text on dark page mode
- some visually impaired users need white graphics on
  dark page.

- revise Annotation dialog to respect dark style
2023-01-03 17:41:33 -05:00
wmayer
6eac8fe8b2 Part: move to new-style connect of DlgPrimitives dialog to make it also working with Qt6 2023-01-03 17:09:49 +01:00
sliptonic
0b9b1d8da7 Merge pull request #7826 from LarryWoestman/staging
Path:  Incorporating feedback from code reviews
2023-01-03 09:18:51 -06:00
wmayer
f1481b1f0c Part: refactor DlgPrimitives dialog 2023-01-03 15:53:12 +01:00
Chris Hennes
7cbecd46c7 Addon Manager: Modify dialog closing during tests 2023-01-02 15:09:01 -06:00
wandererfan
3bae9ab611 [TD]fix Win link error in ViewProvider extensions 2023-01-02 13:49:50 -05:00
wmayer
9efac962ac App: fix failure to detect cyclic dependencies on expressions
See also forum thread: https://forum.freecadweb.org/viewtopic.php?f=3&t=74331
2023-01-02 16:36:10 +01:00
wmayer
d60f2e291f Core: fixes #8119: Make axis values in Property view persistent 2023-01-02 12:48:40 +01:00
wmayer
05959a2beb PD: fix crash in TaskRevolutionParameters::fillAxisCombo
* Replacing the static_cast with a dynamic_cast in 668adaacdf is a regression because it cannot be guaranteed that the linked object is a sketch.
  In fact it can also be a shape binder which is explicitly allowed.
  Forum: https://forum.freecadweb.org/viewtopic.php?f=19&t=74939
* Move initialization of some variables into the if-statement
2023-01-02 09:49:27 +01:00
wmayer
a67f4fcb74 Web: switch to new-style connect in order to find failures with Qt6 2023-01-02 00:35:37 +01:00
wmayer
0e73896aa3 Addon-Manager: [skip ci] get rid of some explicit PySide2 imports 2023-01-01 11:42:39 +01:00
wmayer
91613cc24c Mod: fix some compiler warnings:
* QString::indexOf() is now marked as [[nodiscard]]
* QApplication::fontMetrics() is deprecated, use the constructor of QFontMetricsF
* fix -Wunused-result
* fix -Wunused-but-set-variable
2022-12-31 21:54:45 +01:00
wmayer
7d878e8646 Image: fix deprecation warnings 2022-12-31 21:54:45 +01:00
wmayer
61fe4b6b6c Raytracing: QString::indexOf is now marked as [[nodiscard]] 2022-12-31 21:54:45 +01:00
LarryWoestman
dcab7c4a78 Path: Reformatted to a line length of 88 using black.
Incorporating feedback; now using f-strings all over.
           Incorporating changes from feedback.
           Incorporated more refactoring feedback.
           Changes for Path refactoring.
2022-12-31 09:20:51 -08:00
sliptonic
a11bde5105 Merge pull request #7962 from luvtofish/master
path: dynapath delta 40-60 post processor add
2022-12-31 10:26:44 -06:00
sliptonic
f654f2d421 Merge pull request #8088 from mlampert/bugfix/8087-dont-load-project-files-unless-tests-are-run
[Path] bugfix/8087-dont-load-project-files-unless-tests-are-run fixes #8087
2022-12-31 10:24:29 -06:00
Roy-043
7951dab2bf Draft: update inspect.getargspec to inspect.getfullargspec (#8101) 2022-12-29 23:20:38 +01:00
Chris Hennes
d6094449b9 OpenSCAD: Minor translation issue [skip ci] 2022-12-28 23:33:54 -06:00
Chris Hennes
38ef13efaf Addon Manager: Minor translation issue [skip ci] 2022-12-28 23:33:27 -06:00
wmayer
da956906e3 TD: [skip ci] fix possible crash in ViewProviderViewPart::onChanged 2022-12-28 21:17:23 +01:00