Commit Graph

3949 Commits

Author SHA1 Message Date
Uwe
52b2bc6e38 [FEM] Elmer: add missing direct variant MUMPS
- also use capitalized wording to Umfpack as Elmer does
2022-07-30 14:40:10 +02:00
wmayer
3ef98f002b Fem: use 'using' instead of 'typedef' [modernize-use-using] 2022-07-27 19:11:05 +02:00
Uwe
c25c0888c9 [FEM] fix PostObject hiding issue
- when a PostObject is hidden the FemPostDataAtPointFilter must not be taken into account
2022-07-27 16:56:06 +02:00
Uwe
9a9ac18916 [FEM] save icons as plain SVG - part 2/2 2022-07-27 16:42:46 +02:00
Uwe
4c08e41a88 [FEM] PostDataAtPoint: remove unnecessary style setting
- PostDataAtPoint is a point therefore setting a filling style is not necessary

- also fix a typo in a comment
2022-07-27 16:15:04 +02:00
Uwe
d81fe59c2e [FEM] remove checks for Python 2 2022-07-27 14:09:23 +02:00
Uwe
9c89935297 [FEM] skip CI] update a comment 2022-07-27 03:54:26 +02:00
Uwe
591b0f3e1b [FEM] update ViewProvider selection code
as suggested in
7884cb92d9 (r79459854)
2022-07-27 03:51:46 +02:00
Uwe
1c419864c3 [FEM] save icons as plain SVG - part 1/2 2022-07-27 03:34:04 +02:00
Uwe
2e9788d488 [FEM] BodyHeat constraint: use unique icon
- it was not possible to distinguish the constraint from the heatFlux constraint
2022-07-27 03:09:15 +02:00
Uwe
9c7af25d26 [FEM] BodyHeat constraint: hide unused property
- the constraint does not take a references and when trying to set one as user because one thinks this empty property must be set, one gets a recompute error
2022-07-27 02:55:29 +02:00
Uwe
1cc410cb1e [FEM] update Elmer tests after commit 594b65b3 2022-07-27 02:33:42 +02:00
Uwe
2b6f351880 [FEM] Elmer: a fix for keywords
- according to the Elmer solver manual, check keywords have to be quoted
2022-07-27 01:48:10 +02:00
Uwe
e425ed39a6 [FEM] PostObject: improve color bar refreshing
- for data point filters the color bar must not be updated
2022-07-26 04:00:02 +02:00
Uwe
f0d633eb4b [FEM] Elmer writer: fix errors on missing material properties
- we must in this case raise an error and stop the writer script
2022-07-26 03:37:55 +02:00
Uwe
4325f0386c [FEM] update bodyHeatSource
- to the state of the other constraints

(this constraint is currently completely broken by the way)
2022-07-26 01:47:09 +02:00
wmayer
a9a4cf3d6d Fem: [skip ci] Fix several clazy issues:
* Maybe you meant to call base method instead [-Wclazy-skipped-base-method]
* Using copy-ctor but class SbMatrix has a trivial copy-ctor but non trivial assign operator [-Wclazy-rule-of-two-soft]
* Missing emit keyword on signal call FemGui::PointMarker::PointsChanged [-Wclazy-incorrect-emit]
2022-07-25 12:11:47 +02:00
Uwe
ae33ad545f [FEM] Elmer: fix python error when solver failed
we must then stop the execution of the script
2022-07-25 02:54:12 +02:00
Uwe
777aabe46c [FEM] ViewProviderDocumentObject: fix parenthesis mistake
(I don't know how this happened)
2022-07-24 19:25:53 +02:00
Uwe
d012b8d012 [FEM] fix color bar handling on hiding post objects
- fixed the remaining part of #7230: on hiding an object, refresh the color bar of the new visible object (if there is any)
2022-07-24 19:17:24 +02:00
Uwe
a5b50fd114 [FEM] set default selection mode to BoundBox for post objects
- this fixes a long-standing annoyance that popped up also from time to time in the forum:
  the post objects deliver information via its coloring but a selection in the tree changed the shape color

Even experienced users like me did not know about the SelectionStyle property and always had to click into the model to see the real color, not the selection color.
Therefore SelectionStyle set to BoundBox is sensible as default settings for post objects since this assures that the users always see the right coloring.
2022-07-24 16:24:01 +02:00
Uwe
c3074efb29 [FEM] fix regression of missing stress results
- fixes the regression that went in short as "last minute fix": commit c5daa88b82 -> fixes #7242

- also remove a doubled entry in an IF
2022-07-24 05:41:33 +02:00
Uwe
e95a16408c [FEM] TaskBoxes: add missing info about transparency
The user had no info about the current transparency nor the value he will be selecting.
2022-07-23 19:41:18 +02:00
Uwe
5aedc73ef6 [FEM] better fix for missing colorbar update for FemPostObject
- better fix for #7230 because we can call the direct paint method and because the bar is now also updated when the object is shown

- also add a ToDo note
2022-07-23 16:57:16 +02:00
Uwe
82083ab059 [FEM] task_material_common: add a comment 2022-07-23 14:22:48 +02:00
Uwe
68659771f5 [FEM] fix material task dialog for fluids
- this fixes a mistake from commit 821dc915
- it also consistently use the thermal expansion coefficient
- add code comments

now the material task dialog works with all fluid materials without errors or warnings
2022-07-23 04:59:10 +02:00
Uwe
0105189304 [FEM] [skipCI] ViewProviderFemPostPipeline: remove unused include
- also sorting
2022-07-22 02:08:11 +02:00
Uwe
ac27f4700a [FEM] fix missing colorbar update for FemPostObject
- fixes issue #7230

- to update the color bar for post objects, the Field property has to be reset to trigger this. This PR does this.
2022-07-22 01:20:18 +02:00
Uwe
b726941073 [FEM] [skip CI] fix UI file height entry
- was automatically done by QT designer
2022-07-21 03:43:26 +02:00
Uwe
f467451ae3 [FEM] remove more superfluous nullptr checks 2022-07-18 02:34:57 +02:00
Uwe
5e634c5995 [FEM] remove superfluous nullptr checks 2022-07-18 01:45:19 +02:00
Uwe
947bce371c [FEM] check if Gmsh, CCX and Mystran solver binaries exist
- adds the check like we have already for Z88 and Elmer
- also remove an unnecessary return statement
2022-07-17 01:43:58 +02:00
Uwe
e76fbe6998 [FEM] fix CCX (new framework) binary handling
- when the binary was not found, the function called the non-existing binary
- also push error message to the status info so that user gets feedback also when report view console is not shown
2022-07-17 01:28:54 +02:00
Uwe
1ba44fb1ca [FEM] fix Z88 binary handling
- when the binary was not found, the function called the non-existing binary
- also push error message for Elmer and Z88 to the status info so that user gets feedback also when report view console is not shown
- uniform wording to 'binary'
- avoid unnecessary console output
2022-07-17 01:18:21 +02:00
Uwe
7346ee4073 [FEM] [skip CI] inform user about used CPU cores for Elmer
Since the number of used cores can for Elmer have the impact that a solver run converges or not, output this info prominently
2022-07-16 19:46:46 +02:00
Uwe
c4416e00ca [FEM] [skip CI] tell user when Elmer write succeeded
At the moment the user gets no feedback, while for Z88 and CCX he gets a result
2022-07-16 19:41:43 +02:00
Uwe
b39e91c26f [FEM] [skip CI] fix wording
Calculix will not be broken, but stopped. After clicking the button your will also get a message that it has been 'stopped'
2022-07-16 19:33:02 +02:00
Uwe
bcacab1988 [FEM] [skip CI] fix a typo 2022-07-16 19:21:25 +02:00
Uwe
826a903281 [FEM] [skip CI] fix a string 2022-07-16 18:54:11 +02:00
Uwe
5bbf136174 [FEM] [skip CI] fix a typo 2022-07-16 16:01:38 +02:00
Uwe
eec258ab37 [FEM] enable to run Elmer multi-threaded
- this needs proper testing, especially on a non-Windows system

- note that for some tasks multi-threading requires non-standard additional solvers like MUMPS. Ideally the user should be informed about this, depending on the equations he uses. But this should not block this PR, meaning to use multi-threading in general.
2022-07-16 14:59:25 +02:00
wmayer
9984d6bf86 Fem: replace PyObject_IsTrue with Base::asBoolean 2022-07-16 13:37:55 +02:00
Marshal Horn
3a3a20da46 Replaced python2 usage of next()
iterator.next() is deprecated in python3.
next(iterator) is the direct replacement.
In some cases a for() loop makes more sense
2022-07-14 01:28:10 +02:00
Uwe
1ddb42dcb2 [FEM] femutils.py: style changes
- as requested
2022-07-14 01:21:54 +02:00
Bernd Hahnebach
02fef68c8b FEM: Python code formatting 2022-07-13 12:04:52 +02:00
Uwe
1ce91df8f7 [FEM] [skip CI] electrostatic: remove unused code 2022-07-13 03:23:19 +02:00
Uwe
33a769a426 [FEM] fix solver console bugs
- for Elmer and Z88 on Windows several windows pop up (console windows). This is maybe annoying and the user is wondering what is going on, but the main problem is that when you close them, you break the solving process.
Therefore, on Windows only, hide the empty popup windows.
2022-07-13 02:51:31 +02:00
Bernd Hahnebach
c010a8e6b9 FEM: extend codespell command in code conventions 2022-07-12 15:04:26 +02:00
Bernd Hahnebach
f773f165a7 FEM: typos, found with:
codespell -q 2 -S *.ts -S *.dyn -S *.svg  -L childs,dof,dum,freez,methode,nd,normaly,programm,som,uint,vertexes,inout  src/Mod/Fem/
2022-07-12 15:04:26 +02:00
Bernd Hahnebach
41a8ed83af FEM: python code formatting 2022-07-12 15:04:26 +02:00