Commit Graph

1035 Commits

Author SHA1 Message Date
wandererfan
53290618dd [TD]fix centering of shape
- centering of shape was not affecting the OCC TShape, so
  we now make a deep copy of the original
2023-03-12 19:21:22 -04:00
wmayer
2a0e52e71e clang: fix -Wunused-but-set-variable 2023-03-12 15:05:21 +01:00
Uwe
fb13cbf4b5 [TD] fix compiler warning about code duplication and unused variable 2023-03-10 11:25:16 -05:00
wandererfan
1aa5026fd1 [TD]fix error from BSpline.asCircle 2023-03-09 13:40:16 -05:00
Abdullah Tahiri
ee0c3ad5c1 Console/ILogger: Refactor and extension
=======================================

Refactor:
 - Substitute the use of variadic templates with parameter packs.
 - Use recently incorporated external library "fmt" to handle printf like formating.
 - Extensive cleaning of pragmas and unnecessary forward declarations.
 - Parameter packs and libfmt provide a much stronger type checking now, so
   conversions that are by standard implicit as bool to int need an explicit static_cast
   to avoid compilation warnings.

Extension:
 - Include a notifier field, so that the originator of the message can be provided. E.g. Document#DocumentObject
 - Include a new type of message called CriticalMessage, this message is intended to have
   special behaviour in the future. Namely, it will be used to notify forward compatilibity issues.
   It will be used to substitute the current signal/slot mechanism.
 - Include two new types of messages for user notifications (Notification and TranslatedNotification). This messages
   will be use to convey UI notifications intended for the user (such as non-intrusive message about the usage of a tool). There
   are two versions to mark whether the string provided as a message is already translated or not. When using the console system for
   notifications, these notifications may originate from the App or the Gui. In the former, it is generally the case that the strings
   of messages are not (yet) translated (but they can be marked with QT_TRANSLATE_NOOP). In the latter, often the messages to be provided
   are already translated.

Python support for CriticalMessage, Notification and TranslatedNofification, including shortcuts:

    Crt = FreeCAD.Console.PrintCritical
    Ntf = FreeCAD.Console.PrintNotification
    Tnf = FreeCAD.Console.PrintTranslatedNotification
2023-03-07 16:13:23 +01:00
xtemp09
692399787b [TechDraw] Improved readability of DrawViewSpreadsheet.cpp
I was stretching my fingers
2023-03-04 09:59:02 -05:00
wandererfan
704fb894a5 [TD]getters and setters for geometry
- make attributes private (or protected) and use
  getters and setters instead of accessing attributes
  directly.
2023-02-28 08:15:06 -05:00
Uwe
b846722f3a [TD] fix compiler about a variable redefinition 2023-02-26 10:31:36 +01:00
wandererfan
25e6f33725 [TD]centralize balloon prefs 2023-02-11 13:30:15 -05:00
wandererfan
b6754947f1 [TD]use correct shape for section of section 2023-02-02 05:55:32 -08:00
wandererfan
86d0975b2c [TD]fix handling of perforated section faces 2023-02-02 05:55:32 -08:00
luzpaz
91a336b659 TechDraw: header uniformity + trailing whitespace 2023-01-21 20:11:08 -05:00
wandererfan
547df2b4df [TD]apply tester feedback on DimRepair 2023-01-18 17:48:22 -05:00
Uwe
c792e7b6c5 [TD] remove unused Console include
- no longer used since #8180
2023-01-14 02:39:43 +01:00
wandererfan
bc036abb30 [TD]Allow balloons to be attached to non-part views 2023-01-13 12:15:33 -05:00
wandererfan
437457e996 [TD]remove obsolete log messages 2023-01-13 12:15:33 -05:00
Uwe
1ca527c6ad [skip ci] [TD] fix a typo as reported by the CI 2023-01-09 15:47:40 +01:00
Uwe
c947055821 [TD] remove unused headers (#8155)
* [TD] remove unused headers

- also some sorting
- also improve readability by not using an abbreviation (we consistently don't abbreviate class names)
2023-01-09 14:55:22 +01:00
Uwe
864ef31d81 [TD] minor fixes
- typos and code formatting as reported by the CI
- some more re-sorting
2023-01-09 12:02:50 +01:00
wmayer
c80a60d8be TD: fixes #8144: TD crash 2023-01-09 11:43:14 +01:00
Uwe
79ae9b8280 [TD] attempt to fix compilation with PCH after #8141
- also resort includes
2023-01-09 11:26:51 +01:00
wandererfan
97b6788464 [TD]fix wrong calculation of 3d two edge angle 2023-01-07 16:32:03 -05:00
wandererfan
7d5c47c633 [TD]fix exception on empty list during restore 2023-01-07 16:32:03 -05:00
wandererfan
88c7aac0d9 [TD]fix issues reported by 3d dimension testers
- correct interpretation of True vs Projected

- handle long subelement names in references

- fix "too small" value condition

- better error messages for bad dimension geometry
2023-01-07 16:32:03 -05:00
wandererfan
208104e9e0 [TD]Refactor Dimensions for 3d upgrade
- separate validation, geometry and reference handling into
  individual files
- improve 3d reference geometry handling
- eliminate duplicate dim creation code

- add Dimension reference repair dialog

- Refactor formatting out of DrawViewDimension

- move dimension repaint control to ViewProvider
2023-01-07 16:32:03 -05:00
wandererfan
0e402ae075 [TD]add light text on dark page mode
- some visually impaired users need white graphics on
  dark page.

- revise Annotation dialog to respect dark style
2023-01-03 17:41:33 -05:00
wandererfan
1f3bfe0dd4 [TD]make detail highlight interactive
- drag detail highlight to change detail anchor point
- change detail reference position using HighlightAdjust property
2022-12-28 09:41:44 -05:00
wandererfan
ff1147fbae [TD]add extensions for drag and drop 2022-12-27 19:43:44 -05:00
wandererfan
411bf827a7 [TD]remove debug statements 2022-12-26 12:13:34 -05:00
wandererfan
02ca0ff998 [TD]fix startup exception on empty compound 2022-12-26 12:13:34 -05:00
wandererfan
99114448b6 [TD]fix expression in Scale fails to propagate 2022-12-20 19:08:36 -05:00
wandererfan
100d4956c8 [TD]detail of rotated ComplexSection 2022-12-18 09:42:42 -05:00
wandererfan
02386e3150 [TD]move makeAlignedPieces to separate thread
- correct ComplexSection rotation

- fix fail to load CS for some profiles and directions
2022-12-18 09:42:42 -05:00
wandererfan
fbc458df66 [TD]fix parent page counting
- was returning inflated counts of owning page
2022-12-18 09:42:42 -05:00
wandererfan
ea6fb190f1 [TD]remove problematic boost check for planarity
- boost check for planar graph was consuming memory until
  crashing.
- since all our edges have been projected onto a plane, we
  don't require this check
2022-12-17 08:07:05 -05:00
Uwe
2dcddfef7d [skip ci] [TD] only whitespace and sorting 2022-12-12 02:23:22 +01:00
wandererfan
362d15f967 [TD]fix wrong error message on load
- also improve temp file name generation
2022-12-11 19:11:28 -05:00
wmayer
6c7c001618 TD: [skip ci] fix build failure with boost >= 1.78 on Windows 2022-12-08 22:11:33 +01:00
Uwe
7e70d28761 [TD] Task*, part 2/2: remove unused includes
- also some sorting
- also take care of PreCompiled.h
2022-12-07 19:49:05 +01:00
wandererfan
6cc849fb73 [TD]allow rotation of hatch directions
- faces can have their svg and bitmap hatches rotated to match
  the view rotation or special situations
- section cut face can have svg hatch rotated
2022-12-03 15:15:25 -05:00
wmayer
3df86553f8 TD: [skip ci] fix warnings reported by GH actions 2022-11-27 16:51:15 +01:00
wandererfan
4b02daa895 [TD]fix ComplexSection null cut shape 2022-11-27 08:21:40 -05:00
wandererfan
02008c8877 [TD]fix fail on missing base view (#7856) 2022-11-22 20:38:46 -05:00
Aapo
d0d511f940 [TD] DrawViewPart: Fix Dimension attachment for Coarse Views and faceless Views 2022-11-20 08:08:33 -05:00
Aapo
300ca5b206 [TD] DrawViewPart: Fix Dimension attachment on Cosmetic CenterLines upon document restore 2022-11-17 19:25:43 -05:00
wmayer
77bae9c9a0 TD: fix memory leaks with raw pointers of GeometryObject
Replacing the use of raw pointers of GeometryObject with shared pointers fixes the observed memory leaks when running the unit tests of TechDraw
2022-11-15 16:16:08 -05:00
luz paz
2d94a99740 TechDraw: remove trailing whitespace 2022-11-15 16:17:22 +01:00
wandererfan
356faf94da [TD]prevent Complex Section with no Base View 2022-11-14 19:41:12 -05:00
wandererfan
33bee19d81 [TD]add section line marks for simple section 2022-11-14 19:41:12 -05:00
marioalexis
232b27517c TechDraw: Improve and clean up code in some Python classes 2022-11-14 16:40:07 -05:00