Commit Graph

74 Commits

Author SHA1 Message Date
Uwe
c947055821 [TD] remove unused headers (#8155)
* [TD] remove unused headers

- also some sorting
- also improve readability by not using an abbreviation (we consistently don't abbreviate class names)
2023-01-09 14:55:22 +01:00
Uwe
79ae9b8280 [TD] attempt to fix compilation with PCH after #8141
- also resort includes
2023-01-09 11:26:51 +01:00
wandererfan
88c7aac0d9 [TD]fix issues reported by 3d dimension testers
- correct interpretation of True vs Projected

- handle long subelement names in references

- fix "too small" value condition

- better error messages for bad dimension geometry
2023-01-07 16:32:03 -05:00
wandererfan
208104e9e0 [TD]Refactor Dimensions for 3d upgrade
- separate validation, geometry and reference handling into
  individual files
- improve 3d reference geometry handling
- eliminate duplicate dim creation code

- add Dimension reference repair dialog

- Refactor formatting out of DrawViewDimension

- move dimension repaint control to ViewProvider
2023-01-07 16:32:03 -05:00
Uwe
44a91217a2 [TD] DrawView*: remove unused includes - part 1
- also sort includes
- also additions to precompiled header
2022-10-07 01:08:38 +02:00
wandererfan
9e60f1bbef [TD]fix extent dimension 2022-09-09 13:02:08 -04:00
wandererfan
aa2b1b8392 [TD]CI clang warnings 2022-09-05 17:48:38 -04:00
wmayer
5f91eaa5eb TD: modernize C++: replace 'typedef' with 'using' 2022-08-30 10:59:39 +02:00
Wanderer Fan
81949d0817 [TD]use new style QObject::connect 2022-08-21 21:18:26 -04:00
Wanderer Fan
aa1193559b [TD]clazy warnings and duplicate setter/getter
- clazy warning re missing Q_OBJECT

- include TechDrawGlobal.h in headers

- resolve duplicate setter/getters
2022-08-18 09:34:32 -04:00
berniev
71dc5ead2f Mod: Use override etc 2 2022-08-09 12:52:26 +02:00
berniev
f4ffd15864 Mod: redundant void 2 2022-08-08 10:27:50 +02:00
wmayer
c5910c1530 TD: [skip ci] Fix several clazy issues:
* Using copy-ctor but class TechDraw::anglePoints has a trivial copy-ctor but non trivial assign operator [-Wclazy-rule-of-two-soft]
* Using copy-ctor but class TechDraw::arcPoints has a trivial copy-ctor but non trivial assign operator [-Wclazy-rule-of-two-soft]
* Missing reference in range-for with non trivial type [-Wclazy-range-loop-reference]
* C++11 range-loop might detach Qt container (QList) [-Wclazy-range-loop-detach]
* signal arguments need to be fully-qualified (TechDrawGui::QGIView instead of QGIView) [-Wclazy-fully-qualified-moc-types]
* Use multi-arg instead [-Wclazy-qstring-arg]
* Use midRef() instead [-Wclazy-qstring-ref]
2022-07-25 17:00:48 +02:00
Wanderer Fan
60b79e0d72 [TD]fix Dimension export to DXF 2022-06-30 08:50:07 -04:00
Uwe
60012cd27e [TD] App Headers: remove unused header - part 2 2022-03-25 00:01:49 +01:00
Wanderer Fan
37014eb586 [TD]fix unit display to standards 2022-03-13 19:04:42 -04:00
Wanderer Fan
959061720f [TD]Allow override of dimension line angles 2022-01-27 09:42:49 -05:00
Aapo
dbef970697 [TD] Add under- and overtolerances for Dimension Task layout, fixes for Dimension tolerance refresh and behavior. 2021-01-31 15:17:46 +01:00
Aapo
e6ef62e711 [TD] Fix regression in Dimensions: Setting arbitrary under tolerance was somehow lost. 2021-01-31 15:17:46 +01:00
donovaly
96eaff8e4e [TD] some fixes
- the setting "Standard and Style" only affects new dimensions, thus it must be italic

- fix bug that the Property 'LockPosition' appears for dimensions -> this is an option for views and thus must be hidden for dimensions

- since tolerances are in the vast majority fractions of a millimeter/inch, set its stepsize to 0.1
(I hope I did it right in handleChangedPropertyType.)

- fix inconsistent newlines in TaskBalloon.h

- improve wording for a heading
2021-01-10 00:29:34 +01:00
donovaly
2232b1d48e [TD] handle equal tolerances correctly
the common rule is that if a dimension has equal over- and undertolerance, they are output on the same line as the dimension concatenated using the ± character.

This PR does this.

Note that this is not just cosmetics, it is even standardized in the GD&T norms.

also:
* use one format specifier for tolerances since the norms don't allow a different format for the over- and the undertolerance
* some code optimizations like a self-explaining function name, remove unnecessary/outdated comments
2021-01-08 15:14:37 +01:00
Aapo
2077709329 [TD] Make Dimension Tolerances respect the Prefs formatSpec when creating a Dimension. 2020-12-17 17:30:29 +01:00
donovaly
a2b523fb39 [TD] fix unit mismatch bug
- also make global decimal option italic since it only affects new dimensions
- also fix a typo in UnitsApi.h
2020-12-03 15:50:06 +01:00
wmayer
2c599495a9 [TD] use PropertyQuantity for OverTolerance and UnderTolerance and add backward compatibility 2020-12-02 16:42:10 +01:00
aapo-aapo
3935ef8b8f @aapo-aapo @chennes [TD] Suggested minor improvements for DrawViewDimension.cpp and QGIViewDimension.cpp in Pull request review.
Co-authored-by: Chris Hennes <chennes@pioneerlibrarysystem.org>
2020-12-02 16:38:21 +01:00
Aapo
40bd4b806f [TD] Add tolerance format specifiers and arbitrary tolerances. 2020-12-02 16:38:21 +01:00
Aapo
e7b4d9ed99 [TD] Refactor DrawViewDimension getFormatedValue() into two functions. 2020-12-02 16:38:21 +01:00
Aapo
5ed116283c Refactor code in DrawViewDimension::getRefType() shorter and simpler. No functional change except subelement sizes > 3 are supported, even though they are not supposed to happen. 2020-11-19 13:40:42 +01:00
wandererfan
96d296adf8 [TD]change Angle Dim tolerance format 2020-08-22 08:56:57 -04:00
wandererfan
0e4d893651 [TD]missing prefix/suffix for compound schema 2020-06-15 13:57:55 -04:00
wandererfan
db97daf0e0 [TD]expose dimension arrow position to Python 2020-03-02 08:37:19 -05:00
wandererfan
d1d7098ad6 [TD]Support Landmark Dim in Section and Detail 2020-02-25 17:21:00 -05:00
wandererfan
cb2a3d529c [TD]Landmark Dims initial impl 2020-02-25 17:21:00 -05:00
wmayer
7f77b1e6c9 TechDraw: [skip ci] fix -Winconsistent-missing-override 2019-12-29 00:02:15 +01:00
WandererFan
eb46f15159 [TD]fix overload warning 2019-12-27 20:27:19 -05:00
wandererfan
ed6adae509 [TD]fix dim text for multi value schemas 2019-12-05 07:10:08 -05:00
wandererfan
e64929de14 [TD]const-ness for dump function parameter 2019-11-10 15:58:45 -05:00
wandererfan
b34eb9de77 [TD]Implement unique tags for Cosmetic Vertex 2019-11-02 14:59:32 -04:00
wandererfan
b1e61bcae7 [TD]Improve tolerance formatting 2019-10-11 09:16:41 -04:00
Tomas Pavlicek
39518f8dff Complete remake of drawing dimensions 2019-09-25 15:20:14 +02:00
wandererfan
9828655f48 [TD]Add Properties for Cosmetic persistence 2019-07-15 12:36:48 -04:00
wandererfan
fbfdb69c20 [TD]Py Cosmetic Vertex, Line, Circle Arc 2019-07-15 12:36:48 -04:00
wandererfan
8f35f4c956 Add 3Point Angle Dimension 2018-10-02 09:42:16 -03:00
wandererfan
9f6b61a2a9 Add over/under Tolerance to Dimensions 2018-10-02 09:42:16 -03:00
wandererfan
87bad86dd1 Coverity Fixes
- 175807
- 175808
- 183598
2018-08-18 21:59:06 +02:00
wandererfan
fdaf316e9e Add #3337 Arbitrary Dimension 2018-04-25 11:09:39 +02:00
wandererfan
9bcc7da599 Fix exterior angle arc and value 2018-04-25 11:09:39 +02:00
wandererfan
e9eeea9318 Remove duplicate code/save Dim line geom 2018-04-25 11:09:39 +02:00
WandererFan
bdba11d965 Dimension Graphic Properties to Gui side 2018-02-14 15:42:26 -05:00
WandererFan
d9b71fb754 LinkScope clean up 2017-12-31 14:54:05 +01:00