Commit Graph

33 Commits

Author SHA1 Message Date
donovaly
0a1312e9f5 [PD] fix logic of TaskPrimitiveParameters dialog
- only allow geometrically possible values for the different parameters
- this way also fix a crash
- fix a typo

see https://forum.freecadweb.org/viewtopic.php?f=3&t=44467
2020-03-24 08:36:06 +01:00
donovaly
172e28b6b4 [PD] add expressions to primitive dialog
see https://forum.freecadweb.org/viewtopic.php?f=3&t=36458
(a step forward to fix bug https://tracker.freecadweb.org/view.php?id=3981 )
2020-03-21 22:06:40 +01:00
wmayer
25b3cfc170 issue #0004188: Editing a subtractive box in PartDesign doesn't show the shaded box 2020-01-15 10:00:47 +01:00
wmayer
bff7369e54 fixes #0004188: Editing a subtractive box in PartDesign doesn't show the shaded box 2020-01-15 01:33:28 +01:00
wmayer
9270322d25 Mod: [skip ci] implementation classes don't inherit from UI classes any more 2020-01-10 16:19:35 +01:00
Zheng, Lei
11a93a0578 PartDesign changes
* Mostly for supporting in-place editing

* Add new SubShapeBinder that support cross coordinate system,
  external, and sub-object binding
2019-08-17 15:15:47 +02:00
Abdullah Tahiri
e82c154d1d PartDesign: PCH GUI 2019-05-02 07:12:51 +02:00
wmayer
638845a6f0 fixes 0003845: unwanted rounding for dimensions of subtractive shapes in task dialog 2019-02-19 09:50:12 +01:00
wmayer
f898eafd64 move from deprecated boost.signals to boost.signals2 library 2018-10-30 19:09:03 +01:00
luz.paz
7a09a5774e More misc. typos 2018-05-19 12:17:52 -04:00
wmayer
a20e13b8ae avoid superfluous transaction on PD primitive creation 2018-02-09 23:10:40 +01:00
Abdullah Tahiri
d455600b65 Part Design: Avoid feature modification during initialization
=============================================================

The values for the primitives are set after the connections to the slots "onchange" are connected.

This causes a river of onChanges at feature level which set the properties and modify the feature (to the same values).

Moving the connections at the end of the function just solves this issue.
2018-02-09 16:01:19 +01:00
wmayer
004324bbc5 fix scan coverity issues: uncaught exception 2017-04-11 14:03:08 +02:00
wmayer
8a100bf627 issue #0002836: Crash in sketcher 2017-01-23 22:48:02 +01:00
Stefan Tröger
c4ec348fbd PartDesign: Show origin for primitive editing 2017-01-04 16:01:58 +01:00
Stefan Tröger
b758df7193 Port attachment UI to Part for general use
Furthermore change PartDesign primitives to use the new task dialog
2016-12-07 06:41:40 +01:00
Stefan Tröger
bc133e4de2 PartDesign: Primitives are attachable directly
With the recently introduced AttachExtension the PartDesign primitives can be attachable by themself and don't need anymore the helping coordinate system datum. This simplyfies the code and the TreeView largely
2016-12-07 06:41:40 +01:00
wmayer
3b961bcb5f + add convenience method recomputeFeature()
+ make method recompute() protected
2016-11-06 17:16:50 +01:00
Sergo
ef14bbd88a PartDesign: fix showing base object on newly opened file, cleanup 2016-09-30 11:09:01 -03:00
wmayer
f44df3cdf0 do not use doCommand without using format string, add overloaded method of runCommand 2016-09-15 18:53:37 +02:00
wmayer
6b4821a855 + fix crash on abort of adding primitives 2016-04-24 14:17:01 +02:00
Mateusz Skowroński
b5519922d8 QString::fromAscii() is obsolete in Qt5. Replace it with fromLatin1().
This change is Qt4/Qt5 neutral.
2016-04-15 11:55:12 +02:00
Stefan Tröger
8b0d53358a PartDesign: Adopt primitive preview
The preview was developed when the "one feature only" visibility rule was not yet introduced. This commit maks it work again.
2016-04-12 18:12:23 +02:00
Alexander Golubev
0cfc0cd424 Fix warnings introduced in new PartDesign
Mostly unused wariables and compare of signed & unsigned
2016-04-12 18:12:21 +02:00
Stefan Tröger
54646ef5bd fix wrong torus addition 2016-04-12 18:12:08 +02:00
Stefan Tröger
ec68192fcf fix primitive following cs in edit mode and add python console output when closing the task 2016-04-12 18:12:08 +02:00
Stefan Tröger
c5ae4530ab add primitive preview visualization 2016-04-12 18:12:08 +02:00
Stefan Tröger
7971bdbb8e delete primitive if initial task is canceled 2016-04-12 18:12:07 +02:00
Stefan Tröger
49eb5467f7 add gui for remaining primitives 2016-04-12 18:12:07 +02:00
Stefan Tröger
fec86abc09 visualize the primitive add/sub shape in edit 2016-04-12 18:12:07 +02:00
Stefan Tröger
1f180a11da make primitive task box work 2016-04-12 18:12:07 +02:00
Stefan Tröger
7654659c18 add primitive widget to task dialog 2016-04-12 18:12:07 +02:00
Stefan Tröger
0385734339 primitive bug fixes, add cylinder and sphere 2016-04-12 18:12:07 +02:00