Commit Graph

25 Commits

Author SHA1 Message Date
Russell Johnson
83118395c1 Path: Fix translation issues for Slot operation 2022-02-11 06:34:07 -06:00
luz paz
19e984f8c9 Fix various typos
Found via `codespell -q 3 -L aci,ake,aline,alle,alledges,alocation,als,ang,anid,apoints,ba,beginn,behaviour,bloaded,bottome,byteorder,calculater,cancelled,cancelling,cas,cascade,centimetre,childrens,childs,colour,colours,commen,connexion,currenty,dof,doubleclick,dum,eiter,elemente,ende,feld,finde,findf,freez,hist,iff,indicies,initialisation,initialise,initialised,initialises,initialisiert,inout,ist,kilometre,lod,mantatory,methode,metres,millimetre,modell,nd,noe,normale,normaly,nto,numer,oce,oder,ontop,orgin,orginx,orginy,ot,pard,parm,parms,pres,programm,que,rady,recurrance,rougly,seperator,serie,sinc,strack,substraction,te,thist,thru,tread,uint,unter,vertexes,wallthickness,whitespaces -S ./.git,*.po,*.ts,./ChangeLog.txt,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/CXX,./src/zipios++,./src/Base/swig*,./src/Mod/Robot/App/kdl_cp,./src/Mod/Import/App/SCL,./src/WindowsInstaller,./src/Doc/FreeCAD.uml,./build/doc/SourceDocu`
2022-01-12 14:50:39 -06:00
Russell Johnson
cfca2a790a Path: Allow parent job assignment
Modifications focus on allowing the creation of operations to include direct provision of parent job.
Path: Remove `useGui` implementation
2021-08-13 19:02:40 -05:00
luz paz
427a2ab8d6 Path: fix various typos and superfluous whitespace
Found via `codespell -q 3 -L aci,ake,aline,alle,alledges,alocation,als,ang,anid,apoints,ba,beginn,behaviour,bloaded,bottome,byteorder,calculater,cancelled,cancelling,cas,cascade,centimetre,childs,colour,colours,commen,connexion,currenty,dof,doubleclick,dum,eiter,elemente,ende,feld,finde,findf,freez,hist,iff,indicies,initialisation,initialise,initialised,initialises,initialisiert,inout,ist,kilometre,lod,mantatory,methode,metres,millimetre,modell,nd,noe,normale,normaly,nto,numer,oder,ontop,orgin,orginx,orginy,ot,pard,parms,pres,programm,que,recurrance,rougly,seperator,serie,sinc,strack,substraction,te,thist,thru,tread,uint,unter,vertexes,wallthickness,whitespaces -S ./.git,*.po,*.ts,./ChangeLog.txt,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/CXX,./src/zipios++,./src/Base/swig*,./src/Mod/Robot/App/kdl_cp,./src/Mod/Import/App/SCL,./src/WindowsInstaller,./src/Doc/FreeCAD.uml,./build/doc/SourceDocu`
2021-07-30 11:53:22 -04:00
Russell Johnson
926baf8ce8 Path: Improve horizontal-planar and curved face handling
These changes allow for better identification of horizontally planar faces, and also improve handling of circular arc faces that failed previously for use with ball-end bits.
This fix also improves slot creation based on selection of two arc edges for ball-end slot creation.
2021-04-08 22:43:33 -05:00
Russell Johnson
16d1422bb0 Path: Fix comment syntax 2021-04-08 22:43:33 -05:00
Russell Johnson
fc2e249943 Path: Fix variable naming to use lowercase 2021-04-08 22:43:33 -05:00
Russell Johnson
4a5513cc58 Path: Fix error when no obj.Base features selected 2021-04-08 22:43:32 -05:00
Russell Johnson
d1174dc4b3 Path: Add check for CustomPoint input
If custom points are same, the user has not entered acceptable values for path generation with custom points.
2021-04-08 22:43:32 -05:00
Russell Johnson
90564ea3fd Path: Set CustomPoint2 and CustomPoint1 defaults equal
Setting these two default values equal will aid in code execution and error detection.  Subsequent fixes will rely on this condition.
2021-04-08 22:43:32 -05:00
luz paz
fb52f3177d Path: fix typos in comments [skip ci]
Found via codespell
2021-02-14 10:45:38 +01:00
J-Dunn
94536f9877 Path: fix several minor bugs in arc slot ops
This corrects which end of the slot Extend Slot Start/End are applied; error with Extend lengths between 0 and 1  and direction of extention on arc slots ( neg. is shorten ). 
Some renaming to make code more readable and self documenting.
2021-01-06 12:10:29 +00:00
luz paz
ff96cb301e Fix typos [skip ci]
Found via `codespell v2.1.dev0`
2020-12-23 14:32:38 -05:00
Russell Johnson
d67f636d9d Path: Fixes to path generation for certain selections
Fixes path generation for selection of two non-parallel edges.
Fixes path generation for selection of single, bottom face of slot with two non-parallel ends.
Fixes path generation for selection of two parallel, bottom bounding edges of slot.
2020-12-18 16:04:07 -06:00
Russell Johnson
3b2d06a481 Path: Add docStrings to some methods 2020-12-18 16:04:07 -06:00
Russell Johnson
4d35905a60 Path: LGTM and spelling correction 2020-12-18 16:04:07 -06:00
Russell Johnson
d41369ad52 Path: LGTM cleanup 2020-11-22 18:27:21 -06:00
Russell Johnson
c6d5bb8404 Path: Implement LazyLoader for Arcs module 2020-11-22 18:27:21 -06:00
Russell Johnson
a61aa0563e Path: Fix g-code arc direction
Fixed incorrect point orders assigned to g2 and g3 commands.
Add application of `ReverseDirection` property to `ZigZag` cut pattern.
Make default arc direction clockwise(g2) for all cut patterns and layer modes.
Make tool diameter access backward compatible.
2020-11-22 18:27:21 -06:00
Russell Johnson
9f489b59eb Path: Simplify and fix debugging code 2020-11-22 15:38:50 -06:00
Russell Johnson
a0d7ff24e0 Path: Standardize debugging mode control code 2020-11-22 15:37:31 -06:00
luz paz
b75cd3dd52 Path: Fix header uniformity and remove trailing whitespace
This PR fixes header uniformity across all Path files. It also removes all trailing whitespace.
2020-11-05 19:57:21 +01:00
Russell Johnson
4b02dace0d Path: Add basic support for arc and circular edges
- Arc and circular slots available using single edge selection.
- `ExtendRadius` property to allow for tool compensation.
- Extend path start and end is available. Value is measured along the arc, not linear.
- Includes collision check for arc and circular slots.
2020-07-02 01:16:22 -05:00
Russell Johnson
cfa6ad5de6 Path: Slot operation fixes and improvements
- Add `CutPattern` feature, defaulting to `ZigZag`.
- Change inter-pass retractions to SafeHeight for multi-pass operations.
- Fix division by zero instance for particular Perpendicular use case.
- Synchronize property values with inputs in both the Property View and Tasks Editor windows.
- Change `LayerMode` default value to `Multi-pass`.
- Improve debug messaging.
- Consolidate code and remove unused code.

Path: fix exception thrown
2020-06-20 14:27:12 -05:00
Russell Johnson
f323e635bd Path: Add new Slot operation
New slotting operation:
- Accepts selection of up to two features.
- Selectable features include: faces, edges, and vertices.
- User may select a single face or edge, or a pair of features.
- The path may be extended at the start and end.
- The path may be reversed.
- The path may be altered to the perpendicular in some cases.
- A unique Slot icon is included.
- Includes simple collision detection with warning message.
2020-06-18 19:56:52 -05:00