Commit Graph

72 Commits

Author SHA1 Message Date
tritao
551c2e48fb Gui: Reorganize the selection files into a top Selection folder. 2025-02-03 17:56:57 +01:00
Benjamin Nauck
6f535f19fb Prefer to use BaseClass's isDerivedFrom<T> over non template or Base::Type's
Regex based changes, manually verified
2025-01-27 16:08:18 +01:00
Ladislav Michl
0b3adee2ab Base: Quantity: return std::string 2024-12-23 17:48:42 +01:00
Ladislav Michl
e62b91ada4 Base: Drop QString-std::string conversion functions from Tools
Convenience helpers function Tools::toStdString and Tools::fromStdString
were implemented for Qt4 or older to perform utf8 aware conversion as
QString::toStdString/QString::fromStdString were using toAscii/fromAscii
internally (see https://dreamswork.github.io/qt4/classQString.html).

Since Qt5 QString uses toUtf8/fromUTf8, which makes the helper functions
obsolete (see https://doc.qt.io/qt-5/qstring.html#fromStdString).
2024-12-02 23:30:53 -05:00
Max Wilfinger
8ff5a1f688 Fix source string typos mentioned on Crowdin (#15261) 2024-07-08 17:18:31 -05:00
wmayer
1a84404515 MSVC: Fix compiler warnings
* avoid redefines in Assembly
* explicit cast from size_t to int
* remove unused variables
* avoid implicit cast from double to float
* in test cases replace EXPECT_FLOAT_EQ with EXPECT_DOUBLE_EQ or EXPECT_NEAR when doubles are used
2024-06-20 15:42:16 -05:00
WandererFan
50f970efd7 [TD]Cosmetic function overhaul (#14216)
* [TD]Cosmetic geometry and tools update

- all cosmetics to store geometry in same form
- all cosmetics to survive scaling and rotation
- extension functions to survive scaling and rotation

* [TD]overhaul leader point storage and editing

- add py routine makeLeader(points)

* [TD]add leader conversion utility

* [TD]Set Leader RotateWithView default to true

* [TD]fix intersection vertex position

* [TD]add CosmeticEdge::makeLineFromCanonicalPoints

* [TD]fix 2 Extension tools

- positioning in DrawCosmeticCircle
- mishandling of points in execLineParallelPerpendicular

* [TD]Remove duplicate constexpr

* [TD]fix 2x Cosmetic arc tools

* [TD]refactor LineFormat out of Cosmetic

* [TD]move cosmetic appearance settings to LineFormat

* [TD]remove 2 unused methods

* [TD]apply format to blue line & circle tools

* [TD]fix ballon arrowhead does not rotate with view

* [TD]fix CosmeticCircle3Points

* [TD]allow multiple cosmetic object deletions

* [TD]fix extend/shorten centerline
2024-05-23 09:41:42 -04:00
wandererfan
b719478824 [TD]fix thread line alignment 2024-03-14 21:45:16 -04:00
wandererfan
f57c7a5aa5 [TD]fix extension bolt hole circle re scale/rotate 2024-01-27 08:07:59 -05:00
wandererfan
9e080d13ce [TD]fix extension hole thread re scale/rotate 2024-01-26 10:02:36 -05:00
wandererfan
9e9cd1342a [TD]fix extension Extend function re scale/rotate 2024-01-26 10:02:36 -05:00
wandererfan
f178206a2f [TD]handle View rotation in ExtensionPack circle centerlines 2024-01-21 09:28:19 -05:00
edi271
71df82dad3 [TD] Solve issue in VertexAtIntersection 2024-01-15 09:46:33 -05:00
wandererfan
de320363c9 [TD]use standard lines & LineFormat in extensions 2023-12-27 19:46:34 -05:00
wandererfan
023dd8ed8a [TD]fix location of CV on rotated views 2023-12-24 12:27:25 -05:00
edi271
c40d0c3ef8 [TD]Remove PositionSectionView, solve Line Style issue 2023-12-21 16:04:36 +01:00
pavltom
cc12843e1d [TechDraw] Use OCC to compute intersections - drop limits from hint 2023-12-02 13:54:37 -05:00
pavltom
289dda439a [TechDraw] Use OCC to compute intersections of any types of curves 2023-12-02 13:54:37 -05:00
wandererfan
d4e1731716 [TD]Standard Line Styles - Gui components 2023-12-01 11:27:29 -05:00
wandererfan
b8bea76481 [TD]spelling in comments 2023-11-26 16:42:06 -05:00
pavltom
b8278718e9 [TechDraw] Implement arc length calculation for arbitrary edge 2023-11-26 08:53:39 -05:00
pavltom
2e45b3f856 [TechDraw] Fix area balloon placement for scale != 1 2023-11-26 08:53:39 -05:00
pavltom
f04bac3838 [TechDraw] Fixes #7317 - Calculate Area of Arbitrary Faces 2023-11-23 19:47:04 -05:00
wandererfan
22a73f7d2f [TD]fix 3x extension circle methods #11310 2023-11-11 07:48:03 -05:00
wandererfan
d836baacc2 [TD]fix missing translations 2023-07-02 09:18:06 -04:00
wandererfan
50c2b7e9d8 [TD]fix missing selection guard
- Area dimension extension was not checking that only
  faces were in the selection.
2023-04-10 14:18:34 -04:00
Benjamin Bræstrup Sayoc
0bfae905d9 [TechDraw] Move CenterLine into own file 2023-04-06 13:51:35 -04:00
edi271
c9c82960ab Manage rotated section views 2023-04-05 08:23:47 -04:00
wandererfan
704fb894a5 [TD]getters and setters for geometry
- make attributes private (or protected) and use
  getters and setters instead of accessing attributes
  directly.
2023-02-28 08:15:06 -05:00
wandererfan
bc036abb30 [TD]Allow balloons to be attached to non-part views 2023-01-13 12:15:33 -05:00
Uwe
a722122807 [TD] Gui, A*-C*: remove unused includes
- also sort includes
- also an addition to precompiled header
- TaskCenterLine: remove unused code that interferes with used code with the same name
2022-10-09 03:34:53 +02:00
wandererfan
aa2b1b8392 [TD]CI clang warnings 2022-09-05 17:48:38 -04:00
Wanderer Fan
aa1193559b [TD]clazy warnings and duplicate setter/getter
- clazy warning re missing Q_OBJECT

- include TechDrawGlobal.h in headers

- resolve duplicate setter/getters
2022-08-18 09:34:32 -04:00
berniev
f4ffd15864 Mod: redundant void 2 2022-08-08 10:27:50 +02:00
wmayer
c5910c1530 TD: [skip ci] Fix several clazy issues:
* Using copy-ctor but class TechDraw::anglePoints has a trivial copy-ctor but non trivial assign operator [-Wclazy-rule-of-two-soft]
* Using copy-ctor but class TechDraw::arcPoints has a trivial copy-ctor but non trivial assign operator [-Wclazy-rule-of-two-soft]
* Missing reference in range-for with non trivial type [-Wclazy-range-loop-reference]
* C++11 range-loop might detach Qt container (QList) [-Wclazy-range-loop-detach]
* signal arguments need to be fully-qualified (TechDrawGui::QGIView instead of QGIView) [-Wclazy-fully-qualified-moc-types]
* Use multi-arg instead [-Wclazy-qstring-arg]
* Use midRef() instead [-Wclazy-qstring-ref]
2022-07-25 17:00:48 +02:00
Uwe
7b4e5d7522 [TD] remove more superfluous nullptr checks 2022-07-20 02:32:52 +02:00
Benjamin Bræstrup Sayoc
0bf342b1d8 [TechDraw] Improve readability of commands 2022-07-09 13:07:30 -04:00
Wanderer Fan
db89eec8e3 [TD]implement navigation styles 2022-06-24 10:03:02 -04:00
Wanderer Fan
1c97b3d5df [TD]fix ExtendShorten handling of CenterLine 2022-04-23 18:43:27 -04:00
Wanderer Fan
f53ac146c0 [TD]fix ExtendLine changes CenterLine
- extendShortenLine converts CenterLines to CosmeticEdges
2022-04-23 18:43:27 -04:00
wmayer
ccc0d54d97 TD: [skip ci] activate PCH of TechDraw (Gui) and use forward declarations
For MSVC this reduces compile time by ~20%
2022-03-25 13:54:47 +01:00
wmayer
883012e4b0 TD: Fix several coverity issues:
* CID 316569: Uninitialized scalar variable
* CID 350651: Unchecked dynamic_cast
* CID 350565: Unchecked dynamic_cast
* CID 350595: Unchecked dynamic_cast
* CID 350638: Unchecked dynamic_cast
* CID 350547: Division or modulo by float zero
2022-03-13 15:40:49 +01:00
wmayer
8f786ea6ef Gui: Optimize includes to reduce compile time 2022-03-07 20:29:18 +01:00
Wanderer Fan
7ebc4c44c9 [TD]use <br> in ToolTipText vs \n 2022-03-03 09:31:01 -05:00
Wanderer Fan
4a97a6244c [TD]fix area scale and make unit aware 2022-03-03 09:31:01 -05:00
wmayer
79f8e33b87 TD: further security checks in CmdTechDrawExtensionPositionSectionView::activated 2022-02-28 19:09:31 +01:00
wmayer
f301532efb TD: improve handlings with casts 2022-02-28 18:56:28 +01:00
andrea reale
9b0d9ca6fc Fix uninitialized variable 2022-02-28 18:53:09 +01:00
luz paz
6718d8797e Fix some typos and whitespace 2022-02-12 19:33:28 +01:00
edi271
fcb423992b New tool circle through 3 points 2022-02-02 08:35:34 -05:00