kindred/create
1
1
Fork 0
Code Issues 36 Pull Requests 1 Actions 4 Packages Projects 9 Releases 2 Wiki Activity
35,341 Commits 41 Branches 6 Tags
560898907b317893d90e3a031c41ea1d63109dd9
Commit Graph

34 Commits

Author SHA1 Message Date
André Caldas
560898907b Avoids using getNameInDocument() to test if DocumentObject is attached to a Document. 
This patch substitutes by isAttachedToDocument() (almost) everywhere where
getNameInDocument() is used for this purpose.

The very few places not touched by this patch demand a (just a little) less trivial change.
When we change the returning type of getNameInDocument() to std::string,
those places will be easily found, because they shall generate a compiler error
(converting std::string to bool).

Rationale:
The fact that getNameInDocument() return nullptr to indicate
that the object is not attached to a document is responsible for lots of bugs
where the developer does not check for "nullptr".

The idea is to eliminate all those uses of getNameInDocument() and, in the near future,
make getNameInDocument() return always a valid std::string.
 2023-12-11 17:37:58 +01:00
Florian Foinant-Willig
6adc675a12 PartDesign: modernize type checking 2023-10-23 18:08:16 +02:00
wmayer
ca1cb21498 PD: modernize C++: use equals default 2023-08-22 13:31:17 +02:00
wmayer
9a1f8a11d6 PD: modernize C++: use range-based for loop 2023-08-16 21:54:56 -05:00
wmayer
899932cec0 Part/PD: modernize C++: redundant void arg 2023-08-05 16:50:31 +02:00
Chris Hennes
b03783f274 PD: Attempt to translate exceptions in dialogs 
Relies on the exception text having been added to the translation database in a previous call to QT_TRANSLATE_NOOP, and put in the 'Exception' context.
 2023-04-27 17:41:41 -05:00
wmayer
12ed13ddbe PD: move to new style connect() 2023-01-15 14:27:33 +01:00
berniev
b796a0d376 Mod: use empty 2022-08-06 19:30:13 +02:00
Uwe
697e88aed6 [PD] remove more superfluous nullptr checks 2022-07-18 01:33:28 +02:00
Uwe
35f75064a0 [PD] remove superfluous nullptr checks 2022-07-17 18:12:41 +02:00
wmayer
3608ee7f51 PD: modernize C++11 
* use nullptr
 2022-03-23 19:26:14 +01:00
wmayer
1ca7429705 Gui: Optimize includes to reduce compile time 2022-03-07 20:29:18 +01:00
Uwe
52a0a9ba40 [PD] Gui: Boolean to Groove: remove unused includes 2022-02-21 01:33:04 +01:00
donovaly
2ac84872ec [PD] make pointers to the UI std::unique_ptr 
Same as PR #4293, just for PartDesign

as noted in https://github.com/FreeCAD/FreeCAD/pull/4271#discussion_r554673632
the pointer to the UI should be a unique pointer.

This PR does this for all PartDesign dialogs that don't already use a unique_ptr.
 2021-02-05 18:01:57 +01:00
wmayer
88a60f91e9 PartDesign: use QKeySequence::Delete instead of a QString 2020-02-14 10:11:09 +01:00
donovaly
5ca8b490f0 [PD] add shortcut to context menus 
- people should be informed that there is a shortcut available (that was recently added)
- make the shortcut also translatable since "Del" means nothing in e.g. German
- minor code style fix in TaskDressUpParameters.h
 2020-02-14 09:59:46 +01:00
luz.paz
d38f18af23 PartDesign: [skip ci] fix header uniformity 
This PR fixes header uniformity across all PartDesign WB files
 2019-12-22 00:58:38 +01:00
Zheng, Lei
11a93a0578 PartDesign changes 
* Mostly for supporting in-place editing

* Add new SubShapeBinder that support cross coordinate system,
  external, and sub-object binding
 2019-08-17 15:15:47 +02:00
wmayer
10c745175f support Del shortcut in several PD task dialogs 2019-02-27 13:36:45 +01:00
wmayer
afc44af3e9 In boolean task panel show labels not internal names, fix adding/removing bodies 2019-02-19 20:49:14 +01:00
wmayer
b842274386 PVS: V783 Dereferencing of the invalid iterator 'b' might take place. 2019-02-17 22:39:13 +01:00
sL1pKn07
018b41032a [For v018] Fix build with Qt5 beta 
Seems need add some headers for build with incoming Qt 5.11 (Tested with 5.11.0beta2)
 2018-04-10 12:59:41 +02:00
wmayer
597dbf6094 don't allow to set empty list of bodies for boolean operations 
don't update the body feature if boolean body list is empty
 2018-03-15 12:05:13 +01:00
wmayer
d5d3513a56 remove pointless Section option from boolean operation in PD 2017-11-04 13:46:42 +01:00
Stefan Tröger
972b89d0a0 Make PartDesign::Boolean work with new Link structure 
This is the first feature that used GeoFeatureGroupExtension and required links to the groups inside as well as to things on the same level. Hence a few modifications to link scopes have been nesseccary.
 2017-09-09 16:55:55 +02:00
wmayer
f44df3cdf0 do not use doCommand without using format string, add overloaded method of runCommand 2016-09-15 18:53:37 +02:00
wmayer
e8b36592c0 fix Coverity issues 2016-08-21 18:46:40 +02:00
Mateusz Skowroński
b5519922d8 QString::fromAscii() is obsolete in Qt5. Replace it with fromLatin1(). 
This change is Qt4/Qt5 neutral.
 2016-04-15 11:55:12 +02:00
Alexander Golubev
0cfc0cd424 Fix warnings introduced in new PartDesign 
Mostly unused wariables and compare of signed & unsigned
 2016-04-12 18:12:21 +02:00
Alexander Golubev
c782a11aab PartDesign/Gui: Move various utility stuff from Workbench to a separate file 
Also do some header cleanup.
 2016-04-12 18:12:17 +02:00
Stefan Tröger
4e295c03ed fix crash in boolean op if no base feature exists 2016-04-12 18:12:12 +02:00
jrheinlaender
2d080dd92b Prevent unnecessary error messages while loading a part 2016-04-12 18:11:52 +02:00
jrheinlaender
026242231e Changed tree ordering of booleans and bodies 2016-04-12 18:11:51 +02:00
jrheinlaender
638cfd2682 Allow booleans of bodies in PartDesign 2016-04-12 18:11:51 +02:00