Commit Graph

38616 Commits

Author SHA1 Message Date
wandererfan
6b84b65841 [TD]fix segfault on confused selection
- failure in DrawDimHelper when both 2d & 3d geom selected
2024-06-16 13:15:19 -04:00
Federico Gallo Herosa
b565e72b92 Accidental symbols (+) out of place
Notice there is a recent similar fix: 2ad397e18e
2024-06-16 17:01:05 +02:00
Roy-043
da2ae11ca0 Draft: revert #14206 to fix WP alignment (#14665)
#14206 was an intermediate solution. Now that  `Part.getShape` can handle the new `SubElementNames` it needs to be removed as it breaks the handling of subelements in links.
2024-06-16 16:53:02 +02:00
shai
2a6a3649af Added a fix to issue #14613: tool shapes not shown correctly 2024-06-16 08:27:04 -05:00
shai
382ca30d19 a possible fix for MacOS systems. Issue #14348 2024-06-16 08:27:04 -05:00
shai
bd3f0893fd Fix issue #14513 - simulation of partially selected operations not working. 2024-06-16 08:27:04 -05:00
wmayer
2ad397e18e Core: Remove superfluous + operator 2024-06-16 07:53:50 +02:00
wmayer
6623b60528 Core: Make sure that PropertyMaterialList cannot become empty
The PropertyMaterialList is supposed to guarantee that it always has at least one element
2024-06-15 18:31:24 -05:00
Roy-043
f669ce6634 Ensure that the Dir vector is copied 2024-06-14 15:52:11 +02:00
Roy-043
af8da73ae3 BIM: fix extrusion vector scaling for IFC export
The Dir vector of Part Extrusions also needs to be scaled if obj.LengthFwd.Value is zero.

Forum topic:
https://forum.freecad.org/viewtopic.php?t=88121
2024-06-14 15:39:39 +02:00
Roy-043
30f7f26889 Removed WP related change 2024-06-14 10:41:35 +02:00
Roy-043
6a2eca41b3 BIM: Add IsActive to BIM_Text
Fixes #14586.
2024-06-14 10:41:35 +02:00
Roy-043
a02d4a3cff Draft: revert #14206 to fix WP alignment
#14206 was an intermediate solution. Now that  `Part.getShape` can handle the new `SubElementNames` it needs to be removed as it breaks the handling of subelements in links.
2024-06-14 10:41:35 +02:00
MisterMaker
b205922c42 Default stylesheets revision + clean-up (#13772)
* Added the new QSS file with images

Added the new QSS file with images

* fixed some disabled colors to be the same everywhere.

* update

* big update fixed the scrollbars and lots more.

* small tweaks

* small fixes

* fixed groupbox in qsint

* Added light classic

This light theme is basicallyt exactly no-stylesheet.

* fixed the tabs

* fixed background reportview

* updated overlay stylesheets

* Added preference settings from Opentheme @obelisk79

* tabbar tweaks

* forgot the gradients on dark

* Overlay stylesheets clean-up +move icon to folder.

* removing old stylesheets

removing old stylesheets

* it was icons not icon, fixed it.

* updated cmake and package.xml

* to many spaces

* removing old theme's

* updated default overlay qss

* removed my settings files

* updated cfg files

* Bunch of fixes

I compiled it and didn't see any issues anymore. Could be some discussions about the new startpage thumbnails.

* fixed up double arrows and the correct logo!

* updated the work file for the icons

* Sets no-stylesheet overlay to a stylesheet.

* type in cmakelist

* type in filename

* oeps did set the dark theme

* Update OverlayManager.cpp

I removed a bit to much reverting this line

* fixed text color issue in Qsint on the light theme and dark background

* Update Light Theme + Dark Background.qss

Fine tuning the treeview it now works good for ligth theme and dark brackgrounds.

* removed prodark added back Behave dark overlay

@Syres916 I deleted the overlay qss behave dark by accident.
But you might want to check this PR out since it changes a lot.

I deleted Pro-dark since it was not updated and is outdated and it looks also a lot like the default dark.

* Update Light Theme + Light Background.qss

Fixes

* small fixes

small fixes

* remove ProDark

* Update CMakeLists.txt

* changed the thumbnails

Also removed teh dimensions in the filename since that got annoying real fast :)

* Updated other overlay stylesheets

* missing extension

* cleanup and some fixes to the overlay.

* Update Dark Theme + Light Background.qss

udpated the dark theme overaly with light background for all you maniacs who use this.

* Title bar fix for windows

This makes it so that it uses black title bar in windows if you have dark mode

* updated white background and some colors

* I think I fix merge issue now.

* Some cleanup on the thumbnails

* Create CMakePresets.json

* idk

* trying to fix conflicts

* removing old themes

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Some fixes for Qsint sketcher toolbars icons

* fixed merge issue with maingui

* trying to fix merge conflicts

* and removing again.

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2024-06-13 22:13:05 -05:00
wandererfan
ca00ba8ce3 [TD]fix ActiveView image size 2024-06-13 19:25:29 -04:00
wandererfan
b3b9614cbc [TD]disable crop fields if crop not checked 2024-06-13 19:25:29 -04:00
wandererfan
1e847e3c7b [TD]remove spurious error messages 2024-06-13 19:25:29 -04:00
PaddleStroke
4d15b8f66a Sketcher: Fix circle diameter OVP 2024-06-13 14:51:48 -05:00
PaddleStroke
22a98d81f0 Sketcher: - Give focus to the MDI so that keyboard events are caught after starting edit. Else pressing ESC right after starting edit will not be caught to exit edit mode.
- After tool handler is purged, give back focus to MDI to make sure VPSketch receive the keyboard event. Else if user start a tool, dismiss it with ESC, then press ESC again to exit edit mode it won't be detected.
2024-06-13 14:44:30 -05:00
PaddleStroke
8e1a1c1783 Core: GuiDocument testGetTreeRootObject 2024-06-13 15:51:22 +02:00
Furgo
4500d0fd07 Draft toggle grid as a toggle button to indicate grid visibility (#14452)
Makes the button for the Draft_ToggleGrid command act as a real toggle button to provide visual feedback of the grid visibility state.

---------

Co-authored-by: Syres916 <46537884+Syres916@users.noreply.github.com>
2024-06-13 15:31:29 +02:00
Roy-043
91c7d8bfc9 Draft: _get_shapes in shape2dview.py did not handle null shapes (#14646)
Null shapes do not have a ShapeType (strange IMO). The function did not take that into account.

Forum topic:
https://forum.freecad.org/viewtopic.php?t=88397
2024-06-13 15:27:47 +02:00
Roy-043
fc8f7eeea4 BIM: Fix Arch Panel imports (#14644)
Fixes #14585.
2024-06-13 15:26:06 +02:00
Roy-043
c8c2c52e3e BIM: minor icon cleanup (#14560)
* BIM: minor icon cleanup

* Removed icons used for 'experimental' tools. They are obsolete.
* Updated warning.svg to match .../src/Gui/Icons/Warning.svg
* Renamed Image_CreateImagePlane.svg to BIM_ImagePlane.svg to avoid overwriting the first icon in the Wiki.
* Removed ArchWorkbench.svg and preferences-arch.svg as they are also obsolete.
* To resolve a Wiki name conflict renamed BIM_Project.svg to BIM_ProjectManager.svg, and Arch_Project_IFC.svg to BIM_Project.svg.
2024-06-13 15:22:08 +02:00
Roy-043
7011a21372 BIM: Fix handling of Wall normal (#14540)
The `Part.makeLine()` code is unnecessary and also risky as length can be zero. See first image in #14524.
2024-06-13 15:20:25 +02:00
Roy-043
38a86238e1 BIM: Fix move BuildingPart error (#14539)
Fixes #14524.
2024-06-13 15:18:23 +02:00
PaddleStroke
a0683cce88 OndselSolver: Update solver 2024-06-13 09:02:02 +02:00
wmayer
05e64ee173 Test: make test for STEP import independent of user settings
If the option 'Enable STEP compound merge' is active the test would fail
2024-06-12 20:19:49 +02:00
James Waples
7e62d07538 CAM: Rename CW/CCW to Climb/Conventional for consistency (#14364)
* Find and replace CW/CCW with Climb/Conventional

* Find and replace CCW/CW in CAM tests

* Find and replace in some UI files
2024-06-12 10:48:57 -05:00
wmayer
9b198c7704 MSVC: Fix warnings and build failure 2024-06-12 10:36:58 -05:00
PaddleStroke
e6b18dc381 Sketcher: polygone DSH, typo fix 2024-06-12 10:57:43 +02:00
PaddleStroke
974f57cf94 Core: Add Gui::Document::getTreeRootObjects() 2024-06-12 10:57:24 +02:00
PaddleStroke
26a9a67edd Assembly: Fix bug by replacing const char* by std::string for variables that need to be swapped. 2024-06-12 10:57:16 +02:00
pre-commit-ci[bot]
5c2feabe24 [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
2024-06-12 08:40:22 +02:00
mosfet80
d468a7a631 [Main] MainPy.cpp clean
remove unused code
2024-06-12 08:40:22 +02:00
mosfet80
a6937d8d26 [MOD] clean Finite.cpp (#14476)
removed dead code
2024-06-11 12:31:10 -05:00
hlorus
cda7a20e04 MeasureGui: Show measurement if it doesn't track any subjects 2024-06-11 17:57:01 +02:00
hlorus
71505c3b40 Measure: Migrate old App::MeasureDistance to new type 2024-06-11 17:57:01 +02:00
hlorus
bb7aa6ac74 Remove Std_MeasurementSimple 2024-06-11 17:57:01 +02:00
hlorus
b42c3aade0 Remove Std_MeasureDistance 2024-06-11 17:57:01 +02:00
hlorus
96fba15cb1 [Measure] Add MeasureDistanceDetached 2024-06-11 17:57:01 +02:00
hlorus
039242b964 [Measure] Make VP MeasureDistance only depend on properties 2024-06-11 17:57:01 +02:00
PaddleStroke
9fad901fa8 Assembly: Fix bug by replacing const char* by std::string for variables that need to be swapped. 2024-06-11 12:11:16 +02:00
wmayer
b4c5a6d5ba Fix several regressions:
+ improve PropertyMaterialList::readString
+ fix transparency handling in ViewProviderPartExt
+ do not register the private member '_diffuseColor' as property because it would be exposed to the
  public where it can be modified
+ fix ViewProviderPartExt::finishRestoring() to correctly restore old project files
+ fix ViewProviderPartExt::setHighlightedFaces() to correctly show face colours if VBO is enabled
+ fix ViewProviderBoolean::updateData()
  fix ViewProviderMultiFuse::updateData()
  fix ViewProviderMultiCommon::updateData()
  fix ViewProviderCompound::updateData()
  fix ViewProviderFillet::updateData()
  fix ViewProviderChamfer::updateData()
  that all set invalid transparency values
+ Filter ShapeAppearance in ViewProviderBody::unifyVisualProperty
  because body features usually have different number of faces than the body itself
+ manually fix some bad looking auto-formatted code
+ clean up code and remove duplicated code
2024-06-11 11:58:32 +02:00
wmayer
a58eebd903 Gui: Move texture handling to view provider extension
It should be avoided to add all stuff to the base class when it's only needed in one sub-class
2024-06-11 11:55:44 +02:00
wmayer
dd816a635c Fix several compiler warnings
* variable 'xAngle' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]
* variable 'yAngle' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]
* variable 'zAngle' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]
* unused variable 'base' [-Werror,-Wunused-variable]
* unused variable 'extrude' [-Werror,-Wunused-variable]
2024-06-11 11:42:12 +02:00
PaddleStroke
d0264d6bb0 Assembly: Deletes exploded view deletes the moves objects. 2024-06-11 10:29:46 +02:00
PaddleStroke
27f03e8edf Assembly: Makes sure deleting assembly deletes the joints, the exploded views and the view group. 2024-06-11 10:09:57 +02:00
Kacper Donat
1f35398d5a Gui: Fix use of no longer existing DiffuseColor property 2024-06-10 19:40:48 -05:00
PaddleStroke
b463846bea Assembly: Add validation step during dragging to ignore steps where grounded objects moved. 2024-06-10 11:35:04 -05:00