kindred/create
1
1
Fork 0
Code Issues 30 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity
24,143 Commits 41 Branches 6 Tags
586b2e6aa7b8b3d4ce56c3bbfee020f7ee53c546
Commit Graph

1972 Commits

Author SHA1 Message Date
sliptonic
01ac150212 Working html report with asciidoctor 2020-10-06 13:47:13 -05:00
sliptonic
8f27172316 Merge pull request #3915 from Russ4262/fix_Profile 
Path: Profile - Fix rotation error and remove FinalDepth limit
 2020-10-06 09:04:02 -05:00
J-Dunn
a7af3b33ae PATH: fast retraction and return speeds for grbl_post G83 expansion #3725 
Ensure fast retraction and then plunge to just short off previous drilled depth at G0.  Fixes painfully slow air drilling which makes peck drilling impracticable.
https://forum.freecadweb.org/viewtopic.php?f=15&t=25604&p=435639#p435639
 2020-10-06 01:23:18 +01:00
sliptonic
15b54b7b9b add coolant mode 
fix Z depth
 2020-10-05 18:00:47 -05:00
sliptonic
4c1ea6e911 Merge pull request #3901 from J-Dunn/master 
[Path] fix 3Dsurface with countersink tools
 2020-10-05 14:23:48 -05:00
Russell Johnson
aebc319ced Path: Fix rotational error for certain situations 
Error discovered during recent troubleshooting of Pocket_Shape with rotation.
Initial application of new operation yields path, but subsequent changes and applications failed due to `if ...` statement removed here for the fix.
 2020-10-03 13:56:46 -05:00
Russell Johnson
a8f97febad Path: Remove FinalDepth limitation for internal profile operation 
Requested in forum at https://forum.freecadweb.org/viewtopic.php?f=15&t=50341
 2020-10-01 22:51:33 -05:00
Russell Johnson
2a2c727aba Path: Add debug feedback and comment 2020-10-01 22:49:48 -05:00
sliptonic
d29b2dcd3f whitespace 2020-09-29 14:03:37 -05:00
sliptonic
8b772b03a5 rename OTHER 2020-09-28 14:58:09 -05:00
sliptonic
1e9cabd53b remove need for cuttingedgeheight 
Calculating from diameter and cuttingedgeangle
 2020-09-28 14:58:09 -05:00
sliptonic
3ffa3bf285 improve selection and avoid border case with ultra short segments 2020-09-28 14:58:09 -05:00
sliptonic
971e4a9915 Resolve UI issues 
taskpanel threshold value
add constants to PathVoronoi calls
check for tool properties
set correct z height coloring exterior lines
 2020-09-28 14:58:09 -05:00
sliptonic
315e18c78a Path: Vcarve fixes 
formatting fixes
remove reference to old ToolType
 2020-09-28 14:58:09 -05:00
sliptonic
bfc37274bc Rewrite for boost voronoi 2020-09-28 14:58:09 -05:00
sliptonic
b9d7dbc380 Path: Vcarve - Added threshold property to remove unwanted segments 
code cleanup & debug
 2020-09-28 14:58:09 -05:00
sliptonic
f711cfb192 Path: vcarve add feed rate 2020-09-28 14:58:09 -05:00
sliptonic
7a4ad8be71 path: vcarve requires engraver with proper angle 
vcarve calculates depth with MIC now
 2020-09-28 14:58:09 -05:00
sliptonic
7641a54146 Path: increasing the discretize precision 2020-09-28 14:58:09 -05:00
sliptonic
9c68052d4d Path: add vcarve operation using openvoronoi 2020-09-28 14:58:08 -05:00
J-Dunn
3216ca32a8 Add files via upload 
fix 3Dsurface bugs: variable name error and OCL using half tip angle. 
https://forum.freecadweb.org/viewtopic.php?f=15&t=50570
 2020-09-27 18:34:31 +01:00
sliptonic
922ec0dce5 Merge pull request #3861 from Russ4262/profile_reset_fix 
[Path] Fixes #4433 - `Cut Side` reset with certain Base Geometry changes
 2020-09-15 14:12:01 -05:00
sliptonic
968ea0061e Merge pull request #3862 from Russ4262/pocketshape_fix 
[Path] PocketShape - fix improper path generation
 2020-09-15 14:09:57 -05:00
sliptonic
e1cfe7144b Merge pull request #3849 from Schildkroet/deburr+dressup 
[Path] Fixed DeburrOp not moving to safe height
 2020-09-15 12:48:33 -05:00
vocx-fc
00dc2c8476 Path: use 4-space indentation, and keep lines short 2020-09-15 00:56:17 -05:00
Russell Johnson
3efe9efb68 [Path] PocketShape - fix improper path generation 
Forum identification and discussion at https://forum.freecadweb.org/viewtopic.php?style=3&f=15&t=49513.
 2020-09-12 09:35:34 -05:00
Russell Johnson
da44f6cdcc [Path] Fixes #4433 - Cut Side reset with certain Base Geometry changes 
`Cut Side` value was hard-coded to reset when Base Geometry was empty.  This disallowed retention of the current value with changes to selected Base Geometry involving the clearing thereof.
Also restored fixed visibility to `Cut Side` option in Task panel editor per forum mention.
 2020-09-12 00:24:25 -05:00
Patrick F
79359a7534 Fixed DeburrOp not moving to safe height 2020-09-07 01:30:32 +02:00
luz paz
6f62fd09df Fix typos in various files [skip-ci] 
Found via `codespell 2.0.dev0`  
```
codespell -q 2 -L aci,ake,aline,alle,alledges,alocation,als,ang,anid,ba,beginn,behaviour,bloaded,byteorder,calculater,cancelled,cancelling,cas,cascade,centimetre,childs,colour,colours,commen,currenty,dof,doubleclick,dum,eiter,elemente,feld,freez,hist,iff,indicies,initialisation,initialise,initialised,initialises,initialisiert,ist,kilometre,lod,mantatory,methode,metres,millimetre,modell,nd,noe,normale,normaly,nto,numer,oder,orgin,orginx,orginy,ot,pard,pres,programm,que,recurrance,rougly,seperator,serie,sinc,strack,substraction,te,thist,thru,tread,uint,unter,vertexes,wallthickness,whitespaces -S ./.git,*.po,*.ts,./ChangeLog.txt,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/CXX,./src/zipios++,./src/Base/swig*,./src/Mod/Robot/App/kdl_cp,./src/Mod/Import/App/SCL,./src/WindowsInstaller,./src/Doc/FreeCAD.uml
```
 2020-09-04 10:10:31 +02:00
luz paz
ab7e5fb087 Fix typos in source comments 
Found via `codespell`
 2020-08-29 19:14:13 +02:00
sliptonic
6db220a458 Merge pull request #3763 from Russ4262/PocketShape_fix_t4411 
Path: PocketShape - Fixes ticket #4411
 2020-08-04 10:40:53 -05:00
sliptonic
0a9f7034a9 Merge pull request #3751 from J-Dunn/master 
Path: prevent added paths creating tool crash: fixed #4260
 2020-08-04 10:40:13 -05:00
sliptonic
169a66b225 Merge pull request #3706 from etrombly/emptyPath 
[PATH] don't generate gcode if op isn't valid. Don't plunge to start height if safe and clearance height are the same.
 2020-08-04 10:20:13 -05:00
Russell Johnson
10b5cbc115 Path: Fix reference to undefined ns, and adjust comments 
This `ns` fix might need further attention after testing.  The section to which it pertains deals with optimizing rotations between ops with similar rotational axes.
 2020-08-02 13:27:32 -05:00
Russell Johnson
8e4032fc0d Path: Fix the rotational LimitDepthToFace feature 2020-08-02 13:27:32 -05:00
Russell Johnson
32f82a9b5e Path: Fix InverseAngle feature 
The `ReverseDirection` property is now hidden by default.  It should not be necessary due to recent implementation of `isFaceUp()` method.
 2020-08-02 13:27:32 -05:00
Russell Johnson
015eb0421b Path: PocketShape - Fixes ticket #4411 
Existing code to determine if shape volume indeed existed, failed.
Added additional pre-check for existing edges in shape to determine if shape geometry indeed exists.
In forum:
[Ticket #4411 - Can only generate pocket once for this shape, then it fails.](https://forum.freecadweb.org/viewtopic.php?style=3&f=15&t=49035).
 2020-08-02 13:27:32 -05:00
sliptonic
d95527ca50 Merge pull request #3700 from etrombly/deletedFaces 
[Path] handle makeOffset2D exception in path pocket operation
 2020-07-28 11:50:27 -05:00
sliptonic
1a68959160 Merge pull request #3585 from gwicke/unified_region_experiments 
Path: Area based unified projection implementation
 2020-07-28 11:48:56 -05:00
J-Dunn
2b79cb731a prevent added paths creating tool crash #4260 #3028 
In this path dressup a bogus machine position is used to get an initial edge, this results in a path element which does reflect the input path data and can lead to a tool crash. This PR checks whether X and Y actually come from the input path data and prevent new path elements being added until true machine position has been set. 
Forum thread: https://forum.freecadweb.org/viewtopic.php?f=15&t=42820
 2020-07-28 14:12:11 +01:00
sliptonic
ebe45e5603 Merge pull request #3689 from etrombly/edgesMatchShape 
[PATH] fix pocket attribute error if edge cannot be flipped
 2020-07-27 12:53:37 -05:00
Mark Ganson TheMarkster
181eaa1b7a coverity issue cid 305102 2020-07-23 13:55:32 +02:00
Gabriel Wicke
670f3b6098 Path: Area based unified projection implementation 
Generalize the `extractFaceOffset` method to `getOffsetArea`, which can
handle both face offsetting and projection. Another difference is that
the new method exposes Area's ability to preserve internal holes,
defaulting to preserving. The method is moved to the PathUtils module,
reflecting its generality and fairly wide used across Path.

This method is then used to provide a drop-in alternative to
`FindUnifiedRegions` via a small wrapper in PathSurfaceSupport. The Area
implementation is generally quick, but can fail (throw) in some cases,
so the wrapper is trying the Area method as an optimization first, and
falls back to the full `FindUnifiedRegions` logic if that fails.
 2020-07-21 18:34:09 -07:00
Eric Trombly
fca189debc fix two never ending while loops in PathSurfaceSupport 2020-07-17 13:59:10 -05:00
Eric Trombly
e630e3786f handle offset error in PathPocketShapeGui 2020-07-15 21:31:34 -05:00
Eric Trombly
5fe22270cc handle makeOffset2D exception 2020-07-15 21:31:34 -05:00
Eric Trombly
cf9fec5ffd don't generate gcode if op isn't valid. Don't plunge to start height if safe and clearance height are the same. 2020-07-15 19:35:18 -05:00
Eric Trombly
29e842d4e0 fix attributeError if edge can't be flipped 2020-07-14 18:53:54 -05:00
sliptonic
5faa738002 Merge pull request #3688 from etrombly/deleted 
[PATH] fix Cannot access attribute 'Document' of deleted object when cancelling PathPocket operation
 2020-07-12 16:27:35 -05:00
Eric Trombly
547c6fa26e cleaner fix 2020-07-10 15:42:00 -05:00