kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity
40,989 Commits 41 Branches 6 Tags
59bfee2cfe0d461f7e308aad314c960ae236291d
Commit Graph

396 Commits

Author SHA1 Message Date
Florian Foinant-Willig
94eaa7db78 Sketcher: Arc to arc or circle distance constraint 2023-12-17 16:01:29 +01:00
Chris Hennes
fe0f96ca44 Merge pull request #11494 from Ondsel-Development/Coincident 
[Sketcher] Introduce an optional unified version of coincident and pointOnObject
 2023-12-04 10:46:21 -06:00
Paddle
5839848f21 Introduce CmdSketcherConstrainCoincidentUnified. This is a unified version of coincident + pointOnObject. 
This is disabled by default. Nothing changes by default.
 2023-11-27 21:14:33 +01:00
wmayer
f6d0340abc Sketcher: add security checks to avoid possible undefined behaviour 2023-11-27 10:58:50 +01:00
Paddle
5a4a358f13 hor/ver tool, remove unused variables 2023-11-27 10:44:25 +01:00
Paddle
1c04566548 Sketcher : Replace toggle icons. 2023-11-25 20:55:50 -03:00
Paddle
2deb38aa29 Sketcher: remove unused cursor_createcoincident[] and DrawSketchHandlerCoincident. They are not used anymore. 2023-11-22 16:47:51 +01:00
Paddle
19a2b52277 Sketcher: Move Distance command next to DistanceX. ONLY move code, nothing changed. 2023-11-22 16:19:08 +01:00
PaddleStroke
e56359d6d7 [Sketcher] Auto horizontal/vertical (#11330) 
* Refactor sketcher horizontal / vertical constraints and adds a horizontal/vertical command.

* Sketcher : HorVer : change tool icon.

---------

Co-authored-by: Paddle <PaddleStroke@users.noreply.github.com>
 2023-11-20 11:00:22 -06:00
Paddle
fbcc53d2cb Fix ESC key for Sketcher_Dimension 2023-11-15 14:41:43 +01:00
Abdullah Tahiri
0d221c0969 Sketcher: Fix lints 2023-11-08 17:46:34 +01:00
Abdullah Tahiri
5873403254 Fix Compiler warnings of previous merged PRs 2023-11-08 15:20:13 +01:00
Paddle
a3568333a4 Sketcher_Dimension: If radius of arc is not DoF, then offer arc angle first. 2023-11-06 14:02:54 -06:00
Chris Hennes
cf84c171e6 Merge pull request #10978 from FlachyJoe/modernize-type-check 
Modernize type and derived type checking
 2023-11-06 10:44:32 -06:00
Abdullah Tahiri
1de8d9f10f Sketcher Gui: Fix dead code clang-tidy 2023-11-05 07:11:57 +01:00
Abdullah Tahiri
882262bfa8 Sketcher Gui: clang-tidy diagnostic errors 2023-11-05 07:11:57 +01:00
Florian Foinant-Willig
a32851073d Sketcher: modernize type checking 2023-10-23 18:09:23 +02:00
Paddle
f45fd8fe35 Sketcher: commandConstraint : remove leftover bothexternal variable. 2023-10-22 13:51:21 +02:00
wmayer
7f23467674 Sketch: fix several compiler and lint warnings 
* Remove private unused field 'sketchView'
* Mark constructor with single argument as explicit
* Mark virtual methods of base class as override
* Fix clang code model parsing error
* Avoid too short identifiers
* Avoid redundant ternary operators
* Avoid passing Base::Unit by value but by const reference
 2023-10-20 12:29:59 +02:00
Paddle
951edf3ec4 Fix typo making Sketcher_Dimension fails for angles. 2023-10-10 13:48:07 +02:00
Paddle
37b68f3931 Create makeAngleBetweenTwoLines and Create Create calculateAngle to remove duplicates 2023-10-07 07:43:39 +02:00
wmayer
ab4abab53d Sketch: fix a few minor issues: 
* fix compiler warning about unused variable
* fix const correctness
* fix access type of setExpression()
* removed duplicated method
 2023-09-19 22:01:19 +02:00
Paddle
e3445388a2 Sketcher_Dimension : adds arc-angle mode for arcs. 2023-09-19 08:25:45 +02:00
Paddle
1c8f49ee67 Adds a small convenience function to get arc of circle angle. 2023-09-18 21:33:24 +02:00
howie-j
12913daef5 fixes #10651 2023-09-18 10:56:13 -05:00
Florian Foinant-Willig
f393a90467 Sketcher: refactor CommandConstraint.cpp (#10692) 
* Sketcher: refactor CommandConstraint.cpp with TypeId helpers

* Sketcher: cosmetic empty lines

* fix pointer misusage
 2023-09-18 10:37:03 -05:00
Paddle
594b1aec11 Sketcher_Dimension : enable user to deselect geos by clicking on them again. 2023-09-14 20:57:39 -05:00
wmayer
e9b61bdbe2 Sketcher: fix several inconsistencies in Sketcher_CompDimensionTools 
* The menu text and tooltip of the Sketcher_ConstrainRadius command shouldn't be different if part of the group command or not.
  The explicit mentioning to change the weight of a B-Spline is pointless and confusing.
* The order of Sketcher_ConstrainRadius and Sketcher_ConstrainDiameter has flippend when used in Sketcher_CompDimensionTools
* The command Sketcher_ConstrainRadiam is completely missing
* The command Sketcher_ConstrainSnellsLaw was wrongly re-added
* CmdSketcherCompConstrainRadDia uses a wrong context
 2023-09-14 20:56:14 -05:00
wmayer
89bb28239e MSVC: fix several compiler warnings 2023-09-12 22:57:26 +02:00
howie-j
3d7e01bb7a Fixes #10596 2023-09-07 21:14:56 +02:00
Paddle
3a9135fd30 Sketcher_Dimension Replace SubNames by std::move(SubNames) 2023-09-02 11:35:31 +02:00
Paddle
4f34ef1a97 Sketcher_Dimension fix crash. 2023-09-01 18:50:46 +02:00
wmayer
c7116599ce Sketcher: fix several warnings: 
* fix -Wunused-parameter
* fix -Wsign-compare
 2023-09-01 17:34:29 +02:00
Paddle
fb32c0a6d7 Sketcher_Dimension: Disable arc-circle and arc-line distances as they are not implemented yet. 2023-09-01 08:00:21 -05:00
Paddle
e7b0ffffc4 Sketcher_Dimension: Implement Point-to-Circle distance. 2023-09-01 08:00:21 -05:00
Paddle
a121f8710f Sketcher_Dimension Fix the transaction auto-closing issue 2023-09-01 07:58:45 -05:00
Paddle
c72c9eaaa3 Sketcher_Dimension : Implement selection->tool workflow 2023-09-01 07:58:45 -05:00
Paddle
d74e67336e Sketcher_Dimension : Turn the command into a group-command to have at hand individual commands. 2023-09-01 07:57:44 -05:00
luzpaz
9ed299a57a Fix typos 2023-08-31 22:29:17 -05:00
Florian Foinant-Willig
ae60811fba Sketcher: Point to Circle Distance Constraints (#9559) 2023-08-28 10:58:09 -05:00
Paddle
11fd7f3a32 Implement GeomSelectionSizes to further refactor Dimension::makeAppropriateConstraint 2023-08-27 18:48:33 +02:00
Paddle
4d3b27f9a8 Dimension: Fix 2 circles concentric and length mode. 2023-08-27 18:48:00 +02:00
Paddle
212c0a75af Fix crash when user click 'Close' button while Dimension is active. 
TaskDlgEditSketch didn't purge the handler first as is doing CmdSketcherLeaveSketch.
 2023-08-27 09:26:44 +02:00
Paddle
178257c544 Refactor makeAppropriateConstraint 2023-08-27 08:25:20 +02:00
Paddle
4c161a544d Replace multiple occurence of selVec.size() by s_vec to clean the makeAppropriateConstraint function 2023-08-27 07:26:53 +02:00
Paddle
00cb724341 Small simplification by removing useless tests in makeAppropriateConstraint 2023-08-26 22:13:11 +02:00
Paddle
0908f07521 refactor Sketcher Dimension releaseButton 2023-08-26 19:47:23 +02:00
Paddle
421f35fe95 Remove superfluous virtual add missing override. 2023-08-26 19:13:52 +02:00
Paddle
2b2ba0b08a Change the name to 'Dimension' instead of 'Constrain Contextual' 2023-08-26 08:35:27 +02:00
Paddle
8a858ae7ec Sketcher: Constrain Contextual implementation. 2023-08-26 07:41:09 +02:00