Commit Graph

3926 Commits

Author SHA1 Message Date
Uwe
5aedc73ef6 [FEM] better fix for missing colorbar update for FemPostObject
- better fix for #7230 because we can call the direct paint method and because the bar is now also updated when the object is shown

- also add a ToDo note
2022-07-23 16:57:16 +02:00
Uwe
82083ab059 [FEM] task_material_common: add a comment 2022-07-23 14:22:48 +02:00
Uwe
68659771f5 [FEM] fix material task dialog for fluids
- this fixes a mistake from commit 821dc915
- it also consistently use the thermal expansion coefficient
- add code comments

now the material task dialog works with all fluid materials without errors or warnings
2022-07-23 04:59:10 +02:00
Uwe
0105189304 [FEM] [skipCI] ViewProviderFemPostPipeline: remove unused include
- also sorting
2022-07-22 02:08:11 +02:00
Uwe
ac27f4700a [FEM] fix missing colorbar update for FemPostObject
- fixes issue #7230

- to update the color bar for post objects, the Field property has to be reset to trigger this. This PR does this.
2022-07-22 01:20:18 +02:00
Uwe
b726941073 [FEM] [skip CI] fix UI file height entry
- was automatically done by QT designer
2022-07-21 03:43:26 +02:00
Uwe
f467451ae3 [FEM] remove more superfluous nullptr checks 2022-07-18 02:34:57 +02:00
Uwe
5e634c5995 [FEM] remove superfluous nullptr checks 2022-07-18 01:45:19 +02:00
Uwe
947bce371c [FEM] check if Gmsh, CCX and Mystran solver binaries exist
- adds the check like we have already for Z88 and Elmer
- also remove an unnecessary return statement
2022-07-17 01:43:58 +02:00
Uwe
e76fbe6998 [FEM] fix CCX (new framework) binary handling
- when the binary was not found, the function called the non-existing binary
- also push error message to the status info so that user gets feedback also when report view console is not shown
2022-07-17 01:28:54 +02:00
Uwe
1ba44fb1ca [FEM] fix Z88 binary handling
- when the binary was not found, the function called the non-existing binary
- also push error message for Elmer and Z88 to the status info so that user gets feedback also when report view console is not shown
- uniform wording to 'binary'
- avoid unnecessary console output
2022-07-17 01:18:21 +02:00
Uwe
7346ee4073 [FEM] [skip CI] inform user about used CPU cores for Elmer
Since the number of used cores can for Elmer have the impact that a solver run converges or not, output this info prominently
2022-07-16 19:46:46 +02:00
Uwe
c4416e00ca [FEM] [skip CI] tell user when Elmer write succeeded
At the moment the user gets no feedback, while for Z88 and CCX he gets a result
2022-07-16 19:41:43 +02:00
Uwe
b39e91c26f [FEM] [skip CI] fix wording
Calculix will not be broken, but stopped. After clicking the button your will also get a message that it has been 'stopped'
2022-07-16 19:33:02 +02:00
Uwe
bcacab1988 [FEM] [skip CI] fix a typo 2022-07-16 19:21:25 +02:00
Uwe
826a903281 [FEM] [skip CI] fix a string 2022-07-16 18:54:11 +02:00
Uwe
5bbf136174 [FEM] [skip CI] fix a typo 2022-07-16 16:01:38 +02:00
Uwe
eec258ab37 [FEM] enable to run Elmer multi-threaded
- this needs proper testing, especially on a non-Windows system

- note that for some tasks multi-threading requires non-standard additional solvers like MUMPS. Ideally the user should be informed about this, depending on the equations he uses. But this should not block this PR, meaning to use multi-threading in general.
2022-07-16 14:59:25 +02:00
wmayer
9984d6bf86 Fem: replace PyObject_IsTrue with Base::asBoolean 2022-07-16 13:37:55 +02:00
Marshal Horn
3a3a20da46 Replaced python2 usage of next()
iterator.next() is deprecated in python3.
next(iterator) is the direct replacement.
In some cases a for() loop makes more sense
2022-07-14 01:28:10 +02:00
Uwe
1ddb42dcb2 [FEM] femutils.py: style changes
- as requested
2022-07-14 01:21:54 +02:00
Bernd Hahnebach
02fef68c8b FEM: Python code formatting 2022-07-13 12:04:52 +02:00
Uwe
1ce91df8f7 [FEM] [skip CI] electrostatic: remove unused code 2022-07-13 03:23:19 +02:00
Uwe
33a769a426 [FEM] fix solver console bugs
- for Elmer and Z88 on Windows several windows pop up (console windows). This is maybe annoying and the user is wondering what is going on, but the main problem is that when you close them, you break the solving process.
Therefore, on Windows only, hide the empty popup windows.
2022-07-13 02:51:31 +02:00
Bernd Hahnebach
c010a8e6b9 FEM: extend codespell command in code conventions 2022-07-12 15:04:26 +02:00
Bernd Hahnebach
f773f165a7 FEM: typos, found with:
codespell -q 2 -S *.ts -S *.dyn -S *.svg  -L childs,dof,dum,freez,methode,nd,normaly,programm,som,uint,vertexes,inout  src/Mod/Fem/
2022-07-12 15:04:26 +02:00
Bernd Hahnebach
41a8ed83af FEM: python code formatting 2022-07-12 15:04:26 +02:00
Bernd Hahnebach
90b0d3253e FEM: elmer solver writer, add some comment in the regard of units 2022-07-12 11:35:45 +02:00
Uwe
72c465a19c [FEM] check if solver executables exist
- currently one can enter any path for the solver executables, a check is missing

- moreover for Z88 the executable name is error-prone (just happened to me and cost me half an hour to find out what is wrong), therefore check also the correct filename. For Elmer this cannot be done since there are different executables one can choose of (e.g. for multi-threading etc.)
2022-07-11 02:23:14 +02:00
Uwe
91d7e0b896 [FEM] fix CCX multi-threading bug
- in the preferences one could specify more CPU cores than available

- also correct a label sine the number of cores are since FC 0.20 used for all CCX solver runs

- also remove unnecessary (doubled) slots from the UI file
2022-07-10 17:33:33 +02:00
Uwe
1c8eb28220 [FEM] remove doubled slots from preferences UI files 2022-07-10 17:25:19 +02:00
wehrle
a5a2401a44 correction 2022-07-10 13:43:46 +02:00
Uwe
fb5479e178 [FEM] update includes
- forgot to commit this in previous commit
2022-07-03 22:59:37 +02:00
Uwe
e899c221cc [FEM] fix wrong console outputs for fluid materials
- since a while ThermalExpansionCoefficient is used, VolumetricThermalExpansionCoefficient is only used for the material task panel
- as already stated in a code comment, the unit of VolumetricThermalExpansionCoefficient is ThermalExpansionCoefficient, therefore we must check for ThermalExpansionCoefficient
- we must also check if ThermalExpansionCoefficient exists

- Adapt the existing fluid material cards to use the ThermalExpansionCoefficient
2022-07-02 05:36:43 +02:00
Mihail
6eae0c021a FEM WB Elmer viscosity bug fix.
In Elmer there was errors "Viscosity not found" if used mixed solid and flow calculation.
This fix disables Stokes-Navier eruation for Solid objects.

	modified:      src/Mod/Fem/femsolver/elmer/writer.py
2022-07-02 05:16:50 +02:00
Uwe
5a6c52d8f3 [FEM] [skip CI] fix a typo
- spot by the spellchecker CI
2022-07-01 03:12:15 +02:00
wmayer
0f5725b34a modernize C++: replace boost::function with std::function 2022-06-30 20:31:55 +02:00
mosfet80
c86f0ce670 Remove old msc ver. Freecad 0.20 require 64 bit and windows 7 or higher. For this reason, msc libraries less than 1800 will no longer be used. (#7036)
* remove msc<1800
2022-06-28 00:42:33 +02:00
Uwe
5f5ae2fe4a [FEM] fix point filter initialization issue
- on opening the task dialog of existing point filter, the point value must be displayed
2022-06-27 01:07:36 +02:00
wmayer
2628fb0350 App: fix memory leaks in Enumeration class and simplify code 2022-06-25 18:18:57 +02:00
wmayer
d5340a82ab Gui/Mod: replace several reinterpret_cast with static_cast 2022-06-25 11:36:55 +02:00
wmayer
6e80ffaec3 Fem: remove some superfluous const_cast 2022-06-24 19:43:33 +02:00
wmayer
8b9484c82f App: add pure virtual methods to PropertyGeometry to delegate it to the geometry of sub-classes
Following the law of Demeter add some wrapper methods to PropertyGeometry and implement them in sub-classes. As a side-effect this makes some const_cast obsolete
2022-06-24 16:15:02 +02:00
wmayer
f5235a8057 cppcoreguidelines-pro-type-union-access
According to https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md using union for type-punning is undefined behaviour.
 Replace it with std::memcpy
2022-06-24 14:29:50 +02:00
Yorik van Havre
4c34ae7398 Merge pull request #7067 from Kuzma30/add_ts
Crowdin Add "new" WB to translations.
2022-06-24 13:50:43 +02:00
mosfet80
c48a569696 Boost version <=1.60 is never used in freecad 0.20 (#7038)
* Boost version 1.60 is never used in freecad 0.20
2022-06-24 02:20:26 +02:00
Kuzemko Alexsandr
b99ccc6193 Crowdin Update .ts files with current source. 2022-06-21 17:31:06 +03:00
Uwe
a289ec4a06 [FEM] fix a variable casting
- reported by MSVC not to cast a float to a double but as double directly

- also remove some superfluous Boolean comparisons
2022-06-19 15:15:18 +02:00
wmayer
052a2d8f82 Fem: remove string from translation 2022-06-14 01:43:45 +02:00
wmayer
d64b9750da Fem: added signals and slots to notify when first function is added 2022-06-14 01:38:55 +02:00