Commit Graph

2756 Commits

Author SHA1 Message Date
luzpaz
4dbbe85c2b Fix various typos 2023-09-07 20:34:49 +02:00
Jonas Bähr
880461593f Sketcher: Fix check in carbonCopy's python interface
Presumably due to an copy/paste error, carbonCopy used to verify the
referenced object via `isExternalAllowed` (just like addExternal).
Now using `isCarbonCopyAllowed`, the resulting error message is the
expected one for wrong objects, not a generic one after the operation
failed.
2023-09-05 08:49:31 +02:00
Jonas Bähr
7e84c3f42f Sketcher: Fix wrong format string in PyArg_ParseTuple
The part behind the column represents the function name itself, not an
error message. So previously, an argument error looked like this:
("Give an object" is not the method name)
```
>>> obj.carbonCopy()
Traceback (most recent call last):
  File "<input>", line 1, in <module>
TypeError: Give an object() takes at least 1 argument (0 given)
>>> obj.carbonCopy(123)
Traceback (most recent call last):
  File "<input>", line 1, in <module>
TypeError: Give an object() argument 1 must be str, not int
```

While the format string also supports a text for the complete error message
(using a semicolon instead), I decided against this: Pythons standard text
is more precise than this:
(the type error here is not "Give an object")
```
>>> obj.carbonCopy()
Traceback (most recent call last):
  File "<input>", line 1, in <module>
TypeError: Give an object
>>> obj.carbonCopy(123)
Traceback (most recent call last):
  File "<input>", line 1, in <module>
TypeError: Give an object
```
2023-09-05 00:38:30 +02:00
Jonas Bähr
4db4aeb91a Sketcher: fix docs for solve(..)
Since the docstring was initially written, an additional error code was added.
2023-09-05 00:32:54 +02:00
Chris Hennes
791fe02934 Sketcher: Reformat to current clang-format standard 2023-09-04 07:17:28 -05:00
Paddle
3a9135fd30 Sketcher_Dimension Replace SubNames by std::move(SubNames) 2023-09-02 11:35:31 +02:00
Paddle
4f34ef1a97 Sketcher_Dimension fix crash. 2023-09-01 18:50:46 +02:00
wmayer
c7116599ce Sketcher: fix several warnings:
* fix -Wunused-parameter
* fix -Wsign-compare
2023-09-01 17:34:29 +02:00
Paddle
fb32c0a6d7 Sketcher_Dimension: Disable arc-circle and arc-line distances as they are not implemented yet. 2023-09-01 08:00:21 -05:00
Paddle
e7b0ffffc4 Sketcher_Dimension: Implement Point-to-Circle distance. 2023-09-01 08:00:21 -05:00
Paddle
a121f8710f Sketcher_Dimension Fix the transaction auto-closing issue 2023-09-01 07:58:45 -05:00
Paddle
c72c9eaaa3 Sketcher_Dimension : Implement selection->tool workflow 2023-09-01 07:58:45 -05:00
Paddle
d74e67336e Sketcher_Dimension : Turn the command into a group-command to have at hand individual commands. 2023-09-01 07:57:44 -05:00
luzpaz
9ed299a57a Fix typos 2023-08-31 22:29:17 -05:00
bdieterm
7013ce0cbc Sketcher: fix segfault on distance constraints without SecondPos 2023-08-29 16:24:15 -05:00
kaktus Jacek
0445b88d55 Cleaning code from unnecessary strings generated to Crowdin 4 (#10426)
Cleaning Crowdin of "garbage". Second approach.
https://github.com/FreeCAD/FreeCAD-translations/issues/270
2023-08-29 12:57:26 -05:00
Chris Hennes
6bfafc62dc Update translations 2023-08-29 07:38:09 -05:00
kaktus Jacek
c0060277c8 Cleaning code from unnecessary strings generated to Crowdin 3 (#10420)
Cleaning Crowdin of "garbage". Second approach.
https://github.com/FreeCAD/FreeCAD-translations/issues/270
2023-08-29 07:35:04 -05:00
Florian Foinant-Willig
ae60811fba Sketcher: Point to Circle Distance Constraints (#9559) 2023-08-28 10:58:09 -05:00
Chris Hennes
874b0ff1a8 Merge pull request #9810 from Ondsel-Development/v2_constrain_contextually
Sketcher: Constrain Contextual implementation V2
2023-08-28 10:52:05 -05:00
Florian Foinant-Willig
d3af7e1e8d Sketcher: Fix Visual toolbox visibility 2023-08-28 10:46:48 -05:00
Paddle
11fd7f3a32 Implement GeomSelectionSizes to further refactor Dimension::makeAppropriateConstraint 2023-08-27 18:48:33 +02:00
Paddle
4d3b27f9a8 Dimension: Fix 2 circles concentric and length mode. 2023-08-27 18:48:00 +02:00
kaktus Jacek
06284ede05 Cleaning code from unnecessary strings generated to Crowdin. (#10385)
Cleaning Crowdin of "garbage". Second approach.
https://github.com/FreeCAD/FreeCAD-translations/issues/270
2023-08-27 10:08:11 -05:00
Paddle
212c0a75af Fix crash when user click 'Close' button while Dimension is active.
TaskDlgEditSketch didn't purge the handler first as is doing CmdSketcherLeaveSketch.
2023-08-27 09:26:44 +02:00
Paddle
178257c544 Refactor makeAppropriateConstraint 2023-08-27 08:25:20 +02:00
Paddle
4c161a544d Replace multiple occurence of selVec.size() by s_vec to clean the makeAppropriateConstraint function 2023-08-27 07:26:53 +02:00
Paddle
00cb724341 Small simplification by removing useless tests in makeAppropriateConstraint 2023-08-26 22:13:11 +02:00
Paddle
79bb68ef14 Sketcher settings Dimension Add enums instead of magic numbers 2023-08-26 19:55:17 +02:00
Paddle
0908f07521 refactor Sketcher Dimension releaseButton 2023-08-26 19:47:23 +02:00
Paddle
421f35fe95 Remove superfluous virtual add missing override. 2023-08-26 19:13:52 +02:00
Paddle
2b2ba0b08a Change the name to 'Dimension' instead of 'Constrain Contextual' 2023-08-26 08:35:27 +02:00
Paddle
77bab58039 Fix texts in the new settings. 2023-08-26 07:41:11 +02:00
Paddle
8a858ae7ec Sketcher: Constrain Contextual implementation. 2023-08-26 07:41:09 +02:00
sliptonic
8701e0b7a1 Merge pull request #9703 from FlachyJoe/arc_helper_gui
Sketcher: Add command to switch arc helpers
2023-08-21 11:20:16 -05:00
Syres916
fec225ddcc [Sketcher] Fix minor icon missing bug...
...icon was moved to obsolete in 2020
2023-08-18 17:43:00 +01:00
Chris Hennes
28f396cc75 Update translations
Adds the ten units strings from Base as well.
2023-08-16 22:50:39 -05:00
Florian Foinant-Willig
529de41cfe Fix the fix o:-) 2023-08-14 22:31:36 +02:00
Florian Foinant-Willig
a1d8949194 Fix menu and ressource file 2023-08-14 22:12:18 +02:00
Florian Foinant-Willig
17532f0777 Merge branch 'master' into arc_helper_gui 2023-08-14 16:24:28 +02:00
luzpaz
3d0bfa214f Fix various typos 2023-08-13 08:17:01 -07:00
Chris Hennes
d3c08a2da9 Update translations 2023-08-08 17:52:59 -06:00
wmayer
d150fa7164 modernize C++: avoid bind
In many cases std::bind() is kept because the code is much simpler
2023-08-08 21:10:16 +02:00
wmayer
68d22d864b modernize C++: move from boost::bind to std::bind 2023-08-08 17:36:13 +02:00
wmayer
f94b026456 modernize C++: use transparent functors 2023-08-07 16:08:35 +02:00
wmayer
c7a17468e7 modernize C++: use noexcept 2023-08-07 16:06:58 +02:00
wmayer
d244dcf2da modernize C++: use nullptr 2023-08-05 11:23:12 -06:00
wmayer
39e53e5eb0 Mods: modernize C++: redundant void arg 2023-08-05 16:50:31 +02:00
wmayer
5621a0089f Qt6 port:
Fix deprecation warnings with version 6.3 or 6.4
2023-08-04 21:23:14 -06:00
andrea
6c2a5c1539 removed coin<3 references 2023-08-04 21:19:29 -06:00