* Part/Toponaming: tests for flushElementMap and resetElementMap
* Added test for resetElementMap()
* Added test for flushElementMap()
* restored ComplexGeoData::resetElementMap to RT fork
* modified TopoShape::resetElementMap to match the restored signature of ComplexGeoData::resetElementMap
* added checks in TopoShape::makeShapeWithElementMap to avoid segfaults
* added check in TopoShape::setElementComboName to avoid segfaults
* restored testFindSubShapesForSourceWithTypeAndIndex
* modified test saveDocFileWithNoElementMap to match the restored signature of ComplexGeoData::resetElementMap
* Part/Toponaming: tests for flushElementMap and resetElementMap
* Removed comments in ComplexGeoData::resetElementMap()
* Changed TopoShape::resetElementMap():: from virtual to override
* Removed comment in TopoShape::resetElementMap()
* Added comments about differences between main and RT fork
* Removed comment in test saveDocFileWithNoElementMap
* Updated expected test result in makeElementCompoundTwoShapesGeneratesMap
* Updated expected test result in resetElementMapTest
* Fixed typo in test flushElementMapTest
* Part/Toponaming: tests for flushElementMap and resetElementMap
* updated expected tests results after previous methods modifications
---------
Signed-off-by: CalligaroV <vincenzo.calligaro@gmail.com>
Addresses clang-tidy complaint: declaration 'Feature' is never referenced, but a declaration with the same name found in another namespace 'Part' [bugprone-forward-declaration-namespace]
* Update translations
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
---------
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* Tweak resetElementMap tp default to empty defined element map
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
---------
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
In order to make getNameInDocument() always return a valid string,
we implement a getDagKey() method that shall be used instead of getNameInDocument()
when we want to use the pointer value as a "key" to identify the DocumentObject.
This is the original code from the Toponaming branch, modified slightly to update the
method name and correct some grammatical errors in the descriptive comment.
Co-authored-by: Chris Hennes <chennes@pioneerlibrarysystem.org>
* Possible fix for 10482 circular reference regression with tests
* Remove redundant test
* Cleanup pre PR
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
---------
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* Update translations
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
---------
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
This patch substitutes by isAttachedToDocument() (almost) everywhere where
getNameInDocument() is used for this purpose.
The very few places not touched by this patch demand a (just a little) less trivial change.
When we change the returning type of getNameInDocument() to std::string,
those places will be easily found, because they shall generate a compiler error
(converting std::string to bool).
Rationale:
The fact that getNameInDocument() return nullptr to indicate
that the object is not attached to a document is responsible for lots of bugs
where the developer does not check for "nullptr".
The idea is to eliminate all those uses of getNameInDocument() and, in the near future,
make getNameInDocument() return always a valid std::string.
=====================================================================
Issue #11183
- The message is not useful for the user in terms of content.
- The user can do nothing about it, but move on.
