Commit Graph

48 Commits

Author SHA1 Message Date
Abdullah Tahiri
78ae9c1d7d SketcherGui: apply clang-format 2023-05-25 17:08:03 +02:00
Abdullah Tahiri
0bdc7bb370 SketcherGui: Separate user and developer errors
===============================================

Revisiting all console calls:
- Using the Notification Framework when the user needs to be notified
- Turning them into DeveloperError/DeveloperWarnings when messages are intended only for developers
2023-05-25 14:09:06 +02:00
Abdullah Tahiri
189013389c Sketcher: Remove "Show Edit Section" from preferences
=====================================================

In a previous commit the Edit Section and its preferences where removed, however
Adrián Insaurralde realised that the setting for showing or not this section had been left behind:
https://github.com/FreeCAD/FreeCAD/pull/8716#issuecomment-1462364487

This commit just removes that settings.
2023-03-10 18:19:28 +01:00
Abdullah Tahiri
2896c1445a Sketcher: Remove Edit Controls from the TaskBar 2023-03-02 20:42:48 +01:00
0penBrain
f1bd743b1b Sketcher/Grid: fix error in parameter function call
Sketcher/Grid: fix algorithm computing the automatic grid spacing

Sketcher/Grid: forcefully redraw grid when one of its parameter is changed

Sketcher/Grid: always authorize user to change grid spacing, even if 'auto spacing' is enabled

Sketcher/Grid: apply a default factor of 10 for 'auto spacing' if number of subdivision is 1
2023-02-25 23:13:55 +01:00
Abdullah Tahiri
f486ee74a4 Sketcher: Grid - correction of design decisions
===============================================

Removal of ViewProviderGridExtension properties:
-GridStyle
-GridSnap

Improvement of ViewProviderGridExtension API:
- color via App::Color

Toolbar grid command:
- Conversion of Snapping to edit parameter
- Snap gets a class enum to support future Snapping functionalities as edit parameter

Sketcher Settings:
- Removal of snap preference

Behaviour:
- ShowGrid, GridAuto, GridSize preferences do not change any existing VP. They apply to any newly created sketch.
- Do not limit grid to hardcoded values

Snap to grid:
- Code updated to use closestpoint functionality provided by the extension,

Several other fixes
2023-02-25 23:13:55 +01:00
Abdullah Tahiri
127bc9f57b Sketcher: Grid settings - disable spacing when auto mode selected and vice versa 2023-02-25 23:13:55 +01:00
Paddle
40271a29ea Sketcher: Grid rework. Include:
- Adding 'auto spacing' option.
    - Drawing grid dynamically on viewer area only.
    - Moving code to coinManager.
    - Adding a 'grid tool' to sketcher-edit-mode toolbar.
2023-02-25 23:13:55 +01:00
wmayer
7a8f48d4e0 Sketcher: move to new style connect() 2023-01-13 20:17:53 +01:00
Uwe
b555dc0e89 [Sketch] Gui: Sketch - So: remove unused headers
- also some sorting
2022-12-13 02:45:17 +01:00
wmayer
4b08850edb Qt6 port:
* QApplication::setFallbackSessionManagementEnabled has been removed
* QString::medRef() has been removed. Use QString::mid() again.
* QTextStream::setCodec has been removed
* Use operator QVariant of the QFont class to make code Qt5 and Qt6 compatible
* Signature of QTreeWidget::mimeData() has changed in Qt6. Remove TreeWidget::mimeData() because it doesn't change the implementation
* QLayout::setMargin() is deprecated in Qt5 and has been removed in Qt6. Use QLayout::setContentsMargins()
* QDateTime::toTime_t() is deprecated in Qt5 and has been removed in Qt6. Use QDateTime::toSecsSinceEpoch()
* QDesktopWidget is deprecated in Qt5 and has been removed in Qt6. Use QScreen
2022-11-01 16:55:40 +01:00
Paddle
f320850e38 Sketcher: Make 'Edit control' widget optional. ENABLED by default. 2022-10-07 12:32:55 -07:00
wandererfan
eb93e599c0 [Sketcher]make cursor coord display unit aware 2022-08-31 16:31:27 -04:00
Dirk Olbrich
29b6cd6579 Sketcher: display dimensional constraint name
- checkbox in sketcher settings ui to display dimensional constrain name
- option to format dimensional presentation string
2021-09-01 10:27:42 +02:00
0penBrain
4d8e9e8ba1 [Sketcher] Remove no more used preference 2021-06-19 13:45:53 +02:00
0penBrain
bb434d3ff2 [Sketcher] Visibility automation : add option to force orthographic view when entering edit mode 2021-05-13 14:10:44 +02:00
0penBrain
5c10c586cd [Sketcher] Visibility automation : add ability to open sketch in Section View mode 2021-04-24 16:22:46 +02:00
Syres916
d630156237 [Sketcher] Settings checkBox for..
...setting Diameter as default constraint for Arcs and Circles
See discussion : https://forum.freecadweb.org/viewtopic.php?f=3&t=57054
2021-03-27 06:13:09 +01:00
donovaly
ade2857ba3 [Sketcher] make more pointers to the UI std::unique_ptr
addendum to PR #4362

(Same as PR #4293, just for Sketcher

as noted in https://github.com/FreeCAD/FreeCAD/pull/4271#discussion_r554673632
the pointer to the UI should be a unique pointer.

This PR does this for all Sketcher dialogs that don't already use a unique_ptr.)
2021-02-05 17:14:24 +01:00
Abdullah Tahiri
0ecddc5e33 Sketcher: Invalid Sketch geometry color in preferences 2021-01-23 07:53:28 +01:00
Abdullah Tahiri
d30f877788 Sketcher: Preferences - add 3D view scaling factor
==================================================

In addition to the font size in pixels, which controls the 3D View font size (and indirectly the constraint icons),
it is now possible to configure a scaling factor controlling the width of geometry, axes, information layer, and
constraint lines.
2021-01-07 12:11:01 +01:00
donovaly
a1d02ce109 [Sketch] remove unused code
fixes bug #4522

as discussed in https://forum.freecadweb.org/viewtopic.php?f=10&t=53587&p=460823#p460777

also remove superfluous verticalSpacer
2020-12-28 11:28:26 +01:00
Abdullah Tahiri
0a2d3ddd1a Sketcher: Bring new colors to preferences 2020-12-19 11:58:54 +01:00
Abdullah Tahiri
2ba211f2cf Sketcher: ViewProvider - Show Internal aligment geometry in different color
===========================================================================

The aim is to easily differentiate a circle that is a normal circle from a circle that is internal geometry, no matter
if the normal circle is construction or not.

The underlying reason is that next commits will introduce a different treatment for internal geometry circles being B-Spline
poles, to which a new constraint Weight instead of a normal radius constraint will be applied, even though the representation
continues to be as circles.
2020-12-10 18:34:06 +01:00
0penBrain
c6fdc526dd [Sketcher] Add missing 'Auto remove redundant' to preferences 2020-05-27 19:25:47 +02:00
wmayer
e1b3ec41b6 Sketcher: add option to disable leaving sketch with Esc button 2020-02-09 13:52:09 +01:00
wmayer
c2d0305e44 Sketcher: split huge settings page into two pages 2020-02-08 19:45:23 +01:00
Abdullah Tahiri
a97bb669a9 Sketcher: Settings - Deactivated constraints color selection 2019-06-22 08:26:31 +02:00
hokieengr
341b90a33d Added option to hide units in sketch
Currently not hooked up to anything just yet.
2018-07-23 12:41:14 -03:00
JimStar
8a8348e72b Extended global marker size to be used for Sketcher 2018-07-11 21:22:28 -03:00
Abdullah Tahiri
e9732b4b0a Sketcher: Setting in Preferences to switch on/off notification of constraint substitution
=========================================================================================

By default notification is on, so that Newbies do not complain why FC is deleting that other constraint they have added before.

Power users generally will set it off, as they do not want to be bothered by pop ups and know what they are doing.
2018-01-27 12:33:11 +01:00
Abdullah Tahiri
8814d5ada6 Sketcher: Settings Dialog new color for dependent constraints 2018-01-01 21:00:06 +01:00
Abdullah Tahiri
a309e417fc Sketcher: New Setting for improved dragging mode 2017-12-12 22:20:27 +01:00
Jeff
7f633cfbb2 Added color prefs to sketcher create commands
Create geometry commands in sketcher now have configurable crosshair color and editCurve color.
2017-11-18 15:30:41 +01:00
wmayer
9e90accc81 split sketcher settings page and move to its own group 2017-03-06 14:37:40 +01:00
AjinkyaDahale
286e71074a Sketcher: Added option to turn constraint creation modes on/off
Can be found below geometry creation "continous mode" option
2017-02-24 15:20:26 +01:00
Abdullah Tahiri
02b0351e03 Sketcher: Settings - Allow to set the number of segments per geometry 2017-02-21 13:24:10 +01:00
DeepSOIC
6fcf49b866 Sketcher: TV: preferences UI
* 4 checkboxes for setting defaults for visibility automation
* "Apply to existing sketches" button
2016-06-20 01:19:30 +03:00
wmayer
466a4e6d4d + issue #0001203: Allow User to Adjust Size of Constraint Points 2016-03-08 00:31:50 +01:00
wmayer
6b3340e7b5 + include missing header files 2015-07-01 13:02:29 +02:00
Abdullah Tahiri
2207eadfb7 Sketcher: New setting: Show advanced solver taskbox
===================================================

I makes the advanced solver taskbox by default disabled (not shown) and provides
a setting in Preferences->Display->Sketcher to enable it.
2015-06-24 17:56:59 +02:00
Abdullah Tahiri
213b9e2dda Sketcher: New Feature: Continuous creation mode
===============================================

When creating a type of geometric element, the user can create as many elements of that type he wishes without having to click the button before each insertion.

The insertion of that type of elements ends by pressing ESC or clicking the right button of the mouse.

This mode is by default disabled and can be enabled in Preferences->Display->Sketch->Geometry Creation "Continue Mode".
2015-05-30 16:39:26 +02:00
Abdullah Tahiri
18e5aed762 Sketcher bug fixes: Non-driving constraints editable on double click and color settings not working
===================================================================================================

This fixes a bug in the original implementation, that a non-driving constraint value could be
edited by double clicking on it in the 3D view.

It also includes minimal documentation on some functions.

It also includes:
- Color setting for non-driving constraints was not working.
- Settle UI terminology dispute:
  * Driving Constraint (normal red constraint)
  * Reference Constraint (non-driving constraint)
2015-05-30 16:39:26 +02:00
wmayer
c67b6fafca + fixes #0001049: Sketcher preferences in preferences editor 2014-03-14 19:39:11 +01:00
wmayer
a7a0573114 + sketcher settings 2014-03-14 15:29:00 +01:00
wmayer
cb10b00e29 + issue #0001049: Sketcher preferences in preferences editor 2014-03-09 21:44:37 +01:00
wmayer
6ad25ef75d + fixes #0001393: Allow the user to set desired font size in pixels (used by sketcher constraints) in preferences 2014-03-09 18:29:26 +01:00
wmayer
c21c2ae9fe + move sketcher related settings into own page 2014-03-09 18:07:46 +01:00