Commit Graph

14 Commits

Author SHA1 Message Date
wmayer
d34a8cad32 TD: fix -Wunused-private-field 2021-06-12 11:00:53 +02:00
donovaly
2bc5ac2e4b [TD] fix centerline crashes and bugs
the PR fixes the following things:
- change the way centerlines between 2 lines are calculated. The current implementation leads to many bugs and even crashes (e.g. when the 2 selected lines are parallel ones of a square). There are different forum threads from the last 1.5 years.
The new endpoint line sorting is the one described here: https://forum.freecadweb.org/viewtopic.php?f=35&start=20&t=44255&sid=989a668890f954c13ef81e4a04ee6912#p501179

- as consequence the erroneous and misleading line end flipping can go and is removed (only used internally)

- when creating a new centerline, you see it immediately

- when creating a new or editing an existing centerline and press Cancel, the creation/editing is aborted

- fix crash when the 2 selected lines are bot horizontal and one tries to create a vertical centerline

- fix crash when changing the orientation  of an existing centerline and the result would be invalid

- cleanup the code a bit
2021-05-15 05:21:29 +02:00
donovaly
691eaa6e8f [TD] make pointers to the UI std::unique_ptr
as noted in https://github.com/FreeCAD/FreeCAD/pull/4271#discussion_r554673632
the pointer to the UI should be a unique pointer.

This PR does this for all TD dialogs that don't already use a unique_ptr.
2021-01-19 19:24:27 +01:00
wandererfan
f59188e5e4 [TD]fix crash on bad centerline selection 2020-04-17 10:11:24 -04:00
donovaly
d483cacfb1 [TD] Centerline dialog refurbish
- group the radio buttons
- make edit dialog apply immediately
2020-03-23 09:24:25 -04:00
donovaly
ed2b456818 TaskCenterLine.h: correct line endings 2020-03-19 09:33:31 -04:00
donovaly
00e5c48b3c [TD] cleanup and fixes for Centerlines
- merge the flip Ends option to the main dialog
- use a QuantitySpinBox with angular unit for the angle
- store the state of the flipping correctly
- cleanup UI of dialog to avoid vertical whitespace
2020-03-19 09:33:31 -04:00
wmayer
f144049231 Fix clang compiler warnings:
+ fix -Winconsistent-missing-override
+ fix -Wunused-private-field
2019-08-17 19:53:39 +02:00
wandererfan
a4577a1e5b [TD]Edge and Vertex center lines 2019-07-15 12:36:48 -04:00
wandererfan
5d601c1cdd [TD]Add CenterLine edit function 2019-07-15 12:36:48 -04:00
wandererfan
7ea2cca327 [TD] Add Centerline Shift/Rotate 2019-07-15 12:36:48 -04:00
wandererfan
fbfdb69c20 [TD]Py Cosmetic Vertex, Line, Circle Arc 2019-07-15 12:36:48 -04:00
wandererfan
448c68cd41 Handle multiple face selection 2019-06-06 19:58:15 -04:00
wandererfan
07e26d3624 Initial working version Face Centerline 2019-06-06 19:58:15 -04:00