Commit Graph

2348 Commits

Author SHA1 Message Date
Russell Johnson
c44b7d7b54 Path: Fixes #4645
Fixes bug #4645.
This PR adds a simple `integrityCheck()` method to Job object class.  The method is called on the Gui side before openning the task panel to edit the job.  The same method is also called upon document restoration.
2021-09-24 06:43:16 -05:00
Russell Johnson
2bb8baec06 Path: Delete unnecessary comments 2021-09-24 06:40:53 -05:00
Russell Johnson
dd03e616d0 Path: LGTM cleanup 2021-09-24 06:40:53 -05:00
Russell Johnson
fcd8b8558e Path: Fix Face Region boundary shape usage
This commit removes automatic edge extension for `Face Region` boundary shape.  It applies the `Clear Edges` toggle for `Face Region`.  It applies `Exclude Raised Areas` correctly.  The problem of collision paths for `Clear Edges` with `Exclude Raised Areas` for certain use cases remains and is not fixed with this commit.
2021-09-24 06:39:25 -05:00
Russell Johnson
7ec38a5c3b Path: Remove unused import 2021-09-24 06:39:25 -05:00
Russell Johnson
1fbb7412b7 Path: Add docString and comments for getAllIncludedFaces() method 2021-09-24 06:39:25 -05:00
Russell Johnson
48d10b25b2 Path: LGTM fix
Prompted by LuzPaz in Gitter.im/FreeCAD/Path chatroom
2021-09-24 06:39:25 -05:00
Russell Johnson
61a43a644c Path: Black code formatting only 2021-09-24 06:38:39 -05:00
Russell Johnson
a83871e509 Path: Add Base.Active check early in execute() method
This commit adds a `Base.Active` check to determine if the Base is Active.  If the Base is Inactive, the new code sets the `obj.Path` property to the same inactive message used in PathOp module and the `execution()` method returns immediately, stopping further execution.
2021-09-24 06:38:39 -05:00
jim
6e1784ddba PathArry translate copies along Z axis as it does along X/Y 2021-09-20 21:10:49 -07:00
Chris Hennes
be5971ad8e Path: LGTM - don't catch BaseException 2021-09-19 14:37:11 -05:00
luz paz
6642e28826 Path: Fix PathScripts/PathJobGui.py typo bug 2021-09-08 10:22:26 -04:00
sliptonic
b53ec3bd4e Black reformat 2021-09-01 12:56:00 -05:00
sliptonic
ddc4c69e82 black 2021-09-01 12:26:29 -05:00
sliptonic
829c1d2a7e Merge pull request #5003 from sliptonic/removeArchPanel
[PATH] purge archpanel support
2021-09-01 11:00:54 -05:00
sliptonic
b60edfd9d6 Merge pull request #4974 from Russ4262/cleanup/pathpocketshapegui
[Path] Remove unused imports per LGTM in PathPocketShapeGui module
2021-09-01 10:23:06 -05:00
sliptonic
ffa92561a0 Merge pull request #4976 from Russ4262/cleanup/general_lgtm
[Path] LGTM cleanup
2021-09-01 10:21:09 -05:00
sliptonic
9cd18976d4 Merge pull request #4986 from ho-ho-ho/master
Path: Add missing newline to return-to statement in grbl postprocessor
2021-09-01 10:18:00 -05:00
sliptonic
730159d088 purge archpanel support 2021-09-01 08:34:46 -05:00
Russell Johnson
ae7a8752fb Path: LGTM cleanup 2021-08-27 22:37:41 -05:00
sliptonic
8c361dd3fc Merge pull request #4902 from Russ4262/fix/Extensions_error_msg
[Path] Downgrade Extensions error message priority
2021-08-27 17:17:33 -05:00
ho-ho-ho
baafa2a0c4 Update grbl_post.py
Append new line to return-to line
2021-08-21 12:36:47 +02:00
Russell Johnson
248a89020c Path: Remove unused imports per LGTM 2021-08-17 21:47:22 -05:00
sliptonic
0fcd0cec44 Merge pull request #4797 from Russ4262/feature/tile_job
[Path] GUI scripting support and other improvements
2021-08-14 09:26:25 -05:00
sliptonic
59c36f150e Merge pull request #4815 from Russ4262/fix/GUI_issues
[Path] Fix GUI issues and minor code cleanup
2021-08-14 09:20:03 -05:00
Russell Johnson
1cdfd611fd Path: Downgrade module's debug level to INFO 2021-08-13 19:02:40 -05:00
Russell Johnson
ff3adacd93 Path: Auto-load the user-selected job for the simulator
Add code to auto-load the user-selected job in the simulator so manual selection is not necessary with multi-job documents.
2021-08-13 19:02:40 -05:00
Russell Johnson
be1e394da9 Path: Changes to allow for Adaptive op defaults at job level
Add `SetupProperties()` function to Adaptive module.
Connect `SetupProperties()` function to GUI command resources.
Add string assignment for `App::PropertyPythonObject` property prototype
2021-08-13 19:02:40 -05:00
Russell Johnson
86b4c626a7 Path: Add missing translate() function 2021-08-13 19:02:40 -05:00
Russell Johnson
30ea19a923 Path: Refactor PathBoundary algorithm to independent class
Relocate code for PathBoundary algorithm into an independent class allowing for usage without the Dressup object creation.
2021-08-13 19:02:40 -05:00
Russell Johnson
cfca2a790a Path: Allow parent job assignment
Modifications focus on allowing the creation of operations to include direct provision of parent job.
Path: Remove `useGui` implementation
2021-08-13 19:02:40 -05:00
sliptonic
2736142ddf Merge pull request #4901 from Russ4262/fix/3D_Pocket
[Path] Fix 3D Pocket tuple lengths in return values
2021-08-02 12:22:56 -05:00
sliptonic
8f4d3a7008 Merge pull request #4906 from Russ4262/fix/toolbit_missing_readme_doc
[Path] Fix relative shape files for toolbits
2021-08-02 12:19:37 -05:00
sliptonic
0e59eb565d Merge pull request #4919 from Russ4262/fix/profile_cut_side
[Path] Remove `Side` assignment to `Outside` for full model profiles
2021-08-02 12:15:07 -05:00
sliptonic
d66fbada61 Merge pull request #4818 from Russ4262/refactor/path_array
[Path] Refactor path array algorithm into independent `PathArray` class
2021-08-02 12:11:00 -05:00
sliptonic
eef30446aa Merge pull request #4936 from ho-ho-ho/master
Path: fix grbl --return-to placement
2021-08-02 10:29:58 -05:00
luz paz
427a2ab8d6 Path: fix various typos and superfluous whitespace
Found via `codespell -q 3 -L aci,ake,aline,alle,alledges,alocation,als,ang,anid,apoints,ba,beginn,behaviour,bloaded,bottome,byteorder,calculater,cancelled,cancelling,cas,cascade,centimetre,childs,colour,colours,commen,connexion,currenty,dof,doubleclick,dum,eiter,elemente,ende,feld,finde,findf,freez,hist,iff,indicies,initialisation,initialise,initialised,initialises,initialisiert,inout,ist,kilometre,lod,mantatory,methode,metres,millimetre,modell,nd,noe,normale,normaly,nto,numer,oder,ontop,orgin,orginx,orginy,ot,pard,parms,pres,programm,que,recurrance,rougly,seperator,serie,sinc,strack,substraction,te,thist,thru,tread,uint,unter,vertexes,wallthickness,whitespaces -S ./.git,*.po,*.ts,./ChangeLog.txt,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/CXX,./src/zipios++,./src/Base/swig*,./src/Mod/Robot/App/kdl_cp,./src/Mod/Import/App/SCL,./src/WindowsInstaller,./src/Doc/FreeCAD.uml,./build/doc/SourceDocu`
2021-07-30 11:53:22 -04:00
sliptonic
dde8ec5c7f Merge pull request #4939 from Russ4262/fix/job_template_paths
[Path] Fix multi-OS path issue for Job templates
2021-07-25 13:42:13 -05:00
Russell Johnson
2da26fe715 Path: Add Active property to PathArray object; Fixes #4704
This property is required for the Path Simulator.  It might also be required for some post-processing procedures.
2021-07-24 22:29:18 -05:00
Russell Johnson
fc70edc66a Path: Improve method name for setting editor modes for properties 2021-07-24 22:29:18 -05:00
Russell Johnson
d8806b0e5c Path: Improve variable names for mode values 2021-07-24 22:29:18 -05:00
Russell Johnson
edc358a4a1 Path: Refactor path array algorithm into independent PathArray class
New class is `obj` independent allowing for greater scripting capability.
Added missing `onDocumentRestored()` method to ObjectArray class to handle property visibility and edit modes, per standard Path operations on document restoration.
2021-07-24 22:29:18 -05:00
Russell Johnson
640eb6ace7 Path: Fix multi-OS path issue.
Not all operating systems use the same path scheme - the slash direction.  The issue fixed with this commit exists in other parts of the Path workbench
2021-07-24 16:46:49 -05:00
Russell Johnson
d008303ae7 Path: Code cleanup, remove duplication, fix obj.removalshape shape 2021-07-24 11:57:53 -05:00
Russell Johnson
527e168be2 Path: Fix bug with inaccurate Task Panel values upon new op creation
Path: Fix bug with inaccurate Task Panel values upon new op creation
2021-07-24 11:57:53 -05:00
Russell Johnson
495a4e610a Path: Fix readonly lockout bug with blank expression 2021-07-24 11:57:53 -05:00
Russell Johnson
99b218c63d Path: Prioritize self.parent and self.obj declarations
This prioritization and conversion of `self.parent` declaration allows for removal of the `setParent()` method.
2021-07-24 11:57:53 -05:00
Russell Johnson
b91a4b6ecd Path: Restore edge processing to Adaptive as in 0.19 release 2021-07-24 11:42:30 -05:00
sliptonic
a40812dfbf Merge pull request #4917 from Russ4262/fix/Adaptive_process_edges
[Path] Adaptive: Correct the processing of selected edges
2021-07-23 12:35:08 -05:00
ho-ho-ho
d2c170a929 Path: fix grbl --return-to placement 2021-07-23 16:48:30 +02:00