Commit Graph

30 Commits

Author SHA1 Message Date
Chris Hennes
667514e21b PD: Correct typo in pattern parameters 2024-02-28 13:56:16 -06:00
André Althaus
3936f49ee2 Fix linter hints 2024-02-28 17:29:59 +01:00
André Althaus
0c70b0bd1e Refactor the apply function to be virtual public 2024-02-21 15:04:38 +01:00
André Althaus
30f5595e2a Reformat files with clang-format 2024-02-17 17:13:14 +01:00
André Althaus
cf627f5ce4 Fix apply() method not called consistently
The python console commands where not consistenly reported because
the apply function was not called or not implemented.

The function is now called from the base class and also when
a subfeature is closed in MultiTransform.

Some missing properties are also added.
2024-02-17 17:13:14 +01:00
André Althaus
565b83d8fe Refactor: optimize member access specifiers
After refactoring many members have unnecessarily open access specifiers.
This changes as many members as possible to private or protected.
2024-02-17 17:12:59 +01:00
André Althaus
8694874080 Refactor: remove unused functions 2024-02-17 17:12:59 +01:00
André Althaus
f82663cfb0 Refactor: add default member initializers 2024-02-17 17:12:59 +01:00
André Althaus
0b3eb1ae08 Move duplicated code to the base class
All pattern sublcasses contain the same code for handling the
feature list. This code is now moved into the base class that handles
the common ui.

The subclasses now only need to call the setupUI/setupParameterUI function
in their constructors and implement the setupParameterUI function
to create their parameter ui into the specified widget.

The MultiTransform also handles it's common ui and the subclasses
can reuse setupParameterUI without code duplication.
2024-02-17 17:12:32 +01:00
wmayer
622e46771e PD: modernize C++: use equals default 2023-08-22 13:31:17 +02:00
wmayer
a122aa01a7 PD: move to new style connect() 2023-01-15 14:27:33 +01:00
berniev
180edfa3cc Mod: Single arg ctors must be explicit 2022-08-24 16:55:20 +02:00
berniev
71dc5ead2f Mod: Use override etc 2 2022-08-09 12:52:26 +02:00
berniev
f4ffd15864 Mod: redundant void 2 2022-08-08 10:27:50 +02:00
Uwe
4cd69ee774 [PD] Task dialogs: remove unused headers 2022-03-23 19:43:47 +01:00
wmayer
d1d4b996e7 PD: modernize C++11
* use nullptr
2022-03-23 19:26:14 +01:00
Uwe
7b7a0aa4bf [PD] remove some more unused includes 2022-02-21 15:13:54 +01:00
donovaly
b483fc0518 [PD] make pointers to the UI std::unique_ptr
Same as PR #4293, just for PartDesign

as noted in https://github.com/FreeCAD/FreeCAD/pull/4271#discussion_r554673632
the pointer to the UI should be a unique pointer.

This PR does this for all PartDesign dialogs that don't already use a unique_ptr.
2021-02-05 18:01:57 +01:00
donovaly
ba5fbc5778 [PD] spread the fix from commit 319f38cafc to 3 other affected dialogs 2020-02-15 17:00:26 +01:00
luz.paz
dc8bf3dc39 PartDesign: [skip ci] fix header uniformity
This PR fixes header uniformity across all PartDesign WB files
2019-12-22 00:58:38 +01:00
wmayer
20072a303d fix dangling pointer when cancelling multi-transform task panel 2017-09-29 19:18:34 +02:00
Alexander Golubev
82db88b6db PartDesign/TaskMultiTransformParameters: fix a segfault
The segfault was caused by premature delete of object
TaskMultiTransformParameter::subFeature refered to.
Steps to reproduce:
1. Create a multitransform
2. Add a sub transfurmation to it
3. Press cancel
2016-04-12 18:12:16 +02:00
jrheinlaender
011dbf53da Enable multiple originals for the transformed features 2016-04-12 18:11:56 +02:00
Eivind Kvedalen
8e112bd2db PartDesign: Added support for expressions. 2015-09-21 14:51:09 +02:00
wmayer
6b3340e7b5 + include missing header files 2015-07-01 13:02:29 +02:00
jrheinlaender
a424200862 PartDesign: make MultiTransform honour the "Update view" checkbox when adding transformations 2012-09-14 00:16:43 +02:00
logari81
d9808b4b97 PartDesign: fix bug in checkbox "Update View" of pattern features and do some code refactoring 2012-09-13 15:46:46 +02:00
logari81
cba163a803 PartDesign: restrict patterns to only one original and improve selection of references 2012-09-11 16:54:45 +02:00
logari81
d9f38b15e4 PartDesign: select references for Pattern features from original object 2012-09-09 09:19:18 +02:00
jrheinlaender
023c7fa0b1 PartDesign: implement Transform and Pattern features 2012-09-07 11:55:26 +02:00