Commit Graph

1999 Commits

Author SHA1 Message Date
berniev
5fa05ab83d Mod: Redundant_string_initialization 2022-08-08 16:52:42 +02:00
berniev
f4ffd15864 Mod: redundant void 2 2022-08-08 10:27:50 +02:00
berniev
53ba98d636 Mod: use empty 2022-08-06 19:30:13 +02:00
berniev
47ac049e14 Mod: use emplace_back 2022-08-05 10:36:16 +02:00
Uwe
4dd623466d [PD] remove unnecessary Python check
we only support Python 3
2022-07-31 05:27:45 +02:00
luz paz
ca52b33763 PD: Remove unnecessary semicolons in FeatureHole.py
Discovered through github action check.  
[skip ci]
2022-07-30 13:17:18 +02:00
luzpaz
ef3324fa9e PD: Fix 'testing inequality to None' syntax (#7279)
* PD: Fix 'testing inequality to None' syntax

- Substitute `is not None` for `!= None`
- Fix trailing whitespace
2022-07-30 04:01:40 +02:00
Uwe
f38144c353 [PD] AppPartDesignGui: sort includes 2022-07-25 23:36:39 +02:00
wmayer
a93082bc06 PD: [skip ci] Fix several clazy issues:
* Maybe you meant to call base method instead [-Wclazy-skipped-base-method]
* Missing reference in range-for with non trivial type [-Wclazy-range-loop-reference]
* Mixing iterators with const_iterators [-Wclazy-strict-iterators]
* Unused QByteArray [-Wclazy-unused-non-trivial-variable]
* C++11 range-loop might detach Qt container (QList) [-Wclazy-range-loop-detach]
2022-07-25 13:40:19 +02:00
Uwe
49c9541034 [PD] TaskExtrudeParameters: add missing simplification
forgot this change in commit 8789c4a1
2022-07-20 11:35:46 +02:00
Uwe
04e6414458 [PD] TaskExtrudeParameters: simplify code
to avoid several time the same translatable string
2022-07-20 03:16:56 +02:00
adrianinsaval
76f5c32574 [PD Pad/Pocket] Fix bug with midplane usage in TwoLengths mode (#7216)
* [PD Pad/Pocket] Fix bug with midplane usage in TwoLengths mode
2022-07-20 03:13:01 +02:00
Uwe
aca9973791 [PD] [skip CI] FeatureExtrude.cpp: fix a comment 2022-07-19 03:30:48 +02:00
Uwe
32ab100ed5 Mod: remove some superfluous Boolean checks (#7213)
* Mod: remove some superfluous Python Boolean checks
2022-07-19 01:35:12 +02:00
Uwe
24468b59ad re-add some nullptr
to be safe since their removal within assert() or bools might have some impact I don't know
2022-07-18 02:32:36 +02:00
Uwe
dfecb337e7 [PD] remove more superfluous nullptr checks 2022-07-18 01:33:28 +02:00
Uwe
b16f03ec02 [PD] add parameter enabling logic for pad/pocket
- currently all parameters are always enabled and thus can lead to errors like the one reported here:
https://forum.freecadweb.org/viewtopic.php?f=3&t=70266
2022-07-18 00:26:15 +02:00
Uwe
0eee9221f0 [PD] improve face selection for Pad/Pocket
- this PR extends PR #7191 as described in this forum thread: https://forum.freecadweb.org/viewtopic.php?f=3&t=70327
2022-07-17 18:35:34 +02:00
Uwe
16b25c5dab [PD] remove superfluous nullptr checks 2022-07-17 18:12:41 +02:00
Uwe
ac6235c577 [PD] App: remove superfluous nullptr checks
- also Body: get rid of some nasty single-letter variables
2022-07-17 18:07:00 +02:00
Uwe
86f9b4ec1f [PD] fix Pad/Pocket logic issue
- fixes the bug reported in https://forum.freecadweb.org/viewtopic.php?f=3&t=70266
  as Method #2
  -> When switching to two dimensions, symmetric must be unchecked if it is checked
2022-07-17 02:03:35 +02:00
wmayer
da70aa2dc6 PD: fix ProfileBased::getSupportFace() to also handle the case where a support face is selected 2022-07-16 16:08:09 +02:00
wmayer
423aaccd3f PD: rename getUpToFaceFromLinkSub to getFaceFromLinkSub 2022-07-16 15:59:54 +02:00
wmayer
b6494085b4 Part: replace PyObject_IsTrue with Base::asBoolean 2022-07-16 13:31:10 +02:00
wmayer
a8ac45b090 Replace std::ignore with boost::ignore_unused()
According to https://isocpp.org/blog/2016/09/quick-q-stdignore-for-ignoring-unused-variable std::ignore is not supposed to be used for this
2022-07-15 13:15:47 +02:00
Uwe
030aba9b92 [Part] [PD] add preferences setting for transparency
- allow to specify the default transparency for new shapes
2022-07-09 23:24:17 +02:00
Uwe
596877584d [PD] FeatureDressUp.cpp: add missing include 2022-07-03 21:20:01 +02:00
wmayer
0f5725b34a modernize C++: replace boost::function with std::function 2022-06-30 20:31:55 +02:00
wmayer
2628fb0350 App: fix memory leaks in Enumeration class and simplify code 2022-06-25 18:18:57 +02:00
Uwe
68b02d0641 [PD] re-add accidentally removed code in commit 7bdad502 2022-06-25 16:44:44 +02:00
Uwe
61edc1c0d8 [PD] Hole initialization bugfix
- by default there is no hole head cut and therefore its parameter must be initialized as read-only (will be enably when user sets a head cut)

- also fix a typo

- also fix a UI file issue (automatically done by Qt Designer)
2022-06-25 16:36:50 +02:00
andrea
c66aadeb60 removed references to OCC<7 2022-06-25 14:29:24 +02:00
Uwe
814de93e36 [PD] Hole dialog fixes
- when there is no profile the change of the hole cut type was not handled
- for the deprecated hole cut types it must also be possible to use custom values
2022-06-25 03:31:27 +02:00
Yorik van Havre
4c34ae7398 Merge pull request #7067 from Kuzma30/add_ts
Crowdin Add "new" WB to translations.
2022-06-24 13:50:43 +02:00
marioalexis
15923813d4 PartDesign: Use PyObject_IsTrue in combination with conditional ternary operator 2022-06-22 19:50:03 -04:00
Kuzemko Alexsandr
b99ccc6193 Crowdin Update .ts files with current source. 2022-06-21 17:31:06 +03:00
wmayer
86df83b7a9 PD: several fixes of shape binder:
* add action to context-menu to remove an element
* use an exclusive button group to avoid to have several buttons pressed at the same time
* allow to completely clear the support
* when pressing OK/Cancel then operate on the document the shape binder is part of (which isn't necessarily the active document)
* remove obsolete parameter from ViewProviderShapeBinder::highlightReferences()
2022-06-12 14:03:42 +02:00
wmayer
3e6d0e775f PD: allow to clear the shape when nullifying the Support property 2022-06-12 14:01:19 +02:00
Yorik van Havre
05301abfcb Merged crowdin translations 2022-06-12 11:56:37 +02:00
wmayer
6639146f2e PD: allow to set object in shape binder dialog by typing its name 2022-06-12 00:38:48 +02:00
wmayer
cbad816a3f PD: use WeakPtr to avoid any possible dangling pointers 2022-06-11 23:37:33 +02:00
wmayer
0a5f47fe03 PD: show object label instead of internal name in shape binder dialog 2022-06-11 21:00:15 +02:00
Yorik van Havre
3af0623431 Merged crowdin translations 2022-06-10 11:03:57 +02:00
Uwe
a37ca0e175 [skip CI] [PD] fix typo 2022-06-10 03:39:04 +02:00
Yorik van Havre
56264248eb Merged crowdin translations 2022-06-09 13:40:35 +02:00
Yorik van Havre
6d479e6cda Generated ts files 2022-06-08 12:32:59 +02:00
Yorik van Havre
d2f8b7d4e3 Merged crowdin translations 2022-06-08 12:28:54 +02:00
Yorik van Havre
80982cf87b Merged crowdin translations 2022-06-07 13:34:53 +02:00
Kuzemko Alexsandr
80967344c5 Crowdin Run update.ts with latest source code. 2022-06-07 13:15:44 +03:00
Yorik van Havre
1488714a0f Merged crowdin translations 2022-06-03 11:26:35 +02:00