Commit Graph

1581 Commits

Author SHA1 Message Date
wmayer
72af60c22e App: fixes issue #7628: Crash after creating Sketch for Body
The problem is that inside Transaction::addObjectNew() a transaction object is deleted before removing it from the container. When deleting the corresponding transactional object (i.e. a DocumentObject or ViewProvider)
it can happen that it e.g. calls Transaction::addOrRemoveProperty() that now finds the dangling pointer in the container.

The safe way is to first remove the object from the container before deleting it.
2022-10-24 16:49:29 +02:00
luz paz
2d4482cdf3 Fix source comment typo 2022-10-23 09:14:44 -05:00
wmayer
916891c3fc App: simplify code in Application::newDocument 2022-10-21 21:15:21 +02:00
wmayer
4fff36b550 App: [skip ci] fix string literal 2022-10-21 13:43:26 +02:00
Kuzemko Alexsandr
63174d487f [App] Fix of untranslated first document's name (#7156)
* Change no need function newDocument("Unnamed") call to variant without parameter. "Unnamed" set in App newDocument function instead.
* Refactor New Document command to run without parameter.
* Translate new document's userName. Internal name = "Unnamed".
* Crowdin Add to updatets.py App.ts. Create new file App.ts
* Fix error where document name is set with one function parameter. In this situation set internal and user name to string variable. For default function call (without parameter) set internal name to Unnamed, userName = translate ("Unnamed")
2022-10-20 21:35:09 -05:00
wmayer
67679b8a0f App: [skip ci] use curly braces for if/else-statements and for loops 2022-10-14 13:55:11 +02:00
wmayer
9282fffa07 App: add tests for cell rows and absolute cells 2022-10-13 20:16:48 +02:00
Uwe
a96a3a505f use explicit prefix std:: for vectors
- also add potentially missing include
- this commit is an attempt to fix #7585
2022-10-11 01:44:24 +02:00
Uwe
4a2aff82a6 [TD] Gui, Dlg*: remove unused includes
- also sort includes
- also two whitespace changes
2022-10-09 19:14:31 +02:00
wmayer
ea5a5ff363 App: [skip ci] for the dependency graph use orange color to indicate links that go out of scope 2022-10-08 16:29:36 +02:00
wmayer
f4b4aabc32 App: add option '--pass' to ignore arguments by the application and handle them by a script 2022-09-29 12:30:31 +02:00
Chris Hennes
b5e29c20dc App: Reformat Metadata per clang-tidy 2022-09-26 11:04:42 -05:00
Chris Hennes
1d11c5805a App: Add support for <pythonmin> XML tag in metadata 2022-09-26 11:04:42 -05:00
wmayer
198ce19e46 App: Consider using getpwuid_r(...) instead of getpwuid(...) for improved thread safety. [runtime/threadsafe_fn] 2022-09-25 11:43:15 +02:00
Uwe
5df9546907 [App] Application.cpp: silence some CI warnings
about whitespace, line length etc.
2022-09-24 20:44:07 +02:00
berniev
94a686f348 redundant 2022-09-24 20:36:21 +02:00
wmayer
414ff3fb35 App: [skip ci] improve whitespaces 2022-09-24 17:02:23 +02:00
marioalexis
5cb31ece93 App: Check Python types using Base::PyTypeCheck 2022-09-24 05:10:34 +02:00
Uwe
3eb9207639 [App] silence some CI whitespace warnings 2022-09-24 04:59:38 +02:00
Chris Hennes
cc17bd4335 App: Add support for 'discussion' URL attribute 2022-09-22 10:53:59 -05:00
Chris Hennes
4f51123626 App: Add support for <date> metadata element 2022-09-22 10:27:47 -05:00
Chris Hennes
49e37dd611 Core: Add missing xml namespace property to metadata output 2022-09-21 08:44:38 -05:00
marioalexis
9ccb9eecb2 App: Replace C cast 2022-09-18 11:06:51 -05:00
wmayer
2462f4c7a0 App: move from float to double for accuracy parameter, add a virtual method to determine a default accuracy 2022-09-15 09:52:14 +02:00
wmayer
64784232ab App: [skip ci] fix -Wsometimes-uninitialized 2022-09-12 14:20:41 +02:00
Chris Hennes
139b99d371 Addon Manager: Cleanup 2022-09-09 13:00:11 -05:00
Chris Hennes
cb1f6bffa8 Addon Manager: DevMode content implementation 2022-09-09 13:00:10 -05:00
wmayer
5240a30431 App: modernize C++: replace 'typedef' with 'using' 2022-08-29 12:58:39 +02:00
wmayer
cf399afe87 App: minor improvements:
* use 'using' instead of 'typedef' [modernize-use-using]
* fix bugprone-reserved-identifier
* fix whitespace/comma
2022-08-28 16:15:57 +02:00
wmayer
e809295342 App: replace some while loops with range-based for loops to increase readability 2022-08-28 15:42:57 +02:00
berniev
2a2062ec46 App: use auto - strange iterator (PR #7405) 2022-08-28 15:29:52 +02:00
berniev
85ec32c60e App use explicit 2022-08-25 15:56:23 +02:00
wmayer
949b43aabb App: [skip ci] whitespace improvements 2022-08-24 10:43:56 +02:00
wmayer
3c8a268355 App: [skip ci] improve whitespaces 2022-08-24 07:37:41 +02:00
berniev
d66df602ad App: Single arg ctors must be explicit 2022-08-24 07:20:57 +02:00
luz paz
1a7ddfdc24 Fix typos and whitespace
Found via `codespell -q 3 -L aci,ake,aline,alle,alledges,alocation,als,ang,anid,anormal,apoints,ba,beginn,behaviour,bloaded,bottome,byteorder,calculater,cancelled,cancelling,cas,cascade,centimetre,childrens,childs,colour,colours,commen,connexion,currenty,dof,doubleclick,dum,eiter,elemente,ende,feld,finde,findf,freez,hist,iff,indicies,initialisation,initialise,initialised,initialises,initialisiert,inout,ist,itsel,kilometre,lod,mantatory,methode,metres,millimetre,modell,nd,noe,normale,normaly,nto,numer,oce,oder,ontop,orgin,orginx,orginy,ot,pard,parm,parms,pres,programm,que,rady,recurrance,ro,rougly,seperator,serie,sinc,siz,strack,substraction,te,technic,thist,thru,tread,uint,unter,uptodate,vertexes,wallthickness,whitespaces -S ./.git,*.po,*.ts,./ChangeLog.txt,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/CXX,./src/zipios++,./src/Base/swig*,./src/Mod/Robot/App/kdl_cp,./src/Mod/Import/App/SCL,./src/WindowsInstaller,./src/Doc/FreeCAD.uml,./src/Base/StackWalker.cpp,./build/doc/SourceDocu`
2022-08-23 18:49:47 +02:00
wmayer
8efe30c8a9 Test: add test feature for unit tests 2022-08-22 15:46:40 +02:00
wmayer
71015d23d0 App: fix possible dangling pointer in Document::removeObject() 2022-08-22 11:15:14 +02:00
wmayer
020bf1789a Base: expose enum NumberFormat to Python 2022-08-15 11:12:53 +02:00
berniev
3891e85c32 App: Use override etc 2 2022-08-09 12:42:02 +02:00
wmayer
91ea39a5c0 Base: extend Placement/Rotation API
* Add Placement::isSame() and expose to Python
* Add Placement::multRight/Placement::multLeft
* Fix PlacementPy::rotate
* Add Rotation::multRight/Rotation::multLeft
* Add a test feature FeatureTestPlacement for uni tests
* Add unit tests
2022-08-09 11:54:05 +02:00
berniev
e5d4c09ce2 App: Redundant_string_initialization 2022-08-08 16:50:25 +02:00
wmayer
ec72d96038 App: [skip ci] improve whitespace 2022-08-08 10:11:22 +02:00
berniev
7f699c3dad App: redundant void 2 2022-08-08 09:45:36 +02:00
Uwe
6f9a4ebc7f [App] [Spreadsheet] fix compilation errors
- introduced by #7318 and #7319
2022-08-06 19:59:06 +02:00
berniev
1cc6329eab App: use empty 2022-08-06 19:29:59 +02:00
berniev
e7357c1a99 App: use emplace_back 2022-08-05 10:31:51 +02:00
wmayer
88e32eba9b App: changes in ComplexGeoData:
* rename some methods
* distinguish between Point and Vector
* support of arrays of Point or Vector
2022-08-03 16:18:14 +02:00
wmayer
632e167ed8 App: improve whitespaces 2022-08-01 01:29:47 +02:00
wmayer
7c6b6a3942 App: fix -Winconsistent-missing-override 2022-08-01 01:14:19 +02:00