Abdullah Tahiri
60d73e0e8e
Part: Attacher intersection calculation fix
...
===========================================
In OCCT 7.4 (and apparently <= 7.4 too):
A GeomAdaptor_Curve obtained directly from BRepAdaptor_Curve will not work because it won't respect the
Location/orientation of the underlying curve.
This commit proposes to create a new GeomAdaptor_Curve from an intermediary curve handle to work around
this issue.
2020-07-29 19:06:59 +02:00
wmayer
cd5341001e
remove superfluous includes of iostream, use iosfwd instead
2020-07-28 15:22:23 +02:00
wmayer
244d7aae41
LGTM: [skip ci] fix: Inconsistent definition of copy constructor and assignment ('Rule of Two')
2020-07-27 14:39:14 +02:00
wmayer
3b0eeb63e8
LGTM: [skip ci] fix: Inconsistent definition of copy constructor and assignment ('Rule of Two')
...
Remove user-defined copy constructor of Exception classes without assignment operator
2020-07-27 13:47:41 +02:00
wmayer
44f42a8e2c
LGTM: [skip ci] fix: Declaration hides parameter
...
A local variable hides a parameter. This may be confusing. Consider renaming one of them.
2020-07-27 10:57:34 +02:00
wmayer
d5d7d65bfc
LGTM: [skip ci] fix: Large object passed by value
2020-07-24 18:32:31 +02:00
wmayer
1a16cde1f5
Coverity: Structurally/Logically dead code
2020-07-20 17:34:28 +02:00
wmayer
421f6c52cb
Coverity: Dereference after null check
2020-07-20 17:34:25 +02:00
wmayer
6f06fbf36d
PVS: V601 The bool type is implicitly cast to the double type
2020-07-18 10:59:28 +02:00
wmayer
0f18bdeb72
PVS: V524 It is odd that the body of 'getLastUKnotIndex' function is fully equivalent to the body of 'getFirstUKnotIndex' function
2020-07-18 10:59:27 +02:00
wmayer
f29a1c43cb
PVS: V773 The exception was thrown without releasing the pointer. A memory leak is possible.
2020-07-18 10:59:27 +02:00
Abdullah Tahiri
9ca8568f89
PropertyGeometryList: move setValue and refactor
2020-07-01 14:04:25 +02:00
wmayer
478823b909
Part: [skip ci] fix regression in ruled surface feature by applying placement of source object twice
...
See: https://forum.freecadweb.org/viewtopic.php?p=411934
2020-06-27 23:17:32 +02:00
Gabriel Wicke
487215d2f5
[part] More robust tessellation angular deflection default
...
OCC currently does not reliably enforce linear deflection on curved
surfaces, especially curved lofts over nurbs splines. To avoid surprises
when tight tolerances are needed, replace the static default angular
deflection of 0.5 radians (~28 degrees), with a more sensible angular
deflection derived from the provided linear deflection tolerance.
By adding the default heuristic to TopoShape, we can keep typical
tessellate() and STL export functionality users simple, and also avoid
the need to implement similar heuristics in many places. If more
explicit control over angular deflection is needed for some use cases,
then we could still choose to expose the option to override the derived
default explicitly.
The hope is that OCC's linear deflection enforcement will be more
reliable at some point, at which point this heuristic will no longer be
needed.
2020-06-23 12:17:51 +02:00
wmayer
6c74b78507
Part: [skip ci] add missing headers
2020-06-21 22:53:42 +02:00
wmayer
f3b460e42e
boost: fix for boost < 1.60
2020-06-15 19:38:39 +02:00
wmayer
8ed90c8586
Py2: fix Python 2 build failure
2020-06-12 17:51:33 +02:00
wmayer
4ec45b545e
boost 1.73.0: The practice of declaring the Bind placeholders (_1, _2, ...) in the global namespace is deprecated
2020-06-12 17:51:33 +02:00
wmayer
3f212ad8ac
Porting Py3.8/Py3.9:
...
Since Py3.3: 'Py_ssize_t PyUnicode_GetSize(PyObject*)' is deprecated [-Wdeprecated-declarations]
Since Py3.9: 'PyObject* PyEval_CallObjectWithKeywords(PyObject*, PyObject*, PyObject*)' is deprecated [-Wdeprecated-declarations]
Since Py3.9: 'void PyEval_InitThreads()' is deprecated [-Wdeprecated-declarations]
2020-06-12 17:51:33 +02:00
wmayer
27b6066beb
clang/gcc/cmake: move handling of suppressed deprecated-copy warnings from source file to CMake file to more easily support gcc 10
2020-06-09 15:30:42 +02:00
wmayer
fdc07cb6c9
Py3.8: [skip ci] missing initializer for member '_typeobject::tp_vectorcall' [-Wmissing-field-initializers]
2020-06-08 14:40:00 +02:00
wandererfan
8311b1e66d
[Part]Fix bad shape from Fillet
...
- see #4285 for similar fix on Chamfer
2020-06-07 22:08:41 -04:00
wandererfan
73f086f73d
[Part]Fix #4285 Bad Shape from Chamfer
...
- chamfer was producing invalid shape as output.
fix uses shapefix to correct invalid surface/face.
2020-06-07 11:26:56 -04:00
wandererfan
4a3bd23877
[Part]use BSpline for makeWireString instead of Bezier curves.
...
- the bezier curves from the font definitions cause checkGeometry
errors when extruded. bsplines do not have this problem.
2020-05-31 11:26:22 -04:00
Gabriel Wicke
7822daf1f2
Part: Parallelize tessellations in TopoShape
...
Update parameters for all BRepMesh_IncrementalMesh instances to allow
parallel meshing. This matches what is already done for view
tessellations.
Other positional parameters are filled with their defaults in
BRepMesh_IncrementalMesh, so there should be no behavior change outside
of allowing parallelism.
2020-05-28 22:05:12 +02:00
wmayer
300e887480
Handle clang 10 warnings:
...
+ fix -Wtautological-bitwise-compare
+ fix -Wimplicit-int-float-conversion
+ fix -Wmisleading-indentation
+ fix -Wrange-loop-construct
+ suppress -Wdeprecated-copy of 3rd party libs
2020-05-25 15:34:43 +02:00
wmayer
1d8235c234
Part: [skip ci] get n-th derivative of a surface via Python
2020-05-18 13:17:26 +02:00
wmayer
7b970ab3b7
Part: [skip ci] get n-th derivative of a curve via Python
2020-05-17 23:25:07 +02:00
wmayer
ff0e556b59
Part: [skip ci] add methods to determine continuity
2020-05-17 21:57:25 +02:00
wmayer
34ebb0ecc4
fixes #0004316 : PartWB, "Reverse shapes" command reset position [skip ci]
2020-05-15 19:25:43 +02:00
wmayer
618089d6d8
remove deprecated std::binary_function
2020-05-11 13:46:37 +02:00
luz.paz
0c326f094f
[skip ci] fix documentation typos
...
Found via codespell v1.17.0.dev0
```
codespell -q 3 -L aci,ake,aline,alle,alledges,alocation,als,ang,anid,ba,beginn,behaviour,bloaded,byteorder,calculater,cancelled,cancelling,cas,cascade,centimetre,childs,colour,colours,commen,connexion,currenty,dof,doubleclick,dum,eiter,elemente,ende,feld,finde,findf,freez,hist,iff,indicies,initialisation,initialise,initialised,initialises,initialisiert,ist,kilometre,lod,mantatory,methode,metres,millimetre,modell,nd,noe,normale,normaly,nto,numer,oder,orgin,orginx,orginy,ot,pard,pres,programm,que,recurrance,rougly,seperator,serie,sinc,strack,substraction,te,thist,thru,tread,uint,unter,vertexes,wallthickness,whitespaces -S ./.git,*.po,*.ts,./ChangeLog.txt,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/CXX,./src/zipios++,./src/Base/swig*,./src/Mod/Robot/App/kdl_cp,./src/Mod/Import/App/SCL,./src/WindowsInstaller,./src/Doc/FreeCAD.uml
```
2020-04-20 12:59:09 +02:00
wmayer
d91bd53e10
Part: [skip ci] include missing header file
2020-04-14 09:37:45 +02:00
Eric Trombly
b631c5600a
move getFacets from Path to Part
2020-04-06 06:34:53 -05:00
Zheng, Lei
f501198832
Part: fix Feature::getTopoShape() for link array with LinkTransform
2020-03-27 11:28:59 -04:00
wmayer
a58ecba673
Part: [skip ci] do not print an error message if a sub-object of a Part feature cannot be found
...
Forum thread: https://forum.freecadweb.org/viewtopic.php?f=19&t=42216
2020-03-10 13:45:26 +01:00
Abdullah Tahiri
b748cc6884
Part: GeometryExtensions
...
========================
fixes #4087
Missing "break" in loop after finding the extension was causing segfault because of null pointer access, as the unique pointer had been std:move-d when found and was thus no longer valid.
2020-03-06 16:58:21 +01:00
luz.paz
180805c55e
Fix typos
...
Found via
```
codespell -q 3 -L aci,ake,aline,alle,alledges,alocation,als,ang,anid,ba,beginn,behaviour,bloaded,byteorder,calculater,cancelled,cancelling,cas,cascade,centimetre,childs,colour,colours,commen,connexion,currenty,dof,doubleclick,dum,eiter,elemente,ende,feld,finde,findf,freez,hist,iff,indicies,initialisation,initialise,initialised,initialises,initialisiert,ist,kilometre,lod,mantatory,methode,metres,millimetre,modell,nd,noe,normale,normaly,nto,numer,oder,orgin,orginx,orginy,ot,pard,pres,programm,que,recurrance,rougly,seperator,serie,sinc,strack,substraction,te,thist,thru,tread,uint,unter,vertexes,wallthickness,whitespaces -S ./.git,*.po,*.ts,./ChangeLog.txt,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/CXX,./src/zipios++,./src/Base/swig*,./src/Mod/Robot/App/kdl_cp,./src/Mod/Import/App/SCL,./src/WindowsInstaller,./src/Doc/FreeCAD.uml
```
2020-03-06 14:50:35 +01:00
wmayer
9d311b2b12
Part: [skip ci] add method to project point on surface
2020-03-05 10:48:12 +01:00
Zheng, Lei
b7a9d2dc37
Part: fix crash in TopoShape::makEFace()
2020-03-01 14:53:49 +01:00
wmayer
43e6be9020
Part: [skip ci] the number of domains returned by TopoShape::getDomains must match with number of faces
...
If a face cannot be meshed then an empty domain is added
2020-02-26 00:55:07 +01:00
wandererfan
e3b5b0b177
[Part]Handle CJK font names for ShapeString
2020-02-19 13:11:01 -05:00
wmayer
71ce2156f0
Part: [skip ci] simplify using Wire.approximate() by supporting keyword arguments and making all arguments optional
2020-02-17 15:39:21 +01:00
wmayer
48744aa9b5
Part: [skip ci] check for mults of inner knots when creating B-Spline curve/surface
2020-02-17 15:38:01 +01:00
wmayer
9cefd8858c
Part: [skip ci] fix crash in BRepOffsetAPI_MakeOffsetFix
2020-02-17 15:36:45 +01:00
Zhang Wei
0bef3cdee4
Patch for MIPS64 Architecture
2020-02-15 19:32:58 +01:00
wmayer
3cbe309330
Part: determine tangent intersection of two 2d curves
2020-02-13 12:51:40 +01:00
wmayer
4142fb90f1
Part: make reverse function parametric
2020-01-29 16:43:35 +01:00
MA-LAPTOP\apeltauer
7240de9b2f
make some header include adoption for open cascade 7.4.0
2020-01-27 10:15:32 +01:00
wmayer
c5321691dc
Part: [skip ci] implement methods getBasisCurve of Surface of Revolution/Extrusion
2020-01-22 14:53:17 +01:00