Paddle
692c6a4cd1
DSDWC : typo
2023-11-04 08:58:50 +01:00
Paddle
923a0de70b
Prevent passing the focus to a spinbox when it shouldn't.
...
In some DSH some mode (seekSecond for example) don't have onViewParameter. In this case it would wrongly try to give focus to the previous spinbox with focus.
2023-11-04 08:58:50 +01:00
Paddle
1a8aaa7d2e
Redraw on construction method changed. Avoid a small issue where you had to move mouse first before being able to rechange the methode by the M key.
2023-11-04 08:58:50 +01:00
Paddle
1525b3d024
SketcherToolDefaultWidget : Add a blockParameterFocusPassing bool that let us set parameters without passing focus. To fix undue passing of focus when using shortcuts U/J. For example in Polygon.
2023-11-04 08:58:50 +01:00
Paddle
fcc91e0055
DrawSketchController and DrawSketchDefaultWidgetController : fix lint warnings
2023-11-03 14:02:25 +01:00
Paddle
c9859ab2e2
Sketcher: Polygon DSH
2023-11-03 14:02:25 +01:00
Paddle
513e1a46c8
Sketcher: Offset DSH
2023-11-03 14:02:25 +01:00
Paddle
74e8990044
Sketcher: Rectangle DSH
2023-11-03 14:02:25 +01:00
Paddle
29f17f9c6d
Sketcher: Line DSH
2023-11-03 14:02:25 +01:00
Paddle
feb14870b6
Sketcher: Point DSH
2023-11-03 14:02:25 +01:00
Paddle
6d1c9b4161
DSDH : add canGoToNextMode() methode in onButtonPressed. So that we can prevent going to the next mode on certain conditions.
2023-11-03 14:02:25 +01:00
Abdullah Tahiri
e67f6aa7ae
Sketcher: Make GeometryConstructionMode an enum class
...
=====================================================
Enforce strong typing to avoid all kinds of abusive implicit conversionsm, the corresponding associated bugs and make code more readable.
2023-11-03 14:02:25 +01:00
Abdullah Tahiri
17b5a561d0
Sketcher: New flexible DSH Architecture
...
=======================================
Rewrite of the architecture to accomodate on-view parameters and to enable code reuse
between the default widget and custom widgets.
2023-11-03 14:02:25 +01:00
Paddle
118418c5eb
DSH architecture: On-view spinboxes
2023-11-03 14:02:25 +01:00
Abdullah Tahiri
3e05815834
Sketcher: New DSH architecture to support multiple input
...
========================================================
Architecture to support multiple input from a widget and a mouse.
2023-11-03 14:02:25 +01:00
Abdullah Tahiri
049cef023b
Sketcher: DrawSketchHandler - refactor functions to draw/clear edit curve and markers
2023-11-03 14:02:25 +01:00
Paddle
2c5d90daea
SketcherToolDefaultWidget : add 3 parameter configuration functions.
...
And remove the units from setParameter.
2023-10-24 19:28:13 +02:00
Paddle
48131bafc2
SketcherToolDefaultWidget : add functions to set combobox item icons and checkboxes icons.
2023-10-23 20:24:20 +02:00
Paddle
0f049a6cb0
Sketcher: commandConstraint : remove leftover bothexternal variable.
2023-10-22 13:51:21 +02:00
wmayer
decbcfdd12
Sketch: use new-style connect() in new code
2023-10-20 14:23:21 +02:00
wmayer
e9586c4206
Sketch: fix several compiler and lint warnings
...
* Remove private unused field 'sketchView'
* Mark constructor with single argument as explicit
* Mark virtual methods of base class as override
* Fix clang code model parsing error
* Avoid too short identifiers
* Avoid redundant ternary operators
* Avoid passing Base::Unit by value but by const reference
2023-10-20 12:29:59 +02:00
wmayer
9578b57e3b
Sketch: fix Qt6 build failure
...
QRegExp has been replaced with QRegularExpression and isn't part of the base of Qt6 any more
2023-10-20 11:57:21 +02:00
Abdullah Tahiri
7034795723
Sketcher: ToolSettings Widget - Tool Management
...
===============================================
Sets the full interface between the DrawSketchHandler and a tool widget available somewhere in the UI.
Signalling is as follows:
1. On activation of the tool, DrawSketchHandler notifies the tool widget.
2. The tool widget retrieves tool information necessary for representation (type of widget, visibility, ...)
3. When the tool widget has created an appropriate widget, it notifies back a widget change.
4. The tool receives the widget handler and can now configure and interact with the widget.
2023-10-15 15:20:03 +02:00
Paddle
c6f42e1b68
Sketcher: DrawSketchHandler - add getViewer function to drawsketchHandler to simplify code.
2023-10-15 15:20:03 +02:00
Paddle
5ad7548340
ToolWidget-Sketcher: Tool widget basic framework
...
================================================
Provides a framework to show in the taskbar a taskbox with a tool settings dialog.
2023-10-15 15:20:03 +02:00
Paddle
019bd50bbc
Fix typo making Sketcher_Dimension fails for angles.
2023-10-10 13:48:07 +02:00
wmayer
d305f306df
Core: Revert superfluous changes made with PR #9521
2023-10-09 15:06:45 +02:00
Abdullah Tahiri
ead8a9a5d1
Sketcher: Example new type checking template function usage
...
===========================================================
Just two small refactor examples of how to use the type checking template functions.
2023-10-07 23:12:46 +02:00
Abdullah Tahiri
c7b99b9fbb
Sketcher: Fix segfault when activating a tool in a different view
...
=================================================================
When in Sketcher edit mode, a tool button is activated, while the view has been changing to view of a different type, it segfaults.
This commit checks the pointer of the view to ensure correct type before activation, and refusing to activate if not of the correct type.
fixes #10809
2023-10-07 09:00:06 +02:00
Paddle
2ea27064d5
Create makeAngleBetweenTwoLines and Create Create calculateAngle to remove duplicates
2023-10-07 07:43:39 +02:00
AgCaliva
3ac69993c0
merge master via cli
2023-10-04 13:28:48 -03:00
liukaiwen
721b991b1c
Merge remote-tracking branch 'origin/master' into remove_redundant_definition
2023-10-02 01:42:37 +08:00
Chris Hennes
6c9be93378
Update translations
2023-09-29 22:57:37 -05:00
liukaiwen
329904a055
[cmake] some definitions do not matter build now
2023-09-27 18:17:14 +08:00
AgCaliva
a4e90b2609
Merge branch 'master' into User/Document/Feature_level_units_selection_#7746
2023-09-25 22:58:23 -03:00
howie-j
12f80320fc
[Sketcher] Fix angle constraint expression regression ( #10743 )
...
* fix 10742
* moved expression string modifier to helper function
* Tests: Add example tests for SketchObject
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* made expr modifier func static, pass by value and added unit tests
---------
Co-authored-by: Chris Hennes <chennes@gmail.com >
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2023-09-25 10:44:31 -05:00
wmayer
1cdff85086
MSVC: fix warnings and build failure
2023-09-23 19:10:32 +02:00
Chris Hennes
3f3ab1ae15
Update translations
2023-09-19 22:25:14 -05:00
wmayer
b2d255e5fc
Sketch: fix a few minor issues:
...
* fix compiler warning about unused variable
* fix const correctness
* fix access type of setExpression()
* removed duplicated method
2023-09-19 22:01:19 +02:00
Chris Hennes
fb46c8c6f8
Merge pull request #10656 from Ondsel-Development/dim_arc_angle
...
Sketcher_Dimension: Adds arc angle mode.
2023-09-19 12:42:56 -05:00
Paddle
f080b39829
Sketcher_Dimension : adds arc-angle mode for arcs.
2023-09-19 08:25:45 +02:00
Paddle
9c3c763d10
Sketcher: Angle constraint: when moving it with mouse, it enables user to switch of supplementary angle.
2023-09-19 07:22:50 +02:00
Paddle
3c275de11d
Implement a function in sketchObject that swap an angle constraint to its supplementary.
2023-09-19 07:22:50 +02:00
Paddle
2c2a977e04
Add setter/getter for constraint expression.
2023-09-19 07:22:50 +02:00
AgCaliva
40c05f6714
continue fix DOMDocument redefinition
2023-09-18 18:58:05 -03:00
Paddle
b97a2ef6dc
Adds a small convenience function to get arc of circle angle.
2023-09-18 21:33:24 +02:00
AgCaliva
cfdbd2322a
Merge branch 'master' into User/Document/Feature_level_units_selection_#7746
2023-09-18 14:01:25 -03:00
AgCaliva
ae9bb6ed43
using clang-format tags to avoid get headers reordered(fix DOMDocument redefinition error)
2023-09-18 13:40:13 -03:00
Jonas Bähr
41cae1a561
Sketcher: update SketchObject's pydocs, first batch
...
Style like in e.g. `Part.makeLine(...)`, which seems to loosely follow
Google's recommendations [1]. Note that the signature *is* repeated in
the docstrings, as it's not "inspectable" (see notes for non-python
implementations in `inspect.signature` [2]).
[1]: https://github.com/google/styleguide/blob/gh-pages/pyguide.md#38-comments-and-docstrings
[2]: https://docs.python.org/3/library/inspect.html#inspect.signature
2023-09-18 10:57:12 -05:00
howie-j
49bca90219
fixes #10651
2023-09-18 10:56:13 -05:00