Commit Graph

17004 Commits

Author SHA1 Message Date
Russell Johnson
ed85341cd9 Path: Improve property visibility in Data tab 2020-04-16 00:28:04 -05:00
Russell Johnson
a0cecce62e Path: Expose operation's property details to access via class 2020-04-16 00:27:58 -05:00
Russell Johnson
9e9d5ce962 Path: Fix weakness in face analysis for unique OuterWire cases
synced with PathSurface module
2020-04-16 00:27:49 -05:00
Russell Johnson
01e95b2ac0 Path: Add missing tooltips 2020-04-16 00:27:40 -05:00
Russell Johnson
aa1261dc7d Path: Waterline fixes(5), new IgnoreOuterAbove, and code simplification
Fix module base for getFacets()
Fix isOnLineSegment() usage.
Fix property visibility in Data tab.
Fix missing raise to SafeHeight after clearing layer.
Fix handling of `import ocl` failure
Move Draft import to dependent function
Raise `import ocl` test in code execution
Disable face selection for Waterline and issue warning as intermediate fix. Application of face-selection from 3D Surface requires some modification for use in Waterline.  This work is to be done.  Some existing carryover methods should be usable in current form.
Compact setup() function
Sync some methods with PathSurface in preparation of extracting common methods to independent support module.
Increase SampleInterval range for OCL Dropcutter algorithm.
Convert OCL Dropcutter waterline to use FreeCAD.Vector() points rather than ocl.Point().
Simplify some code and delete unnecessary comments.
LGTM cleanup.
New feature - IgnoreOuterAbove. Ignore the outer-most waterline above this height.  Designed to eliminate the model profile path created in some use cases.
Adjust tooltip language for `Algorithm`
2020-04-16 00:27:40 -05:00
Russell Johnson
c0a5a8c97e Path: Improve Tasks editor interaction
Swap setEnabled() method for show() and hide().
Include showing and hiding associated labels.
Path: Hide `optimizeEnabled` input
2020-04-16 00:27:06 -05:00
Russell Johnson
341da1092d Path: Move more common methods to PathSurfaceSupport module 2020-04-16 00:20:46 -05:00
Russell Johnson
0bd0d52baf Path: Simplify if ... is True: statements. 2020-04-16 00:17:47 -05:00
Russell Johnson
ccfd52477f Path: New class - PathGeometryGenerator; new CutPattern - Offset
Converted _planarMakePathGeom() into independent class, PathGeometryGenerator, as preparation to share common code with Waterline.
Implementation of new class within existing code.
Added new cut pattern: Offset.  It is ported from Waterline.
2020-04-16 00:17:40 -05:00
Russell Johnson
f6ad7101c6 Path: Create shared support module for 3D Surface and Waterline 2020-04-16 00:17:33 -05:00
Russell Johnson
fd34891c99 Path: Improve compatibility between file versions
Verify enumerations on document reload, maintaining the existing value for the property.
2020-04-16 00:17:33 -05:00
Russell Johnson
a6cb530d57 Path: Fix weakness in face analysis for unique OuterWire cases 2020-04-16 00:17:24 -05:00
Russell Johnson
f41ec732e1 Path: Added Spiral cut pattern; Adjusted tooltip language 2020-04-16 00:17:16 -05:00
Russell Johnson
b5048f4f02 Path: Multiple fixes; code optimizations and cleanup
Fix _processRotationalOp() arguments and erroneous call thereto.
Fix isOnLineSegment() usage.
Fix transition between profile edge and clearing.
Fix _planarSinglepassProcess() method.
Fix `ProfileEdges` feature.
Fix Y-axis rotation error in G-code and display.
Fix error handling of `import ocl` test.
Raise `import ocl` test in code sequence.
Convert ocl.Point scan results and handling to FreeCAD.Vector() type throughout `Rotational` scan code.
Change properties group from `Rotational` to `Rotation`.
Make operation property details accessible through class.
Relocate Draft import to dependent function.
Improve property visibility in Data tab.
Issue warning for Rotational scans if faces are selected.
Compact setup() function.
LGTM cleanup throughout.
Delete unnecessary comments.
2020-04-16 00:17:05 -05:00
Russell Johnson
15e1fa7bb9 Path: Added missing tooltips and added new Cut Pattern options
Add `Spiral' option to Cut Pattern list
Add `Offset' option to Cut Pattern list
2020-04-16 00:14:11 -05:00
Russell Johnson
c6b9adec25 Path: GUI improvement - swap setEnabled() for show() and hide()
Improve GUI usability by using hide() and show().
Apply hide() and show() to labels as well.
Fix visibility update issue on loading task window for editing of existing operation.
2020-04-16 00:14:11 -05:00
wandererfan
98aaad5fb1 [TD]fix KB lockout in dialogs
- valueChanged signal is emitted for every keystroke
  causing multiple recomputes for every change of
  parameter.
2020-04-15 15:43:00 -04:00
sliptonic
8641e58c63 Merge pull request #3354 from etrombly/master
[Path] fix some typos in recent lazyloader implementation
2020-04-15 12:55:43 -05:00
Eric Trombly
070099daa4 fix some typos in recent lazyloader implementation 2020-04-15 12:32:48 -05:00
Yorik van Havre
97fbda9b47 Arch: Fixed bug in IFC export of furniture 2020-04-15 18:01:11 +02:00
sliptonic
1ff9c0899b Merge pull request #3330 from etrombly/lazyloader
[Path] Use lazyloader for deferred python imports
2020-04-15 10:22:28 -05:00
donovaly
232b701b36 fix a typo 2020-04-15 10:10:14 -04:00
donovaly
ac82f6ca4a give all preferences dialogs a clear name
The numbering was somewhat artificial.
2020-04-15 10:10:14 -04:00
donovaly
79f7986eb9 This commits splits the "General" dialog to "General" and "Colors". 2020-04-15 10:10:14 -04:00
donovaly
57328a136e [TD] split too long preferences dialogs
- as once discussed 2 of the dialogs are too long for smaller screens.

This commits splits the "Dimensions" dialog to "Dimensions" and "Annotation".
2020-04-15 10:10:14 -04:00
Bernd Hahnebach
f0061fadeb FEM: group meshing, fix retriving group elements in rare cases 2020-04-15 10:50:02 +02:00
Bernd Hahnebach
9dac36eec9 FEM: self weight object, set to not shown in property editor 2020-04-15 10:49:00 +02:00
wandererfan
2d29ac5fc1 [TD]Fix Detail dragger for ProjGroup 2020-04-14 17:42:11 -04:00
Abdullah Tahiri
7d9cfeb2c5 Sketcher: Fix trim
==================

https://forum.freecadweb.org/viewtopic.php?p=387303#p387303

1. Trim had a bug that the type of the constraint on the second point was equal to the first one regardless of the situation.

2. Trim did not have support for checking whether points were close to the edge and relied on preexisting constraints.
2020-04-14 19:00:51 +02:00
Yorik van Havre
a150f8a54f Arch: Fixed IFC4 export of surface styles 2020-04-14 17:56:18 +02:00
Yorik van Havre
659d573d31 Merge branch 'master' of github.com:FreeCAD/FreeCAD 2020-04-14 16:52:33 +02:00
Yorik van Havre
855fa1adc6 Arch: Support App::Parts in IFC export 2020-04-14 16:51:54 +02:00
wandererfan
4104a0e263 [TD]Use PropertyXLinkList for external Sources 2020-04-14 10:24:29 -04:00
Yorik van Havre
66c362a8b4 Draft: Fixed div by zero error in snapping 2020-04-14 16:01:29 +02:00
Yorik van Havre
3eff81df35 Arch: Fixed louvre width/spacing property 2020-04-14 15:49:36 +02:00
Yorik van Havre
97c8eff825 Draft: warn the user if offset direction is not set 2020-04-14 15:35:46 +02:00
wmayer
2c11e0f4cd TechDraw: [skip ci] fix -Winconsistent-missing-override 2020-04-14 12:57:07 +02:00
donovaly
940af87f69 [Arch] split IFC dialog 2020-04-14 11:37:36 +02:00
wmayer
d91bd53e10 Part: [skip ci] include missing header file 2020-04-14 09:37:45 +02:00
Eric Trombly
7fe094ac02 add lazyloader support
lazy_loader is copied to Ext now, modified external imports to lazy_load

add a few more imports to be lazy loaded, think the install path is correct now

[TD]"<" symbol embedded in html

revert changes to path modules for testing

use lazyloader in PathAreaOp.py

add back in deferred loading

temp change to print error message in tests

temp change to print error message in tests

add _init__.py to lazy_loader

make install in CMakeLists.txt one line
2020-04-13 21:14:34 -05:00
donovaly
9e57caf2ec [TD] sanitize Detail view dialog
- fix dialog layout (was broken for Windows) and simplify it
- enable so immediately the changes you make in the dialog -> necessary to fine-tune the right position
2020-04-13 16:15:37 -04:00
sliptonic
1f1043bf3c Merge pull request #3333 from fra589/master
[Path] Add size parameter for syntax highlighting of GCode editor
2020-04-13 08:48:18 -05:00
sliptonic
92aead8bcd Merge pull request #3336 from dubstar-04/chamferFixes
[PATH] Deburr Gui Fixes
2020-04-13 08:47:19 -05:00
sliptonic
143b713614 Merge pull request #3339 from realthunder/FixPathSort
Path: fix path sort
2020-04-13 08:46:31 -05:00
wandererfan
e537972ef9 [TD]GlobalPlacement for loose 2D objects 2020-04-13 09:43:21 -04:00
Sebastian Bachmann
c2a2effac2 Resolve SyntaxWarning literal comparison in py3.8
Comparison with literals should be done using != and == and not 'is
not' and 'is'.
Found the files using:
find . -name \*.py -exec pylint --disable=all --enable=R0123 --score=no {} \;

Python 3.8 prints out SyntaxWarnings when reading the files, this
would happen for example on every installation.
2020-04-13 11:40:16 +02:00
Jean-Marie Verdun
f692494ada Use "simpler" naming convention per user request 2020-04-13 11:39:14 +02:00
lorenz
8afb0379bd Draft: dwg-export: allow overwriting of files 2020-04-13 11:38:25 +02:00
vocx-fc
75623131fa Draft: new ShapeString icon for the tree view 2020-04-13 11:36:47 +02:00
Zheng, Lei
7dc60feab0 Path: fix path sort 2020-04-13 14:34:18 +08:00