Commit Graph

1436 Commits

Author SHA1 Message Date
Eric Trombly
6bb5873e3e add changes to Waterline 2020-04-06 06:34:53 -05:00
Eric Trombly
c8901cd5af clean up commented old code 2020-04-06 06:34:53 -05:00
Eric Trombly
7cc190fff0 remove debug profiling from surface 2020-04-06 06:34:53 -05:00
Eric Trombly
a0e45bffaa remove parallel processing, replace mesh generation with getting facets 2020-04-06 06:34:53 -05:00
Eric Trombly
144d3b62f3 changed some for loops to list comprehensions, added openmp for area to make two loops parallel, changed a fuse to a compound 2020-04-06 06:34:53 -05:00
Eric Trombly
f210d71f18 remove sleep calls, change some for loops to list comp, move isPointOnLine to base vector 2020-04-06 06:34:53 -05:00
sliptonic
23ae15edc2 Merge pull request #3132 from Schildkroet/deburr+dressup
[Path] Deburr+DressupLeadInOut fixes
2020-04-05 18:34:52 -05:00
Patrick F
7d3c7dfef0 Bugfix for circular hole base 2020-04-02 19:38:21 +02:00
luz.paz
1663fbb1cd [skip ci] Fix typos in Path WB
Found via 
```
codespell -q 3 -L aci,ake,aline,alle,alledges,alocation,als,ang,anid,ba,beginn,behaviour,bloaded,byteorder,calculater,cancelled,cancelling,cas,cascade,centimetre,childs,colour,colours,commen,connexion,currenty,dof,doubleclick,dum,eiter,elemente,ende,feld,finde,findf,freez,hist,iff,indicies,initialisation,initialise,initialised,initialises,initialisiert,ist,kilometre,lod,mantatory,methode,metres,millimetre,modell,nd,noe,normale,normaly,nto,numer,oder,orgin,orginx,orginy,ot,pard,pres,programm,que,recurrance,rougly,seperator,serie,sinc,strack,substraction,te,thist,thru,tread,uint,unter,vertexes,wallthickness,whitespaces -S ./.git,*.po,*.ts,./ChangeLog.txt,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/CXX,./src/zipios++,./src/Base/swig*,./src/Mod/Robot/App/kdl_cp,./src/Mod/Import/App/SCL,./src/WindowsInstaller,./src/Doc/FreeCAD.uml
```
2020-04-01 13:28:48 +02:00
Patrick Felixberger
58264bc7da Setup length depending on tool 2020-03-31 17:31:30 +02:00
Patrick Felixberger
b7702d5738 Merge branch 'master' of https://github.com/FreeCAD/FreeCAD into deburr+dressup 2020-03-31 17:18:06 +02:00
sliptonic
4a53aa1100 Merge pull request #3231 from Russ4262/4th_axis_fixes
[Path] 4th-axis rotational alignment improvements;  Code clean-up
2020-03-31 08:17:18 -05:00
Russell Johnson
75d4a66ca1 Path: Synchronize tooltips. Apply DepthOffset. Hide properties.
Sync tooltip text between 3D Surface and Waterline.
Also, apply `DepthOffset` to Experimental Waterline algorithm.
Hide some properties in Data tab.
2020-03-30 23:24:47 -05:00
Russell Johnson
d1e77e2a90 Path: Implement experimental Waterline algorithm
Insert experimental Waterline algorithm that is non-OCL based.  It slices by step-down value, not stepover.
2020-03-30 22:34:57 -05:00
Russell Johnson
e7b328c6cf Path: Fix bug that fails Multi-pass usage 2020-03-30 22:34:57 -05:00
Russell Johnson
732163978d Path: Fix "increase by factor of 10" issue
Forum discussion at https://forum.freecadweb.org/viewtopic.php?style=3&f=15&t=44486.
2020-03-30 22:34:57 -05:00
Russell Johnson
458a6a2244 Path: Four bug fixes per forum discussion
Fix grammar mistake.
Fix Gcode comment formatting.
Fix application of `Optimize Step Over Transitions` by adjusting the offset tolerance for creating the offset cut area for the operation.
Fix math error in circular based cut patterns for small diameter cutters.
Identification of bugs begins in the forum at https://forum.freecadweb.org/viewtopic.php?style=3&f=15&t=41997&start=210.
Path: Lower SampleInterval minimum to 0.0001mm
2020-03-30 22:34:57 -05:00
Russell Johnson
c89bec0847 Path: Add Cut Pattern selection to task panel 2020-03-30 22:34:57 -05:00
Russell Johnson
4f58bbf7a2 Path: Add initPage() call to update GUI upon loading
Added initPage() function call updates task panel values and visibilities when user edits an existing operation.
2020-03-30 22:34:57 -05:00
Russell Johnson
e6dffe4f62 Path: Update GUI inputs for independent Waterline operation 2020-03-30 22:34:57 -05:00
Russell Johnson
270d02cec3 Path: Add ScanType and LayerMode inputs
Added combo boxes with labels
Path: Remove 'Algorithm' property usage.


Path: Connect `ScanType` and `LayerMode' selections from task panel


Path: Update GUI inputs for independent 3D Surface operation
2020-03-30 22:34:57 -05:00
Russell Johnson
186a98a8e2 Path: Restructure initOperation() for backward compatibility
Added initOpProperties() to handle independent creation of properties for backward compatibility and to allow for future storage of enumeration property lists within the operation.
Path: Change from PathSurface code to `Waterline`


Path: Updates and fixes


Path: Simplify code

Remove `Algorithm` and `AreaParams` property usage.
Remove other unused properties.
Simplify setupEditorProperties().
Path: Remove unused methods


Path: Update property initialization and handling

Make properties backward compatible with previous versions of the operation.
Remove references to unused properties due to 3D Surface and Waterline separation.
Path: Insert placeholder for `Experimental` algorithm


Path: Fix missing property and fix syntax

Missing `Algrorithm
2020-03-30 22:34:57 -05:00
Russell Johnson
796a908158 Path: Add Waterline task panel
Path: Update `Waterline` task panel and GUI code
2020-03-30 22:34:57 -05:00
Russell Johnson
2fdf3cd3f3 Path: Add commented references for missing imported modules
PathSurfaceGui and PathWaterlineGui are imported in the initGui.py module due to OCL dependency.
2020-03-30 22:34:57 -05:00
Russell Johnson
1281252c7d Path: Add Waterline selection gate
Using the same gate as PathSurface
2020-03-30 22:34:57 -05:00
Russell Johnson
31e4584142 Path: Add Waterline modules to PathScripts 2020-03-30 22:34:57 -05:00
sliptonic
443118e75b Merge pull request #3290 from fra589/master
[Path] fix tool change and Feature missing output
2020-03-30 22:18:07 -05:00
sliptonic
57352acc9b Merge pull request #3266 from Russ4262/Fix_ProfileEdges_Open-Edges
[Path] Fix failed open edge path for zero GeometryTolerance case
2020-03-30 22:17:03 -05:00
Gauthier
21c377f554 [Path] fix tool change and Feature missing output 2020-03-30 20:01:47 +02:00
sliptonic
6109e4d992 fix error when discretize N=1
cleanup
InitGui to add Path_Probe command
Probe setupsheet
2020-03-26 15:23:23 -05:00
sliptonic
faa4bfb484 discretizing 2020-03-26 13:26:05 -05:00
sliptonic
3f89ecc131 Path: adding dressup task panel 2020-03-26 13:26:05 -05:00
sliptonic
65fcda7daa Path: Finish GUI & Cleanup 2020-03-26 13:26:05 -05:00
sliptonic
61908e5cc7 Path: make setupsheet handle PropertyFile 2020-03-26 13:26:05 -05:00
sliptonic
dc7032542b Path: Layout op panel for probe 2020-03-26 13:26:05 -05:00
sliptonic
6e2fd950a0 Path: Z depth correction from probe data 2020-03-26 13:26:05 -05:00
Russell Johnson
b05361a163 Path: Apply rotation improvement to B(y) rotations 2020-03-26 10:43:32 -05:00
Russell Johnson
988038c5d2 Path: Remove unnecessary comments
PathAreaOp
PathProfileFaces
2020-03-26 10:43:32 -05:00
Russell Johnson
8e3a72b6a8 Path: Improve rotational transitions between operations
Check previous and next operations for rotation, and eliminate rotational reset if can be done.
2020-03-26 10:43:32 -05:00
Russell Johnson
4145e287c0 Path: Improve 4th-axis rotation analysis and application
Fix incorrect depth calculations for envelopes.
Added solid-based model orientation check developed in PathProfileEdges open edges upgrade.
Clean-up some blank indentations.
Down-grade some messaging levels.
Add a few debug comments.
2020-03-26 10:43:32 -05:00
Russell Johnson
1a66c8a1dd Path: Deleting blank indents 2020-03-26 10:43:32 -05:00
Russell Johnson
ac2aafbd52 Path: Fix failed open edge path for zero GeometryTolerance case
Add error message to inform user to set Job.GeometryTolerance to an acceptable value.
Remove creation of docObject in lieu of geometry shape usage.
2020-03-26 10:29:00 -05:00
sliptonic
d51e1126f2 Merge pull request #3245 from Schildkroet/4th-axis-improve
[Path] Added 4th axis support to drilling GUI
2020-03-24 14:24:54 -05:00
luz.paz
65f6347953 [skip ci] Fix typos
Found via 
```
codespell -q 3 -L aci,ake,aline,alle,alledges,alocation,als,ang,anid,ba,beginn,behaviour,bloaded,byteorder,calculater,cancelled,cancelling,cas,cascade,centimetre,childs,colour,colours,commen,connexion,currenty,dof,doubleclick,dum,eiter,elemente,ende,feld,finde,findf,freez,hist,iff,indicies,initialisation,initialise,initialised,initialises,initialisiert,ist,kilometre,lod,mantatory,methode,metres,millimetre,modell,nd,noe,normale,normaly,nto,numer,oder,orgin,orginx,orginy,ot,pard,pres,programm,que,recurrance,rougly,seperator,serie,sinc,strack,substraction,te,thist,thru,tread,uint,unter,vertexes,wallthickness,whitespaces -S ./.git,*.po,*.ts,./ChangeLog.txt,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/CXX,./src/zipios++,./src/Base/swig*,./src/Mod/Robot/App/kdl_cp,./src/Mod/Import/App/SCL,./src/WindowsInstaller,./src/Doc/FreeCAD.uml
```
2020-03-24 11:14:24 +01:00
Patrick Felixberger
37a44c08c3 Added 4th axis support to drilling GUI 2020-03-23 00:48:09 +01:00
Eric Trombly
0102ed64b5 Change example_pre to use a list of commands instead of one string 2020-03-22 17:59:16 -05:00
Patrick Felixberger
f3f21709e3 Merge branch 'master' of https://github.com/FreeCAD/FreeCAD into deburr+dressup 2020-03-22 23:53:08 +01:00
Eric Trombly
d68a5c687b split paths on M6 and change placement to use offset 2020-03-22 12:15:57 -05:00
Eric Trombly
22bf3a83ec split paths on M6 and change placement to use offset 2020-03-22 12:10:11 -05:00
Eric Trombly
3f47c20d14 split paths on M6 and change placement to use offset 2020-03-22 12:06:36 -05:00