Commit Graph

19 Commits

Author SHA1 Message Date
donovaly
d1071026e7 [PD] fix blind hole depth handling
as reported in https://tracker.freecadweb.org/view.php?id=3818
we treat the blind hole depth not according to the conventions. The size of the drill point due to the angle is normally not taken into account but FC does this in any case.

This PR adds therefore an option, that is by default off, to take the drill point size into account.
Without the option, (the new default) the depth is calculated according to the conventions.

The PR also removes unused widgets and restored the tab order in the .ui file. The thread parameters were never used. In case we made in future the decision to carve into holes real (modeled) threads, we need a special UI for that solution anyway so having the dead code in is not helpful at all.
2021-01-25 01:10:23 +01:00
lorenz
cbea54d00c partdesign: fix failing tapered hole test
The given parameters return an invalid shape. This fails with occt7.4 but doesn't with occt7.3. If the angle is 45 degree the cone is self-intersecting as Hole.Depth > Hole.Diameter/2. Changing the Hole.TaperedAngle to 60 degree solves this issue.
2020-05-03 17:49:13 +02:00
luz.paz
dc8bf3dc39 PartDesign: [skip ci] fix header uniformity
This PR fixes header uniformity across all PartDesign WB files
2019-12-22 00:58:38 +01:00
Zheng, Lei
de93446a1c Test cases changes
Slight adjustment of various test cases due to various API changes.
2019-08-17 15:32:48 +02:00
wandererfan
29352e07b3 Fix PD Pocket Through All Unit Test
- test for Pocket Through All case
  generated a multi-solid solution.
  Now returns single solid.
2018-07-13 10:23:42 -03:00
Peter Lama
033334474c Rename superPlacement property to AttachmentOffset
The name Attachment Offset gives a better picture of what the
property does.
2017-11-05 16:41:25 +01:00
Stefan Tröger
700741471f Make Origins work well with scoped links 2017-09-09 16:55:55 +02:00
Stefan Tröger
febfed3c6c PartDesign: Fix multi pattern test 2017-09-09 16:55:55 +02:00
Stefan Tröger
8841fb0805 Make PartDesign::Boolean work with new Link structure
This is the first feature that used GeoFeatureGroupExtension and required links to the groups inside as well as to things on the same level. Hence a few modifications to link scopes have been nesseccary.
2017-09-09 16:55:55 +02:00
Kurt Kremitzki
f67c3c502f PDN: Add several Hole tests 2017-08-30 10:41:55 -03:00
Kurt Kremitzki
0639b7f113 PDN: Add simple hole test 2017-08-30 10:41:55 -03:00
Kurt Kremitzki
81f21518b3 PDN: Update ellipsoid primitive test for OCC < 7 2017-07-26 23:16:12 +02:00
Kurt Kremitzki
b5682d92ed PDN: Add tests for Boolean, MultiTransform, Primitives, Shapebinder 2017-07-26 23:16:12 +02:00
Kurt Kremitzki
9b60b07eb4 Add missing assertions for PartDesign Datum tests 2017-07-11 06:23:25 -05:00
Kurt Kremitzki
90bfae234d Revise PartDesign Draft base test approach 2017-07-11 06:22:52 -05:00
Kurt Kremitzki
8f6b79e37c Add linear and polar pattern tests 2017-07-11 02:27:38 -05:00
Kurt Kremitzki
ba3c4a4bbe Flesh out basic dressup feature tests 2017-07-11 02:27:38 -05:00
Kurt Kremitzki
6c00984f5f Add dressup feature test structure 2017-07-11 02:27:38 -05:00
Kurt Kremitzki
a09e3a8cfd Break out PartDesign tests into own folder 2017-07-11 02:27:38 -05:00