Commit Graph

42 Commits

Author SHA1 Message Date
Russell Johnson
03cce806f3 Path: Remove first-draft rotational code Path
Remove all first-draft rotational-related code from Path workbench to make way for more stable, long-term integration of a rotational indexing capability.
2021-05-27 10:04:31 -05:00
luz paz
60c055e62d Path: Fix header uniformity and remove trailing whitespace
This PR fixes header uniformity across all Path files. It also removes all trailing whitespace.
2020-11-05 19:57:21 +01:00
Markus Lampert
f0602457d7 Fixed PathHelix assert statements 2019-08-22 18:02:49 +02:00
Markus Lampert
cadea61e0b Make Helix op robust against features that don't exist anymore 2019-07-14 21:30:38 -07:00
Russell Johnson
90f31d9023 PathHelix: Add simple x,y path sorting
Same PathUtils.sort_jobs() method copied from PathDrilling
Change feedback comment to debug category
2019-07-12 10:05:18 -05:00
Russell Johnson
9038e63f6c Add new property to SetupProperties()
StartRadius property addedd
2019-07-03 19:52:02 -05:00
sliptonic
c0449c7945 Path: add helix start radius 2019-07-03 19:21:41 -05:00
Russell Johnson
c656fec63c Fix EnableRotation property
PathCircularHoleBase uses `EnableRotation` property
2019-07-03 11:45:53 -05:00
sliptonic
c8e945a3ab Path: normalize proxy stratements
remove bare exceptions
2019-06-21 13:01:01 -05:00
luz.paz
5103002df9 Crowdin: continuing translation string refinements/fixes 2019-03-22 10:44:14 -03:00
Markus Lampert
bf04fa29de Operation settings support for Helix op. 2018-09-02 00:32:22 -07:00
Markus Lampert
353ec4a646 Added name parameter to operation proxy constructor. 2018-09-02 00:32:22 -07:00
Markus Lampert
9cd8ac46f7 Add job as parameter to opSetDefaultValues 2018-09-02 00:32:22 -07:00
Markus Lampert
fe58ef2466 Fixed import statement for py3 2018-03-17 14:09:15 +01:00
Markus Lampert
c38eee06e2 Abort OP creation transaction if TC selection is aborted with cancel, #3274 2017-11-28 12:39:02 -02:00
pekkaroi
57c7626aee Path: Allow removing of all base objects in Circular hole tools 2017-11-21 17:19:57 -03:00
Markus Lampert
6bbd0cf288 Fixed PathHelix to not throw an exception if StartDepth == FinalDepth. 2017-09-21 11:32:32 -07:00
Markus Lampert
684b4f6e7e Added doc strings to operations. 2017-08-22 10:16:58 -03:00
Markus Lampert
9225bae90d Cleaning up some unused functions. 2017-08-22 10:16:58 -03:00
Markus Lampert
b6c31bedab Rebased Helix op on PathOp framework, also it's UI. 2017-08-22 10:16:58 -03:00
sliptonic
4743a7f73b Path: Change Profile 'side' enumeration to inside/outside
left/right was too ambiguous
correct profile direction set
2017-07-10 19:17:41 -03:00
Markus Lampert
af699ab7e2 Replaced default context argument with explicit call for pylupdate to pick up the strings and contexts. 2017-06-03 15:37:41 -07:00
Sabin Iacob
4778d59bfa Path: add zmax to the job weight so we drill the holes that are closer to the surface first 2017-05-27 19:52:21 -03:00
Pekka Roivainen
deeb196578 Path: PathDrilling updates
-Log Level to INFO
-PEP8 formatting
-move sort_jobs to PathUtils
2017-05-10 22:57:14 +02:00
Sabin Iacob
fa1a5c486d [path] Remove duplicate first drill job in PathHelix 2017-05-02 07:10:00 +03:00
Sabin Iacob
7534a2686f [path] Make PathHelix use the new tool controllers 2017-04-30 10:05:18 +02:00
Sabin Iacob
fc9f7510d4 [path] Sort helix drill jobs to improve efficiency 2017-04-29 11:06:41 +03:00
Lorenz Hüdepohl
7dc026ec58 PathHelix: Fix locale issue for Gui::InputField setText() method 2017-02-17 20:55:37 +01:00
Lorenz Hüdepohl
1875c52f13 PathHelix: Be more liberal in what constitues a straight cylinder 2017-02-17 20:55:17 +01:00
Lorenz Hüdepohl
f59c234c59 PathHelix: Switch to QToolBox based task panel
This makes it more consistent with the other Path operations
2017-01-14 17:04:36 +01:00
Lorenz Hüdepohl
3e9d01a143 PathHelix: fix most of the PEP8 issues
Dealt with most issues expect for overly long lines
2017-01-06 15:50:21 +01:00
Lorenz Hüdepohl
f344a1a5ce PathHelix: typo in error path 2017-01-06 15:14:04 +01:00
Lorenz Hüdepohl
f031615492 PathHelix: Drop requirement of scipy.spatial
It was deemed that scipy is too heavy a requirement for FreeCAD just for
this little feature. Fortunately it was possible to extract the k-d tree
module from scipy with just minor modifications - it is quite
self-contained.

Now, only numpy is required.
2017-01-06 13:20:18 +01:00
Lorenz Hüdepohl
6fec950cb2 Path: Helix taskpanel shows interdependencies of holes
Instead of a flat list of holes now a tree is shown, with the various
machining operations for the individual holes grouped together.
2017-01-04 20:11:49 +01:00
Lorenz Hüdepohl
510398c845 Path: Fix GUI race condition in helix task panel checkboxes 2016-12-31 00:02:22 +01:00
Lorenz Hüdepohl
5323eba2e5 Rebase onto current master 2016-12-30 22:47:47 +01:00
Lorenz Hüdepohl
0ca5b14b8d PathHelix: Add GUI list with selected features 2016-12-30 22:47:47 +01:00
Lorenz Hüdepohl
a45204c335 PathHelix: "Cancel" and some logic in task panel
- "Cancel" now restores the original values as it should.
- The various mutually exclusive uses of UseStartDepth, UseFinalDepth
  and ThroughDepth are now reflected in the GUI by grayed-out components
2016-12-30 22:47:47 +01:00
Lorenz Hüdepohl
423c2a3f78 PathHelix: Fixes for clearance, non-aligned centers
The safe Z value was calculated with respect to the current hole, but
the tool should better be always retracted to the safe Z value with
respect to the first hole of a series of holes.

Another fix concerns the detection of holes-within-holes, previously it
was assumed that there the centers must align perfectly, this seems to
be the case only up to some numerical precision. Fixed by just allowing
any hole that is wholly contained in the first hole, even it is not
centered.
2016-12-30 22:47:47 +01:00
Lorenz Hüdepohl
fcc6997b0f PathHelix: Fix StartDepth and FinalDepth for recursive holes
These were previously only applied for the first and last operation,
respectively. Now whole operations can be skipped if they are completely
outside the specified range.
2016-12-30 22:47:47 +01:00
Lorenz Hüdepohl
7f383e5758 A TaskPanel for PathHelix 2016-12-30 22:47:46 +01:00
Lorenz Hüdepohl
a97cfcb2cf HelixCut: A new Path command to make circular holes 2016-12-30 22:47:46 +01:00