Commit Graph

1186 Commits

Author SHA1 Message Date
Markus Lampert
a049b031f7 Cleaned up warnings for PathEngraveBase 2019-07-01 15:29:51 -07:00
Markus Lampert
e3ce356e4f Fixed pylint warnings for PathDressupDogbone 2019-07-01 15:29:51 -07:00
Markus Lampert
1220b49308 Fixed pylint warnings for PathDressupTag 2019-07-01 15:29:51 -07:00
Markus Lampert
56f2eadbef Fixed pylint warnings for PathSetupSheet 2019-07-01 15:29:51 -07:00
Markus Lampert
a3d2da12f0 Some more pylint warning cleanup 2019-07-01 15:29:51 -07:00
Markus Lampert
4bfd06140b fixed pylint warning for PathOp 2019-07-01 15:29:51 -07:00
Markus Lampert
f4bee893d7 fixed pylint warning for PathJob 2019-07-01 15:29:51 -07:00
sliptonic
334a731f47 path: LGTM cleanup post processors 2019-07-01 17:18:15 -05:00
sliptonic
463c195835 Path: lgtm cleanup PathAreaOp 2019-07-01 17:18:15 -05:00
Russell Johnson
6ce105f7ee 4th-axis update (#2311)
Improve property creation
Improve property setup
Implement PathLog.debug() for troubleshooting.
Improve default property values.
Remove unused and incomplete method
Remove unnecessary comments; fix final depth issue
4th-axis improvements
rotation method improvements
remove extra comment blocks
fix incorrect variable references
fix -0.0 re-introduction after initial filter
negative zero re-introduced causes problems with naming method for temp clones
Update faceRotationAnalaysis() method
update opFeatures()
Commented out call to PathOp.FeatureRotation
This feature not yet implemented.
delete call to removed method - self.reportThis()
Remove unnecessary comments
2019-07-01 09:30:58 -05:00
sliptonic
c0e0a9c8f4 Merge pull request #2303 from Russ4262/path_3d_pocket_upgrade
[Path] 3D Pocket: Upgrade to collective face processing!
2019-06-30 18:54:30 -05:00
Russell Johnson
c6efd007f0 PathDrilling 4th-axis integration
Initial integration of 4th-axis functionality to the Drilling op in PathWB
2019-06-30 14:14:38 -05:00
Russell Johnson
e2d04ec991 3D Pocket: Upgrade to collective face processing!
New property added: `HandleMultipleFeatures`.
New property and related code allows for improved, and expected, 3D Pocket operations.
Improvement combines faces selected to create one envelope to be processed as the path shape ('collectively' setting).
Old behavior is available with 'Individually' setting.
Enjoy!
2019-06-30 14:06:37 -05:00
sliptonic
e3ec9ae003 Merge branch 'master' into bugfix/pocket-shape-extensions 2019-06-30 09:32:07 -05:00
Russell Johnson
dd6a6597e9 ProfileFaces: Fix obj.processPerimeter feature (#2306)
https://forum.freecadweb.org/viewtopic.php?f=15&t=37368
if obj.processPerimeter: `else` block re-configured to read new property, `HandleMultipleFeatures`
Removed some excess comments
2019-06-30 09:31:30 -05:00
Markus Lampert
cd2de45af3 Properly deal with deleted objects when cleaning up the extension visualisation. 2019-06-29 19:16:33 -07:00
Markus Lampert
c4e0e8dafc Cover entire hole if pockeet extension is bigger than hole. 2019-06-29 18:16:56 -07:00
Markus Lampert
a162afc95a Fixed extensions for round holes. 2019-06-29 18:16:56 -07:00
Markus Lampert
c4cf901c60 Removed redundant log message 2019-06-29 18:16:56 -07:00
Markus Lampert
d50ce02c7d Fixed extension selection 2019-06-29 18:16:56 -07:00
Markus Lampert
9fffbb0e05 Fixed document restoration logic. 2019-06-29 18:16:56 -07:00
luz.paz
94cfe2d130 Misc. typo and whitespace fixes
Found via `codespell`
2019-06-28 11:39:36 -03:00
sliptonic
617c619d2f remove unnecessary imports. normalize debug log levels 2019-06-21 13:01:01 -05:00
sliptonic
c8e945a3ab Path: normalize proxy stratements
remove bare exceptions
2019-06-21 13:01:01 -05:00
Russell Johnson
d6df552ff0 Fixes bug #4008: removes phantom path cause
Job object was base of transformations, rather than Job base(clone).
2019-06-20 00:02:14 -05:00
Russell Johnson
37336d5701 Fix functionality of manual override of Final Depth
manual Final Depth settings were limited to values greater than the base face for the Op. Manual settings of Final Depth may now proceed below the face (Outside profile ops)
2019-06-20 00:02:14 -05:00
Russell Johnson
e1d3160c50 proxy to obj.Proxy partial conversion 2019-06-20 00:02:13 -05:00
sliptonic
2f456424cd Path: fix proxy error 2019-06-19 10:21:17 -05:00
sliptonic
082c1e71f1 Path: PEP8 and Proxy changes. 2019-06-17 09:17:38 -05:00
Russell Johnson
161a7865b5 Merge branch 'master' into pathpocketshape_fix 2019-06-16 16:38:09 -05:00
luz.paz
9845c002ab Misc. source comment typo and whitespace fixes
Found via codespell
2019-06-16 20:47:07 +02:00
Russell Johnson
0030a17241 Delete disabled code blocks
within guiMessage() method
2019-06-15 12:19:17 -05:00
Russell Johnson
babc848af7 added missing self.stockBB instantiation
job boundbox object was missing in opSetDefaultValues()
2019-06-15 12:05:58 -05:00
Russell Johnson
58e41ea5fd Isolate FreeCADGui dependency
Thanks @mlampert and @sliptonic for assisting in tracking down the error via unit test analysis.
FreeCADGui usage has to be behind an 'if FreeCAD.GuiUp:` test
2019-06-13 15:42:56 -05:00
Russell Johnson
c79beacfc0 Remove unnecessary comment 2019-06-13 12:34:33 -05:00
Russell Johnson
183228cc25 Misc. fixes
Clean up code, improve comments, improve user feedback.
Improve temp clone management.
Correct depth issue with self.finDep
Add comment descriptions for new methods
Clean up comments and contribution information
Initiate recognition of type()==SurfaceOfExtrusion
Adopt standard PathGeom.isRoughly() and .Tolerance rather than idependent precision settings
2019-06-13 10:55:32 -05:00
Russell Johnson
73e00617d1 Fixes for depths and AttemptInverseAngle
Depth correction to obj.FinalDepth.Value in single feature operations
Fix AttemptInverseAngle to be uni-directional
Clean up debug and other user provided feedback
2019-06-13 10:55:31 -05:00
Russell Johnson
33008fbb17 Handle FreeCADGui module with IF: case 2019-06-13 10:55:31 -05:00
Russell Johnson
a7202f151f Improve code structure; correct 4th-axis depth issues 2019-06-13 10:55:30 -05:00
Russell Johnson
1f3b3ad4e4 Integration of 4th-axis feature to PathProfileFaces
4th-axis integration should not affect current feature set
2019-06-13 10:55:29 -05:00
Russell Johnson
5bbb59501a Fix for 'reposition of job model' error
Re-structured 4th-axis implementation, completely; new structure will be easier to implement in other PathWB tools.
Changed basis for rotational pockets from job model to temporary per-rotation clones.
2019-06-13 10:55:28 -05:00
Russell Johnson
8aa27693c9 Improve 4th-axis integration
Improvements to 4th-axis readiness for other PathAreaOp based tools in PathWB.
Add guiMessage() method for rendering GUI messages to user.
2019-06-13 10:55:27 -05:00
Gauthier Brière
9bd10a3e0d [Path] Replace old grbl_post.py with new grbl_G81_post.py. (#2255)
* Replace the old grbl_post.py by grbl_G81_post.py

* Cleaned grbl_G81_post.py replacing old grbl_post.py
2019-06-13 09:14:17 -05:00
sliptonic
7d7fdbebdf Merge pull request #2251 from realthunder/PathFix
Path: handle PathAreaOp object migration
2019-06-10 16:44:11 -05:00
sliptonic
8ceb2aedd9 Merge pull request #2245 from sliptonic/lgtm
Path: lgtm Cleanup
2019-06-10 16:43:38 -05:00
Markus Lampert
13c76d412b More TC ui import cleanup 2019-06-10 23:21:52 +02:00
brad
33b6e25582 Path: remove unnecessary imports 2019-06-10 10:50:06 -05:00
brad
5a4c49da28 Path: post processor cleanup 2019-06-10 10:50:06 -05:00
brad
361bb6e3c8 Path: remove obsolete code 2019-06-10 10:50:06 -05:00
brad
8e372108b5 Path: lgtm Cleanup 2019-06-10 10:50:06 -05:00