Commit Graph

2115 Commits

Author SHA1 Message Date
Russell Johnson
6f4f24c299 Path: Fix ZigZag pattern; Remove some comments
ZigZag pointset is no longer a tuple to unpack.  Grouped it with Line and Spiral.
2020-04-24 22:36:50 -05:00
Eric Trombly
be01153ea7 remove retraction to clearance height for intra-operation travels 2020-04-24 22:32:27 -05:00
Eric Trombly
745945d2cb fix detect of 0,0 start point 2020-04-24 20:05:39 -05:00
Eric Trombly
c10eed7eb0 pass endVectorin PathAreaOp and clean up gcode generation 2020-04-24 20:05:39 -05:00
sliptonic
c9f6a4272c Merge pull request #3362 from dubstar-04/deburrFix
[Path] - Hide the join type on the deburr form.
2020-04-24 12:36:43 -05:00
sliptonic
d8c23e4894 Merge pull request #3386 from dubstar-04/fixes/cycleTimeEstimation
[Path] - fixes/cycle time estimation
2020-04-23 22:34:12 -05:00
sliptonic
f71425ec5a Merge pull request #3368 from spontarelliam/path-link-stock-model
Path: movement of stock and model when setting origin
2020-04-23 22:33:44 -05:00
Adam Spontarelli
d355e3a946 change from radio button to checkbox per feedback 2020-04-23 19:37:12 -04:00
Daniel Wood
e4dacf571b Display 00:00:00 when the cycle time is 0 seconds 2020-04-23 18:07:32 +01:00
Daniel Wood
7153c3d836 ensure the getCycleTime function returns a value 2020-04-23 16:43:00 +01:00
sliptonic
b9af7a1fb2 Merge pull request #3363 from dubstar-04/CoolantTidy
[Path] - Remove Duplicate Signal
2020-04-22 18:09:01 -05:00
Daniel Wood
233d760b6b remove debug print 2020-04-22 19:36:24 +01:00
Daniel Wood
638de03c1f Add CycleTime Attribute to PathJob 2020-04-22 19:12:14 +01:00
Daniel Wood
37ed81d070 Add cycleTime Attribute to PathOp 2020-04-22 19:10:18 +01:00
Daniel Wood
87ce2ec4d4 Add getCycleTime method to Path::ToolPath 2020-04-22 19:08:09 +01:00
sliptonic
4a37aaafa4 Merge pull request #3373 from agren/feature/improve-path-multi-select
[Path] Allow copy and toggle of multiple operations at once
2020-04-22 10:41:58 -05:00
Mikael Ågren
df177ee4ee Copy all path operations in selection
Changes "Copy operation in the job" from only being able to copy one
operation. To copy all operations in a selection.
The copy command will only be enabled if all selected objects are
copyable.
2020-04-20 22:12:40 +02:00
Mikael Ågren
6b48dfa3e8 Toggle active state of all path operations in selection
Changes "Toggle the Active State of the Operation" from only being
able to toggle one operation. To toggle all operations in a selection.
The toggle command will only be enabled if all selected objects can
be toggled.
2020-04-20 22:10:27 +02:00
Eric Trombly
d8cb1d49ed remove hard coded locale from path ui 2020-04-19 20:49:50 -05:00
Adam Spontarelli
dd264df20c Added radio button that links the movement of stock and model when using the set x, y, or z to 0 in Path workbench 2020-04-19 09:00:30 -04:00
Daniel Wood
1f00f7b438 remove duplicate signal 2020-04-18 12:43:39 +01:00
Daniel Wood
3910cbb993 Hide the join type. 2020-04-18 12:17:14 +01:00
Daniel Wood
14f7239926 don't hide the join type 2020-04-18 12:03:57 +01:00
sliptonic
49ba5bef1f Merge pull request #3327 from Russ4262/3D_Surface_updates
[Path] 3D Surface fixes(7), minor optimizations, and cleanup
2020-04-17 10:40:53 -05:00
sliptonic
2e1796cbb5 Merge pull request #3331 from Russ4262/Waterline_updates
[Path] Waterline fixes(5), new IgnoreOuterAbove feature, and code simplification
2020-04-17 10:40:15 -05:00
Russell Johnson
9642271335 Path: Optimization for open edges update
Remove required usage of DocObject creation, in lieu of Part geometry usage - the preferred method.
Limit DocObject creation to debugging mode only.
Remove dependency on Draft module.
Drawback is top edge must be selected, and Final Depth set appropriately when using profiling open edges.
2020-04-16 12:53:32 -05:00
Russell Johnson
c3dcf94ffd Path: Move more common methods to PathSurfaceSupport module 2020-04-16 00:35:05 -05:00
Russell Johnson
0bfea7429b Path: Add new support module for 3D Surface and Waterline 2020-04-16 00:28:33 -05:00
Russell Johnson
fa13068220 Path: Comment cleanup; adjust messages; set 2 default values 2020-04-16 00:28:33 -05:00
Russell Johnson
ba88e0eef2 Path: Implement new module PathSurfaceSupport; Add Spiral cut pattern
New module is shared with 3D Surface operation. Module contains PathGeometryGenerator class. More common methods can be moved into the new module.
2020-04-16 00:28:25 -05:00
Russell Johnson
ce42444afa Path: Preparation for making property defaults readable through class 2020-04-16 00:28:18 -05:00
Russell Johnson
2fc634a22a Path: Improve backwards compatibility capabilities 2020-04-16 00:28:11 -05:00
Russell Johnson
ea960770af Path: Improve property visibility in Data tab 2020-04-16 00:28:04 -05:00
Russell Johnson
873b9c0f6f Path: Expose operation's property details to access via class 2020-04-16 00:27:58 -05:00
Russell Johnson
996d4710f5 Path: Fix weakness in face analysis for unique OuterWire cases
synced with PathSurface module
2020-04-16 00:27:49 -05:00
Russell Johnson
18e6fa2127 Path: Add missing tooltips 2020-04-16 00:27:40 -05:00
Russell Johnson
04093c3d76 Path: Waterline fixes(5), new IgnoreOuterAbove, and code simplification
Fix module base for getFacets()
Fix isOnLineSegment() usage.
Fix property visibility in Data tab.
Fix missing raise to SafeHeight after clearing layer.
Fix handling of `import ocl` failure
Move Draft import to dependent function
Raise `import ocl` test in code execution
Disable face selection for Waterline and issue warning as intermediate fix. Application of face-selection from 3D Surface requires some modification for use in Waterline.  This work is to be done.  Some existing carryover methods should be usable in current form.
Compact setup() function
Sync some methods with PathSurface in preparation of extracting common methods to independent support module.
Increase SampleInterval range for OCL Dropcutter algorithm.
Convert OCL Dropcutter waterline to use FreeCAD.Vector() points rather than ocl.Point().
Simplify some code and delete unnecessary comments.
LGTM cleanup.
New feature - IgnoreOuterAbove. Ignore the outer-most waterline above this height.  Designed to eliminate the model profile path created in some use cases.
Adjust tooltip language for `Algorithm`
2020-04-16 00:27:40 -05:00
Russell Johnson
1c268425a4 Path: Improve Tasks editor interaction
Swap setEnabled() method for show() and hide().
Include showing and hiding associated labels.
Path: Hide `optimizeEnabled` input
2020-04-16 00:27:06 -05:00
Russell Johnson
29b5c39924 Path: Move more common methods to PathSurfaceSupport module 2020-04-16 00:20:46 -05:00
Russell Johnson
5d5a21e5a7 Path: Simplify if ... is True: statements. 2020-04-16 00:17:47 -05:00
Russell Johnson
e23aecc667 Path: New class - PathGeometryGenerator; new CutPattern - Offset
Converted _planarMakePathGeom() into independent class, PathGeometryGenerator, as preparation to share common code with Waterline.
Implementation of new class within existing code.
Added new cut pattern: Offset.  It is ported from Waterline.
2020-04-16 00:17:40 -05:00
Russell Johnson
5701e90cc8 Path: Create shared support module for 3D Surface and Waterline 2020-04-16 00:17:33 -05:00
Russell Johnson
b0a73d1266 Path: Improve compatibility between file versions
Verify enumerations on document reload, maintaining the existing value for the property.
2020-04-16 00:17:33 -05:00
Russell Johnson
8e58f10f7f Path: Fix weakness in face analysis for unique OuterWire cases 2020-04-16 00:17:24 -05:00
Russell Johnson
75ad65ecf1 Path: Added Spiral cut pattern; Adjusted tooltip language 2020-04-16 00:17:16 -05:00
Russell Johnson
c8ece0c437 Path: Multiple fixes; code optimizations and cleanup
Fix _processRotationalOp() arguments and erroneous call thereto.
Fix isOnLineSegment() usage.
Fix transition between profile edge and clearing.
Fix _planarSinglepassProcess() method.
Fix `ProfileEdges` feature.
Fix Y-axis rotation error in G-code and display.
Fix error handling of `import ocl` test.
Raise `import ocl` test in code sequence.
Convert ocl.Point scan results and handling to FreeCAD.Vector() type throughout `Rotational` scan code.
Change properties group from `Rotational` to `Rotation`.
Make operation property details accessible through class.
Relocate Draft import to dependent function.
Improve property visibility in Data tab.
Issue warning for Rotational scans if faces are selected.
Compact setup() function.
LGTM cleanup throughout.
Delete unnecessary comments.
2020-04-16 00:17:05 -05:00
Russell Johnson
a10ec71135 Path: Added missing tooltips and added new Cut Pattern options
Add `Spiral' option to Cut Pattern list
Add `Offset' option to Cut Pattern list
2020-04-16 00:14:11 -05:00
Russell Johnson
d10ad95484 Path: GUI improvement - swap setEnabled() for show() and hide()
Improve GUI usability by using hide() and show().
Apply hide() and show() to labels as well.
Fix visibility update issue on loading task window for editing of existing operation.
2020-04-16 00:14:11 -05:00
Eric Trombly
08fc5556d5 fix some typos in recent lazyloader implementation 2020-04-15 12:32:48 -05:00
sliptonic
9427b5d0aa Merge pull request #3330 from etrombly/lazyloader
[Path] Use lazyloader for deferred python imports
2020-04-15 10:22:28 -05:00