Commit Graph

33 Commits

Author SHA1 Message Date
berniev
53ba98d636 Mod: use empty 2022-08-06 19:30:13 +02:00
Chris Hennes
589369a2cc Sketcher: PR6497 move return statement to new line 2022-03-29 13:25:06 -05:00
wmayer
51186c018e Sketcher: modernize C++11
* use nullptr
2022-03-23 19:26:15 +01:00
wmayer
d0a75e0a84 Sketcher: fix segmentation fault when using sketch validation dialog after document has been closed
Therefore replace the raw pointer of SketchObject with the template class WeakPtrT. This class will be notified as soon as its handled object will be deleted.
2021-10-21 16:22:11 +02:00
wmayer
2b34145e4c Sketcher: [skip ci] add function to sketch validation panel to remove degenerated geometry 2020-08-13 17:24:10 +02:00
wmayer
e14e5b845e [skip ci] use QLocale class consistently to make it possible to change it application-wide 2020-03-26 16:37:45 +01:00
Abdullah Tahiri
62e721e8fd Sketcher: GUI PCH 2019-05-02 07:12:51 +02:00
luz.paz
df7759147e Crowdin: Sketcher/Gui/TaskSketcherValidation.cpp fixed obsolete punct. 2019-01-30 11:08:03 -02:00
Yorik van Havre
47f98403f3 Fixed wording as notifed on crowdin 2018-12-31 16:21:49 -02:00
Abdullah Tahiri
8fbbf4ea9e Move Open vertices detection routine to SketchAnalysis 2018-12-03 12:11:11 +01:00
Abdullah Tahiri
e8e1f13e57 Sketcher: Make use of Sketch Analysis for Sketch Validation - refactoring 2018-07-29 13:44:06 +02:00
JimStar
8a8348e72b Extended global marker size to be used for Sketcher 2018-07-11 21:22:28 -03:00
Abdullah Tahiri
74b097ee75 Sketcher: Improve validation ui to select whether to ignore construction geometry or not
========================================================================================

Users generally expect that validate Sketch checks the visible part, perhaps because it is not called from the sketcher's edit view, but from the 3D view, perhaps
because that part is relevant for further construction.

On the other hand the tool's name is Validate Sketch and construction geometry belongs to the sketch.

So a new checkbox is introduced, by default enabled to ignore construction, but still allowing the user to make it operate in one direction or the other.

See:
https://forum.freecadweb.org/viewtopic.php?f=3&t=26139&p=208582#p208693
2018-01-13 11:31:11 +01:00
Abdullah Tahiri
362ba9c473 Sketcher: Fix "highlight open vertex" visualization
===================================================

fixes #3306
2018-01-13 11:30:48 +01:00
Abdullah Tahiri
3c6fa1f0ed Sketcher: Validation tool improvement
======================================

The sketch validation tool offers the functionality to detect missing coincidences. It is a problem that internal geometry causes detected missing coincidences.

Additionally, the tool only shows the visible profile and not the construction geometry.

This commit introduces the ignoring of construction geometry, which "fixes" the two behaviours indicated above.

fixes #3298
2018-01-13 11:30:35 +01:00
wmayer
ca343c43ab fix scan coverity issues: unchecked dynamic_cast 2017-04-11 12:45:02 +02:00
wmayer
1a97aa2e26 fixes #0002994: Validate Sketch's missing coincidence tool finds false positives 2017-04-10 17:17:40 +02:00
Abdullah Tahiri
832c3a6381 Sketcher: Validation of BSpline 2017-01-05 22:10:31 +01:00
wwmayer
52a65710f8 Merge pull request #401 from abdullahtahiriyo/parabola_2017
Parabola 2017
2016-12-28 13:48:13 +01:00
Abdullah Tahiri
95db1e1c15 Sketcher: Validation of Parabola 2016-12-18 19:29:38 +01:00
wmayer
4db3591e68 fix CIDs 129192, 129078 2016-12-18 12:42:43 +01:00
wmayer
273f3995c0 add class GeomArcOfConic to reduce code duplication 2016-12-04 14:20:56 +01:00
Abdullah Tahiri
e928e418ec Sketcher: New Feature: Hyperbola/ArcOfHyperbola
===============================================

- ArcOfHyperbola creation method
- Solver representation (undefined moving)
- SketchObjectPyImp (here we still miss the Part->Partdesign conversion)
- Sketch validation for hyperbola
- Hyperbola creation method: shows the "proof of concept", but it is very buggy!!

Notes:
- Missing icons, probably missing geo normal curve implementation - rebasing -
- Fixes to adapt Hyperbola to Derivector implementation and make it compile
2016-11-27 18:45:33 +01:00
wmayer
bed76edb48 fix Coverity issues 2016-08-20 17:21:01 +02:00
wmayer
b789f1e36f Add function to sketch validation panel to highlight open vertexes 2016-08-07 15:30:09 +02:00
DeepSOIC
52f062b9c6 Sketch:Validation: swap endpoints for reversed + constraint orientation locking controls
Added buttons to port sketches to CCW-emulation Sketcher.

Bonus =) : Added constraint orientation lock/unlock buttons (affects
point-wise modes of tangent and perpendicular constraints so far)
2015-02-17 12:27:32 +01:00
DeepSOIC
1bbc764e9e Sketcher: fix reversed geometry and rotated arcs
Fixes a bug where an arc, ellipse, or arc-of-ellipse, being reversed in
XY plane, behaved badly in sketcher (see forum thread "Sketch: how to
handle reversed external arcs?"
http://forum.freecadweb.org/viewtopic.php?f=10&t=9130 ).
Also fixes a problem with rotated arcs (see forum thread "Rotating Arc
in Sketcher"
http://forum.freecadweb.org/viewtopic.php?f=22&t=9145#p74262 ).

This is done by adding an emulation flag to a few methods in
Part::GeomXXX, which makes the shape to pretend being non-reversed
(CCW). This causes endpoints of reversed arcs of circles lineked as
external geometry to swap, causing broken sketches sometimes.
2015-02-17 12:27:31 +01:00
wmayer
6220246edb + fixes #0001060: Editing sketch crashes FreeCAD 2014-12-27 22:47:21 +01:00
Abdullah Tahiri
c4fb76eb61 Sketcher Ellipse and ArcOfEllipse: Extra features and bug fixes
- Minor changes to alignment constraint selection to avoid to create objects just for simple calculations
- Equality constraint of Ellipse, ArcOfEllipse and combinations of those elements
- Bugfix for internalalignment creation of major and minor of ellipse and extension to arcofellipse
- Trim support for ellipses
- Solver threshold for rank calculation set at 1e-13.
- Trim support for arc of ellipse
- Ellipses and ArcOfEllipses as external geometry
- Validate Sketch now supports arcs of ellipse
- Tangents of Ellipse or ArcOfEllipse to any of ArcOfcircle, circle and Ellipse (using construction elements)
- Perpendicularity constraint
- Bug fix: Show/hide internal geometry not working for external geometry
- Visualization of Internal alignment constraints when selecting in the constraint widget
- Equality for ellipses and arc of ellipses
2014-12-20 12:33:31 +01:00
wmayer
bb2ae31b65 + allow to set custom tolerances on validate sketch tool 2013-11-18 14:09:52 +01:00
wmayer
008616a30b Allow user to choose tolerance in validate sketch tool 2013-11-13 11:12:02 +01:00
wmayer
0ed47911f6 + Improve sketch validation tool 2013-10-16 17:28:04 +02:00
wmayer
4d16127432 + Add a sketch validation panel 2013-10-15 17:11:49 +02:00