Commit Graph

528 Commits

Author SHA1 Message Date
Abdullah Tahiri
40459e73cd Sketcher: Remove errors in reporting view while deleting
=======================================================

fixes #2275

https://freecadweb.org/tracker/view.php?id=2275

Deletion of coincidents rely on selected vertex. The original code was trying to delete a coincident without checking whether one was there.

The implementation now relies on checking whether a coincident is present.
2018-01-13 15:47:02 +01:00
Abdullah Tahiri
c80e6a8d60 Sketcher: Special sketcher color for dimensions having an expression
fixes #3285
2018-01-01 21:00:06 +01:00
wmayer
ad26e922ef improve whitespaces 2018-01-01 20:51:12 +01:00
Abdullah Tahiri
300ca1d88e Sketcher: Match angle on lines representation match solver result 2018-01-01 20:28:41 +01:00
wmayer
178794610d fixes #0003252: External geometry tool keeps hovered item active after leaving 2017-12-25 10:47:51 +01:00
Abdullah Tahiri
a309e417fc Sketcher: New Setting for improved dragging mode 2017-12-12 22:20:27 +01:00
Abdullah Tahiri
a014c1cbc1 Sketcher: Clean code and adapt previous solution only to non-relative cases
===========================================================================

Cleaning up ViewProviderSketch, as relative mode is never used for points.

Adapting the recalculation of the initial solution only to non-relative cases.

For relative movement cases (movePoint with relative=true) no cases where such a solution will be advantageous have been identified
and applying a similar solution involves changing the current behaviour too much, as to run the risk of introducing further bugs.

Decision to be revised if such cases where an advantage can be found are discovered.
2017-12-12 22:20:27 +01:00
Abdullah Tahiri
c49981c41b Sketcher: Do not show support when entering sketch edit mode if it is a datum plane
=====================================================================================

https://forum.freecadweb.org/viewtopic.php?f=10&t=25700
2017-12-07 11:39:35 +01:00
wmayer
952a4a781f fixes #0002290: Point-on-object constraint icon not selectable 2017-11-20 14:06:12 +01:00
Jeff
7f633cfbb2 Added color prefs to sketcher create commands
Create geometry commands in sketcher now have configurable crosshair color and editCurve color.
2017-11-18 15:30:41 +01:00
DeepSOIC
356e2810a4 Sketcher: fix false detection of doubleclick
Double-click detector code was comparing double-click threshold (value =
5) with distance between clicked objects in model space (i.e.
double-click distance threshold was equal to 5 mm in model space
regardless of zoom). The fix changes the comparison to pixels on screen
instead.

This fixes the inability to select sketch entities in quick succession,
when the sketch is small (i.e. less than 40 mm or so).
2017-11-10 18:12:48 +03:00
wmayer
96d01c9200 fix several kind of warnings:
+ fix -Wparentheses/-Wlogical-op-parentheses
+ fix -Wunused-variable
+ disable -Wundefined-var-template due to many false-positives (clang)
+ fix -Winconsistent-missing-override
+ fix -Wmaybe-uninitialized
2017-10-15 19:12:07 +02:00
Unknown
31a32b9931 Doxygen Typos
+ doxy whitespace formatting
+ added more misc. typos
+ grammar fixes
[skip ci]
2017-10-15 16:27:42 +02:00
wmayer
47fe76fe1d whitespace improvements + some optimizations 2017-10-12 11:22:10 +02:00
wmayer
84eedf2448 don't select circle/ellipse center if not inside selection box 2017-10-12 11:07:27 +02:00
SparkyCola
b5062920dd changed touch-selection so that it doesn't select the center- and end-
points of an object when they're not boxed
2017-10-12 10:42:04 +02:00
SparkyCola
47aec30a51 fixed touch-selection of circle and ellipse centerpoints not working 2017-10-12 10:41:05 +02:00
SparkyCola
695ded7d90 fixed selection of centerpoints when only selecting them resulted in not
selecting anything at all (in Sketcher touch-selection)
2017-10-12 10:36:13 +02:00
SparkyCola
6145699d54 resolves #3204 2017-10-12 10:35:52 +02:00
SparkyCola
267438d6a4 implemented simple selection of b-spline in touch mode, so far it allows
only to select the whole spline if one of the points is selected, a
better implementation requires much more sophisticated algorithms
2017-10-12 10:35:52 +02:00
SparkyCola
75b466dae5 implemented touch mode for arc of parabola with precision inaccuracity 2017-10-12 10:35:52 +02:00
SparkyCola
77b5b282b5 implemented touch mode for arc of hyperbola 2017-10-12 10:35:52 +02:00
SparkyCola
c3c50c3e92 implemented arc of ellipses touch mode (precision issue as well) 2017-10-12 10:35:52 +02:00
SparkyCola
899f3e26ea Implemented arc of circle in touch mode, same issue with precision as in
circle and ellipse
2017-10-12 10:35:52 +02:00
Mattis
295b4ab0f9 fixed issue related to polylines in touchmode, also implemented ellipse
touchmode (same issue as circle touching for now)
2017-10-12 10:35:52 +02:00
Mattis
f674cf5544 touch mode for circle implemented, does work for 90% of the cases, not
yet with relatively big circles and a narrow selectionbox.
2017-10-12 10:35:52 +02:00
Mattis
776cfe62ed added selection of end-points to line touch-select 2017-10-12 10:35:52 +02:00
SparkyCola
826551b740 Added touchMode-detection and partially implemented touchMode for line-
detection (only works when one end-point is selected, yet).
The touchMode refers to a rectangular selection where objects are
selected even if only a part of them is int the box. It's used when the
selection box is drawn from right to left.
2017-10-12 10:35:52 +02:00
wmayer
fde42545ba fix various coverity issues 2017-09-15 11:48:38 +02:00
Abdullah Tahiri
3a9e5499a6 Clarify solver situation at the end of of ViewProvider::OnDelete 2017-08-19 17:14:27 +02:00
Abdullah Tahiri
58210251ca Refactoring solve+recompute and reinstating initial solve+recompute behaviour 2017-08-19 17:14:27 +02:00
wmayer
5661d91371 fixes #0002710: Freecad doesn't show sketch elements added when overconstrained
issue #0002836: Crash in sketcher
2017-08-19 17:14:27 +02:00
wmayer
e73a16e7b4 when drawing constraint icon handle the case when view provider of sketch is not in sync with geometry 2017-08-19 17:14:27 +02:00
wmayer
b9135b594f do not hide any drawing elements when entering edit mode of a sketch 2017-07-15 15:47:22 +02:00
wmayer
90653787a6 various fixes:
+ fix typos
+ fix const correctness
+ whitespace improvements
2017-06-19 17:18:16 +02:00
Stefan Tröger
4b3fb99bf0 GeoFeatureGroup: Make link collection non-DAG save 2017-06-19 15:37:09 +02:00
Stefan Tröger
8a4821f8fc Sketcher: Use correct global placements 2017-06-19 15:37:09 +02:00
Alexander Lin
144e4759ce Adds extend feature to Mod/Sketcher
Fixes #1187
2017-06-19 13:07:37 +02:00
wmayer
22473ae4a8 fix creation of NaN that invalidates the view frustum 2017-05-12 08:05:12 +02:00
Abdullah Tahiri
d8d086b2f2 Sketcher: Visualization of horizontal alignment constraint 2017-05-01 23:35:13 +02:00
wmayer
77d6448da3 Revert "Sketcher: Constraint Node restructuring to enable independent hidding of driving/driven constraints"
This reverts commit aa9255509b9e89b10d8fe21d8d5daa2be7eb5bfb.
2017-05-01 16:17:20 +02:00
wmayer
2cb39de755 Revert "Sketcher: Edit Controls' checkboxes to independently hide/show driving/non-driving constraints"
This reverts commit cfd217071bbe83a44b3601b3df294924a9f3dc8d.
2017-05-01 16:16:49 +02:00
wmayer
57cfa6d836 Revert "Sketcher: hidding constraints - fix entry into empty sketch"
This reverts commit 38eef417110eed51073ad42a5ffa993cc90ab0ef.
2017-05-01 16:16:13 +02:00
Abdullah Tahiri
6595d5564f Sketcher: hidding constraints - fix entry into empty sketch 2017-04-30 10:06:15 +02:00
Abdullah Tahiri
a76286aa27 Sketcher: Edit Controls' checkboxes to independently hide/show driving/non-driving constraints 2017-04-30 10:06:15 +02:00
Abdullah Tahiri
c9fbe9cc6a Sketcher: Constraint Node restructuring to enable independent hidding of driving/driven constraints 2017-04-30 10:06:15 +02:00
Abdullah Tahiri
72a3ddb2b4 Sketcher: On reference constraint double click, change it to driving and enter edit mode 2017-04-22 18:16:27 +02:00
Peter Lama
fa4bebf2e0 Use OCCT Handle macro for Handle_ classes
This is the result of running OCCT's upgrade script provided
with OCCT 7.0. See
https://www.opencascade.com/content/freecad-occt710-and-windows-rtti-data-missing#comment-form
and
https://www.forum.freecadweb.org/viewtopic.php?f=4&t=21405&start=120#p169019
for why this is necessary for OCCT >= 7.1
2017-04-20 12:27:34 +02:00
Abdullah Tahiri
63f77dec59 Sketcher: Remove unused variable 2017-04-17 20:53:12 +02:00
Abdullah Tahiri
daa70d7ada Sketcher: Rendering order widget 2017-04-17 20:53:12 +02:00