kindred/create
1
1
Fork 0
Code Issues 30 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity
37,667 Commits 41 Branches 6 Tags
75b655fea024470ce5f352d904648c9edf8cf285
Commit Graph

393 Commits

Author SHA1 Message Date
Chris Hennes
b9cc70ff99 Merge pull request #14383 from Ondsel-Development/asm_invalid_limits 
Assembly: Fix bad limits automatically
 2024-06-03 11:06:50 -05:00
Chris Hennes
6404de9c21 Update translations 2024-06-03 11:04:42 -05:00
PaddleStroke
2bd57d0817 Assembly: Fix bad limits automatically. Fixes https://github.com/Ondsel-Development/FreeCAD/issues/61 2024-05-30 10:33:59 +02:00
PaddleStroke
9ec47a58a8 Assembly: Translate error 2024-05-30 10:33:19 +02:00
wmayer
560cab6f31 clang/gcc: Add build option FREECAD_WARN_ERROR to force to make warnings into errors 2024-05-29 13:37:07 +02:00
PaddleStroke
5fb3589f26 Assembly: Add 'Angle', 'Perpendicular' and 'Parallel' joints. 2024-05-27 11:59:06 -05:00
Jiří Mácha
635616c88f Missing property Object1 or Object2 of fixed joint causing crash (#13912) 
* Assembly: removal of object of fixed joint causing crash

FreeCAD is crashing if the 'Object'
property of fixed joint (Assembly/Joints/Fixed/Joint Connector 1/Object1 or
Assembly/Joints/Fixed/Joint Connector 2/Object2) is manually removed.

Steps to reproduce:

 - make simple Assembly e.g. of two cubes with Fixed joint
 - Select Fixed joint in the tree and go-to property 'Data' tab
 - Select 'Object1' or 'Object2' of the 'Joint Connector 1' or 'Joint Connector 2'
   and remove this reference
 - click by your pointing device (mouse) to the arbitrary other property

The FreeCAD will crash here because the call
App::DocumentObject* obj = getObjFromNameProp(joint, propObjName, propPartName);
will return NULL pointer.

This problem is similar to the
8d5348ad066aa216c387582bfdcf066966a4fe09.

* Assembly: fixed warning message text

The warning message text is not describing two cases which can happen,
but only one - property of specific joint.

* Assembly: avoiding possible crash in rack pinion joint code

Similar problems:

07c6df61f8456a6b02e88b369dcef5643ac1574e
and
8d5348ad066aa216c387582bfdcf066966a4fe09

were causing real crashes (Linux + Sway Wayland compositor) when
Fixed joint type was used.

This patch tries to avoid the same situation, but now for the
rack pinion joint type.

The returned pointer value (part1 and obj1) can get NULL pointer value
and is used in the code:

    if (obj1->getNameInDocument() != part1->getNameInDocument()) { ....

a few lines later.
 2024-05-27 10:46:02 -05:00
Chris Hennes
73ae4102e6 Update translations 
Arch->BIM is a WIP
 2024-05-25 19:11:51 -05:00
PaddleStroke
0a06b03710 Assembly: JCS selection: cones surfaces offers the cone's apex. Fixes #13958 2024-05-20 12:00:17 -05:00
Max Wilfinger
323ec08e8e Update assembly icons to be consistent with main updates. 
Add commands to menu/toolbar.
 2024-05-20 10:46:45 -05:00
wmayer
154357f115 Assembly: Fix possible build failure with PCH 2024-05-17 13:12:24 +02:00
PaddleStroke
5f4dd814ea Core: Add getRootObjectsIgnoreLinks and fix bugs in tree.cpp and AssemblyObject.cpp, CommandInsertLink.py, UtilsAssembly.py 2024-05-13 17:58:34 +02:00
Chris Hennes
9fead3682d Update translations 2024-05-12 17:06:56 -05:00
wmayer
c1b7d38b27 Assembly: Fix warning: -Wunused-variable 2024-05-07 19:48:33 +02:00
PaddleStroke
b12b95b908 Assembly: Fix Gear Radius2 spinbox issue 2024-05-06 18:32:00 +02:00
PaddleStroke
fed17ff6f1 Assembly: Improve Exploded View's radial explosion, and various small fixes. 2024-05-06 18:32:00 +02:00
PaddleStroke
3d13f5353a Assembly: add try/catch blocks in drag step. 2024-05-06 18:32:00 +02:00
PaddleStroke
c8a6f2c55c Assembly: Improve tooltip of CommandCreateJointDistance 2024-05-06 18:32:00 +02:00
PaddleStroke
ce455de2c5 Assembly: Mark new features as experimental. To enable them you need to create a parameter called ExperimentalFeatures and set it to true. 2024-05-06 18:32:00 +02:00
PaddleStroke
3419d27077 Assembly: Make RackPinion and Screw easier to setup. 2024-05-06 18:32:00 +02:00
PaddleStroke
b25f90c694 Assembly: Fix small bugs in AssemblyObject.cpp, JointObject.py and UtilsAssembly.py 2024-05-06 18:32:00 +02:00
PaddleStroke
13c0ba1902 Assembly: Introduce Belt joint. 2024-05-06 18:32:00 +02:00
PaddleStroke
b4168c95ee Assembly: Drag: switch from solver Solve to dragStep. 2024-05-06 18:32:00 +02:00
PaddleStroke
60b902fc7e Assembly: Adds limit and RackPinion/Screw/Gears 2024-05-06 18:32:00 +02:00
PaddleStroke
083437b5ba Assembly: ViewProviderAssembly: Fix issues raised by @wwmayer 2024-05-06 18:32:00 +02:00
PaddleStroke
4d33659666 Assembly: Add Screw/Pulley/Gears/RackPinion icons. Credits to @maxwxyz 2024-05-06 18:32:00 +02:00
PaddleStroke
b35e4adc13 Assembly: Solve on recompute. Fixes #12983 2024-05-06 18:32:00 +02:00
PaddleStroke
670b945347 Assembly: Add support to origin components Fixes #12446 2024-05-06 18:32:00 +02:00
PaddleStroke
e264a25714 Assembly: Improve dragging behavior. Fixes #13058 2024-05-06 18:32:00 +02:00
PaddleStroke
d389074c61 Assembly: Exploded view refactoring 2024-05-06 18:32:00 +02:00
PaddleStroke
5ad1401ccc Assembly: Fix doubleclicked of joint and view #12958 2024-05-06 18:32:00 +02:00
PaddleStroke
cf81b18d21 Assembly: Remove Lock from labels and add lock to 3dView 2024-05-06 18:32:00 +02:00
PaddleStroke
7327f8011a Assembly: Prevent failure when double clicking a joint if another taskbox is present. Fixes #12770 2024-05-06 18:32:00 +02:00
PaddleStroke
2cfc1cc85b Assembly: Fix distance 0 between 2 vertex. Issue mentioned in #12490 2024-05-06 18:32:00 +02:00
PaddleStroke
263b07376f Assembly: Insert link: insert at the center of the screen rather than origin of document. 2024-05-06 18:32:00 +02:00
PaddleStroke
9b2cee5cbe Assembly: attach selection observer only if in edit mode. 2024-05-06 18:32:00 +02:00
PaddleStroke
4a88f6c62f Assembly: InsertLink : Kill behavior of parts following mouse. 2024-05-06 18:32:00 +02:00
PaddleStroke
ce72c2d438 Assembly: Enable dragger when solid is selected. Fixes #12656 2024-05-06 18:32:00 +02:00
PaddleStroke
061aba3476 Assembly: Remove bad joints : joints between a part and itself. Fixes #12752 2024-05-06 18:32:00 +02:00
PaddleStroke
1045f6aa51 Assembly: Insert Part tool : Change from list to tree. Fixes #12890 2024-05-06 18:32:00 +02:00
PaddleStroke
f27f5bba37 Assembly: Fix #12887: changing offset can move grounded parts in some cases. 2024-05-06 18:32:00 +02:00
PaddleStroke
94a45ae097 Assembly: Joint edition : Fix bug when changing offset while only one part is selected 2024-05-06 18:32:00 +02:00
PaddleStroke
27bb619323 Assembly: Fix #12889 : deleting a part does not delete joint and later crashes freecad. 2024-05-06 18:32:00 +02:00
PaddleStroke
2cf789a45f Assembly: define nested assemblies. Fixes 12440 2024-05-06 18:32:00 +02:00
PaddleStroke
9f8810aa4c Assembly: Introduce 'Exploded Views' 2024-05-06 18:32:00 +02:00
PaddleStroke
cff97eb887 Assembly: Adds a dragger object to the assembly, so that assembly tools can access a dragger. 2024-05-06 18:32:00 +02:00
PaddleStroke
ef384a25cd Assembly: Move static functions from JointObject to UtilsAssembly so they can be reused. And adds few functions 2024-05-06 18:32:00 +02:00
PaddleStroke
f04360ae22 Assembly : Add icon for joint group. 2024-05-06 18:32:00 +02:00
PaddleStroke
fa11eb93f4 Assembly: Insert link, clear selection on deactivation. 2024-05-06 18:32:00 +02:00
PaddleStroke
10e75e2752 Assembly: Change 'Insert Link' name to 'Insert Component' Fixes #12165 2024-05-06 18:32:00 +02:00