Commit Graph

18684 Commits

Author SHA1 Message Date
Yorik van Havre
762728b8c7 Merge pull request #4346 from chennes/validateStartHTMLWithW3C
[Start] Modify generated HTML to comply with W3C Validator Recommendations
2021-02-02 13:59:09 +01:00
Chris Hennes
a6b689f57c Fix Surface task panel shortcut use to use Widget context
The Delete key shortcut of the three different panels in the
Surface Workbench TaskFilling sidebar conflicted between
the panels if multiple were showing. This is resolved by
making the QAction's context the widget, rather than the window.
2021-02-01 19:40:33 -06:00
Chris Hennes
4f3cc41d65 Modify Start HTML to be valid HTML
Using the W3C validator, a number of minor issues were found with the Start page
HTML. Those items were:
* Missing language setting on the body of the document
* Deprecated attributes set for the style and script tags
* Image tags require alt text
* List tags can only contain list items
* All file:/// URLs must not contain backslashes, even on Windows
2021-01-31 22:13:47 -06:00
Chris Hennes
2758e42adb Add tests for Start Page HTML validity
This test is in two parts: first the generated HTML is sanitized to remove any
potentially sensitive information (e.g. filenames, authors, document info, etc.)
and is then sent to the W3C Validator service at https://validator.w3.org/nu.
The results are interrogated and if any errors or warnings are returned, the
test fails. If the site cannot be reached this is NOT treated as a test failure.

Second, the actual (unsanitized) filenames are checked for validity: the HTML
standard prohibits backslashes in URLs, even if the URL refers to a local file
on a system that uses backslashes as a path separator (e.g. Windows). This
would have been caught by the W3C Validator if we had not sanitized the filenames.
2021-01-31 21:49:17 -06:00
wmayer
8adf2aac25 [PD] [skip ci] fix alignment in pad dialog
just a minor UI issue: when you decrease the width of the pad dialog (e.g. because you have a small screen), the alignment of the widgets is lost. This fixes it by grouping the widgets in a grid.
2021-01-31 16:26:22 +01:00
donovaly
a884ea703e [PD] fix alignment in pocket dialog
just a minor UI issue: when you decrease the width of the pocket dialog (e.g. because you have a small screen), the alignment of the widgets is lost. This PR fixes this by grouping the widgets in a grid.
2021-01-31 16:03:57 +01:00
Aapo
9f49b122f4 [TD] Dimensions: donovaly's minor fixes for TheoreticalExact dimensions. 2021-01-31 15:17:46 +01:00
Aapo
f362930664 [TD] Improve arbitrary tolerance and unit handling for Equal Tolerances. 2021-01-31 15:17:46 +01:00
Aapo
dbef970697 [TD] Add under- and overtolerances for Dimension Task layout, fixes for Dimension tolerance refresh and behavior. 2021-01-31 15:17:46 +01:00
Aapo
5350a2c3d0 [TD] Fix degree sign processing for equilateral angular plusminus dimensions. 2021-01-31 15:17:46 +01:00
Aapo
e6ef62e711 [TD] Fix regression in Dimensions: Setting arbitrary under tolerance was somehow lost. 2021-01-31 15:17:46 +01:00
donovaly
96cbb986e2 [PD] correct hole cut definitions
I was able to get the norms and could update the definitions accordingly.
For example in the ISO 10462, sizes smaller than M3 are not defined and your definition files should only contain what is really defined.
2021-01-31 13:45:57 +01:00
wmayer
d77d3e81cb Part: [skip ci] fix path of attachment icon 2021-01-30 17:22:54 +01:00
Stefan Tröger
ec5ac30756 Remove ExtensionProxy and rely on default Python proxy for extensions. fixes #0004534 2021-01-30 16:00:48 +01:00
Benjamin Nauck
51f8ea11d9 Spreadsheet: Add test for undo alias issue 2021-01-30 14:04:57 +01:00
Benjamin Nauck
aa91457491 Spreadsheet: Allow alias removed by undo to be reused
Fixes issue descripted in the forum post:
https://forum.freecadweb.org/viewtopic.php?f=3&t=54009
2021-01-30 14:04:57 +01:00
Kurt Kremitzki
1fb4e38e5e Merge pull request #4134 from donovaly/PD-Hole-DrillPoint
[PD] improve blind hole depth handling
2021-01-30 05:14:52 -06:00
Benjamin Nauck
49b7f237be [MeshPart] Fix copy-paste error
It doesn't make sense to check minLen and then call SetMinSize to maxLen
so this must be a copy-paste error.

Introduced in eb6f60469a

Found with Coverity.
2021-01-30 11:47:06 +01:00
Kurt Kremitzki
f1073ce6ae Merge branch 'master' into PD-Hole-DrillPoint 2021-01-29 19:02:34 -06:00
sliptonic
88a8eba77f Merge pull request #4325 from machste/fix_simple_copy
Path: Fix creating simple copy
2021-01-28 14:14:02 -06:00
Stefan Brüns
27cdc7cd9c Fix ODR violation, correct Ui_TaskSketcherGeneral namespace
The generated ui_TaskSketcherGeneral.h defines the class in the
SketcherGui namespace.

Fixes #4529
2021-01-28 17:43:10 +01:00
Zheng, Lei
99fe37928c Part: fix ViewProviderExt::updateVisual() on incomplete mesh 2021-01-28 17:38:49 +01:00
vosk
1300c630f4 [Part] - Fix memory leaks 2021-01-28 15:45:00 +01:00
Aapo
212381dcf7 [TD] Avoid changing default open/save dir to templateDir when opening a Page template. 2021-01-28 14:54:59 +01:00
Yorik van Havre
10f8d0f26f Merge pull request #4317 from Roy-043/fix_gui_snapper_center_face
[Draft] Fix snap to center of faces of solids
2021-01-28 14:36:15 +01:00
Yorik van Havre
d8f1fd41d1 Merge pull request #4318 from bitacovir/Surface_WB_icons
[UI] Replace SVG icons for Surface WB commands
2021-01-28 14:33:45 +01:00
Yorik van Havre
d206394db5 Merge pull request #4320 from chennes/cleanStartWithLGTM
[Start] Minor tweaks recommended by LGTM
2021-01-28 14:31:28 +01:00
Stefan Mächler
2afba1a7b7 Path: Fix creating simple copy
This commit fixes the issue discussed on the FreeCAD forum:

https://forum.freecadweb.org/viewtopic.php?f=15&t=54769
2021-01-28 09:32:17 +01:00
sliptonic
a631f45e31 Merge pull request #4297 from shadowbane1000/fanuc-1st-pass
[PATH] First pass at a post processor for Fanuc
2021-01-27 13:05:26 -06:00
sliptonic
0a46384bdb Merge pull request #4140 from gauna85/PathStock
Path: Fix #3914: Adding stock label prefix to name comparison in orde…
2021-01-27 11:09:31 -06:00
sliptonic
3676ab0d43 Merge pull request #4286 from kbickar/master
[Path] Fix AttributeError on deleting corrupt dressup
2021-01-27 11:04:40 -06:00
sliptonic
03680187cb Merge pull request #4321 from ci4ic4/patch-1
[PATH] Update philips_post.py
2021-01-27 11:00:33 -06:00
sliptonic
dd9b32f992 fix index bug in toolbit directory creation 2021-01-27 10:27:12 -06:00
sliptonic
39c1b59ac1 Merge pull request #4294 from mlampert/feature/toolbit-free-properties
[Path] - Feature/toolbit free properties
2021-01-27 10:03:46 -06:00
ci4ic4
4ed7665b13 Update philips_post.py
You can't compare dict with an integer.
2021-01-27 11:51:42 +00:00
Abdullah Tahiri
c2dcf6492b ViewProvider: make partial redundant color blue 2021-01-27 07:53:25 +01:00
Markus Lampert
d6584a8b48 Updated toolbit-attributes.py script and cleaned up shapes. 2021-01-26 20:04:46 -08:00
Markus Lampert
82a519277d Added support for deleting empty groups from the property bag's group tracking. 2021-01-26 19:46:06 -08:00
Chris Hennes
76e25a3a96 Minor tweaks to Start recommended by LGTM
Using the results of the vulnerability scan at lgtm.com, some minor
changes were made. First, all Python exception handling now explicitly
catches Exception, rather than BaseException (which would include SystemExit
and KeyboardInterrupt). Second, unused imports were removed. Third, a
couple of unnecessary or unused assignments were addressed. Finally, the
JavaScript was modified to explicitly declare the local ddiv variable when
needed.
2021-01-26 20:38:51 -06:00
Markus Lampert
6abdfd24d5 Disable library name edit 2021-01-26 18:17:09 -08:00
Markus Lampert
2d76414ce6 Add toolbit test files to list to maybe get windows build to pass 2021-01-26 18:14:09 -08:00
sliptonic
fa3668b349 fixed slitting saw shape and bit 2021-01-26 18:14:09 -08:00
sliptonic
535c4646e3 tool bugs 2021-01-26 18:14:09 -08:00
sliptonic
3a3adc7dee fix bug when declining the creation of workdir subdirectories. 2021-01-26 18:14:09 -08:00
Markus Lampert
57689bd2cd Added commit to explain the purpose of dumping the directory tree 2021-01-26 18:14:09 -08:00
Markus Lampert
60ea0d8cee Added Tools directory for recursive test file copy 2021-01-26 18:14:09 -08:00
Markus Lampert
1c3f08d4eb Added test case to determine directory layout. 2021-01-26 18:14:09 -08:00
sliptonic
6ae29e4bdb make initial path defaults slightly more intuitive 2021-01-26 18:14:09 -08:00
Markus Lampert
7fafe2b4ea Fixed relative path search for shapes 2021-01-26 18:14:09 -08:00
sliptonic
478a465f64 check working dir on dock open as well as manager open.
use os.path.sep liberally
choose the first library if no other is selected
2021-01-26 18:14:09 -08:00