Commit Graph

31198 Commits

Author SHA1 Message Date
tarman3
7df127bcbc CAM: PathShape with Tool Controller 2025-05-12 22:57:23 +03:00
Chris Hennes
f9dbaac7aa TD: Fix hatch size constraint
Commit 1155f0d7 changed `UnitsApi::getDecimals()` from `int` to
`size_t`, which changes the meaning of the negation since it is now
unsigned. Cast it to an integer before the negation to restore the old
behavior.
2025-05-12 18:11:15 +02:00
FEA-eng
ff4620ace2 FEM: Update DlgSettingsFemCcx.ui 2025-05-12 11:09:59 -05:00
sliptonic
349b879979 Merge pull request #21193 from davidgilkaufman/adaptive_helix_fixes
[CAM] Adaptive helix fixes
2025-05-12 11:09:16 -05:00
tetektoza
03f41eb11f BIM: Update tooltip for Activate button 2025-05-12 18:00:52 +02:00
tetektoza
3dfa5926d2 BIM: Introduce Activate for BIM Views
Currently there's no option for selecting active working plane other
than selecting `DoubleClickActivates` property on a BIM Level.

So, this patch adds an additional button for the submenu that BIM Views
provides - to activate working plane of the selected item.
2025-05-12 18:00:52 +02:00
tetektoza
e13d0787d3 BIM: Fix missing IFC attributes for certain BIM objects
Some of the objects, like Column, or Beam do not contain `IFC
Attributes` if they are initially created.

As it turns out, they are not being created as we are checking for
`onDocRestoredDone` attribute, which is assigned in `onDocumentRestored`
function. Since users can usually just not restore a document, but just
play on a newly created document, this attribute won't be available,
thus we won't be going through whole `onChanged` logic which populates
`IFC Attributes`.

To preserve current functionality of this additional parameter and not
cause the previous errors to happen, this patch just changes from the
custom flag to globally available `Restoring` flag which tracks document
being restored more reliably.
2025-05-12 17:50:11 +02:00
Roy-043
63c81c2146 BIM: close BIM_Library task panel on doc close
Fixes #21179.

This PR uses the built-in solution to close the task panel.

I was not aware of this feature before. My 2 previous PRs related to the closing of task panels, #20719 and #21073, will (largely) have to be reverted/redone in favor of this solution.
2025-05-12 17:48:39 +02:00
Roy-043
fcf5f8a089 Draft: aux.fake_function should not overwrite functions
The `aux.fake_function` is used in the Draft unit tests as a substitute for functions that, in most cases, do not yet exist. But in test_modification.py it would overwrite Draft.extrude leading to issues with BIM unit tests.

See:
https://github.com/FreeCAD/FreeCAD/pull/21134#issuecomment-2869178563
2025-05-12 10:45:45 -05:00
mosfet80
8ba6d38bdd [Mod] Drawing remove (#20419)
* [Mod] Draw remove

removed deprecated drawing module

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2025-05-12 17:43:25 +02:00
sliptonic
e699fe37d8 Merge pull request #20873 from tarman3/startpoint
CAM: Fixes PickStartPoint
2025-05-12 10:40:57 -05:00
marcuspollio
33c7efae85 BIM: fix some imports and cleanup miscellaneous (#20914) 2025-05-12 17:40:12 +02:00
Chris Hennes
952485dcbb Merge pull request #19907 from benj5378/getAttribute
Base: make getAttribute template
2025-05-12 10:39:55 -05:00
Furgo
68987874b3 BIM: set DoubleClickActivates property true by default 2025-05-12 17:36:29 +02:00
sliptonic
51cbbf37db Merge pull request #21265 from LarryWoestman/refactor
CAM:  updated opensbp post to work with current Processor.py
2025-05-12 09:32:43 -05:00
sliptonic
3b3d41d114 Merge pull request #20828 from tarman3/DressupPathBoundary-KeepToolDown
CAM: Keep tool down in DressupPathBoundary
2025-05-12 09:07:44 -05:00
tarman3
1648ee6cdc CAM: PickStartPoint fixes 2025-05-12 16:57:32 +03:00
tarman3
c76357c148 CAM: Simulator - Decrease speed button (#21222)
* CAM: Simulator - Decrease speed button

* CAM: Simulator - Move slider upper

* CAM: Simulator - Changed speed icons
2025-05-12 08:57:30 -05:00
Kacper Donat
cf4357ed38 Gui: Fix handling - character in OVP 2025-05-12 08:55:09 -05:00
sliptonic
87de9cda77 Merge pull request #21177 from dbtayl/fix_adaptive_repeated_cuts
CAM: Fix adaptive repeating cuts excessively at various depths
2025-05-12 08:15:55 -05:00
sliptonic
1f0b47f79e Merge pull request #21128 from jffmichi/fix_array_dressup
CAM: bring Array dressup in line with existing dressups
2025-05-12 08:10:31 -05:00
tarman3
43bcc5820e CAM: Simulator - Add document name to title 2025-05-12 08:22:44 +02:00
Lawrence Woestman
7b882c394c CAM: updated opensbp post to work with current Processor.py 2025-05-11 15:39:49 -07:00
Benjamin Bræstrup Sayoc
2b6e73c29d Everywhere: clean up getAttribute conversions 2025-05-09 15:54:57 +02:00
Benjamin Bræstrup Sayoc
2b1aec0041 Base: make getAttribute template 2025-05-09 15:54:57 +02:00
pre-commit-ci[bot]
cd3d03c419 CAM: clean up code 2025-05-09 09:53:34 -04:00
David Kaufman
9723d95d4c CAM: add spiral-out to full radius at the bottom of the cone helix 2025-05-09 09:53:34 -04:00
David Kaufman
31baab0870 CAM: delete dedicated cone helix implementation, merge into standard implementation 2025-05-09 09:53:34 -04:00
David Kaufman
d83730b3be CAM: Allow helix angles between 0 and 1 degree 2025-05-09 09:53:27 -04:00
tarman3
27f51b0b4c CAM: Simulator window title 2025-05-09 12:50:32 +02:00
Rayno Jiang
a5a6ed55e2 Sketcher: Scaling of a sketch containing BSplines doesn't work (#20943)
* [FreeCAD-20111] Sketcher: Scaling of a sketch containing BSplines doesn't work
When we executing Scale cmd we don't will lose knots information from shape geometry and it cause the scaled spline build with issue knots and it lead solver gets compute issue.
1. Add string format function PythonConverter::makeArryString(const std::stringstream& ss) for processing the control pnts string, mults string and knots string.
2. Add mults and knots information for python obj to make BSplineCurvePy::buildFromPolesMultsKnots(Args...) initialized Geom_BSplineCurve correctly.

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* 1. fix typo
2. Add wights info to keep spline shape after convert from python object

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* 1. remove static function makeArrayString() from PythonConverter
1. Add template function makeSplineInfoArrayString() to generate string for cleaner code.
2. change python string format as review suggestion

* use fmt format

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Fixes #20111

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2025-05-09 00:02:33 +02:00
Stefan Tröger
97d8608557 FEM: Fix test if VTK or VTK python is not available (#21168)
* FEM: Fix test if VTK or VTK python is not available
* FEM: Make test work if vtk python not installed
2025-05-08 15:55:45 -05:00
Chris Hennes
6a458b5ed0 TD: Fix capitalization of Console calls 2025-05-08 21:08:45 +02:00
theo-vt
777d20b812 PartDesign: Fix no longer possible to make a hole from one selected circle in a sketch (#21030)
* Search for profile shape subelements without simplifying compounds for hole center detection

* Simpler solution
2025-05-08 16:47:26 +00:00
WandererFan
3cabb3f7b8 [TD]Allow non-shape views to have children (#20768) (#21099)
* [TD]Allow non-shape views to have children (#20768)

* Update src/Mod/TechDraw/App/DrawView.cpp

Review comment

Co-authored-by: Benjamin Nauck <benjamin@nauck.se>

* Update src/Mod/TechDraw/App/DrawView.cpp

review comment

Co-authored-by: Benjamin Nauck <benjamin@nauck.se>

* Update src/Mod/TechDraw/Gui/ViewProviderDrawingView.cpp

review comment

Co-authored-by: Benjamin Nauck <benjamin@nauck.se>

* Update src/Mod/TechDraw/Gui/ViewProviderDrawingView.cpp

review comment

Co-authored-by: Benjamin Nauck <benjamin@nauck.se>

---------

Co-authored-by: Benjamin Nauck <benjamin@nauck.se>
2025-05-08 09:18:09 -05:00
tetektoza
20385b3ebe Draft: Introduce new dynamic polygon tracker for Polygon tool (#21045)
As the title says - currently we just have a simple circle, so I thought
with some basic adjustments it's possible to add a cool tracker that
will possibly guide user better on what they are placing on the
viewport.
2025-05-08 14:30:31 +02:00
Beep6581
f2fa2f1360 PartDesign: Merge pull request #21015 from Beep6581/fix-thread-pitch
Fixes hole thread pitch
2025-05-07 21:53:09 +02:00
Roy-043
2a53890045 BIM: show units in Arch_Roof task panel
Fixes: #21137.

Note that the list values in the Property editor are unitless. Therefore lengths are still in mm there.
2025-05-07 17:54:14 +02:00
Syres916
f8dd2d0ec1 [BIM} remove incorrect check which was stopping the default Pipe being created 2025-05-07 17:53:26 +02:00
Furgo
ae6bd1b107 BIM: add docstrings to all Arch module functions 2025-05-07 17:51:57 +02:00
Furgo
8710648480 BIM: refactor whitespace between parameters and operators for improved
readability
2025-05-07 17:51:57 +02:00
sliptonic
ae93bd5907 Merge pull request #21183 from tarman3/fixsimprogress
CAM: Simulator Fix thumb right position with speed > 1
2025-05-07 10:23:29 -05:00
tarman3
e8decef4f5 CAM: Simulator Fix thumb right position with speed > 1 2025-05-07 11:09:17 +03:00
tarman3
7914f0626b CAM: KeepToolDown in Dressup Boundary 2025-05-07 09:42:16 +03:00
Dan Taylor
31d4e051b6 CAM: Fix adaptive repeating cuts excessively at various depths 2025-05-06 20:29:19 -05:00
Jacques Beaurain
1bf656b6e3 Gui: HiDPI fixes for Sketcher (#21098)
* Gui: HiDPI fixes for Sketcher

(cherry picked from commit f043fd7c5c8a6ea003811453165eee7d643f3779)

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

(cherry picked from commit 42567ca9fcf2d6bab612715391a7b1911367f75d)

* Apply suggestions from code review

Co-authored-by: Kacper Donat <kadet1090@gmail.com>
(cherry picked from commit 28b52086e9cceae0e095421985479c546df49e44)

* qreal to double

(cherry picked from commit 4434ef18affa082a88390c1e68274de42f7c181e)

* more qreal to double

(cherry picked from commit df15eb6200d4ceab730ca8cf25ab0a90efe1cf41)

* Restore previous code which converted label size to points. View scaling would result in text that is too big.

* Ensure scaled marker size is one of the supported sizes for CIRCLE_LINE otherwise it would default to 7  (or what was set to "MarkerSize" in hGrp)

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: Tim Ringenbach <tim.ringenbach@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Kacper Donat <kadet1090@gmail.com>
2025-05-06 19:47:09 +02:00
PaddleStroke
90190f8d13 Core: restoreContent not restoring expressions (#21152) 2025-05-06 12:02:35 -05:00
bofdahof
ba2c2ca5ad Console: rename PascalCase named methods to camelCase 2025-05-06 17:50:21 +02:00
sliptonic
2b50357b45 Merge pull request #20928 from LarryWoestman/refactor
CAM:  Fix tool changes not correctly output in gcode in the refactored code base
2025-05-06 10:47:47 -05:00
Benjamin Nauck
afc54f74e4 Merge pull request #21083 from 3x380V/exception-stage-1
Base: simplify Exception
2025-05-06 09:29:45 +02:00