Commit Graph

26924 Commits

Author SHA1 Message Date
wandererfan
80c2942c22 [Import]fix rounding errors in dxf export 2024-01-17 11:33:50 -05:00
Paddle
6db820a580 Sketcher: Define double click on edges : Select the whole wire. 2024-01-17 11:05:28 -03:00
Paddle
b0176c2d92 Sketcher: add isPeriodicBsplineCurve helper function 2024-01-17 11:05:28 -03:00
Roy-043
904bb57538 Draft: Task panel checkboxes were repositioned by accident
In a previous PR of mine I have reorganized some lines of code in DraftGui.py without realizing that this would reposition checkboxes. This PR fixes that.
2024-01-17 11:00:40 +01:00
wandererfan
2e5d902d1a [TD]Dimension validation improvements 2024-01-16 20:07:30 -05:00
Chris Hennes
14d4ea2416 Merge pull request #11883 from wavexx/pch_build_fix
Fix build with precompiled headers
2024-01-16 14:06:34 -06:00
marioalexis
27a0fb1e99 Fem: Fix constraint arrows - fixes #6073 2024-01-15 19:21:09 -06:00
wandererfan
7bc3317455 [TD]fix Balloon parentage in tree 2024-01-15 15:44:12 -05:00
marioalexis
9ceb1e7af1 Fem: Remove pipeline node from analysis view provider - fixes #11175 2024-01-15 11:19:09 -06:00
Chris Hennes
ed6230093f Part/Toponaming: Refactor makeElementCompound
Refactor to address linter issues, breaking up large methods, renaming variables, etc.
2024-01-15 18:17:32 +01:00
Zheng, Lei
4729dc6c59 Part/Toponaming: Add original code for makECompound
Renamed to makeElementCompound and modified as little as possible to get it to compile in the new framework. All required auxilliary methods are also brought in.
2024-01-15 18:17:32 +01:00
mosfet80
9975c74c45 Update Mesher.cpp
removed old code for smesh <v7.
Freecad now requre smesh  version >=7.7.1
2024-01-15 18:02:31 +01:00
Alexander Neumann
d9636aaa25 Guard MEFISTO code with version check against SMESH. 2024-01-15 10:44:06 -06:00
edi271
5ddd9829ad [TD] Solve issue in VertexAtIntersection 2024-01-15 09:46:33 -05:00
Chris Hennes
fa0a25a777 Merge pull request #11896 from Pesc0/toponaming-shapeprotector
Toponaming shapeprotector
2024-01-14 21:03:09 -06:00
Bill Reese
adaa0d171b Fix for missing letters when V-carving a string.
Issue 8064 occurs when FreeCAD passes a Voronoi diagram to
Boost that becomes self-intersecting when Boost truncates the
diagram's coordinates to integers.  This occurs when the discretizer
slightly misses closing the polygon generated for the letter by less
that FreeCAD's epsilon, then the wrapping Python code closes the
polygon by adding the initial polygon point as the final point.
This creates a short segment that, depending on the position of
the letter in the coordinate system, may end up being moved one
Boost coordinate delta away from the intended point, which can
end up self-intersecting.
Since the miss is very small, FreeCAD should treat it as it it
were the initial point.  There's no need for a duplicate copy of
the initial point, so we remove this point close to the initial
point and let insert_many_wires() close the polygon as usual.
2024-01-13 12:41:26 -05:00
Paddle
5ee16df6b7 Draw arc helpers for radius constraints. 2024-01-12 19:03:38 -06:00
Paddle
827781ab3f Improve angle constraint rendering. 2024-01-12 19:03:38 -06:00
Syres916
a0331f2c80 [PartDesign] Revert #11357
See https://github.com/FreeCAD/FreeCAD/issues/11961#issuecomment-1889721739
2024-01-12 18:37:24 -06:00
Chris Hennes
5088c63935 Part/Toponaming: Modify constructors to set owner of ShapeProtector 2024-01-12 10:00:45 -06:00
Pesc0
a74c6b3391 Part/Toponaming: Pesc0's work replacing ShapeProtector
In realthunder's original version this class was not derived from TopoDS_Shape, but rather duplicated
its interface and wrapped its non-const methods. This resulted in quite a lot of boilerplate, so in
the merged implementation we are now deriving from TopoDS_Shape and only overriding the non-const
methods. The downside is that if OCCT adds or changes methods we will have to add them proactively
to this class so that they don't bypass the TNP code.
2024-01-12 09:57:33 -06:00
wandererfan
3ba0c3d795 [TD]fix missing \ in regex 2024-01-12 09:23:38 -05:00
wandererfan
ff2cea3008 [TD]fix Dimension icons 2024-01-12 09:23:38 -05:00
wandererfan
158ef7ee8f [TD]Revert detail to piecewise algo 2024-01-11 18:24:51 -05:00
Kevin Martin
d52cf81bce Move the "Treat ellipses and splines as polylines" to DXF *output* options
This option control DXF export but was confusingly in the Import options area. Fixes #11659
2024-01-11 15:58:26 +01:00
Roy-043
35f10ad5a5 Draft: remove reapply_diffuse_color workaround
The function would trigger the creation of duplicate Draft Polar Arrays (only on Linux and only if the Fuse option is selected and the Link Array option deselected).
Forum topic:
https://forum.freecad.org/viewtopic.php?t=84090

The reapply_diffuse_color function is no longer required anyway as Issue #8340 has been fixed.
2024-01-10 16:46:49 +01:00
wwmayer
d3049deaa9 PD: Add test for helix (#11601)
Co-authored-by: Chris Hennes <chennes@pioneerlibrarysystem.org>
2024-01-10 07:26:18 -06:00
bgbsww
8abd09398a Add support for OCCT 7.8.0 (#11909) 2024-01-09 19:47:25 -06:00
pre-commit-ci[bot]
a930658000 [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
2024-01-09 20:07:57 -05:00
wandererfan
e42e9a4096 [Import]Flatten sketch before dxf export. 2024-01-09 20:07:57 -05:00
sliptonic
00e3980090 Merge pull request #11927 from bdieterm/fix-path-profile
Path: fix wire midpoint calculation
2024-01-08 14:00:03 -06:00
Max Wilfinger
476089a2ad sketcher: create contextual right click menu 2024-01-08 12:39:17 -05:00
sliptonic
5ba5e798bf Merge pull request #11933 from adrianinsaval/gitignore
Update .gitignore and remove unused file in FEM
2024-01-08 11:33:20 -06:00
sliptonic
ca7b867ae3 Merge pull request #11840 from maxwxyz/precise-toggle-command-description
Change the description of the default 'Toggle active object' command
2024-01-08 11:29:01 -06:00
Ajinkya Dahale
56278633ce [PD] Fix reference axis selection in revolve/groove
Fixes #11713.
2024-01-08 14:19:57 -03:00
Kevin Martin
2c0bc89f62 Streamline scaling for DXF import
Eliminate m_measurement_inch to clean up logic for priority of MEASUREMENT and INSUNITS.
Save the actual scaling factor rather than the scaling enum so a switch statement is not executed for each call to mm()
Add to CDxfRead the work to handle dxfScaling option, ImpExpDxfRead just has to set it up now.
Get the scaling factor from a lookup table rather than a switch statement
Display a message explaining what the scaling factor is and where it comes from
Remove large amount of Lint.
2024-01-08 18:01:21 +01:00
Syres916
8cadc2294d [PartDesign] Hole, ignore duplicate circle/curve centers (#11773)
* [PartDesign] Hole, ignore duplicate circle/curve centers

* [PartDesign] Hole correct log output

* [PartDesign] Hole changes based on feedback
2024-01-08 13:55:16 -03:00
Alexander Neumann
d51d2f674f Remove code related to qtxmlpatterns (#11755) 2024-01-08 13:49:38 -03:00
sliptonic
07c664665b Merge pull request #11750 from realthunder/FixActiveBody
Fix object path in active object when creating new body in App::Part
2024-01-08 10:47:45 -06:00
bgbsww
bf3ccbc5b6 Correct mistaken Helix patch; use MakePipe for frenet for speed; add tests (#11598)
* Cleanup and switch to using MakePipe

* Cleanup unused include

* Use Frenet mode in building pipe

* Restore original code, add a control property

* Hide property, and init on new objects

* Restore prior behavior for legacy objects

* Clean up git blame; add missing move to keep helix same with new makePipe call

* Remove debug include

* Use doxygen syntax for deprecation comment

* Add unit tests; restore code for angled helixes; optimize zero angle helixes

* Lower test precision to accept platform variations

* Loosen more

* Correct restoration

* Tweak test volumes to match restored helix creation

* Restore helix generation parameter

* Fix test; delint
2024-01-08 13:43:38 -03:00
Adrian Insaurralde Avalos
a770971f58 FEM: remove unused file 2024-01-08 11:34:56 -03:00
Roy-043
b6b9314d7a Arch: Improve selection of cutting object for Arch_CutPlane
This PR makes the selection of the cutting object more flexible. It can be a face, an edge or an object with a single subelement of that type. Any planar object can also be selected. This PR makes the Arch_CutLine command superfluous. It was therefore removed.
2024-01-08 10:58:30 +01:00
paullee
8c3696adec [ArchWall] Fix getExtrusionData() with DraftWire base problem
See discussion on FreeCAD forum :
- https://forum.freecad.org/viewtopic.php?p=727868#p727868
( How to use the partdesign_subshapebinder for walls / Walls on "3d sketch"? )
2024-01-08 10:56:41 +01:00
Roy-043
57fbbb17cf Arch: Arch_Window fix and improve handling of hosts
Fixes a problem introduced with a previous PR of mine (#7591). Hosts would only be touched if that property of the window was modified. But the hosts of a window should also update if other properties of the window change.

Additionally a width or height change of a window now touches the hosts on the subsequent shape change.
2024-01-08 10:53:20 +01:00
Roy-043
28f2214c3a Arch: Arch_Project avoid ghosts of objects in Group 2024-01-08 10:52:15 +01:00
Roy-043
b9f5b1ae32 Arch: Arch_Window: wrong value for Frame property
The Frame property controls the extrusion of the window components. It should receive the w2 instead of the h1 value.
2024-01-08 10:33:44 +01:00
Paddle
9bb9eb8b21 Sketcher_dimension : Fixes https://github.com/FreeCAD/FreeCAD/issues/11904 2024-01-07 20:53:22 -06:00
bdieterm
0d662251d2 Path: fix wire midpoint calculation 2024-01-07 21:23:13 +01:00
Chris Hennes
108ea5d521 Merge pull request #11786 from Syres916/PD_Fix_Combobox_Issue
[PartDesign] Sprocket fix bug with translated references
2024-01-06 18:31:18 -06:00
bgbsww
365c5f4777 Detect circular references in sketches, and add corresponding tests (#11716)
* Possible fix for 10482 circular reference regression with tests

* Remove redundant test

* Cleanup pre PR

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2024-01-06 18:13:44 -06:00