Commit Graph

1705 Commits

Author SHA1 Message Date
0penBrain
82931b4368 Fix bad 'pt' unit definition
'pt' unit has been defined as 1.25 px while it is 4/3 px (~1.33 px).
Relates to issue #4200
Relates to Syres916@469e01d (despite bug always existed, even before this commit)
Source : https://oreillymedia.github.io/Using_SVG/guide/units.html
2019-11-29 14:52:29 +01:00
vocx-fc
1987ecabdd Draft: PySide should be available already 2019-11-21 16:35:29 +01:00
vocx-fc
6626b52b5f Draft: rename SubelementModify to SubelementHighlight 2019-11-11 18:04:10 -03:00
carlopav
54f59edff1 [Draft] Edit: allow multiple objects editing
Allow editing of multiple objects at once.
2019-11-11 18:00:02 -03:00
carlopav
e3d8da2cf1 [Draft] Edit: fix bug #4187
Fix bug #4187. When canceling a Dwire editing session with the Esc key or the "close" button Dwire editing breaks.
2019-11-11 17:59:08 -03:00
vocx-fc
7bd3dc7b72 Draft: TestDraft, refactor unit tests, 66 in total.
Only 50 test are really performed.

Some tests are not fully implemented, for example, arc_3points, dimension_radial,
shapestring, trim, extend, and stretch. The reason is that there are no proper
functions to test.
In order to have a unit test, basic functions that perform these actions
must be written inside Draft.py. At the moment, these tests just
run a _fake_function() which always returns successfully
and thus the test always passes without problem.

There are also tests for the import and export
of SVG, DXF, DWG, and OCA files. Currently these are also not implemented.
Sample files could be provided in the source tree in order to test basic operations
like opening, import, and export.
A complete unit test would require writing a test for each geometrical element
that could be imported and exported, that is, line, circle, arc, rectangle, etc.

These tests are inspired by the tests in the FEM workbench.
Import of modules is tested, as well as the creation and modification tools.
Eventually, the tests should be migrated to individual modules,
and test files should be provided to serve as reference.
2019-11-05 09:29:25 -03:00
vocx-fc
6f98a20c03 Draft: fix double translation in Draft._PointArray 2019-10-25 10:55:19 -03:00
vocx-fc
28831b4c78 Draft: set the Autoconstraint view property only if the interface is up (FreeCAD.GuiUp) 2019-10-25 10:54:31 -03:00
vocx-fc
10cb6835a3 Draft: change DisplayMode only if the interface is up (FreeCAD.GuiUp) 2019-10-25 10:54:31 -03:00
luz.paz
690209ae5a Draft: whitespace fix [skip-ci] 2019-10-25 10:25:31 -03:00
luz.paz
e804698edc Draft: use string operator instead of numeric LGTM fix 2019-10-25 10:25:31 -03:00
luz.paz
ef95ac7d46 Draft: DraftEdit.py use string operator instead of numeric LGTM fix [skip ci] 2019-10-25 10:25:31 -03:00
luz.paz
5c5fa07c10 Draft: Draft.py missing translate() context LGTM fixes [skip ci] 2019-10-25 10:25:31 -03:00
luz.paz
30a717beac Fix typos and misc. formatting [skip ci]
Found via `codespell -q 3 -L aci,ake,aline,alle,alledges,alocation,als,ang,anid,ba,beginn,behaviour,bloaded,byteorder,calculater,cancelled,cancelling,cas,cascade,centimetre,childs,colour,colours,commen,currenty,dof,doubleclick,dum,eiter,elemente,feld,freez,hist,iff,indicies,initialisation,initialise,initialised,initialises,initialisiert,ist,kilometre,lod,mantatory,methode,metres,millimetre,modell,nd,noe,normale,normaly,nto,numer,oder,orgin,orginx,orginy,ot,pard,pres,programm,que,recurrance,rougly,seperator,serie,sinc,strack,substraction,te,thist,thru,tread,uint,unter,vertexes,wallthickness,whitespaces -S ./.git,*.po,*.ts,./ChangeLog.txt,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/CXX,./src/zipios++,./src/Base/swig*,./src/Mod/Robot/App/kdl_cp,./src/Mod/Import/App/SCL,./src/WindowsInstaller,./src/Doc/FreeCAD.uml`
2019-10-21 16:02:23 -03:00
carlopav
5783027945 [Draft] Edit: pick radius according to user preferences (issue #4162)
Reference tracker issue #4162 https://freecadweb.org/tracker/view.php?id=4162
Reference topic. https://forum.freecadweb.org/viewtopic.php?f=23&t=40060.
Changed ui file to insert edit preferences (at the moment inside draft and grid, for the affinity with snap). Created a new draft preference: DraftEditPickRadius.
2019-10-21 16:00:36 -03:00
Yorik van Havre
7c556b5daa Removed tabs 2019-10-21 15:58:44 -03:00
paullee0
f1219d5e7f [Draft - DraftGeoUtils] Refine isReallyClosed() : Part of ArchWall / DraftGeomUtils Multi-Width Support Improvement Proposal 2019-10-21 15:58:44 -03:00
vocx-fc
8c2ff4ca8a Draft: clone icon with the light comming from above left 2019-10-17 17:44:19 -03:00
carlopav
f3a4dda5b3 [Draft] Edit: preview node with mouseover
Preview editing nodes with mouse move.
Modified edit trackers to store in self.color the value. Also added a method to it to set color.
2019-10-17 17:43:57 -03:00
Yorik van Havre
50a8c070b7 Draft: Fixed non-appearing texts in TechDraw views + support for ShowLine property 2019-10-17 15:33:59 -03:00
vocx-fc
ac0e74b220 Draft: DraftGui, use boolean values to set up an option instead of numeric values 1 and 0 2019-10-14 16:45:33 -03:00
Syres916
15c6b01237 [Draft] ShapeString Task Panel Allow Windows...
....Users to view Font Files without the need to modify permissions on the Fonts folder. Also keeping the rest of FreeCAD file dialog boxes as standard.
2019-10-11 19:11:12 -04:00
vocx-fc
b9a6c0dd2b Draft: renamed the command Draft_Edit_Improved to Draft_SubelementModify because the previous name was confusing; also provide a new icon 2019-10-10 19:13:28 -03:00
Yorik van Havre
60d843b2c1 Draft: Added property to hide lines in dimensions 2019-10-08 17:19:13 -03:00
Yorik van Havre
144df82f14 Draft: Better fix of copy mode 2019-10-08 16:32:23 -03:00
vocx-fc
ac66a65cb2 Draft: added missing file Draft_Dimension_Tree.svg 2019-10-08 08:54:40 +02:00
Yorik van Havre
f6d4c06ce9 Draft: Fixed copying of windows 2019-10-07 15:46:16 -03:00
M G Berberich
4f13d25933 Draft circular array
Adds a circular array case to the Draft Array.

Parameters are: radial and tangential distance, number of circles,
symmetry-axes, axis and center of rotation.

see https://forum.freecadweb.org/viewtopic.php?f=13&t=39726 (german)
2019-10-07 13:53:10 -03:00
M G Berberich
fcb021a4dd Circular Array
ciruclar array for Draft workbench
2019-10-07 13:53:10 -03:00
Syres916
8d11ced84b [Draft] Wire To BSpline fix to show new object
Discussion https://forum.freecadweb.org/viewtopic.php?f=8&t=39466
2019-10-07 13:45:25 -03:00
vocx-fc
7a655c25de Draft: DraftTools, place the CubicBezCurve tool before the BezCurve, as the cubic curve is more used. 2019-10-07 13:45:01 -03:00
vocx-fc
e731d08c38 Draft, makeBezCurve(), changed parameter Degree to degree, preferred lowercase 2019-10-07 13:44:25 -03:00
Francesco Fantoni
eeae3457c4 removed trailing whitespace 2019-10-07 11:26:16 -03:00
Francesco
1da10e84af fixes issue aligning workplane to a face
this is a quick workaround for a problem introduced in the Draft select plane procedure while refactoring the code. not sure it is the best fix though.
2019-10-07 11:26:16 -03:00
Zheng, Lei
694cfc202e Draft: relax Part::Feature type checking for Link support
Replace isDerivedFrom('Part::Feature') with hasattr(obj,'Shape')
2019-10-07 10:48:42 -03:00
vocx-fc
2aa14761d2 Draft: modify the permissions of the icons (755), so that they don't have the execute permission (644) 2019-10-07 14:18:52 +02:00
vocx-fc
f55059cedf Draft: new icon for Draft_Dimension in the tree view in SVG, instead of XPM 2019-10-07 14:17:17 +02:00
vocx-fc
ec0d50459c Draft: re-order alphabetically the resources in Draft.qrc to be easier to spot missing files 2019-10-07 14:17:08 +02:00
luz.paz
fb32601746 Fix various (doxy) typos and whitespace issues
Found via `codespell -q 3 -L aci,ake,aline,alle,alledges,alocation,als,ang,anid,ba,beginn,behaviour,bloaded,byteorder,calculater,cancelled,cancelling,cas,cascade,centimetre,childs,colour,colours,commen,currenty,dof,doubleclick,dum,eiter,elemente,feld,freez,hist,iff,indicies,initialisation,initialise,initialised,initialises,initialisiert,ist,kilometre,lod,mantatory,methode,metres,millimetre,modell,nd,noe,normale,normaly,nto,numer,oder,orgin,orginx,orginy,ot,pard,pres,programm,que,recurrance,rougly,seperator,serie,sinc,strack,substraction,te,thist,thru,tread,uint,unter,vertexes,wallthickness,whitespaces -S ./.git,*.po,*.ts,./ChangeLog.txt,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/CXX,./src/zipios++,./src/Base/swig*,./src/Mod/Robot/App/kdl_cp,./src/Mod/Import/App/SCL,./src/WindowsInstaller,./src/Doc/FreeCAD.uml`
2019-10-03 07:57:13 +02:00
luz.paz
daf96d29fd Draft: DraftEdit.py now gets PickRadius from user preferences
...instead of being hardcoded.  
Note: PickRadius is the proximity in pixels for picking elements in the 3D view  
Forum thread: https://forum.freecadweb.org/viewtopic.php?f=10&t=39203
2019-09-28 12:49:33 +02:00
luz.paz
5807e0b531 Fix typos, grammar, and some whitespace issues
Found via `codespell -q 2 -L aci,ake,aline,alle,alledges,alocation,als,ang,anid,ba,beginn,behaviour,bloaded,byteorder,calculater,cancelled,cancelling,cas,cascade,centimetre,childs,colour,colours,commen,currenty,dof,doubleclick,dum,eiter,elemente,feld,freez,hist,iff,indicies,initialisation,initialise,initialised,initialises,initialisiert,ist,kilometre,lod,mantatory,methode,metres,millimetre,modell,nd,noe,normale,normaly,nto,numer,oder,orgin,orginx,orginy,ot,pard,pres,programm,que,recurrance,rougly,seperator,serie,sinc,strack,substraction,te,thist,thru,tread,uint,unter,vertexes,wallthickness,whitespaces -S ./.git,*.po,*.ts,./ChangeLog.txt,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/CXX,./src/zipios++,./src/Base/swig*,./src/Mod/Robot/App/kdl_cp,./src/Mod/Import/App/SCL,./src/WindowsInstaller,./src/Doc/FreeCAD.uml`
2019-09-07 11:58:38 -04:00
vocx-fc
48aa182287 Draft: DraftLayer, provide Draft_Layer.svg icon, and use it instead of Draft_VisGroup.svg, even if it's the same to be consistent in the naming 2019-09-06 12:08:11 -03:00
Yorik van Havre
2463c2a7d5 Draft: Allow to set a default camera height 2019-09-05 20:50:29 -03:00
vocx-fc
c68c63599a Draft: importDXF, improved coding style, so it is closer to PEP8; spaces around commas and operators, and shorter lines (80 characters max) 2019-09-05 11:29:36 -03:00
vocx-fc
ee2b8c8f52 Draft: DraftFillet clarified comment 2019-09-04 23:14:55 -03:00
vocx-fc
212a5b3291 Draft: DraftFillet, added option for turning the fillet into a chamfer, as the DraftGeomUtil.fillet() function supports it 2019-09-04 23:14:55 -03:00
vocx-fc
1c69298dff Draft: DraftFillet, provide module docstring and Doxygen documentation marks 2019-09-04 23:14:55 -03:00
vocx-fc
eddbfc1e7d Draft: DraftFillet, improved the tool, now the radius of the tool can be selected when launched; the tool should work without needing to import DraftFillet manually 2019-09-04 23:14:55 -03:00
vocx-fc
f29765ff7b Draft: importDXF, added docstrings to every function 2019-09-04 11:30:48 -03:00
Yorik van Havre
90b5f63bc2 Draft: Show info message if an object cannot be scaled 2019-09-03 11:55:07 -03:00