kindred/create
1
1
Fork 0
Code Issues 30 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity
23,565 Commits 41 Branches 6 Tags
82ec99dbc1f0f054748059ae8bb138eb44b43073
Commit Graph

1425 Commits

Author SHA1 Message Date
donovaly
82ec99dbc1 [TD] fix regression for balloon text separators 
as reported here: https://forum.freecadweb.org/viewtopic.php?f=35&t=53664 the balloon text separation no longer works.

The regression was introduced by commit 05577c267 . The mistake thereby was that the textHeight is already handled before the separators and that rectangular balloons behave differently because of the separator feature.
 2020-12-30 23:59:15 +01:00
donovaly
bd1f06cf72 [TD] cleanup preferences 
as discussed here: https://forum.freecadweb.org/viewtopic.php?f=35&t=53680&p=461356#p461349

* change default tolerance scale to 0.8
* the tolerance scale is directly applied, thus it must have non-italic label
* move tolerance scale to "Dimensions" tab
* move Fuzz settings to "Advanced" tab
* move Conventions to General tab since e.g. the projection angle is an important general setting
* add a note for the label font that this is also used for dimensions and that it there only has an effect for new ones
* use more useful step size of 0.1 for some scaling spinboxes
* sort UI fields in the C++ code to avoid doubled or missing entries (there were 2 doubled entries)
* uniform width of all preferences dialogs
* better alignment for the HLR dialog
 2020-12-30 20:22:27 +01:00
Aapo
079b8ff5c3 [TD] DrawViewDimension Tolerances, print zero tolerances without plus sign and decimals. 2020-12-30 18:49:59 +01:00
donovaly
30fcddae40 [TD] fix bug with angular and small values 
* angular as reported here: https://forum.freecadweb.org/viewtopic.php?f=35&t=53473&start=10#p461507
* small values: since we convert to e.g. mm, we must then not output e.g. 'µm'
* also a code optimization, fix a typo, removal of a meanwhile misleading comment
 2020-12-30 16:20:27 +01:00
wmayer
0f31c87cc9 Boost: [skip ci] Fix build warnings from deprecated Boost headers (v1.75) 2020-12-29 15:34:25 +01:00
Mateusz Skowroński
2559f2d29c Fix build warnings from deprecated Boost headers (they are used internally by Boost). Thanks @wwmayer for the hint. 2020-12-29 10:20:53 +01:00
Yorik van Havre
5a322d75cb Merged crowdin translations 2020-12-23 15:13:05 +01:00
Yorik van Havre
5a974f824c Updated ts files 2020-12-23 14:51:04 +01:00
Yorik van Havre
a891c04229 Merge pull request #4175 from donovaly/TD-unit-dimension-fix 
[TD] fix unit conversion for dimensions
 2020-12-23 14:10:04 +01:00
Aapo
07211b0fb1 [TD] ShapeExtractor.cpp: Avoid processing infinite-sized shapes (Datum objects etc). 2020-12-22 17:46:19 +01:00
donovaly
7dea668381 [TD] fix unit conversion for dimensions 
as reported here: https://forum.freecadweb.org/viewtopic.php?f=35&t=53473
my commit cbcf45a4b9 introduced a regression because now units are no longer converted when the unit is displayed.

This PR fixes this.
 2020-12-21 01:27:41 +01:00
Aapo
8462fc1842 [TD] Balloon, fix Origin and scale refresh bugs, make Balloon scale change more reasonable per UI click. 2020-12-18 12:45:34 +01:00
Aapo
3038633069 [TD] Balloon, fix EndTypeScale refresh bug. 2020-12-18 12:45:34 +01:00
Aapo
f3bce14f29 [TD] Balloon, move property LineVisible to View tab and fix a refresh bug. 2020-12-18 12:45:34 +01:00
Aapo
b41cf98583 [TD] Balloon, change ordering of the data properties to more logical. 2020-12-18 12:45:34 +01:00
Aapo
97e3947948 [TD] Make Dimension Tolerances respect the Prefs formatSpec when creating a Dimension. 2020-12-17 17:30:29 +01:00
Yorik van Havre
0e556a082b Merge pull request #4121 from everlanes/TechDraw_Segfault 
[TD] Check return value of getMDIViewPage() a second time
 2020-12-14 12:43:28 +01:00
Yorik van Havre
cbcf45a4b9 Merge pull request #4109 from donovaly/TD-dimensioning-fix 
[TD] treat dimensions the same way, no matter if with unit or not
 2020-12-14 12:08:46 +01:00
Yorik van Havre
46a6ea3351 Merge pull request #4069 from aapo-aapo/TD-Balloon-improvements 
[TD] TechDraw Balloon improvements with two new App::PropertyType properties
 2020-12-14 11:56:08 +01:00
wmayer
aec9d5f07a Py: fix memory leaks by incorrect use of PyList_Append 2020-12-13 16:30:04 +01:00
Chris Hennes
ea3ecf4054 Silence Qt/Windows setGeometry Warning 
Add the optional Qt::MSWindowsFixedSizeDialogHint parameter to all uses of the QInputDialog::getX static functions to silence a Qt/Windows debug mode warning about QWindowsWindow::setGeometry: Unable to set geometry. Increase the size of the unit calculator to eliminate the same warning. Finally, call adjustSize() on the "Unsaved Changes" dialog to silence the warning.
 2020-12-11 09:58:09 +01:00
Andreas Brinner
a6e29e32ae Check return value of getMDIViewPage() a second time 
When exporting a hidden TechDraw::Page with exportPageAs[Pdf|SVG] a
Segmentation Fault occured.

The return value of getMDIViewPage() was only checked for the first call, but
not for the second call. showMDIViewPage() silently returns, when the
TechDraw::Page is hidden and does not load the page.
 2020-12-09 11:21:59 +01:00
Aapo
3d85114f09 [TD] Add a comment about QGIViewBalloon.cpp draw() function needing refactoring. 2020-12-07 23:48:28 +02:00
Aapo
c39ede3b5f [TD] Add Balloon property LineVisible for making the Balloon line visible or hidden. 2020-12-07 23:40:12 +02:00
Aapo
438169b335 [TD] Add Balloon property EndTypeScale for scaling line end decorations (arrows etc). 2020-12-07 23:40:12 +02:00
donovaly
38734f4f86 [TD] treat dimensions the same way, no matter if with unit or not 
fixes the issue reported here: https://forum.freecadweb.org/viewtopic.php?f=35&t=52545&start=40#p454483
 2020-12-05 03:58:39 +01:00
Aapo
72d003f102 [TD] Make DrawViewSpreadSheet respect DrawPage::redrawCommand() update mechanism. 2020-12-05 00:50:20 +02:00
Aapo
6803af4dc4 [TD] Fix column index range checking bug in std::string DrawViewSpreadsheet::getSheetImage(void) 2020-12-05 00:50:19 +02:00
Mark O'Donovan
bc3f90663e Remove unused variable in DrawViewDimension.cpp 2020-12-04 17:13:56 +01:00
donovaly
e09d52500f [TD] uniform wording 
in other/existing elements of line width we speak of "width", so do the same for line groups
 2020-12-04 13:56:38 +01:00
Aapo
dadac36234 [TD] GQIViedDimension.cpp, GQCustomText.cpp - Fix Dimension label unit positioning bug and too tight bounding rectangle. 2020-12-03 21:31:01 +01:00
donovaly
a1915d313a [TD] make LineGroup selectable 
At the moment one has to specify the LineGroup as string. But one doesn't know what groups exist. So one has to check the Wiki, learn there where the groups are defined and then open the definition file with a text editor.

This PR simplifies this by reading the existing groups out of the definition file and fill the combobox accordingly.
It also give the user info what the selected LineGroup defines via the tooltip.

A nice side effect is that no typos can occur since you don't have to enter the LineGroup name as text.
 2020-12-03 17:24:49 +01:00
donovaly
8fe7ca0c21 tolerances can be negative, thus the decimal precision check must be adapted 2020-12-03 15:50:06 +01:00
donovaly
0baabcaa45 [TD] fix unit mismatch bug 
- also make global decimal option italic since it only affects new dimensions
- also fix a typo in UnitsApi.h
 2020-12-03 15:50:06 +01:00
wmayer
578e4aca14 [TD] add an enum to avoid to work with plain numbers 2020-12-02 16:42:21 +01:00
wmayer
e95b3167dd [TD] use PropertyQuantity for OverTolerance and UnderTolerance and add backward compatibility 2020-12-02 16:42:10 +01:00
aapo-aapo
e71b7ac879 @aapo-aapo @chennes [TD] Suggested minor improvements for DrawViewDimension.cpp and QGIViewDimension.cpp in Pull request review. 
Co-authored-by: Chris Hennes <chennes@pioneerlibrarysystem.org>
 2020-12-02 16:38:21 +01:00
Aapo
3f623576d5 [TD] Add tolerance format specifiers and arbitrary tolerances. 2020-12-02 16:38:21 +01:00
Aapo
768a2b1f11 [TD] Make tolerance labels use the same formatValue() conversion as dimension labels. Support MultiValueSchemas for tolerances, too. 2020-12-02 16:38:21 +01:00
Aapo
c695b4009b [TD] Refactor DrawViewDimension getFormatedValue() into two functions. 2020-12-02 16:38:21 +01:00
luz paz
2befcd9502 TD: Issue #0004473: Expose openCommand() to translation 
Continuing the work to expose the undo/redo functionality to translation. This commit does so for the TechDraw Wb.  
Ticket: https://tracker.freecadweb.org/view.php?id=4473
 2020-12-01 14:53:35 +01:00
wmayer
d6a1bd014f TechDraw: [skip ci] fix -Winconsistent-missing-override 2020-12-01 14:45:26 +01:00
Aapo
4e06414552 [TD] Add comments and more transparent tolerance position adjustment calculation. 2020-12-01 14:37:39 +01:00
aapo-aapo
4ed3c99e3e Update src/Mod/TechDraw/Gui/QGCustomText.cpp by compacting boundingRect() 
Co-authored-by: Chris Hennes <chennes@pioneerlibrarysystem.org>
 2020-12-01 14:37:39 +01:00
Aapo
f2e91ec488 [TD] Make dimension number graphical layout more compact by making boundingRect() tighter for dimension number labels. 2020-12-01 14:37:39 +01:00
Aapo
31d6c7528d Refactor code in DrawViewDimension::getRefType() shorter and simpler. No functional change except subelement sizes > 3 are supported, even though they are not supposed to happen. 2020-11-19 13:40:42 +01:00
Aapo
bda3e700fa [TD]fix V2E DistanceX,Y to always use the closest point of edge to the vertex. 2020-11-18 14:54:44 +01:00
luz paz
2cfd04d17c TechDraw: minor cosmetic readability change in Gui/Workbench.cpp 
[skip ci]
 2020-11-16 14:52:42 +01:00
luz paz
a3cb87b117 TechDraw: Header uniformity and whitespace fixes 2020-11-14 16:59:51 +01:00
Yorik van Havre
e76c857036 Merged crowdin translations 2020-11-10 14:58:06 +01:00