Commit Graph

1619 Commits

Author SHA1 Message Date
M G Berberich
82f1f5cc2b PartDesign Pad UI-fix
hide the custom direction fields if no custom direction is used, to
unclutter the UI.
2021-08-16 19:38:05 +02:00
Yorik van Havre
163075b3ba Merge pull request #4967 from Syres916/patch-30
[Base/Gui] Bugfix Property Item formatting
2021-08-16 14:34:41 +02:00
luzpaz
2a900b1850 [PartDesign] Expose WizardShaft/ strings to translation (#4964)
* [PartDesign] Expose WizardShaft/ strings to translation

* Correct use of double quotes

* [PD] Suggested changes in `Crowdin/pd-wizard-shaft` (#4)

* [PartDesign] Use correct method name in `WizardShaft`

Use `QtCore.QT_TRANSLATE_NOOP` instead of `QT_TRANSLATE_NOOP` because latter is
not what is imported.

* [PartDesign] Remove undesired translations in `WizardShaftTable.py`

See comments by @chennes on PR#4964.

Co-authored-by: Ajinkya Dahale <AjinkyaDahale@users.noreply.github.com>
2021-08-13 18:16:42 -05:00
Syres916
f3c2622468 [PD] Gui - Primitives change Base Quantity Format 2021-08-12 10:48:36 +01:00
luzpaz
b0b4b321cb [PartDesign] Linting and cleaning superfluous whitespace (#4851)
* [PartDesign] Linted Mod/PartDesign/Scripts for pep8 compliance

* [PartDesign] Fix superfluous whitespace in WizardShaft/

* Added spaces per @chennes's feedback
2021-08-11 15:02:58 -05:00
luz paz
eab17ddff5 Fix various typos 2021-07-31 09:46:50 +02:00
Yorik van Havre
1cee70cd62 Merged crowdin translations 2021-07-08 16:06:38 +02:00
Yorik van Havre
ed9dca288c Merged crowdin translations 2021-07-01 13:56:25 +02:00
Yorik van Havre
c8b5d8d762 Merged crowdin translations 2021-06-24 17:22:19 +02:00
Yorik van Havre
aa862254dd Updated ts files 2021-06-24 17:18:01 +02:00
Yorik van Havre
c46036a1b8 Merge pull request #4850 from luzpaz/crowdin/PD-fixes
[PartDesign] Translation fixes for reported issues in FreeCAD-translations
2021-06-22 12:41:49 +02:00
Yorik van Havre
69b084f492 Merged crowdin translations 2021-06-17 16:04:02 +02:00
luz paz
56ce278abf Fix typos
Found via `codespell -q 3 -L aci,ake,aline,alle,alledges,alocation,als,ang,anid,apoints,ba,beginn,behaviour,bloaded,bottome,byteorder,calculater,cancelled,cancelling,cas,cascade,centimetre,childs,colour,colours,commen,connexion,currenty,dof,doubleclick,dum,eiter,elemente,ende,feld,finde,findf,freez,hist,iff,indicies,initialisation,initialise,initialised,initialises,initialisiert,inout,ist,kilometre,lod,mantatory,methode,metres,millimetre,modell,nd,noe,normale,normaly,nto,numer,oder,ontop,orgin,orginx,orginy,ot,pard,parms,pres,programm,que,recurrance,rougly,seperator,serie,sinc,strack,substraction,te,thist,thru,tread,uint,unter,vertexes,wallthickness,whitespaces -S ./.git,*.po,*.ts,./ChangeLog.txt,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/CXX,./src/zipios++,./src/Base/swig*,./src/Mod/Robot/App/kdl_cp,./src/Mod/Import/App/SCL,./src/WindowsInstaller,./src/Doc/FreeCAD.uml,./build/doc/SourceDocu`
2021-06-17 08:02:57 +02:00
Yorik van Havre
4a9963a03f Merged crowdin translations 2021-06-10 12:24:24 +02:00
luz paz
9a9a6f6563 [PartDesign] Rearrange translations as they appear in the GUI 2021-06-09 21:59:26 -04:00
luz paz
c418f121b8 [PartDesign] Expose items in PartDesign dropdown to translation
Fixes https://github.com/FreeCAD/FreeCAD-translations/issues/3
2021-06-09 21:59:26 -04:00
luz paz
4702d0026f [PartDesign] Add unexposed strings to be translated
Fixes https://github.com/FreeCAD/FreeCAD-translations/issues/2  
Partial fix for https://github.com/FreeCAD/FreeCAD-translations/issues/8
2021-06-09 21:59:26 -04:00
luz paz
fc26a86e07 PartDesign: tweaks to Gui/Workbench.cpp formatting 2021-06-06 15:02:58 -04:00
Yorik van Havre
fb8b21ec43 Updated ts files 2021-06-04 18:30:30 +02:00
luz paz
c61d37776f Crowdin: remove superfluous whitespace in Gui/Command.cpp
ref: https://crowdin.com/translate/freecad/564/en-de?filter=basic&value=2#6589648
2021-06-03 14:36:21 -04:00
Yorik van Havre
d0d637b2c6 merged crowdin translations 2021-06-03 15:43:34 +02:00
Yorik van Havre
b1d9a5607f Merged crowdin translations 2021-05-27 14:51:33 +02:00
Yorik van Havre
7b0a6358b1 Merged crwodin translations 2021-05-12 16:36:31 +02:00
Yorik van Havre
81a44fcccb Updated ts files 2021-05-11 13:05:20 +02:00
donovaly
b9b42a52f4 [PD] fix primitives issues
- to avoid invalid results:
 - don't allow to set equal radii for cones
 - don't allow to set equal wedge parameters
 - don't allow zero quantities like e.g. the box width

- use full internal precision because it must be possible to create an e.g. 23.5 um wide box and using the default 2 displayed digits

- take spinbox limits from App

- add missing tooltips

- remove disturbing commented out line from Workbench.cpp

- some coding style issues fixed automatically by the MSVC IDE
2021-04-20 19:03:40 +02:00
Mateusz Skowroński
92683e1f63 Fix CMake warning: qt5_make_output_file is not part of the official API, and might be removed in Qt 6. 2021-04-19 15:10:53 +02:00
donovaly
9d95887dcb [PD] [skip ci] fix sprocket icon
in the Wiki it is displayed wrong because e.g. Firefox cannot handle the strange code inside the SVG
2021-04-14 15:20:49 +02:00
wmayer
d504c12517 PD: [skip ci] fixes -Wreturn-std-move 2021-04-13 18:55:18 +02:00
donovaly
3a36602ae8 fix bug that property "SprocketReference" is not an enum 2021-04-07 17:07:01 +02:00
donovaly
cadbacb683 [PD] sort entries in sprocket feature
as the title says.

(The other UI file changes were made by Qt's designer.)
2021-04-07 17:07:01 +02:00
Syres916
476ff00360 [0.20][PartDesign] Sprocket - Correct camelCase 2021-04-06 16:40:44 +02:00
Syres916
ff88c2dbad [0.20][PartDesign] Sprocket UI - Allow multiple...
... standard reference sprockets rather than just ANSI as well as capturing the thickness as stated in the particular standard. The user is not bound by this but it saves them looking it up manually.
See recent posts in discussion : https://forum.freecadweb.org/viewtopic.php?f=22&t=44525
2021-04-06 16:40:44 +02:00
Syres916
49ecb37137 [0.20][PartDesign] Sprocket - Allow multiple...
... standard reference sprockets rather than just ANSI as well as capturing the thickness as stated in the particular standard. The user is not bound by this but it saves them looking it up manually.
See recent posts in discussion : https://forum.freecadweb.org/viewtopic.php?f=22&t=44525
2021-04-06 16:40:44 +02:00
donovaly
dff561a1b0 [PD] UI file fixes
the rotation angle settings of primitives had a different layout than the other parameters, this things like shown in the image below happened.

- The PR uniforms all layouts to grid and for the PD layout
- it sets for the cylinder page a minimum width
- the PD UI file is now also sorted using David's file sorter
- fix the mess with stdset="0"> I accidentally introduced with the merges from yesterday (I simply forgot to install to Qt designer the FreeCAD widgets and then designer pollutes the file with these tags for all FC-specific widgets since it doesn't know them
2021-04-06 13:17:43 +02:00
donovaly
7185ee93f2 [PartDesign] add direction to cylinder primitive
We already have the possibility to create skewed prisms. I recently stumbled upon that I would need this feature for cylinders too.

This PR takes the existing prism extrude direction feature and use it for cylinders too
2021-04-05 14:35:50 +02:00
wmayer
64dbe342e1 PartDesign: for Prism feature use PrismExtension 2021-04-05 13:25:36 +02:00
wmayer
05f1634276 PD: [skip ci] fixes #0004139: Macro - SubtractivePipe attached path object issues after macro executed 2021-03-29 10:43:08 +02:00
wmayer
b9da524451 PD: in setEdit() helper function make sure that recorded macro is handled as Gui command 2021-03-28 18:39:44 +02:00
wmayer
9f93bf3b3c PD: remove superfluous code block from Helix::execute 2021-03-28 13:38:53 +02:00
wmayer
ac3ce00b63 PD: replace error-prone strings with enum to handle different helix modes 2021-03-28 13:37:13 +02:00
tomate44
415034d1eb PartDesign Helix: update NbTurns in Pitch-Height-Angle mode 2021-03-28 13:13:10 +02:00
Chris Hennes
07b9cbb441 [PD] Misc. small LGTM fixes 2021-03-28 11:39:04 +02:00
Yorik van Havre
d25eeae87d Merge pull request #4630 from luzpaz/typos
Fixed misc. typos [skip ci]
2021-03-26 11:29:34 +01:00
donovaly
0a2eb2756f [PD] some fixes for the new pad length feature
- disable 2 properties when no custom direction is used
- rename a property because its name is the opposite of what it is doing
2021-03-25 17:44:30 +01:00
wmayer
b4b1cbedb1 PD: fix several issues in pad:
* pass boolean instead of int to setValue of PropertyBool
* support of symmetric option for two-length mode
* fix bug in TaskPadParameters::updateUI()
* remove strange acronyms from method names
2021-03-22 16:40:15 +01:00
donovaly
cf11f38875 [PD] add along length option for pad
- as discussed here: https://forum.freecadweb.org/viewtopic.php?f=17&t=50466&start=10#p433327
this PR is the first step for new Pad features.
It implements 3 features requested by users:
1. an option to measure the pad length along its direction if there is a custom direction
2. when there are two lengths, the reverse feature should be active
3. the pad dialog shows now always the used pad direction, no matter if it is a custom one or the sketch's normal

- Furthermore there are some code improvements (avoid rounding and blocking signals)

- Also adapt TestPad.py because its test used the case two lengths + reversed but this was not possible before this PR - the reverse option was not take into account for two lengths in FeatureSketchBased.cpp)
Now it is and therefore the test must be updated:
In the test the second sketch has the normal vector 0, -1, 0. As the reverse option is set the pad direction is 0, 1, 0. So in y direction is the length (1mm) and in -y direction is length2 (2mm). This gives together with the other pad of volume 1, a total volume of 4.

- fix UI issue: either reversed or midplane
As noticed by @chennes, when the pad uses symmetric, reversed is not sensible and vice versa.
This commit fixes the missing Gui side for the case midplane is checked and the App side.

- the PR also fix two typos
2021-03-22 16:36:04 +01:00
luz paz
a25a2200cb Fixed misc. typos [skip ci]
Found via
```
codespell -q 3 -L aci,ake,aline,alle,alledges,alocation,als,ang,anid,apoints,ba,beginn,behaviour,bloaded,byteorder,calculater,cancelled,cancelling,cas,cascade,centimetre,childs,colour,colours,commen,connexion,currenty,dof,doubleclick,dum,eiter,elemente,ende,feld,finde,findf,freez,hist,iff,indicies,initialisation,initialise,initialised,initialises,initialisiert,ist,kilometre,lod,mantatory,methode,metres,millimetre,modell,nd,noe,normale,normaly,nto,numer,oder,orgin,orginx,orginy,ot,pard,pres,programm,que,recurrance,rougly,seperator,serie,sinc,strack,substraction,te,thist,thru,tread,uint,unter,vertexes,wallthickness,whitespaces -S ./.git,*.po,*.ts,./ChangeLog.txt,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/CXX,./src/zipios++,./src/Base/swig*,./src/Mod/Robot/App/kdl_cp,./src/Mod/Import/App/SCL,./src/WindowsInstaller,./src/Doc/FreeCAD.uml,./build/doc/SourceDocu
```
2021-03-21 07:38:41 -04:00
wmayer
f55c46cc86 PD: adjust unit test for mirrored offset that doesn't fail any more 2021-03-13 14:48:16 +01:00
wmayer
ee60ccd044 PD: remove empty try/catch block 2021-03-13 14:48:16 +01:00
David Osterberg
3131b97aa8 PartDesign: Transformed. Fix regression in preview 2021-03-13 14:48:16 +01:00