Commit Graph

165 Commits

Author SHA1 Message Date
wmayer
84280330aa print warning also in release mode if an object is still touched after recompute 2018-10-07 22:09:44 +02:00
wmayer
93d9f16588 in topologicalSort check for valid iterator 2018-10-04 00:33:19 +02:00
wmayer
93f06f8256 fixes 0003410: 0.17 Regression: recompute will make parts lose color and take a longer delay compared to FC0.16 2018-10-02 19:04:44 +02:00
wmayer
dfe734f3f1 fix infinite recursion when creating dependency graph with loops 2018-09-30 14:56:47 +02:00
wmayer
7fc487ae6f fixes 0003465: Groups breaking dependency graph 2018-09-26 22:21:52 +02:00
wmayer
dd492d7484 fixes 0003373: 'Save a copy' of a document with a spreadsheet mark the document as touched 2018-09-26 15:22:21 +02:00
Zheng, Lei
8548d72492 App::Document: enable saving with binary brep 2018-08-06 19:01:21 +02:00
wmayer
75a6c68185 fix possible crash when reverting a document 2018-06-09 23:22:56 +02:00
luz.paz
505488c4f9 Misc. typos
Found via `codespell`
2018-04-25 09:41:33 -03:00
Abdullah Tahiri
0517a354c3 Dependency graph crash minimum fix 2018-03-11 21:31:28 +01:00
wmayer
bb39cc783a fixes #0003323: Crash when clearing transaction list 2018-01-31 23:39:13 +01:00
wmayer
114cdc6822 0003279: Error 'invalid DAG' after deleting sketch using expressions 2018-01-31 00:27:38 +01:00
wmayer
e404cadee6 fix automatic update of dependency graph 2018-01-15 22:19:05 +01:00
wmayer
6a15a2f31e verify iterators in partialTopologicalSort to be on the safe side
currently this can cause a crash because issue 3214 is not fixed yet
See also: https://forum.freecadweb.org/viewtopic.php?f=19&t=26295
2018-01-10 22:16:39 +01:00
luz.paz
8690d870a5 Misc. typos
+ stepcode typo submitted upsream https://github.com/stepcode/stepcode/pull/372
2018-01-07 18:41:29 -02:00
Unknown
a8ecffb652 Misc. typo fixes
Various workbenches
2017-12-23 14:30:30 +01:00
wmayer
91bb7ed0c5 fixes #0003185: Recompute should work if only subgraph is cyclic 2017-12-10 17:47:09 +01:00
wmayer
c6f89e6e5d move implementation of topologicalSort to private class DocumentP and add a parameter 2017-12-10 11:04:25 +01:00
wmayer
42aa80bb74 move global function to private class DocumentP 2017-12-10 10:53:34 +01:00
Eivind Kvedalen
3b82ffff02 When we are restoring, don't set the Label on object creation as it will be restored later.
This is to avoid potential duplicate label conflicts.

This fixes issue #3280.
2017-11-30 16:28:41 +01:00
Eivind Kvedalen
2ae1313975 Moved ObjectStatusLocker template class to Base/Tools.h 2017-11-30 16:28:41 +01:00
Eivind Kvedalen
5fe7a9af71 Spreadsheet: Fix for issue #3225.
Done by adding a selector function to Document::renameObjectIdentifiers(...) to ensure
that the Spreadsheet document object is not rewritten twice.
2017-11-08 23:15:16 +01:00
wmayer
ec1bcccb82 fix crashes in dependency walker 2017-11-08 12:12:46 +01:00
wmayer
725a5b6545 method to get paths between two objects 2017-10-20 18:26:18 +02:00
wmayer
92ec59df06 fix possible dangling pointers in function to create dependency graph 2017-10-11 13:24:32 +02:00
luzpaz
ab8f8919b6 Misc. typos
+ some are doxy others are just comment code.  
+ some minor whitespace and grammatical tweaks. 
+ app/SCL/* typos have also been submitted upstream (https://github.com/stepcode/stepcode/pull/366). So it's ok to merge them in to master.
2017-10-04 17:59:11 +02:00
wmayer
09737f2db3 rename method from remObject to removeObject to be more readable 2017-09-13 18:57:38 +02:00
wmayer
9d83392a4f mark document objects with Destroy flag before deleting them and handle this in the link properties 2017-09-13 16:14:19 +02:00
wmayer
4b400fd986 rename status bit 'Delete' to 'Remove' as it fits better for its purpose, add new bit 'Destroy' 2017-09-13 15:47:48 +02:00
wmayer
82537ca863 fix access of dangling pointer (in case undo/redo is off)
use unique_ptr to delete object before leaving remoObject
2017-09-13 15:11:29 +02:00
wmayer
f92ea66903 copy check for disabled or nested recomputes from old implementation of recompute() 2017-09-09 19:11:28 +02:00
wmayer
e260f9dabd improve whitespaces 2017-09-09 18:07:46 +02:00
Stefan Tröger
283ab961b5 Ensure touched features, which override mustExecute(), are recomputed. 2017-09-09 16:55:55 +02:00
Stefan Tröger
71b7811495 Fix GeoFeatureGroup claimChildren in case some out-of-group item links to a child 2017-09-09 16:55:55 +02:00
Stefan Tröger
0439656133 Ensure that GeoFeatureGroup claims children when a parent of it is deleted. fixes #0003150 2017-09-09 16:55:55 +02:00
Stefan Tröger
0584c56777 Fix deleting a Part 2017-09-09 16:55:55 +02:00
Stefan Tröger
79bb7b7f50 DependencyGraph: show invalid links in red 2017-09-09 16:47:07 +02:00
Stefan Tröger
d0954e6e42 Allow interchangable use of link properties and their derivatives 2017-09-09 16:47:07 +02:00
Stefan Tröger
51005bb81e Fix _inList tracking in case of link removal 2017-09-09 16:47:07 +02:00
Stefan Tröger
f96c69deed Prevent cross GeoFeatureGroup links on recompute 2017-09-09 16:47:07 +02:00
Stefan Tröger
ab85c6e784 Make InList hadling and topological sort more robust. fixes #0002871 2017-09-09 16:47:07 +02:00
wmayer
a5bc70cca0 remove properties from transactions when being deleted 2017-08-28 21:20:17 +02:00
Zheng, Lei
fdce472b21 App::Document: fix breakDependency
Fixed breakDependency to handle repetitive entries inside
PropertyLinkList
2017-08-19 18:56:24 +02:00
Markus Lampert
842ea49a64 Prevent segfault if vertex map isn't set. 2017-07-29 11:58:43 +02:00
wmayer
033242ead8 protect document against nested recomputes
+ convert ObjectStatusLocker into a template class to make its usage more flexible
+ add status flag 'Recomputing' and set in Document::recompute to detect and avoid nested calls of recompute
2017-07-17 18:24:10 +02:00
wmayer
989fe4028e various fixes:
+ fix typos
+ fix const correctness
+ whitespace improvements
2017-06-19 17:18:16 +02:00
Stefan Tröger
39bf43202e Add missing header for random numbers 2017-06-19 15:37:09 +02:00
Stefan Tröger
78cb881431 DependencyGraph: Ensure OriginFeatures get in the correct subgraph 2017-06-19 15:37:09 +02:00
Stefan Tröger
eb601df236 Fix undo/redo while checking link integrity 2017-06-19 15:37:09 +02:00
Stefan Tröger
bdf981e770 Unify and fix group handling in geofeaturegroups 2017-06-19 15:37:09 +02:00