bgbsww
888391414d
Sketcher: Do not consider missing external geometry to be an error ( #16590 )
...
* Do not consider missing external geometry to be an error; highlight in conflict color.
2024-09-18 15:18:11 -05:00
Jiří Pinkava
a87701916f
Sketcher: initialize geometry history limit variable ( #16337 )
...
* Sketcher: initialize geometry history limit variable
The variable seems to be uninitialized, valgrind complais about it.
The `git grep geoHistoryLevel` and the code ispection suggest it is never set.
If initialized to zero, most of the related code is never used, which
can point to the fact there is either another bug or the code is unused.
The variable was introduced in 58a0bb40ed.
* Sketcher: Default geoHistoryLevel to 1
---------
Co-authored-by: Chris Hennes <chennes@pioneerlibrarysystem.org >
2024-09-16 17:41:12 +02:00
Chris Hennes
7831bf06d1
Merge pull request #16355 from CalligaroV/Sketcher-checkSubName-from-LS3
...
Sketcher/Toponaming: import SketchObject::checkSubName() from LS3
2024-09-12 21:11:39 -05:00
Morimiue
83c846e411
Sketcher: transfer constraints on conic's mid point to the newly created conic arc (e.g. ellipse arc)" -m "Fixes #15860 " -m "When spliting a sketch curve, constraints on the original curve are transferred to the newly created curve. The original code did not consider the constraints on the center point of an ellipse arc.
2024-09-09 18:31:13 +02:00
CalligaroV
62f9d10321
Sketcher/Toponaming: import code for SketchObject::checkSubName() from LS3
...
* applied review hints
Signed-off-by: CalligaroV <vincenzo.calligaro@gmail.com >
2024-09-08 10:39:54 +02:00
Zheng, Lei
819ae560f1
Sketcher/Toponaming: import code for SketchObject::checkSubName() from LS3
...
* import code
* add modified_item assignment in TaskSketcherElements::onSelectionChanged() like for non ExternalEdge
2024-09-07 14:08:23 +02:00
PaddleStroke
e7ff71c20c
Sketcher: addGeometry : Remove point construction limitation.
2024-09-02 18:22:51 +02:00
PaddleStroke
f763fe5bf3
Sketcher: Fillet preserving point : Make point construction.
2024-09-02 18:22:51 +02:00
bgbsww
608c80b5a3
Toponaming: Remove remaining FC_USE_TNP_FIX defines
2024-08-31 13:21:10 -05:00
bgbsww
e4a509cc77
Toponaming: Remove all FC_USE_TNP_FIX protected old code
2024-08-26 11:12:48 -05:00
bgbsww
4fd5b0b562
Toponaming: Additional element map changes to transform
2024-08-08 09:09:46 -05:00
Chris Hennes
3b33d73b7e
Sketcher: Modernize license text
2024-08-05 10:49:14 -05:00
bgbsww
6269196acf
Toponaming: use correct face maker
2024-08-02 21:55:51 -04:00
bgbsww
5f657bc1ce
Toponaming: bring in code to fix delExternal breakage.
2024-08-02 14:13:38 -05:00
bgbsww
d0abd4e5ad
Toponaming: Final piece nine of fixing Save/Restore sketch external geometry
2024-07-29 09:38:21 -05:00
wmayer
5c9d780a17
Sketch: Fix compiler warnings
...
Fix warning: -Wunused-but-set-variable
2024-07-28 11:59:51 +02:00
Chris Hennes
e290cd48e1
Sketcher/Toponaming: Further linter cleanup
2024-07-26 22:10:44 -05:00
Chris Hennes
48a37e4d1e
Sketcher/Toponaming: Minor code cleanup during review
2024-07-26 21:48:33 -05:00
bgbsww
8b25341a7f
Toponaming: Touchup cleanup
...
Includes some header re-ordering from chennes.
2024-07-26 21:39:39 -05:00
bgbsww
9f2210313d
Toponaming: Tests, cleanup, and fix axis drawing
2024-07-26 11:49:56 -04:00
Zheng, Lei
77f181a307
Toponaming: Transfer in ExportGeo and associated
2024-07-26 11:49:56 -04:00
Chris Hennes
1b4afb2caa
Apply suggestions from code review
2024-07-24 21:48:59 -05:00
bgbsww
1eda66dfd8
Cleanup, format
2024-07-24 16:41:15 -04:00
Zheng, Lei
38269241e6
Toponaming: Transfer in getHigherElement
2024-07-24 15:10:42 -04:00
Zheng, Lei
a600952665
Toponaming: Transfer in SketchObject::InternalShape
2024-07-22 17:26:52 -04:00
bgbsww
19e450a667
Refactor all element name pairs into clearer struct names - renames
2024-07-20 16:32:12 -04:00
Chris Hennes
df8315d747
Sketcher: Fix crash on recompute with points
...
Fixes #15154 .
2024-07-17 10:25:22 -04:00
Pesc0
02b2092f55
Rename variables and clean method
2024-07-15 12:50:30 -04:00
Zheng, Lei
af080ef0fe
Toponaming: Missing getSubObject code in PartDesign::Body and SketchObject::getSubObject
2024-07-15 11:59:15 -04:00
PaddleStroke
b82ecb815f
Sketcher: Fix undo of external creation not working.
2024-07-12 09:41:55 -05:00
Max Wilfinger
8ff5a1f688
Fix source string typos mentioned on Crowdin ( #15261 )
2024-07-08 17:18:31 -05:00
Chris Hennes
e371f7fb43
Merge pull request #14461 from AjinkyaDahale/sk-fix-12592-bsp-by-knot-trim
...
[Part][Sketcher] Fix some B-spline trimming issues
2024-07-01 11:28:50 -05:00
bgbsww
bdcdb630c0
Cleanup
2024-06-28 22:24:30 -04:00
bgbsww
08859462ea
Toponaming: Cleanups
2024-06-28 11:57:43 -05:00
Zheng, Lei
3dbc1d7393
Toponaming: Transfer in missing Code for BaseFeatures and Sketches
2024-06-28 11:57:43 -05:00
Ajinkya Dahale
bf649e2419
[Sketcher] Delete point-on-object on trimmed portion
...
This could cause undesirable shape change, especially in B-splines.
2024-06-24 21:56:58 +05:30
Ajinkya Dahale
ee2d324744
[Sketcher] Fix some issues with trimming splines
...
1. Transfer point-on-object to the correct resulting curve: Currently the
constraint remains on the "start" curve created after the trim.
2. Expose internal geometries of both resulting B-splines.
2024-06-24 21:56:58 +05:30
Ajinkya Dahale
1a6a7d07c2
[Sketcher] Rearrange directives to appease syntax highlight
...
Spacemacs doesn't handle the braces flow very well. This commit can be dropped
if necessary.
2024-06-24 21:56:58 +05:30
wmayer
127f935711
Fix several compiler warnings
...
* -Wmaybe-uninitialized
* -Wunused-parameter
* -Wunused-variable
* -Wnonnull
* -Wstringop-truncation
* -Wstringop-overflow
2024-06-19 21:14:23 -05:00
bgbsww
c5de6ccfc7
Toponaming: Fix crash with invalid external geometry
2024-06-17 11:31:04 -05:00
Mihail Dumitrescu
7eff7ee9d0
Fix importing arcs and elliptical arcs as external geometry.
...
Fix importing elliptical arcs issue #8700 .
Fix importing arcs into sketches in the case where they project as elliptical arcs.
Fix a discontinuity that happens when an external arc projects down to a segment. The segment end points should not jump around if the projection angle changes from 89.9 to 90 degrees.
When handling external geometry compare points for equality in a consistent way and remove some dead code.
2024-06-17 11:04:52 -05:00
mosfet80
e31aa5e5e3
[mod] clean ( #14378 )
...
* [mod] clean
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
---------
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2024-06-10 11:07:14 -05:00
wmayer
ad56548739
Sketch: Refactor SketchAnalysis
...
Refactor makeMissingEquality()
2024-05-28 14:19:58 +02:00
wmayer
b052470b93
Sketch: Refactor SketchAnalysis
...
Refactor makeMissingVerticalHorizontal
2024-05-28 14:08:44 +02:00
wmayer
7f00aad6aa
Sketch: Refactor SketchAnalysis
...
Refactor makeMissingPointOnPoint
2024-05-28 13:40:38 +02:00
wmayer
72fb5782ed
Sketch: Add test case for validating constraints
2024-05-27 19:15:18 +02:00
wmayer
0a5a049c87
Sketcher: Fixes #14240
2024-05-27 12:09:35 +02:00
bgbsww
b82e3c73d4
Toponaming: Fix point crash bug
2024-05-16 09:05:27 -05:00
bgbsww
6fa5dc42c6
Toponaming: bring in missing code fragments in Sketcher
2024-05-13 15:47:44 -05:00
bgbsww
ffba7dcbe6
Fix #13858
...
Mistaken enabling of known bad code
2024-05-07 10:17:48 -05:00
