Commit Graph

88 Commits

Author SHA1 Message Date
wandererfan
88c7aac0d9 [TD]fix issues reported by 3d dimension testers
- correct interpretation of True vs Projected

- handle long subelement names in references

- fix "too small" value condition

- better error messages for bad dimension geometry
2023-01-07 16:32:03 -05:00
wandererfan
208104e9e0 [TD]Refactor Dimensions for 3d upgrade
- separate validation, geometry and reference handling into
  individual files
- improve 3d reference geometry handling
- eliminate duplicate dim creation code

- add Dimension reference repair dialog

- Refactor formatting out of DrawViewDimension

- move dimension repaint control to ViewProvider
2023-01-07 16:32:03 -05:00
Uwe
a722122807 [TD] Gui, A*-C*: remove unused includes
- also sort includes
- also an addition to precompiled header
- TaskCenterLine: remove unused code that interferes with used code with the same name
2022-10-09 03:34:53 +02:00
wandererfan
9e60f1bbef [TD]fix extent dimension 2022-09-09 13:02:08 -04:00
wandererfan
aa2b1b8392 [TD]CI clang warnings 2022-09-05 17:48:38 -04:00
Benjamin Bræstrup Sayoc
71758ecf9b [TechDraw] Clean up precompile in Gui 2022-08-14 09:20:38 -04:00
berniev
f4ffd15864 Mod: redundant void 2 2022-08-08 10:27:50 +02:00
berniev
53ba98d636 Mod: use empty 2022-08-06 19:30:13 +02:00
berniev
47ac049e14 Mod: use emplace_back 2022-08-05 10:36:16 +02:00
Uwe
5486c9808d [TD] remove some more superfluous nullptr checks 2022-07-20 02:53:48 +02:00
Uwe
b514f47c21 [TD] Gui: remove some superfluous nullptr checks 2022-07-19 02:49:46 +02:00
Wanderer Fan
c25756af8a [TD]check for spline on linear Dims 2022-07-16 11:28:38 -04:00
Wanderer Fan
ac7b8026e4 [TD]fixes for 6cf4e31d7a 2022-07-11 22:57:46 -04:00
Benjamin Bræstrup Sayoc
0bf342b1d8 [TechDraw] Improve readability of commands 2022-07-09 13:07:30 -04:00
Wanderer Fan
4fc652b460 [TD]abort dimensioning of spline edge 2022-06-06 18:47:51 -04:00
Kuzemko Alexsandr
92b4e41884 [TD] Add ability to translate for some tooltip text. Fix incorrect use of tr(variable). 2022-06-06 13:08:02 -04:00
wmayer
0b2c73cf32 Gui: clean-up Selection API
Replace the int of the 'resolve' argument of several functions with a proper enum class.
* This avoids the inconsistencies in client code where often true/false is passed when an int is expected
* This avoids the use of magic numbers like 0, 1, 2 or the undocumented 3
2022-04-09 17:03:43 +02:00
wmayer
ccc0d54d97 TD: [skip ci] activate PCH of TechDraw (Gui) and use forward declarations
For MSVC this reduces compile time by ~20%
2022-03-25 13:54:47 +01:00
wmayer
e8f9c8a1d3 TD: modernize C++11
* use nullptr
2022-03-23 19:26:14 +01:00
wmayer
8f786ea6ef Gui: Optimize includes to reduce compile time 2022-03-07 20:29:18 +01:00
Wanderer Fan
bed513b589 [TD]Adjust initial placement of dim text 2022-01-21 11:25:09 -05:00
Wanderer Fan
28c5890bc9 [TD] avoid memory leaks by using shared_ptr
TD geometry objects are sometimes double deleted.  This
change uses shared_ptr instead of raw pointers to manage
deletions.
2022-01-07 13:34:20 -05:00
wmayer
3fa4a321d3 TD: replace usage of raw pointers of Vertex and Face with shared pointers.
This fixes issue 4741: Broken File After Using Landmark Dimension in TechDraw
2021-12-10 14:25:24 +01:00
Roy-043
fa2851a7e8 TechDraw housekeeping: TechDraw_LandmarkDimension icon fix (#5033)
TechDraw housekeeping: TechDraw_LandmarkDimension icon fix
2021-09-16 18:42:11 -05:00
Roy-043
85a84a7176 TechDraw: Changed "TechDraw_Dimension_Link" -> "TechDraw_LinkDimension" (#5032)
* Update and rename TechDraw_Dimension_Link.svg to TechDraw_LinkDimension.svg

Icon name should match the command name.
2021-09-15 10:08:09 -05:00
luz paz
89664642fb TD: Issue #0004473: Expose openCommand() to translation
Continuing the work to expose the undo/redo functionality to translation. This commit does so for the TechDraw Wb.  
Ticket: https://tracker.freecadweb.org/view.php?id=4473
2020-12-01 14:53:35 +01:00
wandererfan
6785ee15c2 [TD]remove restrictions on Edge-Edge Dims 2020-08-29 11:13:35 -04:00
donovaly
7a5be2d42e [TD] add 2 shortcuts for dimensions
as discussed here: https://forum.freecadweb.org/viewtopic.php?f=35&t=48980
2020-07-26 11:22:06 -04:00
wmayer
1ae38aea04 PVS: V522 There might be dereferencing of a potential null pointer 2020-07-18 10:59:27 +02:00
wandererfan
fd240e9ea2 [TD] Landmark Dim minor clean ups
- clean up reference vertices on delete

- protect fail on close empty Page

- hide unimplemented functions
2020-02-27 15:46:31 -05:00
wandererfan
d1d7098ad6 [TD]Support Landmark Dim in Section and Detail 2020-02-25 17:21:00 -05:00
wandererfan
cb2a3d529c [TD]Landmark Dims initial impl 2020-02-25 17:21:00 -05:00
donovaly
ec9dffd535 simplify 2 tool names as suggested
- also correct encoding of a file
2019-11-17 08:22:09 -05:00
donovaly
896f1c25b7 TD renaming tools, part 2/2
as discussed in https://forum.freecadweb.org/viewtopic.php?p=344899#p344800
we need a more consistent naming for the Wiki
2019-11-17 08:22:09 -05:00
wandererfan
88b07896e6 [TD]Extent Dimensions 2019-11-02 14:59:32 -04:00
wmayer
b1dd1e61a7 force strict ISO C++ (-Wpedantic)
for Fem, Import, PartDesign, Robot, Sketcher, TechDraw
2019-09-18 14:18:07 +02:00
Zheng, Lei
e90d09dc40 TechDraw: Link related changes
* Support link and group objects

* Support view sync by implementing view provider API getMDIView()

* Use handleChangedPropertyType() for object migration instead of
  reimplementing Restore() because of a lots of changes in
  PropertyContainer::Restore().

* Various other small fixes.
2019-08-17 15:15:46 +02:00
wandererfan
5d601c1cdd [TD]Add CenterLine edit function 2019-07-15 12:36:48 -04:00
wandererfan
fbfdb69c20 [TD]Py Cosmetic Vertex, Line, Circle Arc 2019-07-15 12:36:48 -04:00
wandererfan
af0271691c Improve radius/diameter dims for ellipse,spline 2019-05-13 12:29:15 -04:00
luz.paz
e10d38a0cc Crowdin: More grammatical and whitespace fixes 2019-01-24 13:30:03 +01:00
wandererfan
94bd69a4fe Fix Text Literals for Translation
- these strings were noted as being difficult to
  translate on Crowdin
2019-01-20 00:29:17 +01:00
wmayer
d7ec2b1368 Replace Base::Exception with appropriate subclass 2018-11-14 19:42:10 +01:00
luz.paz
c7785267a7 Misc. typos and whitespace
Found via `codespell -q 3 --skip="*.po,*.ts,./.git,./src/3rdParty,./src/CXX,./src/zipios++,./src/Mod/Assembly/App/opendcm,./ChangeLog.txt" -I ../fc-word-whitelist.txt` and `grep`. Excess whitespace auto-removed by Atom editor.
2018-11-03 16:13:06 -03:00
wandererfan
8f35f4c956 Add 3Point Angle Dimension 2018-10-02 09:42:16 -03:00
wandererfan
0235df777c Better error messages for bad selections 2018-09-26 17:00:07 +02:00
wandererfan
c0c36138d7 Allow circular BSplines to be dimensioned 2018-08-11 11:24:12 +02:00
wandererfan
cbd9eb18c6 Fix initial placement of linear dims 2018-07-11 21:17:03 -03:00
wandererfan
6ba7f912ee Fix selection for radius Dims
- selection of ellipse curves was allowed
  but not supported for radius dims.
2018-05-15 21:50:48 +02:00
wandererfan
fdaf316e9e Add #3337 Arbitrary Dimension 2018-04-25 11:09:39 +02:00