kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity
15,747 Commits 41 Branches 6 Tags
8a4af3b28cf8e74ae52adca5462c2e378c3bfa3e
Commit Graph

177 Commits

Author SHA1 Message Date
luz.paz
103c118b82 Crwodin: Sketcher/Gui/CommandConstraints.cpp s/root/origin/ 2019-01-30 11:08:03 -02:00
luz.paz
95f16814f6 Crowdin: Sketcher/Gui/CommandConstraints.cpp grammar fix 2019-01-30 11:08:03 -02:00
luz.paz
83c2434bd9 Crowdin: Sketcher/Gui/CommandConstraints.cpp 2019-01-30 11:08:03 -02:00
Yorik van Havre
41fee3bb3d Fixed wording as notifed on crowdin 2018-12-31 16:21:49 -02:00
Abdullah Tahiri
e72bd857c7 Sketcher: Tangency between arcofellipse and other curves 
========================================================

Surprisingly there was no code to handle arcofellipse tangencies using AngleViaPoint constraint.

fixes #3659
 2018-12-20 11:59:26 -02:00
wmayer
56db19824e Replace Base::Exception with appropriate subclass 2018-11-14 19:27:52 +01:00
Abdullah Tahiri
13f589a0a6 Sketcher: Allow driven constraints when autoredundancy removal and autorecomputes active 
==========================================================================================

https://forum.freecadweb.org/viewtopic.php?f=3&t=31998#p266626
 2018-11-04 14:46:37 -03:00
Abdullah Tahiri
6a1aed66e2 Sketcher: Refactor code relating to dimensional constraint checks 2018-11-04 14:41:20 -03:00
wmayer
abb56c35d0 0003544: Crash on creation of vertical dimension with Shift + V 2018-10-04 18:37:33 +02:00
Abdullah Tahiri
b73cbd739c Sketcher: Correct checking of compatible equality geometry 
=========================================================

Before this commit equality line to circle is allowed although the solver can not process it.

Similar happens for several combinations of incompatible edges.
 2018-09-29 18:18:42 +02:00
Abdullah Tahiri
80e4b36f37 Sketcher: No equality to be applied to external axes 
fixes #3532
 2018-09-29 18:18:02 +02:00
Abdullah Tahiri
8505b0eff4 Sketcher: Automatic redundant removal mechanism 
===============================================

It is a long felt need that redundant constraints are not generated while autoconstraining.

The solver sketcher in v0.17 is überpicky with redundants due to the new popularity contest algorithm. The former behaviour is exhacerbated.

This new mode enables automatic redundant constraint removal.

In UI operations IN EDIT MODE, upon detection of redundancy by the solver, the Sketcher will remove all redundant constraints detected by that solve.

This makes the sketcher much less annoying.

How to test this?

The easiest example is to create a vertical line. Then make the endpoints symmetric with respect to the horizontal axis. Without this mode,
the vertical constraint and the symmetry constraint are redundant. With this mode, the vertical constraint gets automatically removed by the Sketcher.
 2018-08-26 20:54:01 +02:00
luz.paz
321b159f27 More typos 2018-08-18 21:48:43 +02:00
luz.paz
781d007321 Misc. typos 
Found via `codespell`
Trivial typos

Found via `codespell`
 2018-08-18 21:48:42 +02:00
Abdullah Tahiri
3d4c5eda21 Sketcher: Fix typos 2018-07-30 00:47:26 +02:00
Abdullah Tahiri
de7bab2f4a Sketcher: Fix Radius/Diameter shortcut 2018-07-30 00:47:26 +02:00
Abdullah Tahiri
a582da50b8 Sketcher: New command to add a Diameter Constraint 2018-07-30 00:47:24 +02:00
luz.paz
55a2a7ab55 Crowdin: Corrected B-spline term in translation 
ref: https://crowdin.com/translate/freecad/569/en-fr#6503804
[skip ci]
 2018-02-07 09:43:55 +01:00
luz.paz
a86c0fe137 sWhatsThis fixes 
ref: https://forum.freecadweb.org/viewtopic.php?f=10&t=26687
 2018-01-31 19:07:07 +01:00
wmayer
acded1c954 save values before invalidating iterator, whitespace improvements 2018-01-27 13:09:44 +01:00
Abdullah Tahiri
94ca105315 Sketcher: Setting in Preferences to switch on/off notification of constraint substitution 
=========================================================================================

By default notification is on, so that Newbies do not complain why FC is deleting that other constraint they have added before.

Power users generally will set it off, as they do not want to be bothered by pop ups and know what they are doing.
 2018-01-27 12:33:11 +01:00
Abdullah Tahiri
620188073e Sketcher: Avoid single tangency plus coincident when preexisting single tangency 
================================================================================

fixes #3299 (remaining)

Draw a line. Draw an arc. Make edge to edge tangency. Select endpoints. Try to create a coincident constraint. You now get an Endpoint-to-Endpoint tangency.
 2018-01-27 12:33:11 +01:00
Abdullah Tahiri
180d722a53 Sketcher: Avoid single tangency when preexisting coincident 
==========================================================

partly fixes 3299

Draw a line. Draw an arc. Make one endpoint of each coincident. Select the line. Select the Arc. Hit tangency. You now get an Endpoint-to-Endpoint tangency.
 2018-01-27 12:33:11 +01:00
wmayer
38da0c7312 improve whitespace, fix const correctness 2018-01-23 00:40:41 +01:00
Abdullah Tahiri
c7b137fe85 Sketcher: Change nomenclature relating to Block constraint 2018-01-22 22:52:56 +01:00
Abdullah Tahiri
c27d5a26b2 Sketcher: UI Block constraint creation sanity checks 
====================================================

Avoid creation of constraints if they would lead to undesirable conflicting situations.
 2018-01-22 22:52:56 +01:00
Abdullah Tahiri
9634da6811 Sketcher: Block constraint - Prevent from adding constraint if the solver has redundant/conflicting constraints 2018-01-22 22:52:56 +01:00
Abdullah Tahiri
1932a2f152 Sketcher: Blocked Constraint toolbar commands 2018-01-22 22:52:56 +01:00
luzpaz
048c787e32 Sketcher: comment typos 2017-12-25 10:59:48 +01:00
Abdullah Tahiri
4006c6ee97 Sketcher: Fixes no horizontal/vertical on edge if previous horizontal/vert aligment on vertex 
=============================================================================================

fixes #3257
 2017-12-07 11:11:40 +01:00
Abdullah Tahiri
aa43197976 Refactoring solve+recompute and reinstating initial solve+recompute behaviour 2017-08-19 17:14:27 +02:00
wmayer
2004544e57 fixes #0002710: Freecad doesn't show sketch elements added when overconstrained 
issue #0002836: Crash in sketcher
 2017-08-19 17:14:27 +02:00
luzpaz
81bdb1f276 Sketcher: typo fix 2017-07-24 18:21:17 -03:00
Abdullah Tahiri
40c6d4be1a Sketcher: Vertical alignment constraint command 2017-05-01 22:39:37 +02:00
Abdullah Tahiri
cfc2d86c2e Sketcher: Horizontal alignment constraint command 2017-05-01 22:39:08 +02:00
Abdullah Tahiri
e44208d56c Sketcher: Lock constraint bug fix 2017-04-22 18:16:27 +02:00
Abdullah Tahiri
0aa9438c0a Sketcher: Lock constraint relative mode and group locking 2017-04-22 18:16:27 +02:00
wmayer
c2e83c7818 consistently use term 'B-spline' in the sketcher GUI 2017-04-12 09:37:58 +02:00
wmayer
ce36b29cb7 fix scan coverity issues 2017-04-11 15:06:37 +02:00
Abdullah Tahiri
2a58ac0cf8 Sketcher: New function to reuse of python exception message text in the UI 2017-04-10 08:57:25 +02:00
Abdullah Tahiri
418beea589 Sketcher: Only Reference constraints allowable on construction points like bspline knots 2017-04-08 12:58:06 +02:00
Abdullah Tahiri
02e370d392 Sketcher: Enable reuse of constraint helper functions in other toolbars 
=======================================================================

bool checkBothExternal(int GeoId1, int GeoId2);
void getIdsFromName(const std::string &name, const Sketcher::SketchObject* Obj, int &GeoId, Sketcher::PointPos &PosId);
bool inline isVertex(int GeoId, Sketcher::PointPos PosId);
bool inline isEdge(int GeoId, Sketcher::PointPos PosId);
bool isSimpleVertex(const Sketcher::SketchObject* Obj, int GeoId, Sketcher::PointPos PosId);
bool IsPointAlreadyOnCurve(int GeoIdCurve, int GeoIdPoint, Sketcher::PointPos PosIdPoint, Sketcher::SketchObject* Obj);
 2017-04-08 12:58:06 +02:00
wmayer
b217fe2287 set continuous constraint mode consistently to true by default 2017-02-24 16:30:13 +01:00
wmayer
a90014c646 add missing word, fix layout 2017-02-24 16:24:24 +01:00
AjinkyaDahale
fc08fa1c09 Sketcher: costraint creation mode uses toolbar icons 2017-02-24 15:20:26 +01:00
AjinkyaDahale
6be9a9bc53 Sketcher: Added option to turn constraint creation modes on/off 
Can be found below geometry creation "continous mode" option
 2017-02-24 15:20:26 +01:00
AjinkyaDahale
e757c57a30 Sketcher: External edges in constraint modes (Symmetry) 2017-02-24 15:20:26 +01:00
AjinkyaDahale
31456a7e30 Sketcher: External edges in constraint modes (Angle) 2017-02-24 15:20:26 +01:00
AjinkyaDahale
167b28d200 Sketcher: External edges in constraint modes (Equal) 2017-02-24 15:20:26 +01:00
AjinkyaDahale
ff74ba32a8 Sketcher: External edges in constraint modes (radius) 2017-02-24 15:20:26 +01:00