Commit Graph

313 Commits

Author SHA1 Message Date
Abdullah Tahiri
c43adafb12 Sketcher: Respect general autoconstraints setting on sketch creation
====================================================================

fixes #3727

https://www.freecadweb.org/tracker/view.php?id=3727

https://forum.freecadweb.org/viewtopic.php?f=3&t=32761
2018-12-17 18:44:56 +01:00
Abdullah Tahiri
57b7142cd7 Sketcher: Do not recompute on geometry deletion
fixes #3642
2018-12-15 16:38:54 +01:00
luz.paz
4dc201e086 Misc. typo, grammar, and whitespace fixes
[skip ci]
2018-11-27 15:02:58 -03:00
wmayer
893f038717 improve whitespaces 2018-11-19 10:03:50 +01:00
Abdullah Tahiri
5705763088 Sketcher: Improving group constraint preselection
=================================================

the position obtained from the SoPath of the picked point when entering
the combined icon object is not the center of the icon, what leads to
wrong preselection or no preselection at all.

This commit uses the translation of the Constraint node, which is the same that
is used to locate the constraint icons on the screen in the first place.
2018-11-18 12:03:13 +01:00
Abdullah Tahiri
6a1aed66e2 Sketcher: Refactor code relating to dimensional constraint checks 2018-11-04 14:41:20 -03:00
wmayer
ebec4cd5e2 fix freeze when editing empty sketch 2018-10-04 00:34:06 +02:00
Abdullah Tahiri
65dd09d5e6 Sketcher: Grid visualization improvement
========================================

Now the Grid is calculated based on the maximum semiaxis length. Grid is recalculated on every redraw of the Sketcher.
2018-10-02 20:59:29 +02:00
Abdullah Tahiri
dedd66e7f4 Sketcher: Axes visualization improvement
========================================

Axes size was bounded to the boundingbox of the underlaying 2D shape. However, this does not even get updated in no update mode and provides unreliable values.

The axes calculation now:
- is coded to be the same size and fully symmetric.
- is coded to be minimum 100 mm semiaxis, which gives a good impresion for empty sketches with default zoom.
- is coded to grow with the largest of the semiaxes.

fixes #3334
2018-10-02 20:59:10 +02:00
Markus Lampert
e4dbc896df Set focus to sketcher window when a new handler is activated to ensure proper handling of keys, espcially Escape. 2018-09-11 07:30:43 +02:00
wmayer
2dc8089852 handle case if a B-spline is straight and thus maximum curvature is zero 2018-08-26 19:17:16 +02:00
Markus Lampert
0b40519f3f Changed all catch types to references for polymorphic exceptions. 2018-08-08 15:45:30 +02:00
Abdullah Tahiri
de3da81293 Sketcher: ViewProvider representation of the Diameter Constraint 2018-07-30 00:47:23 +02:00
luz.paz
0576524144 Misc. code comment typo fixes
Found via `codespell -q 3 -I ../fc-word-whitelist.txt --skip="*.ts,*.po,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./.git,./src/zipios++"`
2018-07-27 10:39:43 -03:00
hokieengr
2b08754c17 Fixed default HideUnits option to FALSE 2018-07-23 12:44:26 -03:00
hokieengr
d7e5534d51 Added code to strip units from display string 2018-07-23 12:44:26 -03:00
hokieengr
f8327a009b WIP. Moving to other machine. 2018-07-23 12:43:46 -03:00
hokieengr
4c2e36b645 WIP. Added logic to not hide non-base units. 2018-07-23 12:43:46 -03:00
hokieengr
841dfeadbe WIP. Moved code to hide units to seperate function 2018-07-23 12:43:46 -03:00
hokieengr
3f1216a58d WIP. Added logic to hide units on distance dimensions.
More of a prototype than anything else right now. Will find a better way to add this functionality to the rest of Sketcher.
2018-07-23 12:41:14 -03:00
JimStar
63f085dd78 Extended global marker size to be used for Sketcher 2018-07-11 21:22:28 -03:00
Abdullah Tahiri
d02d0da7de Sketcher: Do not update point height when highlighted i.e. (pre)selected 2018-06-02 16:44:57 +02:00
Abdullah Tahiri
4805927170 Sketcher: Extend existing rendering order for lines to points 2018-05-31 14:31:29 +02:00
wmayer
717abd0cf3 fix string 2018-05-31 13:27:38 +02:00
Abdullah Tahiri
1d63ed717a Sketcher: Support for clickable DoFs to launch DoF finder 2018-05-31 11:40:28 +02:00
luz.paz
420c2d7c03 Source typos fixes 2018-05-11 10:02:56 -03:00
Abdullah Tahiri
8a2ec12b5a Sketcher: Bug fix not updating constraints on switch of virtual space 2018-01-26 17:04:28 +01:00
Abdullah Tahiri
d987930338 Sketcher: Enable switching of virtual space in ViewProvider 2018-01-26 17:03:16 +01:00
Abdullah Tahiri
31189b6c20 Sketcher: Python Interface for Constraint Virtual Space
=======================================================

set/get/toggle python interface to enable to set the virtual space status of a constraint via SketchObject.
2018-01-26 17:02:46 +01:00
Abdullah Tahiri
d559c1477b Sketcher: Enable Virtual space updates on the View Provider
===========================================================

Basic initial working implementation to hide constraints.
2018-01-26 17:02:22 +01:00
Abdullah Tahiri
c509ec5ded Sketcher: Fix normal rendering when full-constraint
fixes #3320
2018-01-23 16:57:33 +01:00
wmayer
38da0c7312 improve whitespace, fix const correctness 2018-01-23 00:40:41 +01:00
Abdullah Tahiri
c7b137fe85 Sketcher: Change nomenclature relating to Block constraint 2018-01-22 22:52:56 +01:00
Abdullah Tahiri
9b7d1d6042 Sketcher: Blocked constraint viewprovider rendering 2018-01-22 22:52:56 +01:00
wmayer
97f0020093 improve whitespaces 2018-01-13 15:49:39 +01:00
Abdullah Tahiri
bc4d463cdf Sketcher: Remove errors in reporting view while deleting
=======================================================

fixes #2275

https://freecadweb.org/tracker/view.php?id=2275

Deletion of coincidents rely on selected vertex. The original code was trying to delete a coincident without checking whether one was there.

The implementation now relies on checking whether a coincident is present.
2018-01-13 15:47:02 +01:00
Abdullah Tahiri
2a6f55e650 Sketcher: Special sketcher color for dimensions having an expression
fixes #3285
2018-01-01 21:00:06 +01:00
wmayer
65e7932930 improve whitespaces 2018-01-01 20:51:12 +01:00
Abdullah Tahiri
27cff5ce85 Sketcher: Match angle on lines representation match solver result 2018-01-01 20:28:41 +01:00
wmayer
c18bc414bb fixes #0003252: External geometry tool keeps hovered item active after leaving 2017-12-25 10:47:51 +01:00
Abdullah Tahiri
ad855c99e3 Sketcher: New Setting for improved dragging mode 2017-12-12 22:20:27 +01:00
Abdullah Tahiri
023e319b84 Sketcher: Clean code and adapt previous solution only to non-relative cases
===========================================================================

Cleaning up ViewProviderSketch, as relative mode is never used for points.

Adapting the recalculation of the initial solution only to non-relative cases.

For relative movement cases (movePoint with relative=true) no cases where such a solution will be advantageous have been identified
and applying a similar solution involves changing the current behaviour too much, as to run the risk of introducing further bugs.

Decision to be revised if such cases where an advantage can be found are discovered.
2017-12-12 22:20:27 +01:00
Abdullah Tahiri
eb40ddda4e Sketcher: Do not show support when entering sketch edit mode if it is a datum plane
=====================================================================================

https://forum.freecadweb.org/viewtopic.php?f=10&t=25700
2017-12-07 11:39:35 +01:00
wmayer
99a2fd16f4 fixes #0002290: Point-on-object constraint icon not selectable 2017-11-20 14:06:12 +01:00
Jeff
c770ce7a34 Added color prefs to sketcher create commands
Create geometry commands in sketcher now have configurable crosshair color and editCurve color.
2017-11-18 15:30:41 +01:00
DeepSOIC
db26cbcc4c Sketcher: fix false detection of doubleclick
Double-click detector code was comparing double-click threshold (value =
5) with distance between clicked objects in model space (i.e.
double-click distance threshold was equal to 5 mm in model space
regardless of zoom). The fix changes the comparison to pixels on screen
instead.

This fixes the inability to select sketch entities in quick succession,
when the sketch is small (i.e. less than 40 mm or so).
2017-11-10 18:12:48 +03:00
wmayer
8b2fcf3677 fix several kind of warnings:
+ fix -Wparentheses/-Wlogical-op-parentheses
+ fix -Wunused-variable
+ disable -Wundefined-var-template due to many false-positives (clang)
+ fix -Winconsistent-missing-override
+ fix -Wmaybe-uninitialized
2017-10-15 19:12:07 +02:00
Unknown
772c5b1970 Doxygen Typos
+ doxy whitespace formatting
+ added more misc. typos
+ grammar fixes
[skip ci]
2017-10-15 16:27:42 +02:00
wmayer
1be2d52deb whitespace improvements + some optimizations 2017-10-12 11:22:10 +02:00
wmayer
4c7841c071 don't select circle/ellipse center if not inside selection box 2017-10-12 11:07:27 +02:00