Commit Graph

43 Commits

Author SHA1 Message Date
WandererFan
8b45901c5e [TD]handle short&wide hatch area (#17630)
* [TD]handle short&wide hatch area

* [TD]sync .h and .cpp parameter names
2024-11-04 18:01:33 +01:00
Eric Price
aba60775f6 Fix boolean operations (#17119)
* add BRepAlgoAPI wrapper files to CMakeList

* introduce wrapper for BRepAlgoAPI_BooleanOperation and derivatives, set sensible default Fuzzyness for boolean operations

* allow default fuzzyness to be set in settings - including off

* backwards compatibility with OCCT 7.3.3 - removed newer paramateres from wrapper

* added missing header

* reverted src/Mod/Part/App/OpenCascadeAll.h to original state

* implement some changes suggested by @wwmayer

* removed unneeded destructor definitions

* moved getDefaultFuzzyValue into its own helper class

* removed unneeded references to base class default constructor

* default to SetRunParallel(Standard_True) as suggested by @FlachyJoe

* fixed license header as requested

* Added new method to autocalculate fuzzyness to BooleanOperation base class and use it for those parts that do not call the obsolete constructor but also do not set precision

* implemented static variable solution as suggested by @wwmayer

* added helix for test case

* Refactoring FCRepAlgoAPI to FCBRepAlgoAPI

* Added Test Case (fuse cylinder with helix with different working and non-working Fuzzy values)

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* increased default value of FuzzyBoolean and made tests more robust for compatibility with OCCT 7.3

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fixes for FREECAD_USE_PCH - allow testing of FREECAD_USE_PCH on linux with cmake switch (default OFF)

* removed surplus line - wasn't needed after all

* included precompiled as instructed

* set anti-corruption flag in boolean operations, ensures source shape is not damaged in OCCT 7.1 and higher

* fix #17085

* disable subtests that were too specific for now

* fixed all CLI tests - see comments in Pull Request https://github.com/FreeCAD/FreeCAD/pull/17119#issuecomment-2420772452

* Update src/Mod/PartDesign/PartDesignTests/TestTopologicalNamingProblem.py

suggested updated test by CalligaroV

Co-authored-by: Vincenzo Calligaro <vincenzo.calligaro@gmail.com>

* Update tests/src/Mod/Part/App/TopoShapeExpansion.cpp

suggested updated test by CalligaroV

Co-authored-by: Vincenzo Calligaro <vincenzo.calligaro@gmail.com>

* Update tests/src/Mod/Part/App/TopoShapeExpansion.cpp

suggested updated test by CalligaroV

Co-authored-by: Vincenzo Calligaro <vincenzo.calligaro@gmail.com>

* Update tests/src/Mod/Part/App/TopoShapeExpansion.cpp

suggested updated test by CalligaroV

Co-authored-by: Vincenzo Calligaro <vincenzo.calligaro@gmail.com>

* Update tests/src/Mod/Part/App/TopoShapeExpansion.cpp

suggested updated test by CalligaroV

Co-authored-by: Vincenzo Calligaro <vincenzo.calligaro@gmail.com>

* Update tests/src/Mod/Part/App/TopoShapeExpansion.cpp

suggested updated test by CalligaroV

Co-authored-by: Vincenzo Calligaro <vincenzo.calligaro@gmail.com>

* Update tests/src/Mod/Part/App/TopoShapeExpansion.cpp

suggested updated test by CalligaroV

Co-authored-by: Vincenzo Calligaro <vincenzo.calligaro@gmail.com>

* Update tests/src/Mod/Part/App/TopoShapeExpansion.cpp

suggested updated test by CalligaroV

Co-authored-by: Vincenzo Calligaro <vincenzo.calligaro@gmail.com>

* Update tests/src/Mod/Part/App/TopoShapeExpansion.cpp

suggested updated test by CalligaroV

Co-authored-by: Vincenzo Calligaro <vincenzo.calligaro@gmail.com>

* Update tests/src/Mod/Part/App/TopoShapeExpansion.cpp

suggested updated test by CalligaroV

Co-authored-by: Vincenzo Calligaro <vincenzo.calligaro@gmail.com>

* Update tests/src/Mod/Part/App/TopoShapeExpansion.cpp

suggested updated test by CalligaroV

Co-authored-by: Vincenzo Calligaro <vincenzo.calligaro@gmail.com>

* Update tests/src/Mod/Part/App/TopoShapeExpansion.cpp

suggested updated test by CalligaroV

Co-authored-by: Vincenzo Calligaro <vincenzo.calligaro@gmail.com>

* Update tests/src/Mod/Part/App/TopoShapeExpansion.cpp

suggested updated test by CalligaroV

Co-authored-by: Vincenzo Calligaro <vincenzo.calligaro@gmail.com>

* Update tests/src/Mod/Part/App/TopoShapeExpansion.cpp

suggested updated test by CalligaroV

Co-authored-by: Vincenzo Calligaro <vincenzo.calligaro@gmail.com>

* Update tests/src/Mod/Part/App/TopoShapeExpansion.cpp

Co-authored-by: Vincenzo Calligaro <vincenzo.calligaro@gmail.com>

* remove surplus tests from github suggestion interface bug

* hide the BooleanFuzzy variable - can now be only set by manually editing the config file
i
in FCParamGroup "Boolean"
<FCFloat Name="BooleanFuzzy" Value="10.000000000000"/>

* Suggestion by @FlachyJoe - add validity checks to the base and tool shape in any direct boolean op

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Vincenzo Calligaro <vincenzo.calligaro@gmail.com>
2024-10-21 18:38:51 +02:00
wandererfan
84a8800767 [TD]fix hatch fail due to missing translate method 2023-09-14 12:05:13 -04:00
wandererfan
41817c188f [TD]split GeometryObject 2023-08-18 15:18:42 -04:00
Benjamin Bræstrup Sayoc
5d05acc87e [TechDraw] Simplify retrievement of user preferences
for all TechDraw files
2023-04-10 23:34:05 -04:00
Benjamin Bræstrup Sayoc
5da15d23cf [TechDraw] Improve readability of DrawGeomHatch.cpp 2023-04-05 14:32:56 -04:00
wmayer
2a0e52e71e clang: fix -Wunused-but-set-variable 2023-03-12 15:05:21 +01:00
wandererfan
437457e996 [TD]remove obsolete log messages 2023-01-13 12:15:33 -05:00
wandererfan
6cc849fb73 [TD]allow rotation of hatch directions
- faces can have their svg and bitmap hatches rotated to match
  the view rotation or special situations
- section cut face can have svg hatch rotated
2022-12-03 15:15:25 -05:00
wandererfan
a2976bcfbc [TD]simplify embedded hatch file handling 2022-11-12 11:35:22 -05:00
Uwe
4d73bd5a50 [TD] DrawD* - DrawT*: remove unused includes - part 2/2
- also sort includes
- also additions to precompiled header
2022-10-08 17:21:26 +02:00
wandererfan
aa2b1b8392 [TD]CI clang warnings 2022-09-05 17:48:38 -04:00
Wanderer Fan
4cefaa3a13 [TD]code review changes for dgh, dpg, dpgi, dra 2022-08-18 19:43:04 -04:00
Wanderer Fan
e97b95341a [TD]code clean ups
- QtConcurrent include and CMake for Win

- include clean up dvp, dvs, dvd

- variable names and nested if clean up

- remove debug code
2022-08-18 09:34:32 -04:00
berniev
f4ffd15864 Mod: redundant void 2 2022-08-08 10:27:50 +02:00
Uwe
5486c9808d [TD] remove some more superfluous nullptr checks 2022-07-20 02:53:48 +02:00
Uwe
36add10c86 [TD] App: remove some superfluous nullptr checks 2022-07-19 02:03:50 +02:00
Wanderer Fan
74085b609d [TD]fix preference file handling 2022-06-03 18:35:13 -04:00
Wanderer Fan
391bdcccaa [TD]fix GeomHatch change file name 2022-04-23 10:00:02 -04:00
wmayer
e8f9c8a1d3 TD: modernize C++11
* use nullptr
2022-03-23 19:26:14 +01:00
Wanderer Fan
855941d5bb [TD]fix misplaced section line
- BRepBndLib::Add results in wrong bbox center.
- replaced with BRepBndLib::AddOptimal
2022-03-03 09:31:29 -05:00
Wanderer Fan
28c5890bc9 [TD] avoid memory leaks by using shared_ptr
TD geometry objects are sometimes double deleted.  This
change uses shared_ptr instead of raw pointers to manage
deletions.
2022-01-07 13:34:20 -05:00
wandererfan
d66e3396a8 [TD]handle bad preferences in AppImage temp dir 2020-08-14 09:37:14 -04:00
wandererfan
41380359a8 [TD]fix misaligned PAT hatch on section 2020-07-25 10:30:13 -04:00
WandererFan
2db99798f6 [TD]Improve section face display 2020-06-04 09:00:22 -04:00
wandererfan
c7d59e8317 [TD]show section face pat hatch on restore 2020-05-10 11:03:15 -04:00
wandererfan
d210c14167 [TD]GeomHatch - handle empty parameter 2020-03-20 18:42:48 -04:00
wandererfan
4bc0718a3b [TD]common preference getters for hatches 2020-03-20 07:28:33 -04:00
WandererFan
47aeca65e1 [TD]fix Section file included set up 2020-03-17 08:45:26 -04:00
wandererfan
fb035a9a0d [TD]remove Hatches from Display when deleted 2020-03-11 18:17:46 -04:00
donovaly
39be11c459 [TD] reduce scaling increment
see https://forum.freecadweb.org/viewtopic.php?f=35&t=42780
2020-01-26 19:30:02 -05:00
wandererfan
879a259d81 [TD]embed geom hatch file in document 2020-01-12 11:38:53 -05:00
wandererfan
1f4fb612dd [TD]Apply filters to PropertyFile 2019-09-20 12:56:26 -04:00
wandererfan
fbfdb69c20 [TD]Py Cosmetic Vertex, Line, Circle Arc 2019-07-15 12:36:48 -04:00
wandererfan
242717f5e3 Fix out of scope warnings
- Links within TD were not set to Global scope. This caused
  problems when a Page was in a container, but Views were not
  in the container.
2019-01-22 10:15:04 -02:00
wmayer
d7ec2b1368 Replace Base::Exception with appropriate subclass 2018-11-14 19:42:10 +01:00
luz.paz
69d46d1b43 Misc. typo and whitespace fixes
`codespell -q 3 -I ../fc-word-whitelist.txt --skip=".git,*.ts,*.po,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/zipios++"`
2018-09-11 07:27:22 +02:00
WandererFan
8671021f42 Fix upside down GeomHatch on asymmetric faces 2017-07-17 19:47:44 -03:00
WandererFan
235f0a93c6 DrawGeomHatch improvements
-draw & align dash patterns correctly on all QPainters using QGPathItem
-Allow patterns to start with space
-ensure horiz & vert lines pass through pattern origin
-Scalable complex patterns
2017-05-10 17:43:48 +02:00
WandererFan
bf4a80dad5 clean up GeomHatch feature, gui & dialog
Refactor code, allow dialog to edit feature, update graphics on change
prep for dash line start positioning.
2017-05-10 17:43:48 +02:00
WandererFan
813454993c Change Scale to PropertyFloatConstaint to prevent OCC loop when Scale == 0 2017-02-07 10:51:42 -02:00
WandererFan
47d433b64c Install default PAT file 2017-01-29 19:40:34 -05:00
WandererFan
1c8395e229 fix naming conflicts 2017-01-29 19:40:34 -05:00