kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity
35,399 Commits 41 Branches 6 Tags
8d00b00c9b558a3946c99a0040a4347d00a525da
Commit Graph

349 Commits

Author SHA1 Message Date
Abdullah Tahiri
8d00b00c9b Sketcher: Utils/CommandConstraints/EditModeConstraintCoinManager - refactor duplicated code 2023-12-17 16:01:29 +01:00
Abdullah Tahiri
d28fe43565 Sketcher: Redraft circle/arc to circle/arc constraint command 2023-12-17 16:01:29 +01:00
Florian Foinant-Willig
7343bf940b Sketcher: Extend distance constraint to arcs 2023-12-17 16:01:29 +01:00
Florian Foinant-Willig
838802e28d Sketcher: Arc to arc or circle distance constraint 2023-12-17 16:01:29 +01:00
Chris Hennes
bd9a210b65 Merge pull request #11494 from Ondsel-Development/Coincident 
[Sketcher] Introduce an optional unified version of coincident and pointOnObject
 2023-12-04 10:46:21 -06:00
Paddle
d94fdf795e Introduce CmdSketcherConstrainCoincidentUnified. This is a unified version of coincident + pointOnObject. 
This is disabled by default. Nothing changes by default.
 2023-11-27 21:14:33 +01:00
wmayer
7157448b37 Sketcher: add security checks to avoid possible undefined behaviour 2023-11-27 10:58:50 +01:00
Paddle
466395194c hor/ver tool, remove unused variables 2023-11-27 10:44:25 +01:00
Paddle
b3fc34d61b Sketcher : Replace toggle icons. 2023-11-25 20:55:50 -03:00
Paddle
4c7ff0a6be Sketcher: remove unused cursor_createcoincident[] and DrawSketchHandlerCoincident. They are not used anymore. 2023-11-22 16:47:51 +01:00
Paddle
a45bb8626f Sketcher: Move Distance command next to DistanceX. ONLY move code, nothing changed. 2023-11-22 16:19:08 +01:00
PaddleStroke
cce89e4fec [Sketcher] Auto horizontal/vertical (#11330) 
* Refactor sketcher horizontal / vertical constraints and adds a horizontal/vertical command.

* Sketcher : HorVer : change tool icon.

---------

Co-authored-by: Paddle <PaddleStroke@users.noreply.github.com>
 2023-11-20 11:00:22 -06:00
Paddle
ca80f8eee2 Fix ESC key for Sketcher_Dimension 2023-11-15 14:41:43 +01:00
Abdullah Tahiri
f56eebea64 Sketcher: Fix lints 2023-11-08 17:46:34 +01:00
Abdullah Tahiri
dca052bd9d Fix Compiler warnings of previous merged PRs 2023-11-08 15:20:13 +01:00
Paddle
a7e1cba6b0 Sketcher_Dimension: If radius of arc is not DoF, then offer arc angle first. 2023-11-06 14:02:54 -06:00
Chris Hennes
590fb19f31 Merge pull request #10978 from FlachyJoe/modernize-type-check 
Modernize type and derived type checking
 2023-11-06 10:44:32 -06:00
Abdullah Tahiri
3eda026ecb Sketcher Gui: Fix dead code clang-tidy 2023-11-05 07:11:57 +01:00
Abdullah Tahiri
533250bc34 Sketcher Gui: clang-tidy diagnostic errors 2023-11-05 07:11:57 +01:00
Florian Foinant-Willig
c0e8fa1e75 Sketcher: modernize type checking 2023-10-23 18:09:23 +02:00
Paddle
0f049a6cb0 Sketcher: commandConstraint : remove leftover bothexternal variable. 2023-10-22 13:51:21 +02:00
wmayer
e9586c4206 Sketch: fix several compiler and lint warnings 
* Remove private unused field 'sketchView'
* Mark constructor with single argument as explicit
* Mark virtual methods of base class as override
* Fix clang code model parsing error
* Avoid too short identifiers
* Avoid redundant ternary operators
* Avoid passing Base::Unit by value but by const reference
 2023-10-20 12:29:59 +02:00
Paddle
019bd50bbc Fix typo making Sketcher_Dimension fails for angles. 2023-10-10 13:48:07 +02:00
Paddle
2ea27064d5 Create makeAngleBetweenTwoLines and Create Create calculateAngle to remove duplicates 2023-10-07 07:43:39 +02:00
wmayer
b2d255e5fc Sketch: fix a few minor issues: 
* fix compiler warning about unused variable
* fix const correctness
* fix access type of setExpression()
* removed duplicated method
 2023-09-19 22:01:19 +02:00
Paddle
f080b39829 Sketcher_Dimension : adds arc-angle mode for arcs. 2023-09-19 08:25:45 +02:00
Paddle
b97a2ef6dc Adds a small convenience function to get arc of circle angle. 2023-09-18 21:33:24 +02:00
howie-j
49bca90219 fixes #10651 2023-09-18 10:56:13 -05:00
Florian Foinant-Willig
e8becf3f15 Sketcher: refactor CommandConstraint.cpp (#10692) 
* Sketcher: refactor CommandConstraint.cpp with TypeId helpers

* Sketcher: cosmetic empty lines

* fix pointer misusage
 2023-09-18 10:37:03 -05:00
Paddle
cde6afe847 Sketcher_Dimension : enable user to deselect geos by clicking on them again. 2023-09-14 20:57:39 -05:00
wmayer
bc8a5e4704 Sketcher: fix several inconsistencies in Sketcher_CompDimensionTools 
* The menu text and tooltip of the Sketcher_ConstrainRadius command shouldn't be different if part of the group command or not.
  The explicit mentioning to change the weight of a B-Spline is pointless and confusing.
* The order of Sketcher_ConstrainRadius and Sketcher_ConstrainDiameter has flippend when used in Sketcher_CompDimensionTools
* The command Sketcher_ConstrainRadiam is completely missing
* The command Sketcher_ConstrainSnellsLaw was wrongly re-added
* CmdSketcherCompConstrainRadDia uses a wrong context
 2023-09-14 20:56:14 -05:00
wmayer
d9d7bf87ae MSVC: fix several compiler warnings 2023-09-12 22:57:26 +02:00
howie-j
332b64f8b6 Fixes #10596 2023-09-07 21:14:56 +02:00
Paddle
c1bd68d8a5 Sketcher_Dimension Replace SubNames by std::move(SubNames) 2023-09-02 11:35:31 +02:00
Paddle
351bd2d5f4 Sketcher_Dimension fix crash. 2023-09-01 18:50:46 +02:00
wmayer
ee6e9e4923 Sketcher: fix several warnings: 
* fix -Wunused-parameter
* fix -Wsign-compare
 2023-09-01 17:34:29 +02:00
Paddle
465e98a502 Sketcher_Dimension: Disable arc-circle and arc-line distances as they are not implemented yet. 2023-09-01 08:00:21 -05:00
Paddle
126558ccf8 Sketcher_Dimension: Implement Point-to-Circle distance. 2023-09-01 08:00:21 -05:00
Paddle
392d29c20b Sketcher_Dimension Fix the transaction auto-closing issue 2023-09-01 07:58:45 -05:00
Paddle
be7b9b33e7 Sketcher_Dimension : Implement selection->tool workflow 2023-09-01 07:58:45 -05:00
Paddle
3fad071760 Sketcher_Dimension : Turn the command into a group-command to have at hand individual commands. 2023-09-01 07:57:44 -05:00
luzpaz
40d2a90e3a Fix typos 2023-08-31 22:29:17 -05:00
Florian Foinant-Willig
9681ad595b Sketcher: Point to Circle Distance Constraints (#9559) 2023-08-28 10:58:09 -05:00
Paddle
e21b6cf860 Implement GeomSelectionSizes to further refactor Dimension::makeAppropriateConstraint 2023-08-27 18:48:33 +02:00
Paddle
d5bdebfe10 Dimension: Fix 2 circles concentric and length mode. 2023-08-27 18:48:00 +02:00
Paddle
a683f3aca4 Fix crash when user click 'Close' button while Dimension is active. 
TaskDlgEditSketch didn't purge the handler first as is doing CmdSketcherLeaveSketch.
 2023-08-27 09:26:44 +02:00
Paddle
f1f31fd3df Refactor makeAppropriateConstraint 2023-08-27 08:25:20 +02:00
Paddle
1fcfdedb05 Replace multiple occurence of selVec.size() by s_vec to clean the makeAppropriateConstraint function 2023-08-27 07:26:53 +02:00
Paddle
3598dd4820 Small simplification by removing useless tests in makeAppropriateConstraint 2023-08-26 22:13:11 +02:00
Paddle
b95713599a refactor Sketcher Dimension releaseButton 2023-08-26 19:47:23 +02:00