Commit Graph

2566 Commits

Author SHA1 Message Date
vocx-fc
2f48f1caba Draft: split svg.get_text into smaller readable functions
Split the code for SVG string that will be displayed
for TechDraw pages; also split the header for other cases.
2020-09-21 14:25:03 +02:00
vocx-fc
0739ffa58e Draft: clean up SVG processing code, add comments
For the try-except blocks we should trap a specific `Exception`,
not just any type. It seems string handling was an issue
with Python 2, so the string needed UTF8 decoding.

When the software no longer supports Python 2, these
blocks can be removed.
2020-09-21 14:25:03 +02:00
vocx-fc
dea7f5d638 Draft: Drawing is still used in get_dxf function 2020-09-21 14:25:03 +02:00
Zheng, Lei
31e8bb27a6 Draft: fix point array without using link 2020-09-21 14:01:42 +02:00
Zheng, Lei
607c14b512 Draft: add support for point link array 2020-09-21 14:01:39 +02:00
vocx-fc
7a93bcb151 Draft: small fixes to the closest function.
Correct the Pythonic style for the changes made in ea16bb9394.
2020-09-16 13:09:57 +02:00
vocx-fc
c79f890112 Draft: move getDXF to draftfunctions submodule
Update the appropriate interface in `Draft.py`.
2020-09-16 13:09:13 +02:00
Roy-043
2cf9f395c1 Draft: Again revised the 5 scale unit tests. No longer relying on the math module.
Also avoided the use of a Boolean 'result' variable.
2020-09-16 13:07:50 +02:00
Roy-043
30fd275089 Draft: Revised the 5 Draft.scale unit tests. No longer using scale_vector_from_center.
The old Draft.scale unit tests uses the scale_vector_from_center function from Draft.scale. This obviously didn't make sense.
2020-09-16 13:07:50 +02:00
Roy-043
687461cf15 Draft: added 5 scale unit tests to test_modifications
The added functions are test_scale_part_feature_arcs, test_scale_part_feature_lines, test_scale_rectangle, test_scale_spline and test_scale_wire.
When comparing vectors and floats a tolerance of 1e-8 is used, but only for the midpoints of the arcs in test_scale_part_feature_arcs is this tolerance required. Scaling a part feature is not possible with the Draft_Scale command, but Draft.scale does support it.
2020-09-16 13:07:50 +02:00
wmayer
c3d35c65fe dxf: [skip ci] Coverity: Buffer not null terminated 2020-09-14 14:37:20 +02:00
paul lee
be42d1b6cc [ DraftVecUtils.cloest ] Elaborate documentation 2020-09-09 16:01:39 +02:00
paul lee
ea16bb9394 [ DraftVecUtils.closet ] Could return the distance (no unit) of the tested point from the found closest point. 2020-09-09 16:01:39 +02:00
Yorik van Havre
dc97e31707 Draft: Small bugfix in DXF exporter 2020-09-09 14:38:16 +02:00
carlopav
6f2691631c Draft: fixed obj.TypeId output after utils.get_type() change
.


.
2020-09-09 14:13:29 +02:00
carlopav
28c00f8383 Draft: provide the possibility to implement support for Edit in objs
As suggested by @Vanuan. and already implemented in new experimental BIM Wall: 1084a4b0a9
Draft: updated Draft Edit

thanks to the suggestions by @Vanuan
Draft: further bugfixing and improvements in Draft_Edit


Draft: moved Draft_Edit preview code into respective GuiTools
2020-09-09 14:13:29 +02:00
carlopav
8e1bb66cf2 Draft: support experimental BIM wall in Draft_Edit 2020-09-09 14:13:29 +02:00
Roy-043
7f415b4b58 Update scale.py 2020-09-09 14:12:43 +02:00
Roy-043
2d11f16e9d Update gui_stretch.py 2020-09-09 13:16:23 +02:00
vocx-fc
5cf799dd85 Draft: rename svg parameter to fillspaces (lowercase) 2020-09-09 12:53:54 +02:00
vocx-fc
b835e5f29d Draft: replace FreeCAD with App for consistency 2020-09-09 12:53:54 +02:00
vocx-fc
7627d0b81a Draft: move getSVG to draftfunctions submodule
Small fixes where the `get_svg` function is used, for example,
in the (obsolete) `DrawingView` class and `Arch_SectionPlane`.

Also update the unit tests accordingly.
2020-09-09 12:53:54 +02:00
Roy-043
db947e3513 Draft: Fix wire placement issue if Copy=False. 2020-09-08 16:16:16 +02:00
Roy-043
4c0bd797fe Update gui_snapper.py 2020-09-08 16:13:02 +02:00
luz paz
5cd408687b Fix typos in various files [skip-ci]
Found via `codespell 2.0.dev0`  
```
codespell -q 2 -L aci,ake,aline,alle,alledges,alocation,als,ang,anid,ba,beginn,behaviour,bloaded,byteorder,calculater,cancelled,cancelling,cas,cascade,centimetre,childs,colour,colours,commen,currenty,dof,doubleclick,dum,eiter,elemente,feld,freez,hist,iff,indicies,initialisation,initialise,initialised,initialises,initialisiert,ist,kilometre,lod,mantatory,methode,metres,millimetre,modell,nd,noe,normale,normaly,nto,numer,oder,orgin,orginx,orginy,ot,pard,pres,programm,que,recurrance,rougly,seperator,serie,sinc,strack,substraction,te,thist,thru,tread,uint,unter,vertexes,wallthickness,whitespaces -S ./.git,*.po,*.ts,./ChangeLog.txt,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/CXX,./src/zipios++,./src/Base/swig*,./src/Mod/Robot/App/kdl_cp,./src/Mod/Import/App/SCL,./src/WindowsInstaller,./src/Doc/FreeCAD.uml
```
2020-09-04 10:10:31 +02:00
vocx-fc
e477283ffc Draft: new PathTwistedArray object
It takes a `Shape` and replicates it around a path, while at the
same time adding a rotation to each copy. This can be used to create
a twisted "ribcage" from a frame-like object, which can be used
in a more complicated `Shape`, for example, a tunnel or bridge
object.
2020-09-03 12:34:16 +02:00
vocx-fc
4b8ebccc7d Draft: improve style and indentation of getSVG function
Also rename `getSVG` to `get_svg`.

Instead of testing `obj.isDerivedFrom('Part::Feature')`
we test for a Shape, `hasattr(obj, 'Shape')`.
This is to support the SVG generation of `App::Links`.
2020-09-03 11:40:50 +02:00
vocx-fc
4bf665a6fd Draft: move format_point out of getSVG function 2020-09-03 11:40:50 +02:00
vocx-fc
775c4d0a97 Draft: move getText out of getSVG function 2020-09-03 11:40:50 +02:00
vocx-fc
67c0af7b53 Draft: move getOvershoot out of getSVG function 2020-09-03 11:40:50 +02:00
vocx-fc
f240972ffa Draft: move getArrow out of getSVG function 2020-09-03 11:40:50 +02:00
vocx-fc
6eccf47848 Draft: move getEllipse out of getSVG function 2020-09-03 11:40:50 +02:00
vocx-fc
4c498e132e Draft: move getCircle out of getSVG function 2020-09-03 11:40:50 +02:00
vocx-fc
04afa25f91 Draft: move getPath out of getSVG function 2020-09-03 11:40:50 +02:00
vocx-fc
3e12316977 Draft: rename getPattern to get_pattern 2020-09-03 11:40:50 +02:00
vocx-fc
cfce1a8ad2 Draft: rename getDiscretized to get_discretized 2020-09-03 11:40:50 +02:00
vocx-fc
e61efd9e6d Draft: rename getProj to get_proj 2020-09-03 11:40:50 +02:00
vocx-fc
8b5e922e05 Draft: improve initial code of getSVG
Improve also the docstrings, and minor adjustments in PEP8 style
and spacing.
2020-09-03 11:40:50 +02:00
vocx-fc
ee58279b3e Draft: use draftutils.utils module in getSVG 2020-09-03 11:40:50 +02:00
luz paz
30c07083a1 Draft: Fix typo in variable name 2020-08-29 19:14:13 +02:00
Vanuan
b53326b38c High DPI support: Scale Draft cursor to device pixel ratio 2020-08-19 19:59:13 +02:00
Vanuan
024ae4dd9f Fix a typo in draft snapping 2020-08-11 11:59:52 +02:00
vocx-fc
72ec8445f2 Draft: Offset save and restore the value of OCC checkbox 2020-08-11 11:57:35 +02:00
SurajDadral
f97d27cb56 Fix placement of rebar wires in Draft.getSVG.py 2020-08-11 11:25:07 +02:00
paul lee
102cfb4a71 [Draft - geotuils.offsets] Fix To Work with Sketch
Forum Discussion - https://forum.freecadweb.org/viewtopic.php?f=23&t=48852&p=419209#p419209
2020-08-11 11:10:42 +02:00
paul lee
7a41078624 [Draft - geoutils.offsets] Fix Circle and Arc Offset Direction
Forum Discussion - https://forum.freecadweb.org/viewtopic.php?f=23&t=48852#p418903
2020-08-11 11:10:42 +02:00
vocx-fc
d51955f658 Draft: makeLayer, small adjustments to keep compatibility
This follows from the migration of the Layer code
done in 831e517717.

In the older `makeLayer` function, the parameters `drawstyle`
and `transparency` could be `None`; in the new `make_layer` function,
`drawstyle` must be an explicit string, and `transparency`
must be a number. If not provided, they use default values.
2020-08-11 11:08:48 +02:00
luz paz
59e3ea096e Crowdin: Merge new translations [skip-ci] 2020-08-07 17:17:35 +02:00
wmayer
47d570716c LGTM: [skip ci] fix: Non-virtual destructor in base class 2020-07-24 19:30:12 +02:00
wmayer
1a16cde1f5 Coverity: Structurally/Logically dead code 2020-07-20 17:34:28 +02:00