"Professional CMake" book suggest the following:
"Targets should build successfully with or without compiler support for precompiled headers. It
should be considered an optimization, not a requirement. In particular, do not explicitly include a
precompile header (e.g. stdafx.h) in the source code, let CMake force-include an automatically
generated precompile header on the compiler command line instead. This is more portable across
the major compilers and is likely to be easier to maintain. It will also avoid warnings being
generated from certain code checking tools like iwyu (include what you use)."
Therefore, removed the "#include <PreCompiled.h>" from sources, also
there is no need for the "#ifdef _PreComp_" anymore
An operator precedence error in new sanity checking code within
ElementMap::restore() causes <X>.Shape.Map.txt files with more than
2 element maps to be rejected as invalid. This silently corrupts
projects upon loading, potentially unrecoverably.
The preexisting code comment is still appropriate if ironic.
* Part/Toponaming: tests for flushElementMap and resetElementMap
* Added test for resetElementMap()
* Added test for flushElementMap()
* restored ComplexGeoData::resetElementMap to RT fork
* modified TopoShape::resetElementMap to match the restored signature of ComplexGeoData::resetElementMap
* added checks in TopoShape::makeShapeWithElementMap to avoid segfaults
* added check in TopoShape::setElementComboName to avoid segfaults
* restored testFindSubShapesForSourceWithTypeAndIndex
* modified test saveDocFileWithNoElementMap to match the restored signature of ComplexGeoData::resetElementMap
* Part/Toponaming: tests for flushElementMap and resetElementMap
* Removed comments in ComplexGeoData::resetElementMap()
* Changed TopoShape::resetElementMap():: from virtual to override
* Removed comment in TopoShape::resetElementMap()
* Added comments about differences between main and RT fork
* Removed comment in test saveDocFileWithNoElementMap
* Updated expected test result in makeElementCompoundTwoShapesGeneratesMap
* Updated expected test result in resetElementMapTest
* Fixed typo in test flushElementMapTest
* Part/Toponaming: tests for flushElementMap and resetElementMap
* updated expected tests results after previous methods modifications
---------
Signed-off-by: CalligaroV <vincenzo.calligaro@gmail.com>
Minor modifications to make it compile with previous refactorings.
The only substantial change to the original is moving the
getElementHistory function from ComplexGeoData to MappedName so
that the dehash function can remain private.
