Commit Graph

1965 Commits

Author SHA1 Message Date
Russell Johnson
0a59b5307c Path: Synchronize methods with same in PathAreaOp module
The affected methods exist in the PathAreaOp module.  This commit synchronizes the versions here with those.
2020-11-30 20:57:25 -06:00
Russell Johnson
6bbc56cd4b Path: Apply the user's Final Depth value 2020-11-30 20:57:25 -06:00
sliptonic
411562361b fix ui bugs 2020-11-30 15:35:30 -06:00
sliptonic
daea1f53da [path] make toolbit reject invalid filenames
help user create toolbit working location
2020-11-30 15:32:28 -06:00
sliptonic
a42355939a Merge pull request #4073 from Russ4262/fix_slot
Path: Fix arc slotting direction in Slot operation
2020-11-23 15:08:40 -06:00
sliptonic
152351e8a8 Merge pull request #4014 from sliptonic/feature/toolbitdock
[PATH] Feature/toolbitdock
2020-11-23 10:12:58 -06:00
Russell Johnson
37cd09e7ae Path: LGTM cleanup 2020-11-22 18:27:21 -06:00
Russell Johnson
1468c7e842 Path: Implement LazyLoader for Arcs module 2020-11-22 18:27:21 -06:00
Russell Johnson
da3f052270 Path: Fix g-code arc direction
Fixed incorrect point orders assigned to g2 and g3 commands.
Add application of `ReverseDirection` property to `ZigZag` cut pattern.
Make default arc direction clockwise(g2) for all cut patterns and layer modes.
Make tool diameter access backward compatible.
2020-11-22 18:27:21 -06:00
Russell Johnson
1ee1c9a5df Path: Simplify and fix debugging code 2020-11-22 15:38:50 -06:00
Russell Johnson
0d5a728698 Path: Standardize debugging mode control code 2020-11-22 15:37:31 -06:00
sliptonic
015250c810 revert docstring format for help box formatting.
log levels reset to INFO
remove unnecessary comments.
2020-11-22 11:08:28 -06:00
sliptonic
3a8f40a458 fix 'add' button in Job task panel
fix chamfer bit
lgtm cleanup
2020-11-19 17:10:50 -06:00
sliptonic
2e552e88b2 bug: on deleting tool controllers 2020-11-16 12:40:18 -06:00
sliptonic
fff4ed8a5c minor change to make toolcontroller labels better 2020-11-15 18:41:08 -06:00
sliptonic
5f52152f2c Rework default library and toolbits 2020-11-15 18:22:45 -06:00
sliptonic
4fc3adc8f6 Add toolcontroller to open operation 2020-11-15 18:22:45 -06:00
sliptonic
145b915663 Only allow editing of toolbit if shapefile is found 2020-11-15 18:22:45 -06:00
sliptonic
dbf3ebeabe Handle errors is toolbit json more gracefully 2020-11-15 18:22:45 -06:00
sliptonic
cbc8524ff9 Make Toolbit find Bit files relative to the current library directory 2020-11-15 18:22:45 -06:00
sliptonic
1672a33647 Fix duplicate docs being created
fix edit changes not being retained
fix edit removing new toolbit from diretory
2020-11-15 18:22:45 -06:00
sliptonic
d563530c3c Removed diameter dependencies so lathe tools work 2020-11-15 18:22:45 -06:00
sliptonic
3b6dbf8dca Fix default directory bug 2020-11-15 18:22:45 -06:00
sliptonic
ec3285a006 added attribute to Toolbit for spindlepower
setting this to false will suppress M3 commands.
User can configure a toolbit to never have the spindle turn on
this is to prevent accidental powering of the spindle with
unpowered tools like dragknife and probe
2020-11-15 18:22:45 -06:00
sliptonic
5c47912cc1 Better cleanup on new toolbit creation 2020-11-15 18:22:45 -06:00
sliptonic
09bb0d404d fix bug in create toolbit flow 2020-11-15 18:22:45 -06:00
sliptonic
e335fe5384 Editing Works 2020-11-15 18:22:45 -06:00
sliptonic
b556aa47de Basic workflow. No editing
concept dock work
most functions working.
made linuxcnc export work
Fixed some defaults on new install
fixed display label in dock
2020-11-15 18:22:45 -06:00
Russell Johnson
60249f543c Path: Delete irrelevant code 2020-11-13 16:34:59 -06:00
Russell Johnson
6046e0600b Path: Fix div by zero error
Fix MillFace div by zero error reported in forum at https://forum.freecadweb.org/viewtopic.php?f=15&t=51415.
Rotational-related variables were exposed to non-rotational code block.  They have been moved into correct rotational code block.
2020-11-13 16:34:59 -06:00
Russell Johnson
5bb979e34a Path: LGTM cleanup 2020-11-13 16:34:59 -06:00
Russell Johnson
cae33892e1 Path: Organize rotational code in areaOpShapes() method
Relocate the rotational analysis code into smaller independent methods to allow for easier maintenance and support.
Commented out recently added debug object creation statement.
2020-11-13 16:34:59 -06:00
Russell Johnson
45832af35b Path: Fix and cleanup removal shape creation code
The `isFaceUp()` method in the PathAreaOp module was returning false results in some instances.
Rotational code has been consolidated and better organized to fix certain errors reported in the forum.
Overall, this code section has been better organized as a part of the necessary fixes.
2020-11-13 16:34:59 -06:00
Russell Johnson
947bfa345d Path: Improve accuracy of isFaceUp() method
This method is used in rotational operations and some standard operations to identify if a face's normal-direction Z value is +1.0
2020-11-13 16:07:18 -06:00
Russell Johnson
760fa482ef Path: Remove null comments and improve debugging
Added method to create a FreeCAD object when in debug mode.
2020-11-13 16:07:18 -06:00
sliptonic
610f3ebf75 Merge pull request #3989 from Russ4262/Surface_fixes
Path: 3D Surface fix to apply `CutMode` when `CutPattern = Offset`; and LGTM cleanup
2020-11-13 14:25:19 -06:00
Dave Seff
f92b8f6d75 Make the tool setup images a bit nicer. 2020-11-12 16:59:22 +10:00
Daniel Wood
30d0a0a8a0 [Path] rename TurnPart to TurnPartoff 2020-11-11 08:44:09 +00:00
Daniel Wood
ddae642109 [Path] Add Turning Roughing Selection 2020-11-09 21:14:19 +00:00
Russell Johnson
666671e6d6 Path: Fix missing variable declaration for rotational scan
Missing default logical choice within `if...:` block.
Reported in forum at https://forum.freecadweb.org/viewtopic.php?style=3&f=15&t=44473&start=60#p412303
2020-11-08 22:56:49 -06:00
Russell Johnson
9c08f1a72d Path: Fix unsorted arc order for circular cut pattern in some cases 2020-11-08 22:56:49 -06:00
Russell Johnson
3e9ea18051 Path: Fix cut direction when CutPatternReversed is true for Circular 2020-11-08 22:56:49 -06:00
Russell Johnson
f428ba6050 Path: Restructure code to fix closedGap LGTM issue 2020-11-08 22:56:49 -06:00
Russell Johnson
1799f8e807 Path: Some LGTM cleanup 2020-11-08 22:56:49 -06:00
Russell Johnson
d2e7fdc15d Path: Apply missing CutMode setting when CutPattern = Offset
The `CutMode` toggle had no effect. This fix applies the `CutMode` toggle when the `CutPattern = Offset`.  The indicated `CutMode` may not be accurate depending on the situation, but the toggle will change the cut direction as intended.
2020-11-08 22:56:49 -06:00
Daniel Wood
34e9a571df [Path] Fix Typo - Stock object requires uppercase 'S' 2020-11-06 20:01:56 +01:00
luz paz
60c055e62d Path: Fix header uniformity and remove trailing whitespace
This PR fixes header uniformity across all Path files. It also removes all trailing whitespace.
2020-11-05 19:57:21 +01:00
GaryH
b0fcac8ddc Modify code format to PEP8
Add --marlin-config argument
  Marlin requires certain configuration settings in order to work well
  with FreeCAD. Those configuration settings will be added to the
  end of the gcode file as comments, when --marlin-config is entered
  as a post processor argument.
  For PEP8 conformity:
      Change some double-quotes to single-quotes.
      Change sequence of import statements.

Modify code format to PEP8
  Indentation and line length meet PEP8 requirements.
  Other aspects of PEP8 are partially implemented.

Add code to remove embedded comments
  Also, minor tweaks throughout

Change outstring to outList for clarity
  Change format_outstring to format_outList
  Change: if PathUtil.opProperty(obj, 'Active') is False:
    To: if PathUtil.opProperty(obj, 'Active') == False:

Format file to PEP8 standard
  Format first pass using:
    autopep8 --in-place --aggressive --aggressive
  Manually adjust format for better appearance
  Recheck format using http://pep8online.com/
  Change code related to pythonopen into with open() code
  Minor refactoring
2020-11-04 19:55:02 +01:00
GaryH
ef386cf85c Refactor marlin_post.py
Change G4 P to G4 S for Marlin
  Marlin uses P for milliseconds, S for seconds.
  FreeCAD uses P for seconds, so change P to S.

Remove code for G20 inch mode and G91 relative mode
  Due to the fundamentals of the FreeCAD pre-processor,
  this post processor can only operate in the following modes:
  G90 Absolute positions
  G21 Metric units (mm)
  G17 XY plane (3 axis vertical milling only)

Expand RETURN_TO option to float values for XYZ
  The RETURN_TO option previously only accepted integer values, and
  only for X and Y.
  This change allows float values for XY and optionally Z.

Add class: "Drill" within drill_translate()
  The nested functions within drill_translate() need to modify the
  variable that was named trBuff. To allow this, trBuff was changed
  to class: "Drill" with property "gcode".
  Within drill_translate(), including within the nested functions,
  modifying "trBuff" is now replaced with modifying "Drill.gcode".

Merge in updated portions of grbl_post.py
  Prior verson was derived from an older grbl_post.py.
  Merge in the portions of the newer grbl that seem improved.
  Refactor overall after the merge.

Add options for partial comments
  Add option:  --no-finish-comments
  Add option:  --no-path-comments
2020-11-04 19:55:02 +01:00
GaryH
3e223e242b Add files via upload 2020-11-04 19:55:02 +01:00